| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0eb9951c-fe6a-3d98-e55a-542c2047612b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9862:28E279:AD5C7D0:B0D7C16:6A50BCA0 |
| html-safe-nonce | b141807564ff153cb2db1343c2e7a221e00990f246a74f527cc52cd23184d213 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODYyOjI4RTI3OTpBRDVDN0QwOkIwRDdDMTY6NkE1MEJDQTAiLCJ2aXNpdG9yX2lkIjoiNTU1MjE4MzM5ODc1MDAxMDUyOCIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9 |
| visitor-hmac | 32133474560004d152e9a1f845c6f11b62107ff5949943086ef89899db4a1de8 |
| hovercard-subject-tag | pull_request:446408938 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34262/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bb2957d0456fa080cc792b81b9e8e744e0e24d8c44d81b2bb1329435fcf48ef1/nodejs/node/pull/34262 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bb2957d0456fa080cc792b81b9e8e744e0e24d8c44d81b2bb1329435fcf48ef1/nodejs/node/pull/34262 |
| og:image:alt | Builds on #34247 ... the first 15 commits in this PR are from that one.... that one needs to land first.
This is a WIP, will be adding more commits
Checklist
make -j4 test (UNIX), or vcbuild tes... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08e79d53fc070870d5b168356afebb1e286a2ffe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34262#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34262 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34262 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34262 |
| Reload | https://github.com/nodejs/node/pull/34262 |
| Reload | https://github.com/nodejs/node/pull/34262 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:quic-cleanups-5 | https://github.com/jasnell/node/tree/quic-cleanups-5 |
| Conversation | https://github.com/nodejs/node/pull/34262 |
| Commits3 (3) | https://github.com/nodejs/node/pull/34262/commits |
| Checks | https://github.com/nodejs/node/pull/34262/checks |
| Files changed | https://github.com/nodejs/node/pull/34262/files |
| quic: another, another round of quic cleanups | https://github.com/nodejs/node/pull/34262#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:quic-cleanups-5 | https://github.com/jasnell/node/tree/quic-cleanups-5 |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 8, 2020 | https://github.com/nodejs/node/pull/34262#issue-653502758 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| #34247 | https://github.com/nodejs/node/pull/34247 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jul 8, 2020 | https://github.com/nodejs/node/pull/34262#event-3526470992 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/d862211daf0fcfe8d54542ea73c8a73c1c6c660b..e36d749629fef45f3433817b65d3539a9ea7609a |
| d862211 | https://github.com/nodejs/node/commit/d862211daf0fcfe8d54542ea73c8a73c1c6c660b |
| e36d749 | https://github.com/nodejs/node/commit/e36d749629fef45f3433817b65d3539a9ea7609a |
|
Compare
| https://github.com/nodejs/node/compare/d862211daf0fcfe8d54542ea73c8a73c1c6c660b..e36d749629fef45f3433817b65d3539a9ea7609a |
| July 8, 2020 18:43 | https://github.com/nodejs/node/pull/34262#event-3526547561 |
|
| https://github.com/jasnell |
| quic: use less specific error codes | https://github.com/nodejs/node/pull/34262/commits/960252f6895eaa3719569caa74956088b0b7e0d9 |
| 960252f | https://github.com/nodejs/node/pull/34262/commits/960252f6895eaa3719569caa74956088b0b7e0d9 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/e36d749629fef45f3433817b65d3539a9ea7609a..960252f6895eaa3719569caa74956088b0b7e0d9 |
| e36d749 | https://github.com/nodejs/node/commit/e36d749629fef45f3433817b65d3539a9ea7609a |
| 960252f | https://github.com/nodejs/node/commit/960252f6895eaa3719569caa74956088b0b7e0d9 |
|
Compare
| https://github.com/nodejs/node/compare/e36d749629fef45f3433817b65d3539a9ea7609a..960252f6895eaa3719569caa74956088b0b7e0d9 |
| July 9, 2020 16:08 | https://github.com/nodejs/node/pull/34262#event-3530437511 |
| jasnell | https://github.com/jasnell |
| July 9, 2020 10:34 | https://github.com/nodejs/node/pull/34262#commits-pushed-01c68f3 |
|
| https://github.com/jasnell |
| quic: use Number instead of BigInt for more stats | https://github.com/nodejs/node/pull/34262/commits/01c68f3ea15ed3437f1990ca7feca9ba3daf5312 |
| 01c68f3 | https://github.com/nodejs/node/pull/34262/commits/01c68f3ea15ed3437f1990ca7feca9ba3daf5312 |
|
| https://github.com/jasnell |
| quic: set destroyed at timestamps for duration calculation | https://github.com/nodejs/node/pull/34262/commits/ee73cd5cd696ecef5c2d1093a8312bb491189daa |
| ee73cd5 | https://github.com/nodejs/node/pull/34262/commits/ee73cd5cd696ecef5c2d1093a8312bb491189daa |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| July 9, 2020 17:57 | https://github.com/nodejs/node/pull/34262#event-3530836318 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| July 9, 2020 17:57 | https://github.com/nodejs/node/pull/34262#event-3530836329 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 9, 2020 | https://github.com/nodejs/node/pull/34262#issuecomment-656268952 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://ci.nodejs.org/job/node-test-pull-request/32269/ | https://ci.nodejs.org/job/node-test-pull-request/32269/ |
| https://ci.nodejs.org/job/node-test-commit/39548/ | https://ci.nodejs.org/job/node-test-commit/39548/ |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 9, 2020
| https://github.com/nodejs/node/pull/34262#pullrequestreview-445874636 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34262/files/ee73cd5cd696ecef5c2d1093a8312bb491189daa |
| lib/internal/quic/core.js | https://github.com/nodejs/node/pull/34262/files/ee73cd5cd696ecef5c2d1093a8312bb491189daa#diff-c5549710f97326fcab9e777f4eed339897e0b1b78a4e5edf78d38f318a0570f1 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 9, 2020
| https://github.com/nodejs/node/pull/34262#ref-pullrequest-654294546 |
|
quic: more quic refactorings and cleanups
#34283
| https://github.com/nodejs/node/pull/34283 |
| jasnell | https://github.com/jasnell |
|
Jul 10, 2020
| https://github.com/nodejs/node/pull/34262#ref-commit-5e769b2 |
|
| https://github.com/jasnell |
| quic: use less specific error codes | https://github.com/nodejs/node/commit/5e769b2eaf4595e9c8c429c8ae9bb4b32e6a7c8f |
| 5e769b2 | https://github.com/nodejs/node/commit/5e769b2eaf4595e9c8c429c8ae9bb4b32e6a7c8f |
| #34262 | https://github.com/nodejs/node/pull/34262 |
| jasnell | https://github.com/jasnell |
|
Jul 10, 2020
| https://github.com/nodejs/node/pull/34262#ref-commit-48a349e |
|
| https://github.com/jasnell |
| quic: use Number instead of BigInt for more stats | https://github.com/nodejs/node/commit/48a349efd98e20cd73fe6f0f6a82a544576d2602 |
| 48a349e | https://github.com/nodejs/node/commit/48a349efd98e20cd73fe6f0f6a82a544576d2602 |
| #34262 | https://github.com/nodejs/node/pull/34262 |
| jasnell | https://github.com/jasnell |
|
Jul 10, 2020
| https://github.com/nodejs/node/pull/34262#ref-commit-c176d5f |
|
| https://github.com/jasnell |
| quic: set destroyed at timestamps for duration calculation | https://github.com/nodejs/node/commit/c176d5fac2f98205228142040e7778e0fff20967 |
| c176d5f | https://github.com/nodejs/node/commit/c176d5fac2f98205228142040e7778e0fff20967 |
| #34262 | https://github.com/nodejs/node/pull/34262 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 10, 2020 | https://github.com/nodejs/node/pull/34262#issuecomment-656885931 |
| 5e769b2 | https://github.com/nodejs/node/commit/5e769b2eaf4595e9c8c429c8ae9bb4b32e6a7c8f |
| 48a349e | https://github.com/nodejs/node/commit/48a349efd98e20cd73fe6f0f6a82a544576d2602 |
| c176d5f | https://github.com/nodejs/node/commit/c176d5fac2f98205228142040e7778e0fff20967 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 10, 2020 | https://github.com/nodejs/node/pull/34262#event-3535425526 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x |
| Jul 14, 2020 | https://github.com/nodejs/node/pull/34262#event-3544816127 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 14, 2020 | https://github.com/nodejs/node/pull/34262#issuecomment-658261217 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x |
|
backport-requested-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x |
| Jul 14, 2020 | https://github.com/nodejs/node/pull/34262#event-3544864345 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 14, 2020 | https://github.com/nodejs/node/pull/34262#issuecomment-658268114 |
| @MylesBorins | https://github.com/MylesBorins |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34262 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34262/files/ee73cd5cd696ecef5c2d1093a8312bb491189daa |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/34262 |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/MylesBorins |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |