| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cd6fc2c1-c82f-24ba-2390-a1c2776fff1f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C716:14FC13:9ED07E:D7C45D:696AB9EF |
| html-safe-nonce | 78b1118bcd454371f0afff69e575709c0419cab822c366a29e47613455137c2d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzE2OjE0RkMxMzo5RUQwN0U6RDdDNDVEOjY5NkFCOUVGIiwidmlzaXRvcl9pZCI6IjcyOTc4NjU0MDQ0MjU4Nzc5OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a8c9d6fcaa4eca6c57a4ff788eb0262985b5afbe47bc38d04bbb5957d463779d |
| hovercard-subject-tag | pull_request:445022045 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34228/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/eb2675d2e73f6ed9512b0718f0e9334dd4f21081fe3c2afb4a9994e5038755a0/nodejs/node/pull/34228 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eb2675d2e73f6ed9512b0718f0e9334dd4f21081fe3c2afb4a9994e5038755a0/nodejs/node/pull/34228 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34228#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34228 |
| Reload | https://github.com/nodejs/node/pull/34228 |
| Reload | https://github.com/nodejs/node/pull/34228 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34228#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:missing-fs-close | https://github.com/Trott/io.js/tree/missing-fs-close |
|
test: add known issue for fs.open() keeping event loop open
| https://github.com/nodejs/node/pull/34228#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:missing-fs-close | https://github.com/Trott/io.js/tree/missing-fs-close |
|
Conversation
20
| https://github.com/nodejs/node/pull/34228 |
|
Commits
0
| https://github.com/nodejs/node/pull/34228/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34228/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34228/files |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 6, 2020 | https://github.com/nodejs/node/pull/34228#issue-651842775 |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jul 6, 2020 | https://github.com/nodejs/node/pull/34228#event-3517790678 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 6, 2020
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443453061 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34228/files |
| test/known_issues/test-fs-error-no-close.js | https://github.com/nodejs/node/pull/34228/files#diff-aafb799e513700df323aa1269975cad68f147e09e725f722e7c2ec7a0fc153bd |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| July 7, 2020 00:04 | https://github.com/nodejs/node/pull/34228#event-3518060649 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-654523827 |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 7, 2020
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443480764 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34228/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443480764 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jul 7, 2020
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443481979 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34228/files |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 7, 2020
| https://github.com/nodejs/node/pull/34228#ref-issue-651896669 |
|
CI Relability 2020-07-07
JaneaSystems/nodejs-reliability#30
| https://github.com/JaneaSystems/nodejs-reliability/issues/30 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-654532097 |
| https://ci.nodejs.org/job/node-test-pull-request/32231/ | https://ci.nodejs.org/job/node-test-pull-request/32231/ |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-654556821 |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/34228#event-3518378843 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 7, 2020
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443685222 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34228/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443685222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| test/known_issues/test-fs-open-no-close.js | https://github.com/nodejs/node/pull/34228/files#diff-4827d839273c48b9152ce7b2b09325c42c5b5db5cfb550d19a64b8a065860303 |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 7, 2020
| https://github.com/nodejs/node/pull/34228#pullrequestreview-443731786 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34228/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jul 7, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-654750506 |
| @bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/build/blob/master/doc/ssh.md | https://github.com/nodejs/build/blob/master/doc/ssh.md |
| https://github.com/nodejs/build/blob/d4b074cd221cce329ee1f31292e3114845390a56/ansible/ansible.cfg#L24 | https://github.com/nodejs/build/blob/d4b074cd221cce329ee1f31292e3114845390a56/ansible/ansible.cfg#L24 |
| https://github.com/nodejs/build/blob/master/ansible/inventory.yml | https://github.com/nodejs/build/blob/master/ansible/inventory.yml |
| test-requireio_williamkapke-debian10-arm64_pi3-1 | https://ci.nodejs.org/computer/test-requireio_williamkapke-debian10-arm64_pi3-1/ |
| https://ci.nodejs.org/job/node-test-binary-arm-12+/6210/RUN_SUBSET=0,label=pi3-docker/ | https://ci.nodejs.org/job/node-test-binary-arm-12+/6210/RUN_SUBSET=0,label=pi3-docker/ |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 7, 2020
| https://github.com/nodejs/node/pull/34228#pullrequestreview-444203507 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34228/files |
| tools/lint-md.js | https://github.com/nodejs/node/pull/34228/files#diff-7b7f4e56fec118d19fcd306decc1a794dd49a3bba23129336c83e29732046028 |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/387586a69a1c42256d259d4beac0cb7919d8bcb2..24674dfe2f6b99f5052d9247800654b0c1c1ef59 |
| 387586a | https://github.com/nodejs/node/commit/387586a69a1c42256d259d4beac0cb7919d8bcb2 |
| 24674df | https://github.com/nodejs/node/commit/24674dfe2f6b99f5052d9247800654b0c1c1ef59 |
|
Compare
| https://github.com/nodejs/node/compare/387586a69a1c42256d259d4beac0cb7919d8bcb2..24674dfe2f6b99f5052d9247800654b0c1c1ef59 |
| July 7, 2020 19:58 | https://github.com/nodejs/node/pull/34228#event-3522054475 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 8, 2020
| https://github.com/nodejs/node/pull/34228#ref-issue-652769934 |
|
CI Relability 2020-07-08
JaneaSystems/nodejs-reliability#31
| https://github.com/JaneaSystems/nodejs-reliability/issues/31 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 8, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-655812924 |
| https://ci.nodejs.org/job/node-test-pull-request/32257/ | https://ci.nodejs.org/job/node-test-pull-request/32257/ |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 8, 2020
| https://github.com/nodejs/node/pull/34228#ref-issue-653663160 |
|
fs.open() can keep the event loop open in some cases
#34266
| https://github.com/nodejs/node/issues/34266 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 9, 2020
| https://github.com/nodejs/node/pull/34228#ref-issue-653674724 |
|
CI Relability 2020-07-09
JaneaSystems/nodejs-reliability#32
| https://github.com/JaneaSystems/nodejs-reliability/issues/32 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 9, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-655830038 |
| https://ci.nodejs.org/job/node-test-pull-request/32258/ | https://ci.nodejs.org/job/node-test-pull-request/32258/ |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 9, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-655836876 |
| 6ae1b9c | https://github.com/nodejs/node/commit/6ae1b9c457444fdfa5e30d9142bb8cdccf35f8ee |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 9, 2020 | https://github.com/nodejs/node/pull/34228#event-3527569717 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/ca3017f12836bb521b0a9b73c8b8cd9f15321468..6ae1b9c457444fdfa5e30d9142bb8cdccf35f8ee |
| ca3017f | https://github.com/nodejs/node/commit/ca3017f12836bb521b0a9b73c8b8cd9f15321468 |
| 6ae1b9c | https://github.com/nodejs/node/commit/6ae1b9c457444fdfa5e30d9142bb8cdccf35f8ee |
|
Compare
| https://github.com/nodejs/node/compare/ca3017f12836bb521b0a9b73c8b8cd9f15321468..6ae1b9c457444fdfa5e30d9142bb8cdccf35f8ee |
| July 9, 2020 01:11 | https://github.com/nodejs/node/pull/34228#event-3527569720 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 6ae1b9c | https://github.com/nodejs/node/commit/6ae1b9c457444fdfa5e30d9142bb8cdccf35f8ee |
| Jul 9, 2020 | https://github.com/nodejs/node/pull/34228#event-3527569806 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| July 9, 2020 01:11 | https://github.com/nodejs/node/pull/34228#event-3527569892 |
|
CI Relability 2020-07-10
JaneaSystems/nodejs-reliability#33
| https://github.com/JaneaSystems/nodejs-reliability/issues/33 |
|
CI Relability 2020-07-11
JaneaSystems/nodejs-reliability#34
| https://github.com/JaneaSystems/nodejs-reliability/issues/34 |
|
CI Relability 2020-07-12
JaneaSystems/nodejs-reliability#35
| https://github.com/JaneaSystems/nodejs-reliability/issues/35 |
|
CI Relability 2020-07-13
JaneaSystems/nodejs-reliability#36
| https://github.com/JaneaSystems/nodejs-reliability/issues/36 |
|
CI Relability 2020-07-14
JaneaSystems/nodejs-reliability#37
| https://github.com/JaneaSystems/nodejs-reliability/issues/37 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34228#ref-commit-8811058 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: add known issue for fs.open() keeping event loop open | https://github.com/nodejs/node/commit/881105826c16365c5722cb93fa0bd707dc2577c4 |
| 8811058 | https://github.com/nodejs/node/commit/881105826c16365c5722cb93fa0bd707dc2577c4 |
| #34228 | https://github.com/nodejs/node/pull/34228 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34228#ref-pullrequest-656877627 |
|
v14.6.0 proposal
#34371
| https://github.com/nodejs/node/pull/34371 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34228#ref-commit-ec9b49a |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: add known issue for fs.open() keeping event loop open | https://github.com/nodejs/node/commit/ec9b49a9b90c328ca8e1acdd60ee3cc518ebf3b4 |
| ec9b49a | https://github.com/nodejs/node/commit/ec9b49a9b90c328ca8e1acdd60ee3cc518ebf3b4 |
| #34228 | https://github.com/nodejs/node/pull/34228 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34228#ref-commit-a5553dc |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add known issue for fs.open() keeping event loop open | https://github.com/nodejs/node/commit/a5553dc6767ba1cf189d47f0c977de1eea0063d0 |
| a5553dc | https://github.com/nodejs/node/commit/a5553dc6767ba1cf189d47f0c977de1eea0063d0 |
| #34228 | https://github.com/nodejs/node/pull/34228 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2020 | https://github.com/nodejs/node/pull/34228#issuecomment-696880489 |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
dont-land-on-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x |
| Sep 22, 2020 | https://github.com/nodejs/node/pull/34228#event-3794492682 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34228 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/34228/files/387586a69a1c42256d259d4beac0cb7919d8bcb2 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/34228/files/59b9b69e297218d7340d772a96e9f568dab39a4a |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34228/files/1872adfb306783ae2218a324cf01b08c14307118 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/34228/files/1872adfb306783ae2218a324cf01b08c14307118 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/34228 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/rvagg |
|
| https://github.com/richardlau |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/ronag |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |