| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2d6ded26-f887-2f7f-5827-58cdb0fc3765 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B838:36D9CC:340FCE:480E63:696A71F1 |
| html-safe-nonce | 9f6a1a8b3d26eec79fa935712098240fcfe4a72c1ec8065cd18c0307ce886c79 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODM4OjM2RDlDQzozNDBGQ0U6NDgwRTYzOjY5NkE3MUYxIiwidmlzaXRvcl9pZCI6IjEzMDc2NzM4NDY2Nzk3NjEzOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9df69707ba16c259439ee0623eb40235b06240852ceadbd83ec7213a5509c4ae |
| hovercard-subject-tag | pull_request:443784775 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34178/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/762012f1d8c653ebfd67c993140cb263a4abf7a64a01f69d85e84f879becc48f/nodejs/node/pull/34178 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/762012f1d8c653ebfd67c993140cb263a4abf7a64a01f69d85e84f879becc48f/nodejs/node/pull/34178 |
| og:image:alt | The explanation that the HTTP requests include \r\n is true but not
important or relevant in these two specific contexts.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
docum... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34178#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34178 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34178 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34178 |
| Reload | https://github.com/nodejs/node/pull/34178 |
| Reload | https://github.com/nodejs/node/pull/34178 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34178#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:remember | https://github.com/Trott/io.js/tree/remember |
|
doc: remove parenthetical \r\n comment in http and http2 docs
| https://github.com/nodejs/node/pull/34178#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:remember | https://github.com/Trott/io.js/tree/remember |
|
Conversation
2
| https://github.com/nodejs/node/pull/34178 |
|
Commits
0
| https://github.com/nodejs/node/pull/34178/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34178/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34178/files |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 2, 2020 | https://github.com/nodejs/node/pull/34178#issue-650255929 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jul 2, 2020 | https://github.com/nodejs/node/pull/34178#event-3509058988 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 3, 2020
| https://github.com/nodejs/node/pull/34178#pullrequestreview-442566010 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34178/files |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 3, 2020
| https://github.com/nodejs/node/pull/34178#pullrequestreview-442566754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34178/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/34178#pullrequestreview-442566754 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
| https://github.com/MrHeer |
| MrHeer | https://github.com/MrHeer |
|
Jul 4, 2020
| https://github.com/nodejs/node/pull/34178#pullrequestreview-442603749 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34178/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 4, 2020 | https://github.com/nodejs/node/pull/34178#issuecomment-653823861 |
| 56dbe46 | https://github.com/nodejs/node/commit/56dbe466fdbc598baea3bfce289bf52b97b8b8f7 |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 4, 2020 | https://github.com/nodejs/node/pull/34178#event-3512913831 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/085e2bcd1625f285ffd4f26bb4b8089d3633d6fc..56dbe466fdbc598baea3bfce289bf52b97b8b8f7 |
| 085e2bc | https://github.com/nodejs/node/commit/085e2bcd1625f285ffd4f26bb4b8089d3633d6fc |
| 56dbe46 | https://github.com/nodejs/node/commit/56dbe466fdbc598baea3bfce289bf52b97b8b8f7 |
|
Compare
| https://github.com/nodejs/node/compare/085e2bcd1625f285ffd4f26bb4b8089d3633d6fc..56dbe466fdbc598baea3bfce289bf52b97b8b8f7 |
| July 4, 2020 23:46 | https://github.com/nodejs/node/pull/34178#event-3512913832 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 56dbe46 | https://github.com/nodejs/node/commit/56dbe466fdbc598baea3bfce289bf52b97b8b8f7 |
| Jul 4, 2020 | https://github.com/nodejs/node/pull/34178#event-3512913858 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| July 4, 2020 23:47 | https://github.com/nodejs/node/pull/34178#event-3512913859 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34178#ref-commit-f174288 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: remove parenthetical \r\n comment in http and http2 docs | https://github.com/nodejs/node/commit/f1742882bb661b123e344f543d92f9b9b14de97c |
| f174288 | https://github.com/nodejs/node/commit/f1742882bb661b123e344f543d92f9b9b14de97c |
| #34178 | https://github.com/nodejs/node/pull/34178 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34178#ref-pullrequest-656877627 |
|
v14.6.0 proposal
#34371
| https://github.com/nodejs/node/pull/34371 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34178#ref-commit-326b854 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: remove parenthetical \r\n comment in http and http2 docs | https://github.com/nodejs/node/commit/326b854e6ed0bd46de94aa1491baedb7dc8f0933 |
| 326b854 | https://github.com/nodejs/node/commit/326b854e6ed0bd46de94aa1491baedb7dc8f0933 |
| #34178 | https://github.com/nodejs/node/pull/34178 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34178#ref-commit-c62941e |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: remove parenthetical \r\n comment in http and http2 docs | https://github.com/nodejs/node/commit/c62941e84c4d3e4ece141847dd5a1c94efd7de5e |
| c62941e | https://github.com/nodejs/node/commit/c62941e84c4d3e4ece141847dd5a1c94efd7de5e |
| #34178 | https://github.com/nodejs/node/pull/34178 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34178#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34178 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34178/files/085e2bcd1625f285ffd4f26bb4b8089d3633d6fc |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/34178/files/085e2bcd1625f285ffd4f26bb4b8089d3633d6fc |
|
| https://github.com/MrHeer |
|
MrHeer
| https://github.com/MrHeer |
|
| https://github.com/nodejs/node/pull/34178/files/085e2bcd1625f285ffd4f26bb4b8089d3633d6fc |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/34178 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/mhdawson |
|
| https://github.com/MrHeer |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |