René's URL Explorer Experiment


Title: http: add note about timer unref by ronag · Pull Request #34143 · nodejs/node · GitHub

Open Graph Title: http: add note about timer unref by ronag · Pull Request #34143 · nodejs/node

X Title: http: add note about timer unref by ronag · Pull Request #34143 · nodejs/node

Description: This tripped me a bit and was not trivial to git blame. Adding a comment. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is...

Open Graph Description: This tripped me a bit and was not trivial to git blame. Adding a comment. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is...

X Description: This tripped me a bit and was not trivial to git blame. Adding a comment. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is...

Opengraph URL: https://github.com/nodejs/node/pull/34143

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b6f9569a-5d87-1876-9c23-e8586305ea6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9648:C8A64:DD5727:1314779:696A9196
html-safe-nonce84bb20599d96b9f8afebe6533c2e5a8c7b4d356994e52fe161d2fcce119acd5b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjQ4OkM4QTY0OkRENTcyNzoxMzE0Nzc5OjY5NkE5MTk2IiwidmlzaXRvcl9pZCI6IjYzNjg4MjAzMTEzNjg1NjkyMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfc872967d0f0c7a6f6f6a638a7da1c851d146247dadab6931b9fec6ea47e5fed
hovercard-subject-tagpull_request:442315081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34143/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/75546f99aacc29cade79f944fa1e76d1ed486c62cf4523f99ef7662ff0278443/nodejs/node/pull/34143
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/75546f99aacc29cade79f944fa1e76d1ed486c62cf4523f99ef7662ff0278443/nodejs/node/pull/34143
og:image:altThis tripped me a bit and was not trivial to git blame. Adding a comment. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34143#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34143
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34143
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34143
Reloadhttps://github.com/nodejs/node/pull/34143
Reloadhttps://github.com/nodejs/node/pull/34143
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34143
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34143
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34143#issue-comment-box
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-unref-dochttps://github.com/nxtedition/node/tree/http-unref-doc
http: add note about timer unref https://github.com/nodejs/node/pull/34143#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-unref-dochttps://github.com/nxtedition/node/tree/http-unref-doc
Conversation 4 https://github.com/nodejs/node/pull/34143
Commits 1 https://github.com/nodejs/node/pull/34143/commits
Checks 0 https://github.com/nodejs/node/pull/34143/checks
Files changed https://github.com/nodejs/node/pull/34143/files
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2020https://github.com/nodejs/node/pull/34143#issue-648518186
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jun 30, 2020https://github.com/nodejs/node/pull/34143#event-3499781716
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2020https://github.com/nodejs/node/pull/34143#issuecomment-652064812
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.com/ronag
http: add note about timer unrefhttps://github.com/nodejs/node/pull/34143/commits/354000c704478091acdfc4b0e118b6308410f47b
354000chttps://github.com/nodejs/node/pull/34143/commits/354000c704478091acdfc4b0e118b6308410f47b
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/997d580ebbba1baf73c1528c9dcef5e1b4b09751..354000c704478091acdfc4b0e118b6308410f47b
997d580https://github.com/nodejs/node/commit/997d580ebbba1baf73c1528c9dcef5e1b4b09751
354000chttps://github.com/nodejs/node/commit/354000c704478091acdfc4b0e118b6308410f47b
Compare https://github.com/nodejs/node/compare/997d580ebbba1baf73c1528c9dcef5e1b4b09751..354000c704478091acdfc4b0e118b6308410f47b
June 30, 2020 21:53https://github.com/nodejs/node/pull/34143#event-3499790312
https://github.com/ronag
ronaghttps://github.com/ronag
addaleaxhttps://github.com/addaleax
bnoordhuishttps://github.com/bnoordhuis
jasnellhttps://github.com/jasnell
July 5, 2020 17:09https://github.com/nodejs/node/pull/34143#event-3513497230
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 8, 2020https://github.com/nodejs/node/pull/34143#issuecomment-655381717
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 8, 2020 https://github.com/nodejs/node/pull/34143#pullrequestreview-444797332
View reviewed changes https://github.com/nodejs/node/pull/34143/files/354000c704478091acdfc4b0e118b6308410f47b
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/34143#pullrequestreview-444797332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 9, 2020 https://github.com/nodejs/node/pull/34143#pullrequestreview-445297491
View reviewed changes https://github.com/nodejs/node/pull/34143/files/354000c704478091acdfc4b0e118b6308410f47b
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 9, 2020https://github.com/nodejs/node/pull/34143#issuecomment-655947578
e8f5745https://github.com/nodejs/node/commit/e8f57456bec8f4b2b23ab2a326a619ac28e8e8cf
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 9, 2020https://github.com/nodejs/node/pull/34143#event-3528299672
ronaghttps://github.com/ronag
Jul 9, 2020 https://github.com/nodejs/node/pull/34143#ref-commit-e8f5745
https://github.com/ronag
http: add note about timer unrefhttps://github.com/nodejs/node/commit/e8f57456bec8f4b2b23ab2a326a619ac28e8e8cf
e8f5745https://github.com/nodejs/node/commit/e8f57456bec8f4b2b23ab2a326a619ac28e8e8cf
#34143https://github.com/nodejs/node/pull/34143
MylesBorinshttps://github.com/MylesBorins
Jul 14, 2020 https://github.com/nodejs/node/pull/34143#ref-commit-a30f5b3
https://github.com/ronag
https://github.com/MylesBorins
http: add note about timer unrefhttps://github.com/nodejs/node/commit/a30f5b31b4b7eb5c7538d2d277fb3feedaed95fc
a30f5b3https://github.com/nodejs/node/commit/a30f5b31b4b7eb5c7538d2d277fb3feedaed95fc
#34143https://github.com/nodejs/node/pull/34143
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 14, 2020 https://github.com/nodejs/node/pull/34143#ref-pullrequest-656877627
v14.6.0 proposal #34371 https://github.com/nodejs/node/pull/34371
MylesBorinshttps://github.com/MylesBorins
Jul 16, 2020 https://github.com/nodejs/node/pull/34143#ref-commit-96ebd5f
https://github.com/ronag
https://github.com/MylesBorins
http: add note about timer unrefhttps://github.com/nodejs/node/commit/96ebd5f352c3eaf9ada5904a98444ceb48b52b21
96ebd5fhttps://github.com/nodejs/node/commit/96ebd5f352c3eaf9ada5904a98444ceb48b52b21
#34143https://github.com/nodejs/node/pull/34143
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34143#ref-commit-6415185
https://github.com/ronag
https://github.com/addaleax
http: add note about timer unrefhttps://github.com/nodejs/node/commit/641518519439bfa0376ae424c66c136090dcc840
6415185https://github.com/nodejs/node/commit/641518519439bfa0376ae424c66c136090dcc840
#34143https://github.com/nodejs/node/pull/34143
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34143#ref-commit-4e07faa
https://github.com/ronag
https://github.com/addaleax
http: add note about timer unrefhttps://github.com/nodejs/node/commit/4e07faa7cf89bacbc5ae6171170563fba546791d
4e07faahttps://github.com/nodejs/node/commit/4e07faa7cf89bacbc5ae6171170563fba546791d
#34143https://github.com/nodejs/node/pull/34143
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34143#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34143
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34143/files/354000c704478091acdfc4b0e118b6308410f47b
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/34143/files/354000c704478091acdfc4b0e118b6308410f47b
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/addaleax
addaleax https://github.com/addaleax
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/34143
https://github.com/ronag
https://github.com/jasnell
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.