René's URL Explorer Experiment


Title: stream: add the pipeline destoryDestOnError option by rickyes · Pull Request #34133 · nodejs/node · GitHub

Open Graph Title: stream: add the pipeline destoryDestOnError option by rickyes · Pull Request #34133 · nodejs/node

X Title: stream: add the pipeline destoryDestOnError option by rickyes · Pull Request #34133 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #26311 /cc @mcollina @ronag Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follo...

X Description: Fixes: #26311 /cc @mcollina @ronag Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follo...

Opengraph URL: https://github.com/nodejs/node/pull/34133

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7b427922-27c0-707a-5328-d4aa44dd66c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1D2:1F5F5F:CA3040:10C5F5D:6AED3DF9
html-safe-nonce5804bda34039b29bcaba5f4b36a239dca31eb412ff96468a52d53665115f0ed1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUQyOjFGNUY1RjpDQTMwNDA6MTBDNUY1RDo2QUVEM0RGOSIsInZpc2l0b3JfaWQiOiIxNDcxODE1MzAyMzExNjAzMTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc28d5bb264ec1e6eec4f93ec0854450817a2b608ff4f43d3610527978a8a14f6
hovercard-subject-tagpull_request:442098521
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34133/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ab654701cc42553e0523d613f0484955e8c4603e44cef554906c8d1b4f52a35a/nodejs/node/pull/34133
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ab654701cc42553e0523d613f0484955e8c4603e44cef554906c8d1b4f52a35a/nodejs/node/pull/34133
og:image:altFixes: #26311 /cc @mcollina @ronag Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerickyes
hostnamegithub.com
expected-hostnamegithub.com
None26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec629ad99c254d306375fc8354d04321c2c362236
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34133#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34133
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34133
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34133
Reloadhttps://github.com/nodejs/node/pull/34133
Reloadhttps://github.com/nodejs/node/pull/34133
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
rickyeshttps://github.com/rickyes
nodejs:masterhttps://github.com/nodejs/node/tree/master
rickyes:add-pipeline-destoryDestOnErrorhttps://github.com/rickyes/node/tree/add-pipeline-destoryDestOnError
Conversationhttps://github.com/nodejs/node/pull/34133
Commits11 (11)https://github.com/nodejs/node/pull/34133/commits
Checkshttps://github.com/nodejs/node/pull/34133/checks
Files changedhttps://github.com/nodejs/node/pull/34133/files
stream: add the pipeline destoryDestOnError optionhttps://github.com/nodejs/node/pull/34133#top
rickyeshttps://github.com/rickyes
nodejs:masterhttps://github.com/nodejs/node/tree/master
rickyes:add-pipeline-destoryDestOnErrorhttps://github.com/rickyes/node/tree/add-pipeline-destoryDestOnError
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jun 30, 2020https://github.com/nodejs/node/pull/34133#issue-648258244
#26311https://github.com/nodejs/node/issues/26311
@mcollinahttps://github.com/mcollina
@ronaghttps://github.com/ronag
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2020https://github.com/nodejs/node/pull/34133#issuecomment-651859898
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jun 30, 2020https://github.com/nodejs/node/pull/34133#issuecomment-651861562
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/ronag
ronaghttps://github.com/ronag
Jun 30, 2020https://github.com/nodejs/node/pull/34133#issuecomment-651913336
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jun 30, 2020https://github.com/nodejs/node/pull/34133#event-3498834326
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 1, 2020https://github.com/nodejs/node/pull/34133#issuecomment-652211144
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 1, 2020 https://github.com/nodejs/node/pull/34133#pullrequestreview-440996809
View reviewed changes https://github.com/nodejs/node/pull/34133/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/34133#pullrequestreview-440996809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 1, 2020https://github.com/nodejs/node/pull/34133#issuecomment-652519278
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 1, 2020https://github.com/nodejs/node/pull/34133#issuecomment-652523084
Please reload this pagehttps://github.com/nodejs/node/pull/34133
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 1, 2020https://github.com/nodejs/node/pull/34133#issuecomment-652529612
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 1, 2020https://github.com/nodejs/node/pull/34133#issuecomment-652530412
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 1, 2020https://github.com/nodejs/node/pull/34133#issuecomment-652531123
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
mcollinahttps://github.com/mcollina
July 2, 2020 13:51https://github.com/nodejs/node/pull/34133#event-3507209091
rickyeshttps://github.com/rickyes
July 8, 2020 12:41https://github.com/nodejs/node/pull/34133#commits-pushed-9fc6369
https://github.com/rickyes
stream: add the pipeline destoryDestOnError optionhttps://github.com/nodejs/node/pull/34133/commits/9fc636967e1773a544671dd2f4e7e1f8ea74ff5c
9fc6369https://github.com/nodejs/node/pull/34133/commits/9fc636967e1773a544671dd2f4e7e1f8ea74ff5c
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/1bd4c47ca8b2b7f440580f8031e9f9563ae069b8
1bd4c47https://github.com/nodejs/node/pull/34133/commits/1bd4c47ca8b2b7f440580f8031e9f9563ae069b8
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/c83249a73707ae726dddab7b4ef4fdd90a43e82f
c83249ahttps://github.com/nodejs/node/pull/34133/commits/c83249a73707ae726dddab7b4ef4fdd90a43e82f
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/5d8a89013d8037be4b71c2193302e4f70282f6b3
5d8a890https://github.com/nodejs/node/pull/34133/commits/5d8a89013d8037be4b71c2193302e4f70282f6b3
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/d97d1879df5298b49c920c1418db91dffc75dfe4
d97d187https://github.com/nodejs/node/pull/34133/commits/d97d1879df5298b49c920c1418db91dffc75dfe4
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/97ee87b08fb60dfaf07f9920a269dd5a78d48805
97ee87bhttps://github.com/nodejs/node/pull/34133/commits/97ee87b08fb60dfaf07f9920a269dd5a78d48805
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/75ad4808e5a88e256f86bc1078d091d4939de104
75ad480https://github.com/nodejs/node/pull/34133/commits/75ad4808e5a88e256f86bc1078d091d4939de104
https://github.com/rickyes
rickyeshttps://github.com/rickyes
force-pushedhttps://github.com/nodejs/node/compare/198779e736388be4d85379c55a99c034247aabf6..75ad4808e5a88e256f86bc1078d091d4939de104
198779ehttps://github.com/nodejs/node/commit/198779e736388be4d85379c55a99c034247aabf6
75ad480https://github.com/nodejs/node/commit/75ad4808e5a88e256f86bc1078d091d4939de104
Compare https://github.com/nodejs/node/compare/198779e736388be4d85379c55a99c034247aabf6..75ad4808e5a88e256f86bc1078d091d4939de104
July 8, 2020 04:43https://github.com/nodejs/node/pull/34133#event-3523387957
rickyeshttps://github.com/rickyes
July 8, 2020 12:58https://github.com/nodejs/node/pull/34133#commits-pushed-fd62858
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/fd62858103495c11373ea92011e04e57fd91ed72
fd62858https://github.com/nodejs/node/pull/34133/commits/fd62858103495c11373ea92011e04e57fd91ed72
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/69df9a0eb6ac655e06e492774dcd2f0458ae2882
69df9a0https://github.com/nodejs/node/pull/34133/commits/69df9a0eb6ac655e06e492774dcd2f0458ae2882
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/a335b1b3ef22fdd488d6038c7b7f9051c1a86dc0
a335b1bhttps://github.com/nodejs/node/pull/34133/commits/a335b1b3ef22fdd488d6038c7b7f9051c1a86dc0
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 8, 2020https://github.com/nodejs/node/pull/34133#issuecomment-655286811
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 8, 2020https://github.com/nodejs/node/pull/34133#issuecomment-655445955
@mafintoshhttps://github.com/mafintosh
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/mcollina
mcollinahttps://github.com/mcollina
mafintoshhttps://github.com/mafintosh
July 8, 2020 10:59https://github.com/nodejs/node/pull/34133#event-3524653051
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 8, 2020 https://github.com/nodejs/node/pull/34133#pullrequestreview-444786046
View reviewed changes https://github.com/nodejs/node/pull/34133/files/a335b1b3ef22fdd488d6038c7b7f9051c1a86dc0
doc/api/stream.mdhttps://github.com/nodejs/node/pull/34133/files/a335b1b3ef22fdd488d6038c7b7f9051c1a86dc0#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
jasnellhttps://github.com/jasnell
Jul 8, 2020https://github.com/nodejs/node/pull/34133#discussion_r451561770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34133
rickyeshttps://github.com/rickyes
Jul 8, 2020https://github.com/nodejs/node/pull/34133#discussion_r451579535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
fixuphttps://github.com/nodejs/node/pull/34133/commits/931231d75111a910ac341f5b517fed77ef97be2a
931231dhttps://github.com/nodejs/node/pull/34133/commits/931231d75111a910ac341f5b517fed77ef97be2a
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 11, 2020https://github.com/nodejs/node/pull/34133#issuecomment-657023482
@mafintoshhttps://github.com/mafintosh
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
Jul 11, 2020https://github.com/nodejs/node/pull/34133#issuecomment-657053145
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 11, 2020https://github.com/nodejs/node/pull/34133#issuecomment-657055216
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Aug 3, 2020https://github.com/nodejs/node/pull/34133#issuecomment-668027015
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Aug 3, 2020https://github.com/nodejs/node/pull/34133#event-3615951357
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 30, 2021 https://github.com/nodejs/node/pull/34133#ref-issue-414448477
stream.pipeline destroys writable stream when error is occurred #26311 https://github.com/nodejs/node/issues/26311
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Dec 10, 2021 https://github.com/nodejs/node/pull/34133#ref-pullrequest-1077026459
stream: manual destroy ServerResponse on pipeline #41137 https://github.com/nodejs/node/pull/41137
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34133
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34133/files/a335b1b3ef22fdd488d6038c7b7f9051c1a86dc0
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
Please reload this pagehttps://github.com/nodejs/node/pull/34133
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream.pipeline destroys writable stream when error is occurred https://github.com/nodejs/node/issues/26311
Please reload this pagehttps://github.com/nodejs/node/pull/34133
https://github.com/rickyes
https://github.com/ronag
https://github.com/mcollina
https://github.com/mafintosh
https://github.com/jasnell
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.