| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:57af178e-5acf-cccf-cef0-b10f3d5a6cdd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83D6:2A0D62:E6190D:13E1F5A:696A9142 |
| html-safe-nonce | 99821ab0e45bcc5156a426004d881d62088ae8d2b81c6053173fc5d0a2f34679 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0Q2OjJBMEQ2MjpFNjE5MEQ6MTNFMUY1QTo2OTZBOTE0MiIsInZpc2l0b3JfaWQiOiI0NzUzNjQwMzQxNTA1NzQxMTIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 88081b1385e67386b0187e22bea67f24e8a861c71dce6c5c8f6e86ccb89691a3 |
| hovercard-subject-tag | pull_request:437978162 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34015/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6564db98db1af935e76620c5fd8f1fa7c0796a22e916f410215fd621a5b7a091/nodejs/node/pull/34015 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6564db98db1af935e76620c5fd8f1fa7c0796a22e916f410215fd621a5b7a091/nodejs/node/pull/34015 |
| og:image:alt | This PR combines the following separate PRs, with fixups, to make them easier to land (landing them one at a time was starting to get extremely painful)
events: EventTarget use validators and smal... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34015#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34015 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34015 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34015 |
| Reload | https://github.com/nodejs/node/pull/34015 |
| Reload | https://github.com/nodejs/node/pull/34015 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34015#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:eventtarget-fixups | https://github.com/jasnell/node/tree/eventtarget-fixups |
|
events: combined event target fixes
| https://github.com/nodejs/node/pull/34015#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:eventtarget-fixups | https://github.com/jasnell/node/tree/eventtarget-fixups |
|
Conversation
4
| https://github.com/nodejs/node/pull/34015 |
|
Commits
11
| https://github.com/nodejs/node/pull/34015/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34015/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34015/files |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 22, 2020 | https://github.com/nodejs/node/pull/34015#issue-643114376 |
| events: EventTarget use validators and small fix #33663 | https://github.com/nodejs/node/pull/33663 |
| events: on EventTarget support + once compliance #33659 | https://github.com/nodejs/node/pull/33659 |
| events: Handle a range of this values for dispatchEvent #33661 | https://github.com/nodejs/node/pull/33661 |
| events: expose Event statics #33649 | https://github.com/nodejs/node/pull/33649 |
| events: support event handlers #33646 | https://github.com/nodejs/node/pull/33646 |
| events: support dispatching event from event #33624 | https://github.com/nodejs/node/pull/33624 |
| events: improve argument handling, start passive #33637 | https://github.com/nodejs/node/pull/33637 |
| benchmark: fix EventTarget benchmark #34004 | https://github.com/nodejs/node/pull/34004 |
| @benjamingr | https://github.com/benjamingr |
| @mscdex | https://github.com/mscdex |
| @lundibundi | https://github.com/lundibundi |
| @Zirak | https://github.com/Zirak |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
| lundibundi | https://github.com/lundibundi |
| June 21, 2020 07:35 | https://github.com/nodejs/node/pull/34015#commits-pushed-343bcf7 |
|
| https://github.com/lundibundi |
|
| https://github.com/jasnell |
| events: use internal/validators in event_target.js | https://github.com/nodejs/node/pull/34015/commits/343bcf7594c8f0c9975a2adc657fae63be74bf6a |
| 343bcf7 | https://github.com/nodejs/node/pull/34015/commits/343bcf7594c8f0c9975a2adc657fae63be74bf6a |
|
| https://github.com/lundibundi |
|
| https://github.com/jasnell |
| events: fix depth in customInspectSymbol and clean up | https://github.com/nodejs/node/pull/34015/commits/8a220fc7ea02b0be4bb89efd1b02994250cb69e0 |
| 8a220fc | https://github.com/nodejs/node/pull/34015/commits/8a220fc7ea02b0be4bb89efd1b02994250cb69e0 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
eventtarget
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aeventtarget |
| Jun 22, 2020 | https://github.com/nodejs/node/pull/34015#event-3468619077 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
| Jun 22, 2020 | https://github.com/nodejs/node/pull/34015#event-3468619418 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
experimental
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental |
| Jun 22, 2020 | https://github.com/nodejs/node/pull/34015#event-3468620160 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34015 |
| benjamingr | https://github.com/benjamingr |
| June 22, 2020 07:54 | https://github.com/nodejs/node/pull/34015#commits-pushed-fea2394 |
|
| https://github.com/benjamingr |
|
| https://github.com/jasnell |
| events: fix EventTarget support | https://github.com/nodejs/node/pull/34015/commits/fea2394ea1cdbb220a0002b7fccb24d24da9e33d |
| fea2394 | https://github.com/nodejs/node/pull/34015/commits/fea2394ea1cdbb220a0002b7fccb24d24da9e33d |
|
| https://github.com/Zirak |
|
| https://github.com/jasnell |
| events: Handle a range of this values for dispatchEvent | https://github.com/nodejs/node/pull/34015/commits/5d34ea003264d29e478ecf8c4c1c775f0c89f896 |
| 5d34ea0 | https://github.com/nodejs/node/pull/34015/commits/5d34ea003264d29e478ecf8c4c1c775f0c89f896 |
|
| https://github.com/benjamingr |
|
| https://github.com/jasnell |
| events: expose Event statics | https://github.com/nodejs/node/pull/34015/commits/df1a0061b1dd9b72b89534061b2e3d1c31251933 |
| df1a006 | https://github.com/nodejs/node/pull/34015/commits/df1a0061b1dd9b72b89534061b2e3d1c31251933 |
|
| https://github.com/benjamingr |
|
| https://github.com/jasnell |
| events: support event handlers | https://github.com/nodejs/node/pull/34015/commits/5893b88c2fc20f155bb8dea882300ad11a42e3d4 |
| 5893b88 | https://github.com/nodejs/node/pull/34015/commits/5893b88c2fc20f155bb8dea882300ad11a42e3d4 |
|
| https://github.com/benjamingr |
|
| https://github.com/jasnell |
| event: cancelBubble is a property | https://github.com/nodejs/node/pull/34015/commits/2c7b2b615a733d59cea4a6680a360a4fb3e7b459 |
| 2c7b2b6 | https://github.com/nodejs/node/pull/34015/commits/2c7b2b615a733d59cea4a6680a360a4fb3e7b459 |
| nodejs#33613 | https://github.com/nodejs/node/pull/33613 |
|
| https://github.com/jasnell |
| events: add event-target tests | https://github.com/nodejs/node/pull/34015/commits/d900f872beeae1237c9487ed157b35f89c463184 |
| d900f87 | https://github.com/nodejs/node/pull/34015/commits/d900f872beeae1237c9487ed157b35f89c463184 |
|
| https://github.com/jasnell |
|
| https://github.com/benjamingr |
| events: support dispatching event from event | https://github.com/nodejs/node/pull/34015/commits/dbddf3c4d2e3342429b01248f4fdc2e1051b3882 |
| dbddf3c | https://github.com/nodejs/node/pull/34015/commits/dbddf3c4d2e3342429b01248f4fdc2e1051b3882 |
|
| https://github.com/jasnell |
|
| https://github.com/benjamingr |
| events: improve argument handling, start passive | https://github.com/nodejs/node/pull/34015/commits/227258bd91ce5d24d285180ed953c6ec5ba9ecaa |
| 227258b | https://github.com/nodejs/node/pull/34015/commits/227258bd91ce5d24d285180ed953c6ec5ba9ecaa |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
| benchmark: fix EventTarget benchmark | https://github.com/nodejs/node/pull/34015/commits/65af6f1838ebd0c074b96341a05315c79ea0f272 |
| 65af6f1 | https://github.com/nodejs/node/pull/34015/commits/65af6f1838ebd0c074b96341a05315c79ea0f272 |
| nodejs#33782 | https://github.com/nodejs/node/issues/33782 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/532379f7add0a299aea2d4331e19911099012728..65af6f1838ebd0c074b96341a05315c79ea0f272 |
| 532379f | https://github.com/nodejs/node/commit/532379f7add0a299aea2d4331e19911099012728 |
| 65af6f1 | https://github.com/nodejs/node/commit/65af6f1838ebd0c074b96341a05315c79ea0f272 |
|
Compare
| https://github.com/nodejs/node/compare/532379f7add0a299aea2d4331e19911099012728..65af6f1838ebd0c074b96341a05315c79ea0f272 |
| June 22, 2020 15:05 | https://github.com/nodejs/node/pull/34015#event-3468821067 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 22, 2020 | https://github.com/nodejs/node/pull/34015#issuecomment-647578170 |
| https://ci.nodejs.org/job/node-test-pull-request/32021/ | https://ci.nodejs.org/job/node-test-pull-request/32021/ |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
|
events: EventTarget use validators and small fix
#33663
| https://github.com/nodejs/node/pull/33663 |
|
events: on EventTarget support + once compliance
#33659
| https://github.com/nodejs/node/pull/33659 |
|
events: Handle a range of this values for dispatchEvent
#33661
| https://github.com/nodejs/node/pull/33661 |
|
events: expose Event statics
#33649
| https://github.com/nodejs/node/pull/33649 |
|
events: support event handlers
#33646
| https://github.com/nodejs/node/pull/33646 |
|
events: support dispatching event from event
#33624
| https://github.com/nodejs/node/pull/33624 |
|
events: improve argument handling, start passive
#33637
| https://github.com/nodejs/node/pull/33637 |
|
benchmark: fix EventTarget benchmark
#34004
| https://github.com/nodejs/node/pull/34004 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Jun 22, 2020
| https://github.com/nodejs/node/pull/34015#pullrequestreview-435069780 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34015/files/65af6f1838ebd0c074b96341a05315c79ea0f272 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 22, 2020 | https://github.com/nodejs/node/pull/34015#event-3469679053 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jun 23, 2020
| https://github.com/nodejs/node/pull/34015#ref-issue-643437799 |
|
CI Relability 2020-06-23
JaneaSystems/nodejs-reliability#16
| https://github.com/JaneaSystems/nodejs-reliability/issues/16 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jun 23, 2020
| https://github.com/nodejs/node/pull/34015#pullrequestreview-435590554 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34015/files/65af6f1838ebd0c074b96341a05315c79ea0f272 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jun 23, 2020 | https://github.com/nodejs/node/pull/34015#issuecomment-648014842 |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 27, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-ea1a2d7 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: support dispatching event from event | https://github.com/nodejs/node/commit/ea1a2d7bc9dd6af9298980d02bb73da2d95ba1a7 |
| ea1a2d7 | https://github.com/nodejs/node/commit/ea1a2d7bc9dd6af9298980d02bb73da2d95ba1a7 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 27, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-c34f474 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: improve argument handling, start passive | https://github.com/nodejs/node/commit/c34f4743c4107d7b8e866c6390f62513a087dc7f |
| c34f474 | https://github.com/nodejs/node/commit/c34f4743c4107d7b8e866c6390f62513a087dc7f |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 27, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-0eed22d |
|
| https://github.com/mscdex |
|
| https://github.com/codebytere |
| benchmark: fix EventTarget benchmark | https://github.com/nodejs/node/commit/0eed22d6ed6335fef2e848391860ddde2f1e41cb |
| 0eed22d | https://github.com/nodejs/node/commit/0eed22d6ed6335fef2e848391860ddde2f1e41cb |
| #33782 | https://github.com/nodejs/node/issues/33782 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 28, 2020
| https://github.com/nodejs/node/pull/34015#ref-pullrequest-646828333 |
|
v14.5.0 proposal
#34093
| https://github.com/nodejs/node/pull/34093 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-eaf5e21 |
|
| https://github.com/lundibundi |
|
| https://github.com/codebytere |
| events: use internal/validators in event_target.js | https://github.com/nodejs/node/commit/eaf5e2169d9563a290f99a965726e4bf0a0be9f6 |
| eaf5e21 | https://github.com/nodejs/node/commit/eaf5e2169d9563a290f99a965726e4bf0a0be9f6 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-655422a |
|
| https://github.com/lundibundi |
|
| https://github.com/codebytere |
| events: fix depth in customInspectSymbol and clean up | https://github.com/nodejs/node/commit/655422a816a5d3d03f72651d65f567596c1390fd |
| 655422a | https://github.com/nodejs/node/commit/655422a816a5d3d03f72651d65f567596c1390fd |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-6659aec |
|
| https://github.com/benjamingr |
|
| https://github.com/codebytere |
| events: fix EventTarget support | https://github.com/nodejs/node/commit/6659aec1c1eb61bb2faa550961f66289cb530dc5 |
| 6659aec | https://github.com/nodejs/node/commit/6659aec1c1eb61bb2faa550961f66289cb530dc5 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-5810885 |
|
| https://github.com/Zirak |
|
| https://github.com/codebytere |
| events: Handle a range of this values for dispatchEvent | https://github.com/nodejs/node/commit/5810885879ec094185851c7c5a2eb6b17a406077 |
| 5810885 | https://github.com/nodejs/node/commit/5810885879ec094185851c7c5a2eb6b17a406077 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-a3a6a4d |
|
| https://github.com/benjamingr |
|
| https://github.com/codebytere |
| events: expose Event statics | https://github.com/nodejs/node/commit/a3a6a4d618e0f6d01e371ea27c2f7a5d44f6b7ec |
| a3a6a4d | https://github.com/nodejs/node/commit/a3a6a4d618e0f6d01e371ea27c2f7a5d44f6b7ec |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-6ac767c |
|
| https://github.com/benjamingr |
|
| https://github.com/codebytere |
| events: support event handlers | https://github.com/nodejs/node/commit/6ac767ca97f262b229451f15f1fed7ff00946a36 |
| 6ac767c | https://github.com/nodejs/node/commit/6ac767ca97f262b229451f15f1fed7ff00946a36 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-3190d85 |
|
| https://github.com/benjamingr |
|
| https://github.com/codebytere |
| event: cancelBubble is a property | https://github.com/nodejs/node/commit/3190d85d3d011a4ef6452cb92fe672c934c2c8d6 |
| 3190d85 | https://github.com/nodejs/node/commit/3190d85d3d011a4ef6452cb92fe672c934c2c8d6 |
| #33613 | https://github.com/nodejs/node/pull/33613 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-79339d7 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: add event-target tests | https://github.com/nodejs/node/commit/79339d72677f8cd91c5388f00c5196338838391e |
| 79339d7 | https://github.com/nodejs/node/commit/79339d72677f8cd91c5388f00c5196338838391e |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-f462057 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: support dispatching event from event | https://github.com/nodejs/node/commit/f46205736d34a789d511b7b7dd5c9d28d39cc04d |
| f462057 | https://github.com/nodejs/node/commit/f46205736d34a789d511b7b7dd5c9d28d39cc04d |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-a711165 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: improve argument handling, start passive | https://github.com/nodejs/node/commit/a71116502295101e309a2f95cf2a5c6bd7c7837b |
| a711165 | https://github.com/nodejs/node/commit/a71116502295101e309a2f95cf2a5c6bd7c7837b |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/34015#ref-commit-8c48ef5 |
|
| https://github.com/mscdex |
|
| https://github.com/codebytere |
| benchmark: fix EventTarget benchmark | https://github.com/nodejs/node/commit/8c48ef54f99eae4c235d0d34a5738108bf13d6c2 |
| 8c48ef5 | https://github.com/nodejs/node/commit/8c48ef54f99eae4c235d0d34a5738108bf13d6c2 |
| #33782 | https://github.com/nodejs/node/issues/33782 |
| #34015 | https://github.com/nodejs/node/pull/34015 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 3, 2020
| https://github.com/nodejs/node/pull/34015#ref-issue-691704377 |
|
indefinite behavior of nodejs/events.once() on WebSocket
websockets/ws#1795
| https://github.com/websockets/ws/issues/1795 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34015#ref-pullrequest-705877178 |
|
V14.12.0 proposal
#35285
| https://github.com/nodejs/node/pull/35285 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34015#ref-pullrequest-624383334 |
|
events: initial implementation of experimental EventTarget
#33556
| https://github.com/nodejs/node/pull/33556 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backport-requested-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x |
| Sep 22, 2020 | https://github.com/nodejs/node/pull/34015#event-3795094527 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34015 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/34015/files/65af6f1838ebd0c074b96341a05315c79ea0f272 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/34015/files/65af6f1838ebd0c074b96341a05315c79ea0f272 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
eventtarget
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aeventtarget |
|
experimental
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Please reload this page | https://github.com/nodejs/node/pull/34015 |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/benjamingr |
|
| https://github.com/lundibundi |
|
| https://github.com/addaleax |
|
| https://github.com/Zirak |
|
| https://github.com/mscdex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |