René's URL Explorer Experiment


Title: src: reduce scope of code cache mutex by addaleax · Pull Request #33980 · nodejs/node · GitHub

Open Graph Title: src: reduce scope of code cache mutex by addaleax · Pull Request #33980 · nodejs/node

X Title: src: reduce scope of code cache mutex by addaleax · Pull Request #33980 · nodejs/node

Description: As indicated in the added comment, this can lead to a deadlock otherwise. In the concrete instance in which I encountered this, the relevant nested call is the one to require('internal/tty') inside...

Open Graph Description: As indicated in the added comment, this can lead to a deadlock otherwise. In the concrete instance in which I encountered this, the relevant nested call is the one to require('internal/tty'...

X Description: As indicated in the added comment, this can lead to a deadlock otherwise. In the concrete instance in which I encountered this, the relevant nested call is the one to require('internal/tty&...

Opengraph URL: https://github.com/nodejs/node/pull/33980

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:35dc654c-a8f6-b9ae-106f-86d0ce1c5410
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD622:178041:131ECF0:1A66D3E:696A91B9
html-safe-nonce16f5b9f8069bea111eaae6dc8110f2f375a2ef60bdcdf6459ae79d2ad96ed27f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjIyOjE3ODA0MToxMzFFQ0YwOjFBNjZEM0U6Njk2QTkxQjkiLCJ2aXNpdG9yX2lkIjoiNTQzNTcyMzU3ODA5MjQ1ODQyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc13bcf4b892aa1a32ac4f2deeb8f18e6e102819c899b9c4a5540314829b6155d
hovercard-subject-tagpull_request:437301039
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33980/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fc35e2fe2f541319af9262a65025827d950e8faf141c86f9ca199b3fca6c0176/nodejs/node/pull/33980
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fc35e2fe2f541319af9262a65025827d950e8faf141c86f9ca199b3fca6c0176/nodejs/node/pull/33980
og:image:altAs indicated in the added comment, this can lead to a deadlock otherwise. In the concrete instance in which I encountered this, the relevant nested call is the one to require('internal/tty'...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33980#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33980
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33980
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33980
Reloadhttps://github.com/nodejs/node/pull/33980
Reloadhttps://github.com/nodejs/node/pull/33980
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33980
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33980
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33980#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:native-module-code-cache-lockhttps://github.com/addaleax/node/tree/native-module-code-cache-lock
src: reduce scope of code cache mutex https://github.com/nodejs/node/pull/33980#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:native-module-code-cache-lockhttps://github.com/addaleax/node/tree/native-module-code-cache-lock
Conversation 2 https://github.com/nodejs/node/pull/33980
Commits 1 https://github.com/nodejs/node/pull/33980/commits
Checks 0 https://github.com/nodejs/node/pull/33980/checks
Files changed https://github.com/nodejs/node/pull/33980/files
Please reload this pagehttps://github.com/nodejs/node/pull/33980
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 19, 2020https://github.com/nodejs/node/pull/33980#issue-642224655
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33980
https://github.com/addaleax
src: reduce scope of code cache mutexhttps://github.com/nodejs/node/pull/33980/commits/0840aab1e0c549755e85aaa187278ddea8a294a9
0840aabhttps://github.com/nodejs/node/pull/33980/commits/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
joyeecheunghttps://github.com/joyeecheung
June 19, 2020 21:23https://github.com/nodejs/node/pull/33980#event-3463923561
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 19, 2020https://github.com/nodejs/node/pull/33980#event-3463923693
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 19, 2020 https://github.com/nodejs/node/pull/33980#pullrequestreview-434358836
View reviewed changes https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 20, 2020 https://github.com/nodejs/node/pull/33980#pullrequestreview-434412303
View reviewed changes https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 20, 2020 https://github.com/nodejs/node/pull/33980#pullrequestreview-434429181
View reviewed changes https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 20, 2020https://github.com/nodejs/node/pull/33980#event-3464700847
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 20, 2020https://github.com/nodejs/node/pull/33980#issuecomment-647010995
https://ci.nodejs.org/job/node-test-pull-request/31992/https://ci.nodejs.org/job/node-test-pull-request/31992/
Please reload this pagehttps://github.com/nodejs/node/pull/33980
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 20, 2020https://github.com/nodejs/node/pull/33980#event-3464792469
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jun 21, 2020 https://github.com/nodejs/node/pull/33980#pullrequestreview-434488381
View reviewed changes https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/himself65
himself65https://github.com/himself65
Jun 22, 2020 https://github.com/nodejs/node/pull/33980#pullrequestreview-434555635
View reviewed changes https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 22, 2020 https://github.com/nodejs/node/pull/33980#pullrequestreview-434922377
View reviewed changes https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
danbevhttps://github.com/danbev
Jun 24, 2020 https://github.com/nodejs/node/pull/33980#ref-commit-d8f8723
https://github.com/addaleax
https://github.com/danbev
src: reduce scope of code cache mutexhttps://github.com/nodejs/node/commit/d8f8723577583d0d3d0239013c6e503c7d4e3abb
d8f8723https://github.com/nodejs/node/commit/d8f8723577583d0d3d0239013c6e503c7d4e3abb
#33980https://github.com/nodejs/node/pull/33980
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 24, 2020https://github.com/nodejs/node/pull/33980#issuecomment-648568030
d8f8723https://github.com/nodejs/node/commit/d8f8723577583d0d3d0239013c6e503c7d4e3abb
Please reload this pagehttps://github.com/nodejs/node/pull/33980
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 24, 2020https://github.com/nodejs/node/pull/33980#event-3475666483
codebyterehttps://github.com/codebytere
Jun 27, 2020 https://github.com/nodejs/node/pull/33980#ref-commit-0dd67d9
https://github.com/addaleax
https://github.com/codebytere
src: reduce scope of code cache mutexhttps://github.com/nodejs/node/commit/0dd67d992ec3a9a4baa5946d9c8d86df27b33e2c
0dd67d9https://github.com/nodejs/node/commit/0dd67d992ec3a9a4baa5946d9c8d86df27b33e2c
#33980https://github.com/nodejs/node/pull/33980
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33980#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33980#ref-commit-15b6d38
https://github.com/addaleax
https://github.com/codebytere
src: reduce scope of code cache mutexhttps://github.com/nodejs/node/commit/15b6d38e77316675962c7202c204861dd8acb981
15b6d38https://github.com/nodejs/node/commit/15b6d38e77316675962c7202c204861dd8acb981
#33980https://github.com/nodejs/node/pull/33980
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33980#ref-commit-437f387
https://github.com/addaleax
https://github.com/codebytere
src: reduce scope of code cache mutexhttps://github.com/nodejs/node/commit/437f387de9d5c072f7b476f1d29566f3e29b2cf7
437f387https://github.com/nodejs/node/commit/437f387de9d5c072f7b476f1d29566f3e29b2cf7
#33980https://github.com/nodejs/node/pull/33980
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/33980#ref-pullrequest-656085086
v12.18.3 proposal #34343 https://github.com/nodejs/node/pull/34343
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33980#ref-commit-cc2d380
https://github.com/addaleax
https://github.com/codebytere
src: reduce scope of code cache mutexhttps://github.com/nodejs/node/commit/cc2d380197b0782cdea781353ad26320d9aabef5
cc2d380https://github.com/nodejs/node/commit/cc2d380197b0782cdea781353ad26320d9aabef5
#33980https://github.com/nodejs/node/pull/33980
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33980
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/33980/files/0840aab1e0c549755e85aaa187278ddea8a294a9
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33980
https://github.com/addaleax
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com/devnexen
https://github.com/devsnek
https://github.com/himself65
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.