| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d53e624-1ef8-07c5-e17c-abf59a7266af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A9D4:3E22DA:86EE2F:BA0CCA:696A7629 |
| html-safe-nonce | d13c0b8ec186f8eebbd4b847b92e861b7de2dd4e4c0953f919d116809c8c0e3b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUQ0OjNFMjJEQTo4NkVFMkY6QkEwQ0NBOjY5NkE3NjI5IiwidmlzaXRvcl9pZCI6IjQyMjE1NzY0NDI4MDI3NjMzMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a03aee5a0877dca3b18cbe19a0a3aec66248509d85ab32d8d42bd7622086bb90 |
| hovercard-subject-tag | pull_request:435458541 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33915/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8fa7755397dc5a2959bf5eea238a251def67e421cf1b299afd71a4a3f66fb19c/nodejs/node/pull/33915 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8fa7755397dc5a2959bf5eea238a251def67e421cf1b299afd71a4a3f66fb19c/nodejs/node/pull/33915 |
| og:image:alt | Document that it is not necessary to open handle and/or callback scopes
inside finalizer, async work, thread-safe function etc. callbacks
unless for reasons documented in the section about object l... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33915#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33915 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33915 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33915 |
| Reload | https://github.com/nodejs/node/pull/33915 |
| Reload | https://github.com/nodejs/node/pull/33915 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33915#issue-comment-box |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:document-scope-usage | https://github.com/gabrielschulhof/node/tree/document-scope-usage |
|
doc: document n-api callback scope usage
| https://github.com/nodejs/node/pull/33915#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gabrielschulhof:document-scope-usage | https://github.com/gabrielschulhof/node/tree/document-scope-usage |
|
Conversation
3
| https://github.com/nodejs/node/pull/33915 |
|
Commits
1
| https://github.com/nodejs/node/pull/33915/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33915/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33915/files |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 16, 2020 | https://github.com/nodejs/node/pull/33915#issue-639962318 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jun 16, 2020 | https://github.com/nodejs/node/pull/33915#event-3450807054 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| BridgeAR | https://github.com/BridgeAR |
| mhdawson | https://github.com/mhdawson |
| sam-github | https://github.com/sam-github |
| June 16, 2020 20:48 | https://github.com/nodejs/node/pull/33915#event-3450807065 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jun 16, 2020
| https://github.com/nodejs/node/pull/33915#pullrequestreview-431886347 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33915/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/33915#pullrequestreview-431886347 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/06e0c9c89d090fbad95e73759fcfe7d5191b2ab9..792f4f77cb388ea4d15801f87a6f1c093dc30189 |
| 06e0c9c | https://github.com/nodejs/node/commit/06e0c9c89d090fbad95e73759fcfe7d5191b2ab9 |
| 792f4f7 | https://github.com/nodejs/node/commit/792f4f77cb388ea4d15801f87a6f1c093dc30189 |
|
Compare
| https://github.com/nodejs/node/compare/06e0c9c89d090fbad95e73759fcfe7d5191b2ab9..792f4f77cb388ea4d15801f87a6f1c093dc30189 |
| June 16, 2020 23:30 | https://github.com/nodejs/node/pull/33915#event-3451224298 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 16, 2020 | https://github.com/nodejs/node/pull/33915#issuecomment-645062514 |
| #33893 | https://github.com/nodejs/node/issues/33893 |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Jun 19, 2020
| https://github.com/nodejs/node/pull/33915#pullrequestreview-433780151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33915/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 19, 2020
| https://github.com/nodejs/node/pull/33915#pullrequestreview-434202944 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33915/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 19, 2020
| https://github.com/nodejs/node/pull/33915#pullrequestreview-434259929 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33915/files |
| doc: document n-api callback scope usage | https://github.com/nodejs/node/pull/33915/commits/e15ff2e3c1f0eff830d9081b4c19e8758b76c6de |
| e15ff2e | https://github.com/nodejs/node/pull/33915/commits/e15ff2e3c1f0eff830d9081b4c19e8758b76c6de |
| nodejs#33893 | https://github.com/nodejs/node/issues/33893 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node/compare/792f4f77cb388ea4d15801f87a6f1c093dc30189..e15ff2e3c1f0eff830d9081b4c19e8758b76c6de |
| 792f4f7 | https://github.com/nodejs/node/commit/792f4f77cb388ea4d15801f87a6f1c093dc30189 |
| e15ff2e | https://github.com/nodejs/node/commit/e15ff2e3c1f0eff830d9081b4c19e8758b76c6de |
|
Compare
| https://github.com/nodejs/node/compare/792f4f77cb388ea4d15801f87a6f1c093dc30189..e15ff2e3c1f0eff830d9081b4c19e8758b76c6de |
| June 23, 2020 18:36 | https://github.com/nodejs/node/pull/33915#event-3474290477 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 23, 2020
| https://github.com/nodejs/node/pull/33915#ref-commit-af83dcd |
| doc: document n-api callback scope usage | https://github.com/nodejs/node/commit/af83dcd5f46ecc6c3662cd0c18100a61118ca5e7 |
| af83dcd | https://github.com/nodejs/node/commit/af83dcd5f46ecc6c3662cd0c18100a61118ca5e7 |
| #33893 | https://github.com/nodejs/node/issues/33893 |
| #33915 | https://github.com/nodejs/node/pull/33915 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 23, 2020 | https://github.com/nodejs/node/pull/33915#issuecomment-648468606 |
| af83dcd | https://github.com/nodejs/node/commit/af83dcd5f46ecc6c3662cd0c18100a61118ca5e7 |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jun 23, 2020 | https://github.com/nodejs/node/pull/33915#event-3475100847 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| June 23, 2020 22:52 | https://github.com/nodejs/node/pull/33915#event-3475101711 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/33915#ref-commit-9c7c29f |
|
| https://github.com/MylesBorins |
| doc: document n-api callback scope usage | https://github.com/nodejs/node/commit/9c7c29f0ff1df1786f31deb863edee35ec78c934 |
| 9c7c29f | https://github.com/nodejs/node/commit/9c7c29f0ff1df1786f31deb863edee35ec78c934 |
| #33893 | https://github.com/nodejs/node/issues/33893 |
| #33915 | https://github.com/nodejs/node/pull/33915 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/33915#ref-pullrequest-656877627 |
|
v14.6.0 proposal
#34371
| https://github.com/nodejs/node/pull/34371 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/33915#ref-commit-b8a17cc |
|
| https://github.com/MylesBorins |
| doc: document n-api callback scope usage | https://github.com/nodejs/node/commit/b8a17ccc9a5e835e50fcee5592c5d8abffde1321 |
| b8a17cc | https://github.com/nodejs/node/commit/b8a17ccc9a5e835e50fcee5592c5d8abffde1321 |
| #33893 | https://github.com/nodejs/node/issues/33893 |
| #33915 | https://github.com/nodejs/node/pull/33915 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/33915#ref-commit-6d22ae3 |
|
| https://github.com/addaleax |
| doc: document n-api callback scope usage | https://github.com/nodejs/node/commit/6d22ae36302a9f86d417f1eb35b1ca694b468e9d |
| 6d22ae3 | https://github.com/nodejs/node/commit/6d22ae36302a9f86d417f1eb35b1ca694b468e9d |
| #33893 | https://github.com/nodejs/node/issues/33893 |
| #33915 | https://github.com/nodejs/node/pull/33915 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/33915#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33915 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33915/files/792f4f77cb388ea4d15801f87a6f1c093dc30189 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/33915/files/792f4f77cb388ea4d15801f87a6f1c093dc30189 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/33915/files/792f4f77cb388ea4d15801f87a6f1c093dc30189 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/33915/files/06e0c9c89d090fbad95e73759fcfe7d5191b2ab9 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/33915 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/legendecas |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |