René's URL Explorer Experiment


Title: lib: remove manual exception handling in queueMicrotask by devsnek · Pull Request #33859 · nodejs/node · GitHub

Open Graph Title: lib: remove manual exception handling in queueMicrotask by devsnek · Pull Request #33859 · nodejs/node

X Title: lib: remove manual exception handling in queueMicrotask by devsnek · Pull Request #33859 · nodejs/node

Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/33859

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b266c6d-e0bd-a6ce-a5ac-912daaa24509
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB7E:247E0C:DEA0CD:134E3A5:696A8F78
html-safe-nonce79ee4a68f9c036b9d3af974fac4ca22777cd1a437148ae46a813e0eb223951c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjdFOjI0N0UwQzpERUEwQ0Q6MTM0RTNBNTo2OTZBOEY3OCIsInZpc2l0b3JfaWQiOiIzNDQ0NjM3MzM3MzYwNDM3MTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbe2064f0b2c9217d978621992696db205790f44799df119ae20c5257df8046f3
hovercard-subject-tagpull_request:433887353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33859/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c68e0d0dd10ba52fa14a013328089c3f984e01546596795c12772ac97b3c58a/nodejs/node/pull/33859
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c68e0d0dd10ba52fa14a013328089c3f984e01546596795c12772ac97b3c58a/nodejs/node/pull/33859
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevsnek
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33859#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33859
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33859
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33859
Reloadhttps://github.com/nodejs/node/pull/33859
Reloadhttps://github.com/nodejs/node/pull/33859
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33859
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33859
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33859#issue-comment-box
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:proper-error-handlinghttps://github.com/devsnek/node/tree/proper-error-handling
lib: remove manual exception handling in queueMicrotask https://github.com/nodejs/node/pull/33859#top
devsnekhttps://github.com/devsnek
nodejs:masterhttps://github.com/nodejs/node/tree/master
devsnek:proper-error-handlinghttps://github.com/devsnek/node/tree/proper-error-handling
Conversation 5 https://github.com/nodejs/node/pull/33859
Commits 2 https://github.com/nodejs/node/pull/33859/commits
Checks 0 https://github.com/nodejs/node/pull/33859/checks
Files changed https://github.com/nodejs/node/pull/33859/files
Please reload this pagehttps://github.com/nodejs/node/pull/33859
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Jun 12, 2020https://github.com/nodejs/node/pull/33859#issue-638006642
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33859
devsnekhttps://github.com/devsnek
June 12, 2020 14:45https://github.com/nodejs/node/pull/33859#commits-pushed-ce4d184
https://github.com/devsnek
deps: V8: cherry-pick 767e65f945e7https://github.com/nodejs/node/pull/33859/commits/ce4d184fbd2883492f835898d822b48c69a5a7af
ce4d184https://github.com/nodejs/node/pull/33859/commits/ce4d184fbd2883492f835898d822b48c69a5a7af
https://chromium-review.googlesource.com/c/v8/v8/+/2162121https://chromium-review.googlesource.com/c/v8/v8/+/2162121
v8/v8@767e65fhttps://github.com/v8/v8/commit/767e65f945e7caa4becc2bd4b5e9ea8562da0ca4
https://github.com/devsnek
lib: remove manual exception handling in queueMicrotaskhttps://github.com/nodejs/node/pull/33859/commits/b9f5307ce2d5290470ad9df00c6fff5d143776c6
b9f5307https://github.com/nodejs/node/pull/33859/commits/b9f5307ce2d5290470ad9df00c6fff5d143776c6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jun 12, 2020https://github.com/nodejs/node/pull/33859#event-3439960818
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 13, 2020 https://github.com/nodejs/node/pull/33859#pullrequestreview-430166926
View reviewed changes https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 13, 2020 https://github.com/nodejs/node/pull/33859#pullrequestreview-430166951
View reviewed changes https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
lib/internal/process/task_queues.jshttps://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6#diff-99bad7c13fcb19d95a5047ca8d7f7e519c19932899f2346085390b1b2e1f33c1
addaleaxhttps://github.com/addaleax
Jun 13, 2020https://github.com/nodejs/node/pull/33859#discussion_r439769043
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33859
devsnekhttps://github.com/devsnek
Jun 13, 2020https://github.com/nodejs/node/pull/33859#discussion_r439776749
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33859
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 13, 2020https://github.com/nodejs/node/pull/33859#issuecomment-643692684
https://ci.nodejs.org/job/node-test-pull-request/31857/https://ci.nodejs.org/job/node-test-pull-request/31857/
Please reload this pagehttps://github.com/nodejs/node/pull/33859
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jun 14, 2020 https://github.com/nodejs/node/pull/33859#pullrequestreview-430227612
View reviewed changes https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 14, 2020https://github.com/nodejs/node/pull/33859#issuecomment-643780490
https://ci.nodejs.org/job/node-test-pull-request/31864/https://ci.nodejs.org/job/node-test-pull-request/31864/
Please reload this pagehttps://github.com/nodejs/node/pull/33859
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2020 https://github.com/nodejs/node/pull/33859#pullrequestreview-430237535
View reviewed changes https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
CI Relability 2020-06-18 JaneaSystems/nodejs-reliability#11 https://github.com/JaneaSystems/nodejs-reliability/issues/11
CI Relability 2020-06-19 JaneaSystems/nodejs-reliability#12 https://github.com/JaneaSystems/nodejs-reliability/issues/12
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Jun 19, 2020https://github.com/nodejs/node/pull/33859#event-3463062362
addaleaxhttps://github.com/addaleax
Jun 19, 2020 https://github.com/nodejs/node/pull/33859#ref-commit-8f000ea
https://github.com/devsnek
https://github.com/addaleax
deps: V8: cherry-pick 767e65f945e7https://github.com/nodejs/node/commit/8f000ea09f6ee20b50cb83e6f7b2cb25671ef6f2
8f000eahttps://github.com/nodejs/node/commit/8f000ea09f6ee20b50cb83e6f7b2cb25671ef6f2
v8:8326https://bugs.chromium.org/p/v8/issues/detail?id=8326
https://chromium-review.googlesource.com/c/v8/v8/+/2162121https://chromium-review.googlesource.com/c/v8/v8/+/2162121
v8/v8@767e65fhttps://github.com/v8/v8/commit/767e65f945e7caa4becc2bd4b5e9ea8562da0ca4
#33859https://github.com/nodejs/node/pull/33859
addaleaxhttps://github.com/addaleax
Jun 19, 2020 https://github.com/nodejs/node/pull/33859#ref-commit-178e52a
https://github.com/devsnek
https://github.com/addaleax
lib: remove manual exception handling in queueMicrotaskhttps://github.com/nodejs/node/commit/178e52a7ead2ef9ffb6eb5e17be167f17beb45a8
178e52ahttps://github.com/nodejs/node/commit/178e52a7ead2ef9ffb6eb5e17be167f17beb45a8
#33859https://github.com/nodejs/node/pull/33859
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 19, 2020https://github.com/nodejs/node/pull/33859#issuecomment-646715202
a86a295...178e52ahttps://github.com/nodejs/node/compare/a86a295fd7162a7fdf406a21b3c3c679819c60b5...178e52a7ead2ef9ffb6eb5e17be167f17beb45a8
Please reload this pagehttps://github.com/nodejs/node/pull/33859
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 19, 2020https://github.com/nodejs/node/pull/33859#event-3463065039
https://github.com/devsnek
devsnekhttps://github.com/devsnek
June 19, 2020 17:04https://github.com/nodejs/node/pull/33859#event-3463275542
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x
backport-requested-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x
Jun 27, 2020https://github.com/nodejs/node/pull/33859#event-3489141721
codebyterehttps://github.com/codebytere
Jun 27, 2020 https://github.com/nodejs/node/pull/33859#ref-commit-5957afc
https://github.com/devsnek
https://github.com/codebytere
deps: V8: cherry-pick 767e65f945e7https://github.com/nodejs/node/commit/5957afc31a26b109929090bffd97a1106f400925
5957afchttps://github.com/nodejs/node/commit/5957afc31a26b109929090bffd97a1106f400925
v8:8326https://bugs.chromium.org/p/v8/issues/detail?id=8326
https://chromium-review.googlesource.com/c/v8/v8/+/2162121https://chromium-review.googlesource.com/c/v8/v8/+/2162121
v8/v8@767e65fhttps://github.com/v8/v8/commit/767e65f945e7caa4becc2bd4b5e9ea8562da0ca4
#33859https://github.com/nodejs/node/pull/33859
codebyterehttps://github.com/codebytere
Jun 27, 2020 https://github.com/nodejs/node/pull/33859#ref-commit-b6ef6c8
https://github.com/devsnek
https://github.com/codebytere
lib: remove manual exception handling in queueMicrotaskhttps://github.com/nodejs/node/commit/b6ef6c8476666fddeb378a049aaefedae7dec754
b6ef6c8https://github.com/nodejs/node/commit/b6ef6c8476666fddeb378a049aaefedae7dec754
#33859https://github.com/nodejs/node/pull/33859
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33859#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33859#ref-commit-59ca593
https://github.com/devsnek
https://github.com/codebytere
deps: V8: cherry-pick 767e65f945e7https://github.com/nodejs/node/commit/59ca593fccc04e5acf96259c62667df372490dfb
59ca593https://github.com/nodejs/node/commit/59ca593fccc04e5acf96259c62667df372490dfb
v8:8326https://bugs.chromium.org/p/v8/issues/detail?id=8326
https://chromium-review.googlesource.com/c/v8/v8/+/2162121https://chromium-review.googlesource.com/c/v8/v8/+/2162121
v8/v8@767e65fhttps://github.com/v8/v8/commit/767e65f945e7caa4becc2bd4b5e9ea8562da0ca4
#33859https://github.com/nodejs/node/pull/33859
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33859#ref-commit-9a4a283
https://github.com/devsnek
https://github.com/codebytere
lib: remove manual exception handling in queueMicrotaskhttps://github.com/nodejs/node/commit/9a4a283b30402fb4fb43be5593ce1d1458ab6170
9a4a283https://github.com/nodejs/node/commit/9a4a283b30402fb4fb43be5593ce1d1458ab6170
#33859https://github.com/nodejs/node/pull/33859
Throw within queueMicrotask callbacks should not crash Node #38145 https://github.com/nodejs/node/issues/38145
Throw within queueMicrotask callbacks should not crash Node #38225 https://github.com/nodejs/node/pull/38225
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33859
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33859/files/b9f5307ce2d5290470ad9df00c6fff5d143776c6
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/33859
https://github.com/devsnek
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/jasnell
https://github.com/devnexen
https://github.com/codebytere
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.