René's URL Explorer Experiment


Title: src: remove unnecessary calculation in base64.h by sapics · Pull Request #33839 · nodejs/node · GitHub

Open Graph Title: src: remove unnecessary calculation in base64.h by sapics · Pull Request #33839 · nodejs/node

X Title: src: remove unnecessary calculation in base64.h by sapics · Pull Request #33839 · nodejs/node

Description: This PR removes unnecessary calculation in base64.h. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: This PR removes unnecessary calculation in base64.h. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This PR removes unnecessary calculation in base64.h. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/33839

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7610fd0f-426a-e52c-1254-6e3ba7006e3b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BCC:1D81B0:1E1CA3B:29273C7:696ABE76
html-safe-nonce932ea423c2de96ee7299250853cd354cdbb48bf8796422abd11a9925bbb60b4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkNDOjFEODFCMDoxRTFDQTNCOjI5MjczQzc6Njk2QUJFNzYiLCJ2aXNpdG9yX2lkIjoiODQ1MTY3OTIzNTczMzExMDM5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ba20a5f9b270868a160708e4e102cf301efa63f3af75f0ec313bb196d9f2781
hovercard-subject-tagpull_request:432852730
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33839/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/42fc22bdfbc417699783aa406da1d571a9b48353eceed1b05cb989321496e931/nodejs/node/pull/33839
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/42fc22bdfbc417699783aa406da1d571a9b48353eceed1b05cb989321496e931/nodejs/node/pull/33839
og:image:altThis PR removes unnecessary calculation in base64.h. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesapics
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33839#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33839
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33839
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33839
Reloadhttps://github.com/nodejs/node/pull/33839
Reloadhttps://github.com/nodejs/node/pull/33839
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33839
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33839
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33839#issue-comment-box
sapicshttps://github.com/sapics
nodejs:masterhttps://github.com/nodejs/node/tree/master
sapics:src/simplify-base64https://github.com/sapics/node/tree/src/simplify-base64
src: remove unnecessary calculation in base64.h https://github.com/nodejs/node/pull/33839#top
sapicshttps://github.com/sapics
nodejs:masterhttps://github.com/nodejs/node/tree/master
sapics:src/simplify-base64https://github.com/sapics/node/tree/src/simplify-base64
Conversation 8 https://github.com/nodejs/node/pull/33839
Commits 1 https://github.com/nodejs/node/pull/33839/commits
Checks 0 https://github.com/nodejs/node/pull/33839/checks
Files changed https://github.com/nodejs/node/pull/33839/files
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/sapics
sapicshttps://github.com/sapics
Jun 11, 2020https://github.com/nodejs/node/pull/33839#issue-636734135
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 11, 2020https://github.com/nodejs/node/pull/33839#event-3432551073
https://github.com/sapics
sapicshttps://github.com/sapics
force-pushedhttps://github.com/nodejs/node/compare/28913ae37e9267b198f9b01ec5c62bf0d55c7325..82f408bf89c9b464cf2b4f3c4de7311e2837df0e
28913aehttps://github.com/nodejs/node/commit/28913ae37e9267b198f9b01ec5c62bf0d55c7325
82f408bhttps://github.com/nodejs/node/commit/82f408bf89c9b464cf2b4f3c4de7311e2837df0e
Compare https://github.com/nodejs/node/compare/28913ae37e9267b198f9b01ec5c62bf0d55c7325..82f408bf89c9b464cf2b4f3c4de7311e2837df0e
June 11, 2020 06:34https://github.com/nodejs/node/pull/33839#event-3432678558
https://github.com/yashLadha
yashLadhahttps://github.com/yashLadha
Jun 11, 2020 https://github.com/nodejs/node/pull/33839#pullrequestreview-428632583
View reviewed changes https://github.com/nodejs/node/pull/33839/files
yashLadhahttps://github.com/yashLadha
https://github.com/nodejs/node/pull/33839#pullrequestreview-428632583
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33839
src/base64.hhttps://github.com/nodejs/node/pull/33839/files#diff-54a9c9bc5e6544410885c357b8f0858183220d4f1e4654a16d2f813df81f85bf
Please reload this pagehttps://github.com/nodejs/node/pull/33839
src/base64.hhttps://github.com/nodejs/node/pull/33839/files#diff-54a9c9bc5e6544410885c357b8f0858183220d4f1e4654a16d2f813df81f85bf
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.com/sapics
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/pull/33839/commits/0a142225ed91127d222341837eaffd1562c810bd
0a14222https://github.com/nodejs/node/pull/33839/commits/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/sapics
sapicshttps://github.com/sapics
force-pushedhttps://github.com/nodejs/node/compare/82f408bf89c9b464cf2b4f3c4de7311e2837df0e..0a142225ed91127d222341837eaffd1562c810bd
82f408bhttps://github.com/nodejs/node/commit/82f408bf89c9b464cf2b4f3c4de7311e2837df0e
0a14222https://github.com/nodejs/node/commit/0a142225ed91127d222341837eaffd1562c810bd
Compare https://github.com/nodejs/node/compare/82f408bf89c9b464cf2b4f3c4de7311e2837df0e..0a142225ed91127d222341837eaffd1562c810bd
June 11, 2020 07:11https://github.com/nodejs/node/pull/33839#event-3432789224
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 11, 2020https://github.com/nodejs/node/pull/33839#issuecomment-642495442
https://ci.nodejs.org/job/node-test-pull-request/31828/https://ci.nodejs.org/job/node-test-pull-request/31828/
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 11, 2020 https://github.com/nodejs/node/pull/33839#pullrequestreview-429080138
View reviewed changes https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 11, 2020https://github.com/nodejs/node/pull/33839#issuecomment-642788063
https://ci.nodejs.org/job/node-test-pull-request/31835/https://ci.nodejs.org/job/node-test-pull-request/31835/
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.com/yashLadha
yashLadhahttps://github.com/yashLadha
Jun 11, 2020 https://github.com/nodejs/node/pull/33839#pullrequestreview-429083153
View reviewed changes https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jun 14, 2020 https://github.com/nodejs/node/pull/33839#pullrequestreview-430227665
View reviewed changes https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2020 https://github.com/nodejs/node/pull/33839#pullrequestreview-430237569
View reviewed changes https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 18, 2020 https://github.com/nodejs/node/pull/33839#ref-issue-640818227
CI Relability 2020-06-18 JaneaSystems/nodejs-reliability#11 https://github.com/JaneaSystems/nodejs-reliability/issues/11
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 18, 2020 https://github.com/nodejs/node/pull/33839#pullrequestreview-433322247
View reviewed changes https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 25, 2020https://github.com/nodejs/node/pull/33839#issuecomment-649594567
a80000ehttps://github.com/nodejs/node/commit/a80000ec08a6a11f7e9e0291287fbc18357b2739
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 25, 2020https://github.com/nodejs/node/pull/33839#event-3482740476
addaleaxhttps://github.com/addaleax
Jun 25, 2020 https://github.com/nodejs/node/pull/33839#ref-commit-a80000e
https://github.com/sapics
https://github.com/addaleax
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/commit/a80000ec08a6a11f7e9e0291287fbc18357b2739
a80000ehttps://github.com/nodejs/node/commit/a80000ec08a6a11f7e9e0291287fbc18357b2739
#33839https://github.com/nodejs/node/pull/33839
https://github.com/sapics
sapicshttps://github.com/sapics
June 25, 2020 16:38https://github.com/nodejs/node/pull/33839#event-3483232142
codebyterehttps://github.com/codebytere
Jun 27, 2020 https://github.com/nodejs/node/pull/33839#ref-commit-74f4aae
https://github.com/sapics
https://github.com/codebytere
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/commit/74f4aae22f7729fe43c2b4140825c54f5d596bd3
74f4aaehttps://github.com/nodejs/node/commit/74f4aae22f7729fe43c2b4140825c54f5d596bd3
#33839https://github.com/nodejs/node/pull/33839
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33839#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33839#ref-commit-ced68bf
https://github.com/sapics
https://github.com/codebytere
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/commit/ced68bfa3d9e223c0da840afdf7b681c9afef9bb
ced68bfhttps://github.com/nodejs/node/commit/ced68bfa3d9e223c0da840afdf7b681c9afef9bb
#33839https://github.com/nodejs/node/pull/33839
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33839#ref-commit-ee02d22
https://github.com/sapics
https://github.com/codebytere
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/commit/ee02d228dc7a2b27b9ca572e956713648c68e26f
ee02d22https://github.com/nodejs/node/commit/ee02d228dc7a2b27b9ca572e956713648c68e26f
#33839https://github.com/nodejs/node/pull/33839
codebyterehttps://github.com/codebytere
Jul 12, 2020 https://github.com/nodejs/node/pull/33839#ref-commit-69f9629
https://github.com/sapics
https://github.com/codebytere
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/commit/69f962953c8e2bc7e5c87424d6001b577e2ea92e
69f9629https://github.com/nodejs/node/commit/69f962953c8e2bc7e5c87424d6001b577e2ea92e
#33839https://github.com/nodejs/node/pull/33839
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/33839#ref-pullrequest-656085086
v12.18.3 proposal #34343 https://github.com/nodejs/node/pull/34343
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33839#ref-commit-1bfa597
https://github.com/sapics
https://github.com/codebytere
src: remove unnecessary calculation in base64.hhttps://github.com/nodejs/node/commit/1bfa5970b2611a4b3bf0193171b51ce8755bea8e
1bfa597https://github.com/nodejs/node/commit/1bfa5970b2611a4b3bf0193171b51ce8755bea8e
#33839https://github.com/nodejs/node/pull/33839
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33839
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
https://github.com/yashLadha
yashLadha https://github.com/yashLadha
https://github.com/nodejs/node/pull/33839/files/0a142225ed91127d222341837eaffd1562c810bd
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33839
https://github.com/sapics
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/jasnell
https://github.com/tniessen
https://github.com/devnexen
https://github.com/yashLadha
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.