René's URL Explorer Experiment


Title: src: avoid unnecessary ToLocalChecked calls by danbev · Pull Request #33824 · nodejs/node · GitHub

Open Graph Title: src: avoid unnecessary ToLocalChecked calls by danbev · Pull Request #33824 · nodejs/node

X Title: src: avoid unnecessary ToLocalChecked calls by danbev · Pull Request #33824 · nodejs/node

Description: This commit removes two unnecessary ToLocalChecked calls in StringBytes::Encode. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: This commit removes two unnecessary ToLocalChecked calls in StringBytes::Encode. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This commit removes two unnecessary ToLocalChecked calls in StringBytes::Encode. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/33824

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e8e5a656-9eae-7f77-8e57-1fa6957fde6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCE0:1D81B0:1E08038:290BFFB:696ABE37
html-safe-nonce186a2adbf2e7d5839f3a93bba30733a5e529db23203952fab6945b39192ed5ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0UwOjFEODFCMDoxRTA4MDM4OjI5MEJGRkI6Njk2QUJFMzciLCJ2aXNpdG9yX2lkIjoiNDczNjE0MDU0ODc5NzgwODE4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfe98b58a11898a2156a22e5f9192888c768a1257d03449ff6e6ddc7f676bf680
hovercard-subject-tagpull_request:432231945
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33824/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dde17c5cb5289aa9a9039a45daa75542f6c5f664104c0dde8a1fb7c0b4c011e4/nodejs/node/pull/33824
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dde17c5cb5289aa9a9039a45daa75542f6c5f664104c0dde8a1fb7c0b4c011e4/nodejs/node/pull/33824
og:image:altThis commit removes two unnecessary ToLocalChecked calls in StringBytes::Encode. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33824#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33824
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33824
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33824
Reloadhttps://github.com/nodejs/node/pull/33824
Reloadhttps://github.com/nodejs/node/pull/33824
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33824
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33824
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33824#issue-comment-box
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:string_bytes_tolocalcheckedhttps://github.com/danbev/node/tree/string_bytes_tolocalchecked
src: avoid unnecessary ToLocalChecked calls https://github.com/nodejs/node/pull/33824#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:string_bytes_tolocalcheckedhttps://github.com/danbev/node/tree/string_bytes_tolocalchecked
Conversation 2 https://github.com/nodejs/node/pull/33824
Commits 2 https://github.com/nodejs/node/pull/33824/commits
Checks 0 https://github.com/nodejs/node/pull/33824/checks
Files changed https://github.com/nodejs/node/pull/33824/files
Please reload this pagehttps://github.com/nodejs/node/pull/33824
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 10, 2020https://github.com/nodejs/node/pull/33824#issue-635967808
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33824
https://github.com/danbev
src: avoid unnecessary ToLocalChecked callshttps://github.com/nodejs/node/pull/33824/commits/db81fc8c169474959cfa000fb58780ced06f6818
db81fc8https://github.com/nodejs/node/pull/33824/commits/db81fc8c169474959cfa000fb58780ced06f6818
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 10, 2020https://github.com/nodejs/node/pull/33824#event-3428025014
https://github.com/danbev
src: remove unused vector include in string_byteshttps://github.com/nodejs/node/pull/33824/commits/ae911246af7f8820dd737ff80b89371baeb17d30
ae91124https://github.com/nodejs/node/pull/33824/commits/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 10, 2020https://github.com/nodejs/node/pull/33824#issuecomment-641757142
https://ci.nodejs.org/job/node-test-pull-request/31819/https://ci.nodejs.org/job/node-test-pull-request/31819/
Please reload this pagehttps://github.com/nodejs/node/pull/33824
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 10, 2020 https://github.com/nodejs/node/pull/33824#pullrequestreview-427853912
View reviewed changes https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 10, 2020 https://github.com/nodejs/node/pull/33824#pullrequestreview-427862751
View reviewed changes https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 10, 2020 https://github.com/nodejs/node/pull/33824#pullrequestreview-428051427
View reviewed changes https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/devnexen
devnexenhttps://github.com/devnexen
Jun 11, 2020 https://github.com/nodejs/node/pull/33824#pullrequestreview-428988262
View reviewed changes https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/danbev
danbevhttps://github.com/danbev
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 15, 2020https://github.com/nodejs/node/pull/33824#event-3442494406
danbevhttps://github.com/danbev
Jun 15, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-8f7211a
https://github.com/danbev
src: avoid unnecessary ToLocalChecked callshttps://github.com/nodejs/node/commit/8f7211a60a45a5fcdbe99fa5150a3c7b30c1b5ed
8f7211ahttps://github.com/nodejs/node/commit/8f7211a60a45a5fcdbe99fa5150a3c7b30c1b5ed
#33824https://github.com/nodejs/node/pull/33824
danbevhttps://github.com/danbev
Jun 15, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-74d8011
https://github.com/danbev
src: remove unused vector include in string_byteshttps://github.com/nodejs/node/commit/74d80115b64c4aa3f697ea1199be439dce9af3cc
74d8011https://github.com/nodejs/node/commit/74d80115b64c4aa3f697ea1199be439dce9af3cc
#33824https://github.com/nodejs/node/pull/33824
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 15, 2020https://github.com/nodejs/node/pull/33824#issuecomment-643889156
8f7211ahttps://github.com/nodejs/node/commit/8f7211a60a45a5fcdbe99fa5150a3c7b30c1b5ed
74d8011https://github.com/nodejs/node/commit/74d80115b64c4aa3f697ea1199be439dce9af3cc
Please reload this pagehttps://github.com/nodejs/node/pull/33824
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 15, 2020https://github.com/nodejs/node/pull/33824#event-3442504657
https://github.com/danbev
danbevhttps://github.com/danbev
June 15, 2020 03:59https://github.com/nodejs/node/pull/33824#event-3442505104
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-fb2b0a0
https://github.com/danbev
https://github.com/codebytere
src: avoid unnecessary ToLocalChecked callshttps://github.com/nodejs/node/commit/fb2b0a094b4a6118eb50349052e465dffc30bd71
fb2b0a0https://github.com/nodejs/node/commit/fb2b0a094b4a6118eb50349052e465dffc30bd71
#33824https://github.com/nodejs/node/pull/33824
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-dfa0ee1
https://github.com/danbev
https://github.com/codebytere
src: remove unused vector include in string_byteshttps://github.com/nodejs/node/commit/dfa0ee13ee98000e30665db2d95776430addad6c
dfa0ee1https://github.com/nodejs/node/commit/dfa0ee13ee98000e30665db2d95776430addad6c
#33824https://github.com/nodejs/node/pull/33824
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33824#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-8ea4c37
https://github.com/danbev
https://github.com/codebytere
src: avoid unnecessary ToLocalChecked callshttps://github.com/nodejs/node/commit/8ea4c37a3dfbc7bbc8f538cf7b5630ac57210ecf
8ea4c37https://github.com/nodejs/node/commit/8ea4c37a3dfbc7bbc8f538cf7b5630ac57210ecf
#33824https://github.com/nodejs/node/pull/33824
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-7f67c2c
https://github.com/danbev
https://github.com/codebytere
src: remove unused vector include in string_byteshttps://github.com/nodejs/node/commit/7f67c2c2ad1a0f018bbfd14b731f6747dd44c973
7f67c2chttps://github.com/nodejs/node/commit/7f67c2c2ad1a0f018bbfd14b731f6747dd44c973
#33824https://github.com/nodejs/node/pull/33824
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-ec2452c
https://github.com/danbev
https://github.com/codebytere
src: avoid unnecessary ToLocalChecked callshttps://github.com/nodejs/node/commit/ec2452c4af34765d3948aa841728fd1c76eedb2c
ec2452chttps://github.com/nodejs/node/commit/ec2452c4af34765d3948aa841728fd1c76eedb2c
#33824https://github.com/nodejs/node/pull/33824
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-185657d
https://github.com/danbev
https://github.com/codebytere
src: remove unused vector include in string_byteshttps://github.com/nodejs/node/commit/185657dfd7e4dc65f8ea1be97a90fec9d40ffaac
185657dhttps://github.com/nodejs/node/commit/185657dfd7e4dc65f8ea1be97a90fec9d40ffaac
#33824https://github.com/nodejs/node/pull/33824
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/33824#ref-pullrequest-656085086
v12.18.3 proposal #34343 https://github.com/nodejs/node/pull/34343
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-53f4295
https://github.com/danbev
https://github.com/codebytere
src: avoid unnecessary ToLocalChecked callshttps://github.com/nodejs/node/commit/53f429564c43c9a5f6ef69620d1f8be89d857d82
53f4295https://github.com/nodejs/node/commit/53f429564c43c9a5f6ef69620d1f8be89d857d82
#33824https://github.com/nodejs/node/pull/33824
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33824#ref-commit-70d46ab
https://github.com/danbev
https://github.com/codebytere
src: remove unused vector include in string_byteshttps://github.com/nodejs/node/commit/70d46abd48e0a9d8839ddee7003e7706d725a05f
70d46abhttps://github.com/nodejs/node/commit/70d46abd48e0a9d8839ddee7003e7706d725a05f
#33824https://github.com/nodejs/node/pull/33824
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33824
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33824/files/ae911246af7f8820dd737ff80b89371baeb17d30
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33824
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.