René's URL Explorer Experiment


Title: events:use property, primordials by benjamingr · Pull Request #33775 · nodejs/node · GitHub

Open Graph Title: events:use property, primordials by benjamingr · Pull Request #33775 · nodejs/node

X Title: events:use property, primordials by benjamingr · Pull Request #33775 · nodejs/node

Description: Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter. This commit uses SymbolToStringTag from primordials and set...

Open Graph Description: Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter. This commit uses SymbolToStringTag from primordials and set...

X Description: Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter. This commit uses SymbolToStringTag from primordials and set...

Opengraph URL: https://github.com/nodejs/node/pull/33775

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:66585d03-2fe8-0523-7a75-4853625d106c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDD4:378C0F:1128627:17D94FE:696A8FAE
html-safe-nonceec926735a451c44c0673503984063c387714e0a4809dc1498cc8ed294cd65f86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREQ0OjM3OEMwRjoxMTI4NjI3OjE3RDk0RkU6Njk2QThGQUUiLCJ2aXNpdG9yX2lkIjoiMjIxNTI5NTkxMzQ0NzU1OTA4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca550e4a0a95a44bdc73c2b644ba6ad925cba9a622ac9af01b990cf66a4adc057
hovercard-subject-tagpull_request:429380094
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33775/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7e5f6711e5c2b2a42aad99cf8d428188eb1ee8c61650630bb0db42676b83aacc/nodejs/node/pull/33775
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7e5f6711e5c2b2a42aad99cf8d428188eb1ee8c61650630bb0db42676b83aacc/nodejs/node/pull/33775
og:image:altPer Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. Commit 56e4460 introduced it as a getter. This commit uses SymbolToStringTag from primordials and set...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebenjamingr
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33775#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33775
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33775
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33775
Reloadhttps://github.com/nodejs/node/pull/33775
Reloadhttps://github.com/nodejs/node/pull/33775
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33775
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33775
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33775#issue-comment-box
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:event-target-string-tag-symbolhttps://github.com/benjamingr/io.js/tree/event-target-string-tag-symbol
events:use property, primordials https://github.com/nodejs/node/pull/33775#top
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:event-target-string-tag-symbolhttps://github.com/benjamingr/io.js/tree/event-target-string-tag-symbol
Conversation 2 https://github.com/nodejs/node/pull/33775
Commits 2 https://github.com/nodejs/node/pull/33775/commits
Checks 0 https://github.com/nodejs/node/pull/33775/checks
Files changed https://github.com/nodejs/node/pull/33775/files
Please reload this pagehttps://github.com/nodejs/node/pull/33775
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 6, 2020https://github.com/nodejs/node/pull/33775#issue-632661015
56e4460https://github.com/nodejs/node/commit/56e44601d285483ffe3c6efa3b80743900d84856
#33773https://github.com/nodejs/node/issues/33773
@jasnellhttps://github.com/jasnell
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33775
https://github.com/benjamingr
events:use property, primordialshttps://github.com/nodejs/node/pull/33775/commits/b3c260ea1a81cb359b63f8984fb57c7d5ae17a20
b3c260ehttps://github.com/nodejs/node/pull/33775/commits/b3c260ea1a81cb359b63f8984fb57c7d5ae17a20
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
jasnellhttps://github.com/jasnell
June 6, 2020 18:47https://github.com/nodejs/node/pull/33775#event-3415159220
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Jun 6, 2020 https://github.com/nodejs/node/pull/33775#pullrequestreview-425761496
View reviewed changes https://github.com/nodejs/node/pull/33775/files/b3c260ea1a81cb359b63f8984fb57c7d5ae17a20
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 6, 2020 https://github.com/nodejs/node/pull/33775#pullrequestreview-425768667
View reviewed changes https://github.com/nodejs/node/pull/33775/files/b3c260ea1a81cb359b63f8984fb57c7d5ae17a20
https://github.com/benjamingr
fixup! compliance no setter on isTrustedhttps://github.com/nodejs/node/pull/33775/commits/0109d6c3e184bc40a252142632729c40e25d5182
0109d6chttps://github.com/nodejs/node/pull/33775/commits/0109d6c3e184bc40a252142632729c40e25d5182
https://github.com/himself65
himself65https://github.com/himself65
Jun 7, 2020 https://github.com/nodejs/node/pull/33775#pullrequestreview-425816924
View reviewed changes https://github.com/nodejs/node/pull/33775/files/0109d6c3e184bc40a252142632729c40e25d5182
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 7, 2020https://github.com/nodejs/node/pull/33775#event-3416454459
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 8, 2020 https://github.com/nodejs/node/pull/33775#pullrequestreview-426276091
View reviewed changes https://github.com/nodejs/node/pull/33775/files/0109d6c3e184bc40a252142632729c40e25d5182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 17, 2020https://github.com/nodejs/node/pull/33775#issuecomment-645570156
https://ci.nodejs.org/job/node-test-pull-request/31913/https://ci.nodejs.org/job/node-test-pull-request/31913/
Please reload this pagehttps://github.com/nodejs/node/pull/33775
jasnellhttps://github.com/jasnell
Jun 18, 2020 https://github.com/nodejs/node/pull/33775#ref-commit-ea866dc
https://github.com/benjamingr
https://github.com/jasnell
events: use property, primordialshttps://github.com/nodejs/node/commit/ea866dc81b81a71f6ff4c9cb44f8953ce5b398a6
ea866dchttps://github.com/nodejs/node/commit/ea866dc81b81a71f6ff4c9cb44f8953ce5b398a6
#33775https://github.com/nodejs/node/pull/33775
#33773https://github.com/nodejs/node/issues/33773
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 18, 2020https://github.com/nodejs/node/pull/33775#issuecomment-646331784
ea866dchttps://github.com/nodejs/node/commit/ea866dc81b81a71f6ff4c9cb44f8953ce5b398a6
Please reload this pagehttps://github.com/nodejs/node/pull/33775
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 18, 2020https://github.com/nodejs/node/pull/33775#event-3460245380
codebyterehttps://github.com/codebytere
Jun 22, 2020 https://github.com/nodejs/node/pull/33775#ref-commit-eb01214
https://github.com/benjamingr
https://github.com/codebytere
events: use property, primordialshttps://github.com/nodejs/node/commit/eb01214ab285e7b25008639f75751908e2153057
eb01214https://github.com/nodejs/node/commit/eb01214ab285e7b25008639f75751908e2153057
#33775https://github.com/nodejs/node/pull/33775
#33773https://github.com/nodejs/node/issues/33773
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33775#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33775#ref-commit-17edf65
https://github.com/benjamingr
https://github.com/codebytere
events: use property, primordialshttps://github.com/nodejs/node/commit/17edf65e506253c72b4732aef6dabe3daf5f3934
17edf65https://github.com/nodejs/node/commit/17edf65e506253c72b4732aef6dabe3daf5f3934
#33775https://github.com/nodejs/node/pull/33775
#33773https://github.com/nodejs/node/issues/33773
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/33775#ref-pullrequest-624383334
events: initial implementation of experimental EventTarget #33556 https://github.com/nodejs/node/pull/33556
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Sep 22, 2020https://github.com/nodejs/node/pull/33775#event-3795094383
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33775
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33775/files/0109d6c3e184bc40a252142632729c40e25d5182
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33775/files/b3c260ea1a81cb359b63f8984fb57c7d5ae17a20
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/33775/files/0109d6c3e184bc40a252142632729c40e25d5182
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/33775/files/b3c260ea1a81cb359b63f8984fb57c7d5ae17a20
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Minor EventTarget correctness issues https://github.com/nodejs/node/issues/33773
Please reload this pagehttps://github.com/nodejs/node/pull/33775
https://github.com/benjamingr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/addaleax
https://github.com/lundibundi
https://github.com/himself65
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.