| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8937978d-9bf4-9f4e-3780-1cd6558604dc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A68:3B507F:DEC84F:13409A8:696A8F78 |
| html-safe-nonce | 136de39ad26499a02482783e40f0037458add4de83a817c0160ecfb48bfbc25b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTY4OjNCNTA3RjpERUM4NEY6MTM0MDlBODo2OTZBOEY3OCIsInZpc2l0b3JfaWQiOiIzNjI4MDExNjc3NzY1MTgwMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 199a76682d96067810eb86ad3e1da730847253d668849f96be212a84c40db0e7 |
| hovercard-subject-tag | pull_request:429112255 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33770/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b210f402a6d8f35bb9b6eeee21de59ed33c34a9ec815f12a96fc8efb99c8aebc/nodejs/node/pull/33770 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b210f402a6d8f35bb9b6eeee21de59ed33c34a9ec815f12a96fc8efb99c8aebc/nodejs/node/pull/33770 |
| og:image:alt | /cc @joyeecheung there's a problem with the new assert_throws_js function. It now checks error.constructor === constructor. This doesn't work with Node's errors because they extend the ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | targos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33770#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33770 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33770 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33770 |
| Reload | https://github.com/nodejs/node/pull/33770 |
| Reload | https://github.com/nodejs/node/pull/33770 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33770#issue-comment-box |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:update-wpt | https://github.com/targos/node/tree/update-wpt |
|
test: update WPT harness
| https://github.com/nodejs/node/pull/33770#top |
| targos | https://github.com/targos |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| targos:update-wpt | https://github.com/targos/node/tree/update-wpt |
|
Conversation
18
| https://github.com/nodejs/node/pull/33770 |
|
Commits
3
| https://github.com/nodejs/node/pull/33770/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33770/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33770/files |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33770#issue-632358986 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33770#event-3414524857 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 11, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-642509850 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 11, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-642509951 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jun 12, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-643036052 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jun 12, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-643159107 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jun 12, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-643279213 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 12, 2020
| https://github.com/nodejs/node/pull/33770#ref-pullrequest-637799156 |
|
lib: remove NodeError from the prototype of errors with code
#33857
| https://github.com/nodejs/node/pull/33857 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jun 12, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-643308110 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| addaleax | https://github.com/addaleax |
|
Jun 19, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-a86a295 |
|
| https://github.com/targos |
|
| https://github.com/addaleax |
| lib: remove NodeError from the prototype of errors with code | https://github.com/nodejs/node/commit/a86a295fd7162a7fdf406a21b3c3c679819c60b5 |
| a86a295 | https://github.com/nodejs/node/commit/a86a295fd7162a7fdf406a21b3c3c679819c60b5 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/3dd4184af56246425d63dbd7a425f8cbb49fb98e..7b89a1cf2f1f6ca1e6755b5e3810f3891cf6b560 |
| 3dd4184 | https://github.com/nodejs/node/commit/3dd4184af56246425d63dbd7a425f8cbb49fb98e |
| 7b89a1c | https://github.com/nodejs/node/commit/7b89a1cf2f1f6ca1e6755b5e3810f3891cf6b560 |
|
Compare
| https://github.com/nodejs/node/compare/3dd4184af56246425d63dbd7a425f8cbb49fb98e..7b89a1cf2f1f6ca1e6755b5e3810f3891cf6b560 |
| July 3, 2020 15:03 | https://github.com/nodejs/node/pull/33770#event-3511359557 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 26, 2020
| https://github.com/nodejs/node/pull/33770#ref-pullrequest-664830437 |
|
Implement using web-streams-polyfill
nodejs/whatwg-stream#3
| https://github.com/nodejs/whatwg-stream/pull/3 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/7b89a1cf2f1f6ca1e6755b5e3810f3891cf6b560..c822b85b5de353175f66f17c6b18a2b9dd1dfba4 |
| 7b89a1c | https://github.com/nodejs/node/commit/7b89a1cf2f1f6ca1e6755b5e3810f3891cf6b560 |
| c822b85 | https://github.com/nodejs/node/commit/c822b85b5de353175f66f17c6b18a2b9dd1dfba4 |
|
Compare
| https://github.com/nodejs/node/compare/7b89a1cf2f1f6ca1e6755b5e3810f3891cf6b560..c822b85b5de353175f66f17c6b18a2b9dd1dfba4 |
| August 2, 2020 08:36 | https://github.com/nodejs/node/pull/33770#event-3613159849 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/c822b85b5de353175f66f17c6b18a2b9dd1dfba4..dca82e1a9c91b9103e3872b04ba3d044e90258d3 |
| c822b85 | https://github.com/nodejs/node/commit/c822b85b5de353175f66f17c6b18a2b9dd1dfba4 |
| dca82e1 | https://github.com/nodejs/node/commit/dca82e1a9c91b9103e3872b04ba3d044e90258d3 |
|
Compare
| https://github.com/nodejs/node/compare/c822b85b5de353175f66f17c6b18a2b9dd1dfba4..dca82e1a9c91b9103e3872b04ba3d044e90258d3 |
| August 18, 2020 11:23 | https://github.com/nodejs/node/pull/33770#event-3665869752 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
help wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22 |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/33770#event-3665877725 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-675422408 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-675422630 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 21, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-678291481 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-680853608 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/jsdom/whatwg-url/blob/master/src/url-state-machine.js#L419-L421 | https://github.com/jsdom/whatwg-url/blob/master/src/url-state-machine.js#L419-L421 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-680971652 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| @targos | https://github.com/targos |
| soft hyphen | http://www.ltg.ed.ac.uk/~richard/utf-8.cgi?input=%C2%AD&mode=char |
| IDNA spec | https://unicode.org/reports/tr46/#Table_Data_File_Fields |
| @watilde | https://github.com/watilde |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
|
Sep 6, 2020
| https://github.com/nodejs/node/pull/33770#ref-pullrequest-694473513 |
|
test: separate the test fixtures between ICU and URL
#35077
| https://github.com/nodejs/node/pull/35077 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/dca82e1a9c91b9103e3872b04ba3d044e90258d3..52e170594c848665b16a45edd4ba26b0630925bf |
| dca82e1 | https://github.com/nodejs/node/commit/dca82e1a9c91b9103e3872b04ba3d044e90258d3 |
| 52e1705 | https://github.com/nodejs/node/commit/52e170594c848665b16a45edd4ba26b0630925bf |
|
Compare
| https://github.com/nodejs/node/compare/dca82e1a9c91b9103e3872b04ba3d044e90258d3..52e170594c848665b16a45edd4ba26b0630925bf |
| September 7, 2020 13:53 | https://github.com/nodejs/node/pull/33770#event-3737292152 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 7, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-688341465 |
| whatwg/url#486 | https://github.com/whatwg/url/pull/486 |
| whatwg/url#497 | https://github.com/whatwg/url/pull/497 |
| #35077 | https://github.com/nodejs/node/pull/35077 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/targos |
| targos | https://github.com/targos |
| force-pushed | https://github.com/nodejs/node/compare/52e170594c848665b16a45edd4ba26b0630925bf..8e623cfd635d0e21df9393b76da6ce363e4fe087 |
| 52e1705 | https://github.com/nodejs/node/commit/52e170594c848665b16a45edd4ba26b0630925bf |
| 8e623cf | https://github.com/nodejs/node/commit/8e623cfd635d0e21df9393b76da6ce363e4fe087 |
|
Compare
| https://github.com/nodejs/node/compare/52e170594c848665b16a45edd4ba26b0630925bf..8e623cfd635d0e21df9393b76da6ce363e4fe087 |
| September 7, 2020 13:58 | https://github.com/nodejs/node/pull/33770#event-3737313577 |
| watilde | https://github.com/watilde |
|
Sep 8, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-7913ac5 |
|
| https://github.com/Leko |
|
| https://github.com/watilde |
| test: separate the test fixtures between ICU and URL | https://github.com/nodejs/node/commit/7913ac569419668c8727295ee787169a6a662362 |
| 7913ac5 | https://github.com/nodejs/node/commit/7913ac569419668c8727295ee787169a6a662362 |
| #33770 (comment) | https://github.com/nodejs/node/pull/33770#issuecomment-680853608 |
| #35077 | https://github.com/nodejs/node/pull/35077 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
|
help wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22 |
| Sep 8, 2020 | https://github.com/nodejs/node/pull/33770#event-3740434050 |
| targos | https://github.com/targos |
| September 8, 2020 13:29 | https://github.com/nodejs/node/pull/33770#commits-pushed-1dbbf1c |
|
| https://github.com/targos |
| test: update WPT harness and tests | https://github.com/nodejs/node/pull/33770/commits/1dbbf1ce79f8fa3f48c12df3a9803820ecae982c |
| 1dbbf1c | https://github.com/nodejs/node/pull/33770/commits/1dbbf1ce79f8fa3f48c12df3a9803820ecae982c |
|
| https://github.com/targos |
| url: remove U+0000 case in the fragment state | https://github.com/nodejs/node/pull/33770/commits/3d7899e7983b8993468702ba7d23e9ab1f96126d |
| 3d7899e | https://github.com/nodejs/node/pull/33770/commits/3d7899e7983b8993468702ba7d23e9ab1f96126d |
| whatwg/url#486 | https://github.com/whatwg/url/pull/486 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 11, 2020
| https://github.com/nodejs/node/pull/33770#pullrequestreview-486468777 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33770/files/d3aca2592fa749c4db660090872d22a6467fd946 |
| https://github.com/targos |
| targos | https://github.com/targos |
| jasnell | https://github.com/jasnell |
| September 11, 2020 14:49 | https://github.com/nodejs/node/pull/33770#event-3756614297 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
| joyeecheung | https://github.com/joyeecheung |
| September 14, 2020 16:07 | https://github.com/nodejs/node/pull/33770#event-3764210088 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 15, 2020
| https://github.com/nodejs/node/pull/33770#pullrequestreview-489148341 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33770/files/d3aca2592fa749c4db660090872d22a6467fd946 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/33770#event-3771544582 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/33770#event-3771547049 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/33770#issuecomment-693200192 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| 9cf9e4a...69ef4c2 | https://github.com/nodejs/node/compare/9cf9e4aebccd3dc946d1ccb8d3f00b31d3e6371c...69ef4c2375b5110886b08957cd2305ce8aa8eb32 |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/33770#event-3771547737 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-eb9d7a4 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
| test: update WPT harness and tests | https://github.com/nodejs/node/commit/eb9d7a437e960753a7344d7e7885e6e3df4370aa |
| eb9d7a4 | https://github.com/nodejs/node/commit/eb9d7a437e960753a7344d7e7885e6e3df4370aa |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-4831278 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
| url: remove U+0000 case in the fragment state | https://github.com/nodejs/node/commit/4831278a16d0cbe9e54ba89f1bf4f114aed06e69 |
| 4831278 | https://github.com/nodejs/node/commit/4831278a16d0cbe9e54ba89f1bf4f114aed06e69 |
| whatwg/url#486 | https://github.com/whatwg/url/pull/486 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-69ef4c2 |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
| url: verify domain is not empty after "ToASCII" | https://github.com/nodejs/node/commit/69ef4c2375b5110886b08957cd2305ce8aa8eb32 |
| 69ef4c2 | https://github.com/nodejs/node/commit/69ef4c2375b5110886b08957cd2305ce8aa8eb32 |
| whatwg/url#497 | https://github.com/whatwg/url/pull/497 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/33770#ref-issue-678857349 |
|
Tracking Issue: commit queue issues and feedback
#34770
| https://github.com/nodejs/node/issues/34770 |
| https://github.com/targos |
| targos | https://github.com/targos |
| September 16, 2020 06:29 | https://github.com/nodejs/node/pull/33770#event-3771562733 |
|
Different query parsing behavior between node and browsers for URLSearchParams
#33892
| https://github.com/nodejs/node/issues/33892 |
|
Catch up to recent changes in whatwg/url
#33315
| https://github.com/nodejs/node/issues/33315 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 17, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-9faaa65 |
|
| https://github.com/Leko |
|
| https://github.com/ruyadorno |
| test: separate the test fixtures between ICU and URL | https://github.com/nodejs/node/commit/9faaa659b229359648c00bdc94681df95197f73f |
| 9faaa65 | https://github.com/nodejs/node/commit/9faaa659b229359648c00bdc94681df95197f73f |
| #33770 (comment) | https://github.com/nodejs/node/pull/33770#issuecomment-680853608 |
| #35077 | https://github.com/nodejs/node/pull/35077 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/33770#ref-pullrequest-685677579 |
|
url: support non-special URLs
#34925
| https://github.com/nodejs/node/pull/34925 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/33770#ref-pullrequest-690440226 |
|
2020-10-20, Version 15.0.0 (Current)
#35014
| https://github.com/nodejs/node/pull/35014 |
|
test: update wpt tests for url
#35329
| https://github.com/nodejs/node/pull/35329 |
|
test: update wpt status for url
#35335
| https://github.com/nodejs/node/pull/35335 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Oct 8, 2020
| https://github.com/nodejs/node/pull/33770#ref-pullrequest-714045830 |
|
url: file URL path normalization
#35477
| https://github.com/nodejs/node/pull/35477 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 19, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-782053e |
|
| https://github.com/BethGriggs |
| 2020-10-20, Version 15.0.0 (Current) | https://github.com/nodejs/node/commit/782053ea417ae77aae80c7dda7ff3cb0cfb7fce8 |
| 782053e | https://github.com/nodejs/node/commit/782053ea417ae77aae80c7dda7ff3cb0cfb7fce8 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #32379 | https://github.com/nodejs/node/pull/32379 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35022 | https://github.com/nodejs/node/pull/35022 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33405 | https://github.com/nodejs/node/pull/33405 |
| #33172 | https://github.com/nodejs/node/pull/33172 |
| #31818 | https://github.com/nodejs/node/pull/31818 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #33161 | https://github.com/nodejs/node/pull/33161 |
| #33535 | https://github.com/nodejs/node/pull/33535 |
| #33193 | https://github.com/nodejs/node/pull/33193 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34682 | https://github.com/nodejs/node/pull/34682 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32312 | https://github.com/nodejs/node/pull/32312 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34762 | https://github.com/nodejs/node/pull/34762 |
| #35498 | https://github.com/nodejs/node/pull/35498 |
| #35033 | https://github.com/nodejs/node/pull/35033 |
| #33579 | https://github.com/nodejs/node/pull/33579 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #33971 | https://github.com/nodejs/node/pull/33971 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #32859 | https://github.com/nodejs/node/pull/32859 |
| #34314 | https://github.com/nodejs/node/pull/34314 |
| #34204 | https://github.com/nodejs/node/pull/34204 |
| #33991 | https://github.com/nodejs/node/pull/33991 |
| #34101 | https://github.com/nodejs/node/pull/34101 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33075 | https://github.com/nodejs/node/pull/33075 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| #32763 | https://github.com/nodejs/node/pull/32763 |
| #29179 | https://github.com/nodejs/node/pull/29179 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35477 | https://github.com/nodejs/node/pull/35477 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33325 | https://github.com/nodejs/node/pull/33325 |
| #33328 | https://github.com/nodejs/node/pull/33328 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35210 | https://github.com/nodejs/node/pull/35210 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34394 | https://github.com/nodejs/node/pull/34394 |
| #33872 | https://github.com/nodejs/node/pull/33872 |
| #35014 | https://github.com/nodejs/node/pull/35014 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-d683e3d |
|
| https://github.com/BethGriggs |
| 2020-10-20, Version 15.0.0 (Current) | https://github.com/nodejs/node/commit/d683e3dda09b6b3cc6cad6fd2c106e3061a48f0d |
| d683e3d | https://github.com/nodejs/node/commit/d683e3dda09b6b3cc6cad6fd2c106e3061a48f0d |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #32379 | https://github.com/nodejs/node/pull/32379 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35022 | https://github.com/nodejs/node/pull/35022 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33405 | https://github.com/nodejs/node/pull/33405 |
| #33172 | https://github.com/nodejs/node/pull/33172 |
| #31818 | https://github.com/nodejs/node/pull/31818 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #33161 | https://github.com/nodejs/node/pull/33161 |
| #33535 | https://github.com/nodejs/node/pull/33535 |
| #33193 | https://github.com/nodejs/node/pull/33193 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34682 | https://github.com/nodejs/node/pull/34682 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32312 | https://github.com/nodejs/node/pull/32312 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34762 | https://github.com/nodejs/node/pull/34762 |
| #35498 | https://github.com/nodejs/node/pull/35498 |
| #35033 | https://github.com/nodejs/node/pull/35033 |
| #33579 | https://github.com/nodejs/node/pull/33579 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #33971 | https://github.com/nodejs/node/pull/33971 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #32859 | https://github.com/nodejs/node/pull/32859 |
| #34314 | https://github.com/nodejs/node/pull/34314 |
| #34204 | https://github.com/nodejs/node/pull/34204 |
| #33991 | https://github.com/nodejs/node/pull/33991 |
| #34101 | https://github.com/nodejs/node/pull/34101 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33075 | https://github.com/nodejs/node/pull/33075 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| #32763 | https://github.com/nodejs/node/pull/32763 |
| #29179 | https://github.com/nodejs/node/pull/29179 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35477 | https://github.com/nodejs/node/pull/35477 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33325 | https://github.com/nodejs/node/pull/33325 |
| #33328 | https://github.com/nodejs/node/pull/33328 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35210 | https://github.com/nodejs/node/pull/35210 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34394 | https://github.com/nodejs/node/pull/34394 |
| #33872 | https://github.com/nodejs/node/pull/33872 |
| #35014 | https://github.com/nodejs/node/pull/35014 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 20, 2020
| https://github.com/nodejs/node/pull/33770#ref-commit-57613f8 |
|
| https://github.com/BethGriggs |
| 2020-10-20, Version 15.0.0 (Current) | https://github.com/nodejs/node/commit/57613f8c564982494c5af8070816d675544386bb |
| 57613f8 | https://github.com/nodejs/node/commit/57613f8c564982494c5af8070816d675544386bb |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #32379 | https://github.com/nodejs/node/pull/32379 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34001 | https://github.com/nodejs/node/pull/34001 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #27576 | https://github.com/nodejs/node/pull/27576 |
| #33694 | https://github.com/nodejs/node/pull/33694 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35093 | https://github.com/nodejs/node/pull/35093 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32953 | https://github.com/nodejs/node/pull/32953 |
| #35316 | https://github.com/nodejs/node/pull/35316 |
| #35022 | https://github.com/nodejs/node/pull/35022 |
| #35562 | https://github.com/nodejs/node/pull/35562 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33405 | https://github.com/nodejs/node/pull/33405 |
| #33172 | https://github.com/nodejs/node/pull/33172 |
| #31818 | https://github.com/nodejs/node/pull/31818 |
| #34664 | https://github.com/nodejs/node/pull/34664 |
| #33161 | https://github.com/nodejs/node/pull/33161 |
| #33535 | https://github.com/nodejs/node/pull/33535 |
| #33193 | https://github.com/nodejs/node/pull/33193 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34682 | https://github.com/nodejs/node/pull/34682 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33857 | https://github.com/nodejs/node/pull/33857 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #33527 | https://github.com/nodejs/node/pull/33527 |
| #34022 | https://github.com/nodejs/node/pull/34022 |
| #33647 | https://github.com/nodejs/node/pull/33647 |
| #31806 | https://github.com/nodejs/node/pull/31806 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #33021 | https://github.com/nodejs/node/pull/33021 |
| #33600 | https://github.com/nodejs/node/pull/33600 |
| #32312 | https://github.com/nodejs/node/pull/32312 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #33286 | https://github.com/nodejs/node/pull/33286 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #34762 | https://github.com/nodejs/node/pull/34762 |
| #35498 | https://github.com/nodejs/node/pull/35498 |
| #35033 | https://github.com/nodejs/node/pull/35033 |
| #33579 | https://github.com/nodejs/node/pull/33579 |
| #33874 | https://github.com/nodejs/node/pull/33874 |
| #33971 | https://github.com/nodejs/node/pull/33971 |
| #33648 | https://github.com/nodejs/node/pull/33648 |
| #32859 | https://github.com/nodejs/node/pull/32859 |
| #34314 | https://github.com/nodejs/node/pull/34314 |
| #34204 | https://github.com/nodejs/node/pull/34204 |
| #33991 | https://github.com/nodejs/node/pull/33991 |
| #34101 | https://github.com/nodejs/node/pull/34101 |
| #29656 | https://github.com/nodejs/node/pull/29656 |
| #33075 | https://github.com/nodejs/node/pull/33075 |
| #32780 | https://github.com/nodejs/node/pull/32780 |
| #32763 | https://github.com/nodejs/node/pull/32763 |
| #29179 | https://github.com/nodejs/node/pull/29179 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35631 | https://github.com/nodejs/node/pull/35631 |
| #35474 | https://github.com/nodejs/node/pull/35474 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33950 | https://github.com/nodejs/node/pull/33950 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35477 | https://github.com/nodejs/node/pull/35477 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33770 | https://github.com/nodejs/node/pull/33770 |
| #33325 | https://github.com/nodejs/node/pull/33325 |
| #33328 | https://github.com/nodejs/node/pull/33328 |
| #32744 | https://github.com/nodejs/node/pull/32744 |
| #35415 | https://github.com/nodejs/node/pull/35415 |
| #35210 | https://github.com/nodejs/node/pull/35210 |
| #35496 | https://github.com/nodejs/node/pull/35496 |
| #34394 | https://github.com/nodejs/node/pull/34394 |
| #33872 | https://github.com/nodejs/node/pull/33872 |
| #35014 | https://github.com/nodejs/node/pull/35014 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/33770#ref-commit-256fc39 |
|
| https://github.com/Leko |
|
| https://github.com/joesepi |
| test: separate the test fixtures between ICU and URL | https://github.com/joesepi/node/commit/256fc3992b3bf6fb26991a875560fd24c9a05f12 |
| 256fc39 | https://github.com/joesepi/node/commit/256fc3992b3bf6fb26991a875560fd24c9a05f12 |
| nodejs#33770 (comment) | https://github.com/nodejs/node/pull/33770#issuecomment-680853608 |
| nodejs#35077 | https://github.com/nodejs/node/pull/35077 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/33770#ref-commit-4040a3b |
|
| https://github.com/targos |
|
| https://github.com/joesepi |
| test: update WPT harness and tests | https://github.com/joesepi/node/commit/4040a3b25a15621fa25e26b8581ce0f609dcdc8f |
| 4040a3b | https://github.com/joesepi/node/commit/4040a3b25a15621fa25e26b8581ce0f609dcdc8f |
| nodejs#33770 | https://github.com/nodejs/node/pull/33770 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/33770#ref-commit-907bdd2 |
|
| https://github.com/targos |
|
| https://github.com/joesepi |
| url: remove U+0000 case in the fragment state | https://github.com/joesepi/node/commit/907bdd2f98290a76d31bab47610787ae4532a583 |
| 907bdd2 | https://github.com/joesepi/node/commit/907bdd2f98290a76d31bab47610787ae4532a583 |
| whatwg/url#486 | https://github.com/whatwg/url/pull/486 |
| nodejs#33770 | https://github.com/nodejs/node/pull/33770 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/33770#ref-commit-081441a |
|
| https://github.com/targos |
|
| https://github.com/joesepi |
| url: verify domain is not empty after "ToASCII" | https://github.com/joesepi/node/commit/081441a8be8515d5c381d488021b36311974c63e |
| 081441a | https://github.com/joesepi/node/commit/081441a8be8515d5c381d488021b36311974c63e |
| whatwg/url#497 | https://github.com/whatwg/url/pull/497 |
| nodejs#33770 | https://github.com/nodejs/node/pull/33770 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33770 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/33770/files/d3aca2592fa749c4db660090872d22a6467fd946 |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/33770/files/d3aca2592fa749c4db660090872d22a6467fd946 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/33770/files/d3aca2592fa749c4db660090872d22a6467fd946 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/Leko |
|
Leko
| https://github.com/Leko |
|
| https://github.com/nodejs/node/pull/33770/files/d3aca2592fa749c4db660090872d22a6467fd946 |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
| Please reload this page | https://github.com/nodejs/node/pull/33770 |
|
| https://github.com/targos |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/joyeecheung |
|
| https://github.com/watilde |
|
| https://github.com/Leko |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |