René's URL Explorer Experiment


Title: src: fix FastStringKey equal operator by sapics · Pull Request #33748 · nodejs/node · GitHub

Open Graph Title: src: fix FastStringKey equal operator by sapics · Pull Request #33748 · nodejs/node

X Title: src: fix FastStringKey equal operator by sapics · Pull Request #33748 · nodejs/node

Description: This PR fixes the FastStringKey == operator. (Currently, there are some cases which return true, when the length of string is not same). Currently, FastStringKey::HashImpl return multiple of 33, th...

Open Graph Description: This PR fixes the FastStringKey == operator. (Currently, there are some cases which return true, when the length of string is not same). Currently, FastStringKey::HashImpl return multiple of 33, th...

X Description: This PR fixes the FastStringKey == operator. (Currently, there are some cases which return true, when the length of string is not same). Currently, FastStringKey::HashImpl return multiple of 33, th...

Opengraph URL: https://github.com/nodejs/node/pull/33748

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:46120f82-f77a-b1b4-1238-43760938207c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C50:1B7E6F:121E01B:18FFC06:696A8FD1
html-safe-nonce7a73caae4e2bd5c0b585601952380de0f296ee3a7a33b200c0fecff34bf40c23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzUwOjFCN0U2RjoxMjFFMDFCOjE4RkZDMDY6Njk2QThGRDEiLCJ2aXNpdG9yX2lkIjoiNjQ4Nzc3Nzc3MDE5NTIzMDI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf59544a213afd1ed80451c906db6150ee24b1130231725bc6c455fff702151fd
hovercard-subject-tagpull_request:428442422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33748/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/348a5b7042faa8a0b38bff0d1c66399766343740df68c71961ee068ac6d80f37/nodejs/node/pull/33748
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/348a5b7042faa8a0b38bff0d1c66399766343740df68c71961ee068ac6d80f37/nodejs/node/pull/33748
og:image:altThis PR fixes the FastStringKey == operator. (Currently, there are some cases which return true, when the length of string is not same). Currently, FastStringKey::HashImpl return multiple of 33, th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesapics
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33748#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33748
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33748
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33748
Reloadhttps://github.com/nodejs/node/pull/33748
Reloadhttps://github.com/nodejs/node/pull/33748
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33748
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33748
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33748#issue-comment-box
sapicshttps://github.com/sapics
nodejs:masterhttps://github.com/nodejs/node/tree/master
sapics:fix-faststringkey-operatorhttps://github.com/sapics/node/tree/fix-faststringkey-operator
src: fix FastStringKey equal operator https://github.com/nodejs/node/pull/33748#top
sapicshttps://github.com/sapics
nodejs:masterhttps://github.com/nodejs/node/tree/master
sapics:fix-faststringkey-operatorhttps://github.com/sapics/node/tree/fix-faststringkey-operator
Conversation 6 https://github.com/nodejs/node/pull/33748
Commits 1 https://github.com/nodejs/node/pull/33748/commits
Checks 0 https://github.com/nodejs/node/pull/33748/checks
Files changed https://github.com/nodejs/node/pull/33748/files
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/sapics
sapicshttps://github.com/sapics
Jun 5, 2020https://github.com/nodejs/node/pull/33748#issue-631580827
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.com/sapics
src: fix FastStringKey equal operatorhttps://github.com/nodejs/node/pull/33748/commits/46524c324f2ef17227604dc713f528ff9b457f9c
46524c3https://github.com/nodejs/node/pull/33748/commits/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 5, 2020https://github.com/nodejs/node/pull/33748#event-3411253731
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 5, 2020 https://github.com/nodejs/node/pull/33748#pullrequestreview-425289327
View reviewed changes https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 5, 2020 https://github.com/nodejs/node/pull/33748#pullrequestreview-425290948
View reviewed changes https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 5, 2020 https://github.com/nodejs/node/pull/33748#pullrequestreview-425295288
View reviewed changes https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/MrHeer
MrHeerhttps://github.com/MrHeer
Jun 5, 2020 https://github.com/nodejs/node/pull/33748#pullrequestreview-425360679
View reviewed changes https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 5, 2020 https://github.com/nodejs/node/pull/33748#pullrequestreview-425371355
View reviewed changes https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 12, 2020https://github.com/nodejs/node/pull/33748#event-3439998772
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 12, 2020https://github.com/nodejs/node/pull/33748#issuecomment-643491878
https://ci.nodejs.org/job/node-test-pull-request/31850/https://ci.nodejs.org/job/node-test-pull-request/31850/
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 19, 2020https://github.com/nodejs/node/pull/33748#issuecomment-646419855
https://ci.nodejs.org/job/node-test-pull-request/31934/https://ci.nodejs.org/job/node-test-pull-request/31934/
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 19, 2020https://github.com/nodejs/node/pull/33748#issuecomment-646702438
https://ci.nodejs.org/job/node-test-pull-request/31956/https://ci.nodejs.org/job/node-test-pull-request/31956/
Please reload this pagehttps://github.com/nodejs/node/pull/33748
CI Relability 2020-06-20 JaneaSystems/nodejs-reliability#13 https://github.com/JaneaSystems/nodejs-reliability/issues/13
CI Relability 2020-06-21 JaneaSystems/nodejs-reliability#14 https://github.com/JaneaSystems/nodejs-reliability/issues/14
CI Relability 2020-06-22 JaneaSystems/nodejs-reliability#15 https://github.com/JaneaSystems/nodejs-reliability/issues/15
CI Relability 2020-06-23 JaneaSystems/nodejs-reliability#16 https://github.com/JaneaSystems/nodejs-reliability/issues/16
jasnellhttps://github.com/jasnell
Jun 24, 2020 https://github.com/nodejs/node/pull/33748#ref-commit-5a0c6a6
https://github.com/sapics
https://github.com/jasnell
src: fix FastStringKey equal operatorhttps://github.com/nodejs/node/commit/5a0c6a6b5dbcb97a0f0fcd38df46cf8f090c1271
5a0c6a6https://github.com/nodejs/node/commit/5a0c6a6b5dbcb97a0f0fcd38df46cf8f090c1271
#33748https://github.com/nodejs/node/pull/33748
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 24, 2020https://github.com/nodejs/node/pull/33748#issuecomment-649128260
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 24, 2020https://github.com/nodejs/node/pull/33748#event-3479763012
https://github.com/sapics
sapicshttps://github.com/sapics
June 24, 2020 23:35https://github.com/nodejs/node/pull/33748#event-3479765027
codebyterehttps://github.com/codebytere
Jun 27, 2020 https://github.com/nodejs/node/pull/33748#ref-commit-e1bebf1
https://github.com/sapics
https://github.com/codebytere
src: fix FastStringKey equal operatorhttps://github.com/nodejs/node/commit/e1bebf13db7e807e49b72e1e303d4c85a1211afc
e1bebf1https://github.com/nodejs/node/commit/e1bebf13db7e807e49b72e1e303d4c85a1211afc
#33748https://github.com/nodejs/node/pull/33748
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33748#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33748#ref-commit-0190cf6
https://github.com/sapics
https://github.com/codebytere
src: fix FastStringKey equal operatorhttps://github.com/nodejs/node/commit/0190cf6ce1d2a460353709f389f28367a98d223b
0190cf6https://github.com/nodejs/node/commit/0190cf6ce1d2a460353709f389f28367a98d223b
#33748https://github.com/nodejs/node/pull/33748
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 10, 2020https://github.com/nodejs/node/pull/33748#issuecomment-656815693
#33139https://github.com/nodejs/node/pull/33139
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Jul 10, 2020https://github.com/nodejs/node/pull/33748#event-3534939789
https://github.com/sapics
sapicshttps://github.com/sapics
Jul 11, 2020https://github.com/nodejs/node/pull/33748#issuecomment-657005866
#33139https://github.com/nodejs/node/pull/33139
#33139https://github.com/nodejs/node/pull/33139
Please reload this pagehttps://github.com/nodejs/node/pull/33748
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33748
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
https://github.com/MrHeer
MrHeer https://github.com/MrHeer
https://github.com/nodejs/node/pull/33748/files/46524c324f2ef17227604dc713f528ff9b457f9c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33748
https://github.com/sapics
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/codebytere
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/cjihrig
https://github.com/MrHeer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.