| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b0518857-6b8f-0fc4-e175-f3137a3a25f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C53A:388B78:E648AF:12A20CB:696B066F |
| html-safe-nonce | 9f8eac9118902648743ad3a0dfa289a72a8a14534344485e933edc7f645d563a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTNBOjM4OEI3ODpFNjQ4QUY6MTJBMjBDQjo2OTZCMDY2RiIsInZpc2l0b3JfaWQiOiIyODg2ODc2NTgwNjA2MDUxOTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 479beffbcc16377b8bc376dc79c48d0a1bc6d5e49d1821d3c797a06cabad1563 |
| hovercard-subject-tag | pull_request:428001407 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33730/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/72a3a1c1ef0d6db9e9070f844f31d9a5b67980333d5195be08bed87a3bd81142/nodejs/node/pull/33730 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/72a3a1c1ef0d6db9e9070f844f31d9a5b67980333d5195be08bed87a3bd81142/nodejs/node/pull/33730 |
| og:image:alt | use writeFile(1) everywhere to log
prettify execution id graph
add clearer explanation for TickObject presence
add causation graph via triggerAsyncId
Checklist
make -j4 test (UNIX), or vcbuild... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lundibundi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33730#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33730 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33730 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33730 |
| Reload | https://github.com/nodejs/node/pull/33730 |
| Reload | https://github.com/nodejs/node/pull/33730 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33730#issue-comment-box |
| lundibundi | https://github.com/lundibundi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lundibundi:improve-async-hook-doc | https://github.com/lundibundi/node/tree/improve-async-hook-doc |
|
doc: improve async_hooks asynchronous context example
| https://github.com/nodejs/node/pull/33730#top |
| lundibundi | https://github.com/lundibundi |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| lundibundi:improve-async-hook-doc | https://github.com/lundibundi/node/tree/improve-async-hook-doc |
|
Conversation
6
| https://github.com/nodejs/node/pull/33730 |
|
Commits
1
| https://github.com/nodejs/node/pull/33730/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33730/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33730/files |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| Jun 4, 2020 | https://github.com/nodejs/node/pull/33730#issue-631040048 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jun 4, 2020 | https://github.com/nodejs/node/pull/33730#event-3408099436 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 4, 2020
| https://github.com/nodejs/node/pull/33730#pullrequestreview-424805310 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33730/files |
| doc/api/async_hooks.md | https://github.com/nodejs/node/pull/33730/files#diff-cfacde5f1154593965e866b7f65c8e25e136dd16ee53fa76bfbfbd280d2ee6e3 |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Jun 4, 2020
| https://github.com/nodejs/node/pull/33730#pullrequestreview-424820552 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33730/files |
| https://github.com/puzpuzpuz |
| puzpuzpuz | https://github.com/puzpuzpuz |
|
Jun 5, 2020
| https://github.com/nodejs/node/pull/33730#pullrequestreview-425267671 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33730/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 5, 2020
| https://github.com/nodejs/node/pull/33730#pullrequestreview-425287762 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33730/files |
|
| https://github.com/lundibundi |
| doc: improve async_hooks asynchronous context example | https://github.com/nodejs/node/pull/33730/commits/5fd26d58830c979166968e0fe239c897be3ee51d |
| 5fd26d5 | https://github.com/nodejs/node/pull/33730/commits/5fd26d58830c979166968e0fe239c897be3ee51d |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
| force-pushed | https://github.com/nodejs/node/compare/0dcb7b6582d86bca3face0768d729595a06defd1..5fd26d58830c979166968e0fe239c897be3ee51d |
| 0dcb7b6 | https://github.com/nodejs/node/commit/0dcb7b6582d86bca3face0768d729595a06defd1 |
| 5fd26d5 | https://github.com/nodejs/node/commit/5fd26d58830c979166968e0fe239c897be3ee51d |
|
Compare
| https://github.com/nodejs/node/compare/0dcb7b6582d86bca3face0768d729595a06defd1..5fd26d58830c979166968e0fe239c897be3ee51d |
| June 8, 2020 15:00 | https://github.com/nodejs/node/pull/33730#event-3420523482 |
| https://github.com/vdeturckheim |
| vdeturckheim | https://github.com/vdeturckheim |
|
Jun 12, 2020
| https://github.com/nodejs/node/pull/33730#pullrequestreview-429738177 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33730/files/5fd26d58830c979166968e0fe239c897be3ee51d |
| jasnell | https://github.com/jasnell |
|
Jul 3, 2020
| https://github.com/nodejs/node/pull/33730#ref-commit-b4fe76d |
|
| https://github.com/lundibundi |
|
| https://github.com/jasnell |
| doc: improve async_hooks asynchronous context example | https://github.com/nodejs/node/commit/b4fe76d656d51ead949f2a35c13a221616f78c4c |
| b4fe76d | https://github.com/nodejs/node/commit/b4fe76d656d51ead949f2a35c13a221616f78c4c |
| #33730 | https://github.com/nodejs/node/pull/33730 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 3, 2020 | https://github.com/nodejs/node/pull/33730#issuecomment-653669566 |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 3, 2020 | https://github.com/nodejs/node/pull/33730#event-3511935919 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/33730#ref-commit-0130939 |
|
| https://github.com/lundibundi |
|
| https://github.com/MylesBorins |
| doc: improve async_hooks asynchronous context example | https://github.com/nodejs/node/commit/01309392dc597295828f4f5eb07a019f9e5d2a6c |
| 0130939 | https://github.com/nodejs/node/commit/01309392dc597295828f4f5eb07a019f9e5d2a6c |
| #33730 | https://github.com/nodejs/node/pull/33730 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/33730#ref-pullrequest-656877627 |
|
v14.6.0 proposal
#34371
| https://github.com/nodejs/node/pull/34371 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/33730#ref-commit-146538d |
|
| https://github.com/lundibundi |
|
| https://github.com/MylesBorins |
| doc: improve async_hooks asynchronous context example | https://github.com/nodejs/node/commit/146538de65f40c52edc5a8bb359426a0f121a13d |
| 146538d | https://github.com/nodejs/node/commit/146538de65f40c52edc5a8bb359426a0f121a13d |
| #33730 | https://github.com/nodejs/node/pull/33730 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/33730#ref-commit-f12c6f4 |
|
| https://github.com/lundibundi |
|
| https://github.com/addaleax |
| doc: improve async_hooks asynchronous context example | https://github.com/nodejs/node/commit/f12c6f406a83a0802101a138f12fb0fdc320ae86 |
| f12c6f4 | https://github.com/nodejs/node/commit/f12c6f406a83a0802101a138f12fb0fdc320ae86 |
| #33730 | https://github.com/nodejs/node/pull/33730 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/33730#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33730 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/33730/files/20619f4693cf653a8f10a1282b9a32e607a6c9b7 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33730/files/0dcb7b6582d86bca3face0768d729595a06defd1 |
|
| https://github.com/Flarna |
|
Flarna
| https://github.com/Flarna |
|
| https://github.com/nodejs/node/pull/33730/files/20619f4693cf653a8f10a1282b9a32e607a6c9b7 |
|
| https://github.com/vdeturckheim |
|
vdeturckheim
| https://github.com/vdeturckheim |
|
| https://github.com/nodejs/node/pull/33730/files/5fd26d58830c979166968e0fe239c897be3ee51d |
|
| https://github.com/puzpuzpuz |
|
puzpuzpuz
| https://github.com/puzpuzpuz |
|
| https://github.com/nodejs/node/pull/33730/files/0dcb7b6582d86bca3face0768d729595a06defd1 |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/33730 |
|
| https://github.com/lundibundi |
|
| https://github.com/jasnell |
|
| https://github.com/benjamingr |
|
| https://github.com/vdeturckheim |
|
| https://github.com/Flarna |
|
| https://github.com/puzpuzpuz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |