René's URL Explorer Experiment


Title: src: simplify Reindent function in json_utils.cc by sapics · Pull Request #33722 · nodejs/node · GitHub

Open Graph Title: src: simplify Reindent function in json_utils.cc by sapics · Pull Request #33722 · nodejs/node

X Title: src: simplify Reindent function in json_utils.cc by sapics · Pull Request #33722 · nodejs/node

Description: This PR replaces std::string indent; for (int i = 0; i < indent_depth; i++) indent += ' '; to const std::string indent(indent_depth, ' '); and do{...}while(true); to for(;;){...}. This PR adds a fa...

Open Graph Description: This PR replaces std::string indent; for (int i = 0; i < indent_depth; i++) indent += ' '; to const std::string indent(indent_depth, ' '); and do{...}while(true); to for(;;){...}...

X Description: This PR replaces std::string indent; for (int i = 0; i &lt; indent_depth; i++) indent += &#39; &#39;; to const std::string indent(indent_depth, &#39; &#39;); and do{...}while(tr...

Opengraph URL: https://github.com/nodejs/node/pull/33722

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e8d81db8-903a-f32c-7552-86a1d007d814
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D50:258BE8:26FA792:3369BB6:696B21AE
html-safe-nonce7a1d38d5886d62d821f74cb375f1996ea2d57b412cace14b06df3423a72e3232
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDUwOjI1OEJFODoyNkZBNzkyOjMzNjlCQjY6Njk2QjIxQUUiLCJ2aXNpdG9yX2lkIjoiMjQ0Mjc3MzQzMTczNjU0MTYxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59b623b5e02c2ca95f42235979e635cbe7ca2dde2426ee49697581b562c32663
hovercard-subject-tagpull_request:427639299
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33722/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/493e1090adbf3ec7bb3d9a0b0a7154c36c898f02a691e86ba2542df6af563957/nodejs/node/pull/33722
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/493e1090adbf3ec7bb3d9a0b0a7154c36c898f02a691e86ba2542df6af563957/nodejs/node/pull/33722
og:image:altThis PR replaces std::string indent; for (int i = 0; i < indent_depth; i++) indent += ' '; to const std::string indent(indent_depth, ' '); and do{...}while(true); to for(;;){...}...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesapics
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33722#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33722
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33722
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33722
Reloadhttps://github.com/nodejs/node/pull/33722
Reloadhttps://github.com/nodejs/node/pull/33722
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33722
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33722
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33722#issue-comment-box
sapicshttps://github.com/sapics
nodejs:masterhttps://github.com/nodejs/node/tree/master
sapics:src/simplify-reindenthttps://github.com/sapics/node/tree/src/simplify-reindent
src: simplify Reindent function in json_utils.cc https://github.com/nodejs/node/pull/33722#top
sapicshttps://github.com/sapics
nodejs:masterhttps://github.com/nodejs/node/tree/master
sapics:src/simplify-reindenthttps://github.com/sapics/node/tree/src/simplify-reindent
Conversation 3 https://github.com/nodejs/node/pull/33722
Commits 2 https://github.com/nodejs/node/pull/33722/commits
Checks 0 https://github.com/nodejs/node/pull/33722/checks
Files changed https://github.com/nodejs/node/pull/33722/files
Please reload this pagehttps://github.com/nodejs/node/pull/33722
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/sapics
sapicshttps://github.com/sapics
Jun 4, 2020https://github.com/nodejs/node/pull/33722#issue-630574967
Please reload this pagehttps://github.com/nodejs/node/pull/33722
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33722
https://github.com/sapics
src: simplify Reindent function in json_utils.cchttps://github.com/nodejs/node/pull/33722/commits/cc0fcf86151070dd2a8d68a81f22b244153c7780
cc0fcf8https://github.com/nodejs/node/pull/33722/commits/cc0fcf86151070dd2a8d68a81f22b244153c7780
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 4, 2020https://github.com/nodejs/node/pull/33722#event-3405440705
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 4, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424206173
View reviewed changes https://github.com/nodejs/node/pull/33722/files/cc0fcf86151070dd2a8d68a81f22b244153c7780
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/33722#pullrequestreview-424206173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33722
https://github.com/sapics
fix indent error reported by linthttps://github.com/nodejs/node/pull/33722/commits/47386059c589cab8658e382d3013bb2bbd303728
4738605https://github.com/nodejs/node/pull/33722/commits/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 4, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424231729
View reviewed changes https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 4, 2020https://github.com/nodejs/node/pull/33722#issuecomment-638711136
https://ci.nodejs.org/job/node-test-pull-request/31716/https://ci.nodejs.org/job/node-test-pull-request/31716/
Please reload this pagehttps://github.com/nodejs/node/pull/33722
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 4, 2020https://github.com/nodejs/node/pull/33722#event-3405799546
https://github.com/himself65
himself65https://github.com/himself65
Jun 4, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424269967
View reviewed changes https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 4, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424375728
View reviewed changes https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 4, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424435474
View reviewed changes https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 4, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424677296
View reviewed changes https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Jun 5, 2020 https://github.com/nodejs/node/pull/33722#pullrequestreview-424956637
View reviewed changes https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
danbevhttps://github.com/danbev
Jun 8, 2020 https://github.com/nodejs/node/pull/33722#ref-commit-689680a
https://github.com/sapics
https://github.com/danbev
src: simplify Reindent function in json_utils.cchttps://github.com/nodejs/node/commit/689680a5315a51cfe347968a893c38bb60be56eb
689680ahttps://github.com/nodejs/node/commit/689680a5315a51cfe347968a893c38bb60be56eb
#33722https://github.com/nodejs/node/pull/33722
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 8, 2020https://github.com/nodejs/node/pull/33722#issuecomment-640562567
689680ahttps://github.com/nodejs/node/commit/689680a5315a51cfe347968a893c38bb60be56eb
Please reload this pagehttps://github.com/nodejs/node/pull/33722
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 8, 2020https://github.com/nodejs/node/pull/33722#event-3419726444
https://github.com/sapics
sapicshttps://github.com/sapics
June 8, 2020 13:26https://github.com/nodejs/node/pull/33722#event-3420043844
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33722#ref-commit-1f996b7
https://github.com/sapics
https://github.com/codebytere
src: simplify Reindent function in json_utils.cchttps://github.com/nodejs/node/commit/1f996b7372026fa96ba43fc58c660327d4cc69bd
1f996b7https://github.com/nodejs/node/commit/1f996b7372026fa96ba43fc58c660327d4cc69bd
#33722https://github.com/nodejs/node/pull/33722
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33722#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33722#ref-commit-c7e2ec1
https://github.com/sapics
https://github.com/codebytere
src: simplify Reindent function in json_utils.cchttps://github.com/nodejs/node/commit/c7e2ec11ab1402790ba9e92f6f81df3fa8a3e104
c7e2ec1https://github.com/nodejs/node/commit/c7e2ec11ab1402790ba9e92f6f81df3fa8a3e104
#33722https://github.com/nodejs/node/pull/33722
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33722#ref-commit-e07c1c2
https://github.com/sapics
https://github.com/codebytere
src: simplify Reindent function in json_utils.cchttps://github.com/nodejs/node/commit/e07c1c25085ec3f717267018fb2e76fe4611cb50
e07c1c2https://github.com/nodejs/node/commit/e07c1c25085ec3f717267018fb2e76fe4611cb50
#33722https://github.com/nodejs/node/pull/33722
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/33722#ref-pullrequest-656085086
v12.18.3 proposal #34343 https://github.com/nodejs/node/pull/34343
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33722#ref-commit-c97c287
https://github.com/sapics
https://github.com/codebytere
src: simplify Reindent function in json_utils.cchttps://github.com/nodejs/node/commit/c97c2878110457c5adafe6d60e0cd0cd0ce1f560
c97c287https://github.com/nodejs/node/commit/c97c2878110457c5adafe6d60e0cd0cd0ce1f560
#33722https://github.com/nodejs/node/pull/33722
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33722
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/33722/files/cc0fcf86151070dd2a8d68a81f22b244153c7780
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/33722/files/47386059c589cab8658e382d3013bb2bbd303728
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33722
https://github.com/sapics
https://github.com/nodejs-github-bot
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/richardlau
https://github.com/himself65
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.