| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2a8b8ed4-dea5-7083-b35f-f5d01a60c807 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D572:338071:1BC9CA1:2669163:696AAC51 |
| html-safe-nonce | 04553289a7bb35d1e27f6971907e770de960f8e1d6e62867ef558cc9bb14481e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTcyOjMzODA3MToxQkM5Q0ExOjI2NjkxNjM6Njk2QUFDNTEiLCJ2aXNpdG9yX2lkIjoiODg5OTY3NjI3NDk2NzYyMDY4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 112672c30bfbb338272e4d9733d9f41ca83d43ae826158bea5c7ba66773f2b70 |
| hovercard-subject-tag | pull_request:427532687 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33717/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f6cd63cda53b02d2f47dfd8abc25a86207fde6bccdfb15af92749f14a4c7f69d/nodejs/node/pull/33717 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f6cd63cda53b02d2f47dfd8abc25a86207fde6bccdfb15af92749f14a4c7f69d/nodejs/node/pull/33717 |
| og:image:alt | /cc @BridgeAR
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33717#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33717 |
| Reload | https://github.com/nodejs/node/pull/33717 |
| Reload | https://github.com/nodejs/node/pull/33717 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33717#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:lazy-load-perf-hooks | https://github.com/jasnell/node/tree/lazy-load-perf-hooks |
|
events: lazy load perf_hooks for EventTarget
| https://github.com/nodejs/node/pull/33717#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:lazy-load-perf-hooks | https://github.com/jasnell/node/tree/lazy-load-perf-hooks |
|
Conversation
9
| https://github.com/nodejs/node/pull/33717 |
|
Commits
2
| https://github.com/nodejs/node/pull/33717/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33717/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33717/files |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 4, 2020 | https://github.com/nodejs/node/pull/33717#issue-630436366 |
| @BridgeAR | https://github.com/BridgeAR |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2020 | https://github.com/nodejs/node/pull/33717#issuecomment-638543532 |
| https://ci.nodejs.org/job/node-test-pull-request/31713/ | https://ci.nodejs.org/job/node-test-pull-request/31713/ |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 4, 2020
| https://github.com/nodejs/node/pull/33717#pullrequestreview-424038538 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33717/files |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Jun 4, 2020
| https://github.com/nodejs/node/pull/33717#pullrequestreview-424273577 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33717/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Jun 4, 2020 | https://github.com/nodejs/node/pull/33717#event-3406866787 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 4, 2020 | https://github.com/nodejs/node/pull/33717#issuecomment-638849813 |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Jun 4, 2020
| https://github.com/nodejs/node/pull/33717#pullrequestreview-424499580 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33717/files |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Jun 5, 2020
| https://github.com/nodejs/node/pull/33717#pullrequestreview-424965886 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33717/files |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jun 6, 2020
| https://github.com/nodejs/node/pull/33717#pullrequestreview-425726452 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33717/files |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Jun 7, 2020
| https://github.com/nodejs/node/pull/33717#pullrequestreview-425780315 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33717/files |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
| jasnell | https://github.com/jasnell |
| June 8, 2020 09:00 | https://github.com/nodejs/node/pull/33717#commits-pushed-47e4fb9 |
|
| https://github.com/jasnell |
| events: lazy load perf_hooks for EventTarget | https://github.com/nodejs/node/pull/33717/commits/47e4fb952baf324d3d3ac78ba0685447a575e261 |
| 47e4fb9 | https://github.com/nodejs/node/pull/33717/commits/47e4fb952baf324d3d3ac78ba0685447a575e261 |
|
| https://github.com/jasnell |
| fixup! events: lazy load perf_hooks for EventTarget | https://github.com/nodejs/node/pull/33717/commits/a19d755b13f4837bb98bb12469d1757479715d5e |
| a19d755 | https://github.com/nodejs/node/pull/33717/commits/a19d755b13f4837bb98bb12469d1757479715d5e |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15..a19d755b13f4837bb98bb12469d1757479715d5e |
| 760fc3c | https://github.com/nodejs/node/commit/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
| a19d755 | https://github.com/nodejs/node/commit/a19d755b13f4837bb98bb12469d1757479715d5e |
|
Compare
| https://github.com/nodejs/node/compare/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15..a19d755b13f4837bb98bb12469d1757479715d5e |
| June 8, 2020 16:27 | https://github.com/nodejs/node/pull/33717#event-3420956788 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
|
CI Relability 2020-06-09
JaneaSystems/nodejs-reliability#9
| https://github.com/JaneaSystems/nodejs-reliability/issues/9 |
|
CI Relability 2020-06-10
JaneaSystems/nodejs-reliability#10
| https://github.com/JaneaSystems/nodejs-reliability/issues/10 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 16, 2020 | https://github.com/nodejs/node/pull/33717#issuecomment-644941282 |
| https://ci.nodejs.org/job/node-test-pull-request/31897/ | https://ci.nodejs.org/job/node-test-pull-request/31897/ |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
| jasnell | https://github.com/jasnell |
|
Jun 16, 2020
| https://github.com/nodejs/node/pull/33717#ref-commit-bc71278 |
|
| https://github.com/jasnell |
| events: lazy load perf_hooks for EventTarget | https://github.com/nodejs/node/commit/bc71278563b60caba7e2d39c170d439a205ff529 |
| bc71278 | https://github.com/nodejs/node/commit/bc71278563b60caba7e2d39c170d439a205ff529 |
| #33717 | https://github.com/nodejs/node/pull/33717 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 16, 2020 | https://github.com/nodejs/node/pull/33717#issuecomment-644968008 |
| bc71278 | https://github.com/nodejs/node/commit/bc71278563b60caba7e2d39c170d439a205ff529 |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 16, 2020 | https://github.com/nodejs/node/pull/33717#event-3450546675 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33717#ref-issue-640818227 |
|
CI Relability 2020-06-18
JaneaSystems/nodejs-reliability#11
| https://github.com/JaneaSystems/nodejs-reliability/issues/11 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33717#ref-commit-f1b0291 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: lazy load perf_hooks for EventTarget | https://github.com/nodejs/node/commit/f1b0291d8282392d96604e45e58da2296c76cfb3 |
| f1b0291 | https://github.com/nodejs/node/commit/f1b0291d8282392d96604e45e58da2296c76cfb3 |
| #33717 | https://github.com/nodejs/node/pull/33717 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 28, 2020
| https://github.com/nodejs/node/pull/33717#ref-pullrequest-646828333 |
|
v14.5.0 proposal
#34093
| https://github.com/nodejs/node/pull/34093 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33717#ref-commit-7169dc0 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| events: lazy load perf_hooks for EventTarget | https://github.com/nodejs/node/commit/7169dc04ee938fd3b52e5a0e596dd4eb97a02acf |
| 7169dc0 | https://github.com/nodejs/node/commit/7169dc04ee938fd3b52e5a0e596dd4eb97a02acf |
| #33717 | https://github.com/nodejs/node/pull/33717 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backport-requested-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x |
| Sep 26, 2020 | https://github.com/nodejs/node/pull/33717#event-3810767650 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 26, 2020
| https://github.com/nodejs/node/pull/33717#ref-pullrequest-624383334 |
|
events: initial implementation of experimental EventTarget
#33556
| https://github.com/nodejs/node/pull/33556 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33717 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/33717/files/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/33717/files/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/33717/files/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/33717/files/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/33717/files/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/33717/files/760fc3c0b7112dbcca0aa9b1afbd6d4365260b15 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Please reload this page | https://github.com/nodejs/node/pull/33717 |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/benjamingr |
|
| https://github.com/BridgeAR |
|
| https://github.com/lundibundi |
|
| https://github.com/himself65 |
|
| https://github.com/trivikr |
|
| https://github.com/juanarbol |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |