| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b00b95a0-3b58-2686-8f18-f21d5c807dd8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7BC:1CEAED:294C926:36406FE:696B26CE |
| html-safe-nonce | 55baab9a2c002b65182c21a571583c34ef41bf6e491e90f6c05932b4b4df09d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0JDOjFDRUFFRDoyOTRDOTI2OjM2NDA2RkU6Njk2QjI2Q0UiLCJ2aXNpdG9yX2lkIjoiNTI1OTQ2NzE2MTE3MDgxNDY3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5114ef7d6a440f86202e3a07d498276cad045e005e75402f41ec2ecebec77993 |
| hovercard-subject-tag | pull_request:427183177 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33711/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/aba62e35f05c3e76fa840e12bdb4135bf856af36e189a9f39230bb4fb1760617/nodejs/node/pull/33711 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aba62e35f05c3e76fa840e12bdb4135bf856af36e189a9f39230bb4fb1760617/nodejs/node/pull/33711 |
| og:image:alt | Converted anonymous callback functions to arrow functions for better readability.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
document... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sagar-jadhav |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33711#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33711 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33711 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33711 |
| Reload | https://github.com/nodejs/node/pull/33711 |
| Reload | https://github.com/nodejs/node/pull/33711 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33711#issue-comment-box |
| sagar-jadhav | https://github.com/sagar-jadhav |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Test: Changed function to arrow function
| https://github.com/nodejs/node/pull/33711#top |
| sagar-jadhav | https://github.com/sagar-jadhav |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
6
| https://github.com/nodejs/node/pull/33711 |
|
Commits
1
| https://github.com/nodejs/node/pull/33711/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33711/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33711/files |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sagar-jadhav |
| sagar-jadhav | https://github.com/sagar-jadhav |
| Jun 3, 2020 | https://github.com/nodejs/node/pull/33711#issue-629971088 |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jun 3, 2020 | https://github.com/nodejs/node/pull/33711#event-3402018871 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jun 3, 2020
| https://github.com/nodejs/node/pull/33711#pullrequestreview-423524558 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33711/files |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Jun 3, 2020
| https://github.com/nodejs/node/pull/33711#pullrequestreview-423534663 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33711/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 3, 2020
| https://github.com/nodejs/node/pull/33711#pullrequestreview-423755606 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33711/files |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Jun 5, 2020
| https://github.com/nodejs/node/pull/33711#pullrequestreview-424968447 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33711/files |
| test/parallel/test-util-promisify.js | https://github.com/nodejs/node/pull/33711/files#diff-04f5e01692be4eb45fa1b88e405a95c0c45052570c0cb79e0413d4e314cedd72 |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Jun 5, 2020
| https://github.com/nodejs/node/pull/33711#pullrequestreview-424968475 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33711/files |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33711#event-3414021452 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33711#issuecomment-639961722 |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://ci.nodejs.org/job/node-test-pull-request/31746/ | https://ci.nodejs.org/job/node-test-pull-request/31746/ |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/juanarbol |
| test: changed function to arrow function | https://github.com/nodejs/node/pull/33711/commits/d126e5767f60b739017a7fc90a2a94f0ccb1ab83 |
| d126e57 | https://github.com/nodejs/node/pull/33711/commits/d126e5767f60b739017a7fc90a2a94f0ccb1ab83 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33711#issuecomment-639965739 |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://ci.nodejs.org/job/node-test-pull-request/31747/ | https://ci.nodejs.org/job/node-test-pull-request/31747/ |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Jun 6, 2020
| https://github.com/nodejs/node/pull/33711#pullrequestreview-425708478 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33711/files/d126e5767f60b739017a7fc90a2a94f0ccb1ab83 |
| juanarbol | https://github.com/juanarbol |
|
Jun 6, 2020
| https://github.com/nodejs/node/pull/33711#ref-commit-3ac50e1 |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/juanarbol |
| test: changed function to arrow function | https://github.com/nodejs/node/commit/3ac50e12090a40e681cf1e9843a54ccfc102fbd5 |
| 3ac50e1 | https://github.com/nodejs/node/commit/3ac50e12090a40e681cf1e9843a54ccfc102fbd5 |
| #33711 | https://github.com/nodejs/node/pull/33711 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33711#issuecomment-639973689 |
| 3ac50e1 | https://github.com/nodejs/node/commit/3ac50e12090a40e681cf1e9843a54ccfc102fbd5 |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33711#event-3414106224 |
| https://github.com/sagar-jadhav |
| sagar-jadhav | https://github.com/sagar-jadhav |
| June 6, 2020 04:01 | https://github.com/nodejs/node/pull/33711#event-3414115598 |
| https://github.com/sagar-jadhav |
| sagar-jadhav | https://github.com/sagar-jadhav |
| Jun 6, 2020 | https://github.com/nodejs/node/pull/33711#issuecomment-639975025 |
| 3ac50e1 | https://github.com/nodejs/node/commit/3ac50e12090a40e681cf1e9843a54ccfc102fbd5 |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
|
CI Relability 2020-06-07
JaneaSystems/nodejs-reliability#7
| https://github.com/JaneaSystems/nodejs-reliability/issues/7 |
|
CI Relability 2020-06-08
JaneaSystems/nodejs-reliability#8
| https://github.com/JaneaSystems/nodejs-reliability/issues/8 |
|
CI Relability 2020-06-09
JaneaSystems/nodejs-reliability#9
| https://github.com/JaneaSystems/nodejs-reliability/issues/9 |
|
CI Relability 2020-06-10
JaneaSystems/nodejs-reliability#10
| https://github.com/JaneaSystems/nodejs-reliability/issues/10 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33711#ref-commit-c3ac47c |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/codebytere |
| test: changed function to arrow function | https://github.com/nodejs/node/commit/c3ac47c03dc5ed55f66ac8129ace1531ab2ae73f |
| c3ac47c | https://github.com/nodejs/node/commit/c3ac47c03dc5ed55f66ac8129ace1531ab2ae73f |
| #33711 | https://github.com/nodejs/node/pull/33711 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 28, 2020
| https://github.com/nodejs/node/pull/33711#ref-pullrequest-646828333 |
|
v14.5.0 proposal
#34093
| https://github.com/nodejs/node/pull/34093 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33711#ref-commit-e9627bc |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/codebytere |
| test: changed function to arrow function | https://github.com/nodejs/node/commit/e9627bc81819b9c961c10f9a4ffbf74e91ac7478 |
| e9627bc | https://github.com/nodejs/node/commit/e9627bc81819b9c961c10f9a4ffbf74e91ac7478 |
| #33711 | https://github.com/nodejs/node/pull/33711 |
| codebytere | https://github.com/codebytere |
|
Jul 9, 2020
| https://github.com/nodejs/node/pull/33711#ref-commit-d374e76 |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/codebytere |
| test: changed function to arrow function | https://github.com/nodejs/node/commit/d374e764282c7f8fd8c0fcdde1c4c9d36ff9fccf |
| d374e76 | https://github.com/nodejs/node/commit/d374e764282c7f8fd8c0fcdde1c4c9d36ff9fccf |
| #33711 | https://github.com/nodejs/node/pull/33711 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jul 13, 2020
| https://github.com/nodejs/node/pull/33711#ref-pullrequest-656085086 |
|
v12.18.3 proposal
#34343
| https://github.com/nodejs/node/pull/34343 |
| codebytere | https://github.com/codebytere |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/33711#ref-commit-8a51670 |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/codebytere |
| test: changed function to arrow function | https://github.com/nodejs/node/commit/8a516707b04baa20cf0766eafe2765d07396305a |
| 8a51670 | https://github.com/nodejs/node/commit/8a516707b04baa20cf0766eafe2765d07396305a |
| #33711 | https://github.com/nodejs/node/pull/33711 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33711 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33711/files/f6c9956341487bf4e09189f4b001d8dd398ae2a4 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/33711/files/f6c9956341487bf4e09189f4b001d8dd398ae2a4 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/33711/files/f6c9956341487bf4e09189f4b001d8dd398ae2a4 |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/33711/files/d126e5767f60b739017a7fc90a2a94f0ccb1ab83 |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/33711/files/f6c9956341487bf4e09189f4b001d8dd398ae2a4 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/33711 |
|
| https://github.com/sagar-jadhav |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/juanarbol |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/himself65 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |