René's URL Explorer Experiment


Title: build: add LINT_CPP_FILES to checkimports check by danbev · Pull Request #33697 · nodejs/node · GitHub

Open Graph Title: build: add LINT_CPP_FILES to checkimports check by danbev · Pull Request #33697 · nodejs/node

X Title: build: add LINT_CPP_FILES to checkimports check by danbev · Pull Request #33697 · nodejs/node

Description: This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

Open Graph Description: This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...

X Description: This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. Checklist make -j4 test (UNIX), or vcbuild test (W...

Opengraph URL: https://github.com/nodejs/node/pull/33697

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:63bc6331-16cb-e484-8930-1f30eb28f9c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7CE:2C2C4D:EFC820:14BB9D2:696A9145
html-safe-nonce4fe2387ddc1ea9ec06fb96682f91f96794d88ff0e098e2028f5ae7eff40e0d2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0NFOjJDMkM0RDpFRkM4MjA6MTRCQjlEMjo2OTZBOTE0NSIsInZpc2l0b3JfaWQiOiIzMTE0NjA1Mzg4ODQxNTIxNDc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace82b5dac402de9db646d2c83625425e1014dd9b04b90bbe71a185308c769152f
hovercard-subject-tagpull_request:426525447
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33697/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97caf78a58569ff3c7384dbf2ef1425d109fae3bef8b31544621e4a702f5cf61/nodejs/node/pull/33697
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97caf78a58569ff3c7384dbf2ef1425d109fae3bef8b31544621e4a702f5cf61/nodejs/node/pull/33697
og:image:altThis commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33697#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33697
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33697
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33697
Reloadhttps://github.com/nodejs/node/pull/33697
Reloadhttps://github.com/nodejs/node/pull/33697
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33697
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33697
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33697#issue-comment-box
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:checkimports-toolshttps://github.com/danbev/node/tree/checkimports-tools
build: add LINT_CPP_FILES to checkimports check https://github.com/nodejs/node/pull/33697#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:checkimports-toolshttps://github.com/danbev/node/tree/checkimports-tools
Conversation 4 https://github.com/nodejs/node/pull/33697
Commits 2 https://github.com/nodejs/node/pull/33697/commits
Checks 0 https://github.com/nodejs/node/pull/33697/checks
Files changed https://github.com/nodejs/node/pull/33697/files
Please reload this pagehttps://github.com/nodejs/node/pull/33697
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 2, 2020https://github.com/nodejs/node/pull/33697#issue-629128677
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33697
danbevhttps://github.com/danbev
June 2, 2020 13:21https://github.com/nodejs/node/pull/33697#commits-pushed-7f29637
https://github.com/danbev
build: add LINT_CPP_FILES to checkimports checkhttps://github.com/nodejs/node/pull/33697/commits/7f29637b19c875809434a42626b8074c0a51cdf6
7f29637https://github.com/nodejs/node/pull/33697/commits/7f29637b19c875809434a42626b8074c0a51cdf6
https://github.com/danbev
tools: remove unused using declarations code_cachehttps://github.com/nodejs/node/pull/33697/commits/5f5c1fd8639adb471cb56e0824f0b10149be1cab
5f5c1fdhttps://github.com/nodejs/node/pull/33697/commits/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jun 2, 2020https://github.com/nodejs/node/pull/33697#event-3397207782
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 2, 2020 https://github.com/nodejs/node/pull/33697#pullrequestreview-422613707
View reviewed changes https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/targos
targoshttps://github.com/targos
Jun 2, 2020 https://github.com/nodejs/node/pull/33697#pullrequestreview-422615015
View reviewed changes https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 2, 2020 https://github.com/nodejs/node/pull/33697#pullrequestreview-422640011
View reviewed changes https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 2, 2020 https://github.com/nodejs/node/pull/33697#pullrequestreview-422729108
View reviewed changes https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 5, 2020https://github.com/nodejs/node/pull/33697#issuecomment-639280028
https://ci.nodejs.org/job/node-test-pull-request/31730/https://ci.nodejs.org/job/node-test-pull-request/31730/
Please reload this pagehttps://github.com/nodejs/node/pull/33697
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 5, 2020https://github.com/nodejs/node/pull/33697#issuecomment-639472531
https://ci.nodejs.org/job/node-test-pull-request/31733/https://ci.nodejs.org/job/node-test-pull-request/31733/
Please reload this pagehttps://github.com/nodejs/node/pull/33697
CI Relability 2020-06-06 JaneaSystems/nodejs-reliability#6 https://github.com/JaneaSystems/nodejs-reliability/issues/6
CI Relability 2020-06-07 JaneaSystems/nodejs-reliability#7 https://github.com/JaneaSystems/nodejs-reliability/issues/7
CI Relability 2020-06-08 JaneaSystems/nodejs-reliability#8 https://github.com/JaneaSystems/nodejs-reliability/issues/8
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 8, 2020https://github.com/nodejs/node/pull/33697#issuecomment-640400800
node-test-commit-osxhttps://ci.nodejs.org/job/node-test-commit-osx/34592/
Please reload this pagehttps://github.com/nodejs/node/pull/33697
danbevhttps://github.com/danbev
Jun 8, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-0c31702
https://github.com/danbev
build: add LINT_CPP_FILES to checkimports checkhttps://github.com/nodejs/node/commit/0c31702405341eade38b2864c4381b0493360737
0c31702https://github.com/nodejs/node/commit/0c31702405341eade38b2864c4381b0493360737
#33697https://github.com/nodejs/node/pull/33697
danbevhttps://github.com/danbev
Jun 8, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-111d1e5
https://github.com/danbev
tools: remove unused using declarations code_cachehttps://github.com/nodejs/node/commit/111d1e523d632c489bfe99adfb3f8c080e996d32
111d1e5https://github.com/nodejs/node/commit/111d1e523d632c489bfe99adfb3f8c080e996d32
#33697https://github.com/nodejs/node/pull/33697
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 8, 2020https://github.com/nodejs/node/pull/33697#issuecomment-640403444
0c31702https://github.com/nodejs/node/commit/0c31702405341eade38b2864c4381b0493360737
111d1e5https://github.com/nodejs/node/commit/111d1e523d632c489bfe99adfb3f8c080e996d32
Please reload this pagehttps://github.com/nodejs/node/pull/33697
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 8, 2020https://github.com/nodejs/node/pull/33697#event-3418390665
https://github.com/danbev
danbevhttps://github.com/danbev
June 8, 2020 06:47https://github.com/nodejs/node/pull/33697#event-3418391408
CI Relability 2020-06-09 JaneaSystems/nodejs-reliability#9 https://github.com/JaneaSystems/nodejs-reliability/issues/9
CI Relability 2020-06-10 JaneaSystems/nodejs-reliability#10 https://github.com/JaneaSystems/nodejs-reliability/issues/10
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-e8f7670
https://github.com/danbev
https://github.com/codebytere
build: add LINT_CPP_FILES to checkimports checkhttps://github.com/nodejs/node/commit/e8f7670b77c271b85eece37df98a7e6795ee3377
e8f7670https://github.com/nodejs/node/commit/e8f7670b77c271b85eece37df98a7e6795ee3377
#33697https://github.com/nodejs/node/pull/33697
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-a14e38a
https://github.com/danbev
https://github.com/codebytere
tools: remove unused using declarations code_cachehttps://github.com/nodejs/node/commit/a14e38a6c09b5831cfa7423d9ace665c43aea5a2
a14e38ahttps://github.com/nodejs/node/commit/a14e38a6c09b5831cfa7423d9ace665c43aea5a2
#33697https://github.com/nodejs/node/pull/33697
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33697#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-092138a
https://github.com/danbev
https://github.com/codebytere
build: add LINT_CPP_FILES to checkimports checkhttps://github.com/nodejs/node/commit/092138ac12a71902cfd0e8beb20dd2eea02032b6
092138ahttps://github.com/nodejs/node/commit/092138ac12a71902cfd0e8beb20dd2eea02032b6
#33697https://github.com/nodejs/node/pull/33697
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-2b5898e
https://github.com/danbev
https://github.com/codebytere
tools: remove unused using declarations code_cachehttps://github.com/nodejs/node/commit/2b5898eebc20918ebe7389b14918a1a4782c921c
2b5898ehttps://github.com/nodejs/node/commit/2b5898eebc20918ebe7389b14918a1a4782c921c
#33697https://github.com/nodejs/node/pull/33697
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-d56585e
https://github.com/danbev
https://github.com/codebytere
build: add LINT_CPP_FILES to checkimports checkhttps://github.com/nodejs/node/commit/d56585ec8d1db2d31843b11af53aa42e35fc02d0
d56585ehttps://github.com/nodejs/node/commit/d56585ec8d1db2d31843b11af53aa42e35fc02d0
#33697https://github.com/nodejs/node/pull/33697
codebyterehttps://github.com/codebytere
Jul 10, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-5328089
https://github.com/danbev
https://github.com/codebytere
tools: remove unused using declarations code_cachehttps://github.com/nodejs/node/commit/5328089c919e00d99dc6dd0603febf96d2a14e7c
5328089https://github.com/nodejs/node/commit/5328089c919e00d99dc6dd0603febf96d2a14e7c
#33697https://github.com/nodejs/node/pull/33697
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/33697#ref-pullrequest-656085086
v12.18.3 proposal #34343 https://github.com/nodejs/node/pull/34343
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-68615a0
https://github.com/danbev
https://github.com/codebytere
build: add LINT_CPP_FILES to checkimports checkhttps://github.com/nodejs/node/commit/68615a01d1b95a2cc705f16acdab3cd7cb9f023e
68615a0https://github.com/nodejs/node/commit/68615a01d1b95a2cc705f16acdab3cd7cb9f023e
#33697https://github.com/nodejs/node/pull/33697
codebyterehttps://github.com/codebytere
Jul 14, 2020 https://github.com/nodejs/node/pull/33697#ref-commit-f458be2
https://github.com/danbev
https://github.com/codebytere
tools: remove unused using declarations code_cachehttps://github.com/nodejs/node/commit/f458be228c83cb972c99f8f2bf65df0014b01020
f458be2https://github.com/nodejs/node/commit/f458be228c83cb972c99f8f2bf65df0014b01020
#33697https://github.com/nodejs/node/pull/33697
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33697
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/33697/files/5f5c1fd8639adb471cb56e0824f0b10149be1cab
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/33697
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/targos
https://github.com/cjihrig
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.