| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:314db56d-c7fa-03d8-3e93-a305f56c4773 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB18:F74F6:172CB61:1EB3BF1:696AE794 |
| html-safe-nonce | 0490804514463569bd71a1839a6b1d3b722b5b6f6b43595d419de83521b597d4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjE4OkY3NEY2OjE3MkNCNjE6MUVCM0JGMTo2OTZBRTc5NCIsInZpc2l0b3JfaWQiOiIyNDIzNTUxMTk4MjI5MDk2MzQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 74e82840480fedad1a17166e0f549b7787601845d114ebb891d5a646e9b94f02 |
| hovercard-subject-tag | pull_request:425644677 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33675/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7acadba9b585ea5058ed0f4325438a739e5eaa523827b062d41ed54666b016c2/nodejs/node/pull/33675 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7acadba9b585ea5058ed0f4325438a739e5eaa523827b062d41ed54666b016c2/nodejs/node/pull/33675 |
| og:image:alt | Since there is a setPrompt() there should be a getPrompt().
There are use-cases where it is needed to know what the
current prompt is. Adding a getPrompt() negates the need
to store the set prompt ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mattiasrunge |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d84d50b3c75fa36755c3cf392edbc09e626f979 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33675#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33675 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33675 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33675 |
| Reload | https://github.com/nodejs/node/pull/33675 |
| Reload | https://github.com/nodejs/node/pull/33675 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33675#issue-comment-box |
| mattiasrunge | https://github.com/mattiasrunge |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mattiasrunge:readline-prompt-improve | https://github.com/mattiasrunge/node/tree/readline-prompt-improve |
|
readline: add getPrompt to get the current prompt
| https://github.com/nodejs/node/pull/33675#top |
| mattiasrunge | https://github.com/mattiasrunge |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mattiasrunge:readline-prompt-improve | https://github.com/mattiasrunge/node/tree/readline-prompt-improve |
|
Conversation
23
| https://github.com/nodejs/node/pull/33675 |
|
Commits
1
| https://github.com/nodejs/node/pull/33675/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33675/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33675/files |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| May 31, 2020 | https://github.com/nodejs/node/pull/33675#issue-628008474 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| May 31, 2020 | https://github.com/nodejs/node/pull/33675#event-3390819678 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
May 31, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-421516365 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/33675/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
May 31, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-421516386 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/33675/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
May 31, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-421519374 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/33675#pullrequestreview-421519374 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| May 31, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-636514767 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| May 31, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-636514956 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jun 1, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-637078283 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jun 1, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422175137 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/33675/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jun 2, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422280593 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Jun 2, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422315730 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jun 2, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422469421 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422469421 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Jun 2, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422533984 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| BridgeAR | https://github.com/BridgeAR |
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422533984 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 2, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422547148 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| Jun 2, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-637566102 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jun 2, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422721331 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/33675#pullrequestreview-422721331 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| force-pushed | https://github.com/nodejs/node/compare/59b2c023e8d21a6e09d8e0f92ef54f6670899acd..b17a0e6b52417447926fb9ce51caf0ed5130443d |
| 59b2c02 | https://github.com/nodejs/node/commit/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
| b17a0e6 | https://github.com/nodejs/node/commit/b17a0e6b52417447926fb9ce51caf0ed5130443d |
|
Compare
| https://github.com/nodejs/node/compare/59b2c023e8d21a6e09d8e0f92ef54f6670899acd..b17a0e6b52417447926fb9ce51caf0ed5130443d |
| June 23, 2020 13:31 | https://github.com/nodejs/node/pull/33675#event-3472966227 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| force-pushed | https://github.com/nodejs/node/compare/b17a0e6b52417447926fb9ce51caf0ed5130443d..682f17f1dacfebfbe87cd315ec1435b6134bd238 |
| b17a0e6 | https://github.com/nodejs/node/commit/b17a0e6b52417447926fb9ce51caf0ed5130443d |
| 682f17f | https://github.com/nodejs/node/commit/682f17f1dacfebfbe87cd315ec1435b6134bd238 |
|
Compare
| https://github.com/nodejs/node/compare/b17a0e6b52417447926fb9ce51caf0ed5130443d..682f17f1dacfebfbe87cd315ec1435b6134bd238 |
| October 14, 2020 18:16 | https://github.com/nodejs/node/pull/33675#event-3877916652 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| Oct 14, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-708576492 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Oct 15, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-708987010 |
| @mattiasrunge | https://github.com/mattiasrunge |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
|
| https://github.com/mattiasrunge |
|
| https://github.com/cjihrig |
| readline: add getPrompt to get the current prompt | https://github.com/nodejs/node/pull/33675/commits/f315b21523447b1cd2abee50720346f7b11fbaf4 |
| f315b21 | https://github.com/nodejs/node/pull/33675/commits/f315b21523447b1cd2abee50720346f7b11fbaf4 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| force-pushed | https://github.com/nodejs/node/compare/682f17f1dacfebfbe87cd315ec1435b6134bd238..f315b21523447b1cd2abee50720346f7b11fbaf4 |
| 682f17f | https://github.com/nodejs/node/commit/682f17f1dacfebfbe87cd315ec1435b6134bd238 |
| f315b21 | https://github.com/nodejs/node/commit/f315b21523447b1cd2abee50720346f7b11fbaf4 |
|
Compare
| https://github.com/nodejs/node/compare/682f17f1dacfebfbe87cd315ec1435b6134bd238..f315b21523447b1cd2abee50720346f7b11fbaf4 |
| October 19, 2020 06:52 | https://github.com/nodejs/node/pull/33675#event-3891625582 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| Oct 19, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-711698371 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 8, 2020 | https://github.com/nodejs/node/pull/33675#event-3970995766 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 8, 2020 | https://github.com/nodejs/node/pull/33675#event-3971006426 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33675 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 9, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724165914 |
| https://ci.nodejs.org/job/node-test-pull-request/34247/ | https://ci.nodejs.org/job/node-test-pull-request/34247/ |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#event-3977941506 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#event-3977981439 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724590239 |
| https://github.com/nodejs/node/actions/runs/355594986 | https://github.com/nodejs/node/actions/runs/355594986 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724684002 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724684021 |
| https://ci.nodejs.org/job/node-test-pull-request/34284/ | https://ci.nodejs.org/job/node-test-pull-request/34284/ |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Nov 10, 2020
| https://github.com/nodejs/node/pull/33675#pullrequestreview-527427151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33675/files/f315b21523447b1cd2abee50720346f7b11fbaf4 |
| juanarbol | https://github.com/juanarbol |
| https://github.com/nodejs/node/pull/33675#pullrequestreview-527427151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#event-3980636495 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#event-3980657499 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724926703 |
| 3c38445...60a97c0 | https://github.com/nodejs/node/compare/3c38445cc8996911ba443961088e971da6409a65...60a97c0b42433df051fb5b665dcb62c3472a5328 |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#event-3980658058 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Nov 10, 2020
| https://github.com/nodejs/node/pull/33675#ref-commit-60a97c0 |
|
| https://github.com/mattiasrunge |
|
| https://github.com/nodejs-github-bot |
| readline: add getPrompt to get the current prompt | https://github.com/nodejs/node/commit/60a97c0b42433df051fb5b665dcb62c3472a5328 |
| 60a97c0 | https://github.com/nodejs/node/commit/60a97c0b42433df051fb5b665dcb62c3472a5328 |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724927458 |
| @mattiasrunge | https://github.com/mattiasrunge |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| https://github.com/mattiasrunge |
| mattiasrunge | https://github.com/mattiasrunge |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/33675#issuecomment-724929731 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/33675#ref-commit-d1baae3 |
|
| https://github.com/mattiasrunge |
|
| https://github.com/codebytere |
| readline: add getPrompt to get the current prompt | https://github.com/nodejs/node/commit/d1baae364033e3c1c8e87b8e834248dce2bcd8fc |
| d1baae3 | https://github.com/nodejs/node/commit/d1baae364033e3c1c8e87b8e834248dce2bcd8fc |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/33675#ref-commit-ac213a0 |
|
| https://github.com/codebytere |
| 2020-11-24, Version 15.3.0 (Current) | https://github.com/nodejs/node/commit/ac213a0b1b7b2a0158a614e84f8529cc516762e7 |
| ac213a0 | https://github.com/nodejs/node/commit/ac213a0b1b7b2a0158a614e84f8529cc516762e7 |
| #33099 | https://github.com/nodejs/node/pull/33099 |
| #36001 | https://github.com/nodejs/node/pull/36001 |
| #36048 | https://github.com/nodejs/node/pull/36048 |
| #35978 | https://github.com/nodejs/node/pull/35978 |
| #33716 | https://github.com/nodejs/node/pull/33716 |
| #34962 | https://github.com/nodejs/node/pull/34962 |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| #35940 | https://github.com/nodejs/node/pull/35940 |
| #34055 | https://github.com/nodejs/node/pull/34055 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/33675#ref-pullrequest-748354048 |
|
v15.3.0 proposal
#36232
| https://github.com/nodejs/node/pull/36232 |
| codebytere | https://github.com/codebytere |
|
Nov 24, 2020
| https://github.com/nodejs/node/pull/33675#ref-commit-636a649 |
|
| https://github.com/codebytere |
| 2020-11-24, Version 15.3.0 (Current) | https://github.com/nodejs/node/commit/636a6491c87a84cdefe98a5d40bb6c7aa88d7e7b |
| 636a649 | https://github.com/nodejs/node/commit/636a6491c87a84cdefe98a5d40bb6c7aa88d7e7b |
| #33099 | https://github.com/nodejs/node/pull/33099 |
| #36001 | https://github.com/nodejs/node/pull/36001 |
| #36048 | https://github.com/nodejs/node/pull/36048 |
| #35978 | https://github.com/nodejs/node/pull/35978 |
| #33716 | https://github.com/nodejs/node/pull/33716 |
| #34962 | https://github.com/nodejs/node/pull/34962 |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| #35940 | https://github.com/nodejs/node/pull/35940 |
| #34055 | https://github.com/nodejs/node/pull/34055 |
| codebytere | https://github.com/codebytere |
|
Nov 24, 2020
| https://github.com/nodejs/node/pull/33675#ref-commit-63e7dc1 |
|
| https://github.com/codebytere |
| 2020-11-24, Version 15.3.0 (Current) | https://github.com/nodejs/node/commit/63e7dc1e5c71b70c80ed9eda230991edb00811e2 |
| 63e7dc1 | https://github.com/nodejs/node/commit/63e7dc1e5c71b70c80ed9eda230991edb00811e2 |
| #33099 | https://github.com/nodejs/node/pull/33099 |
| #36001 | https://github.com/nodejs/node/pull/36001 |
| #36048 | https://github.com/nodejs/node/pull/36048 |
| #35978 | https://github.com/nodejs/node/pull/35978 |
| #33716 | https://github.com/nodejs/node/pull/33716 |
| #34962 | https://github.com/nodejs/node/pull/34962 |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| #35940 | https://github.com/nodejs/node/pull/35940 |
| #34055 | https://github.com/nodejs/node/pull/34055 |
| #36232 | https://github.com/nodejs/node/pull/36232 |
| codebytere | https://github.com/codebytere |
|
Nov 24, 2020
| https://github.com/nodejs/node/pull/33675#ref-commit-7b5b8ef |
|
| https://github.com/codebytere |
| 2020-11-24, Version 15.3.0 (Current) | https://github.com/nodejs/node/commit/7b5b8ef42474c7370740c1feefc41330c44ce1ea |
| 7b5b8ef | https://github.com/nodejs/node/commit/7b5b8ef42474c7370740c1feefc41330c44ce1ea |
| #33099 | https://github.com/nodejs/node/pull/33099 |
| #36001 | https://github.com/nodejs/node/pull/36001 |
| #36048 | https://github.com/nodejs/node/pull/36048 |
| #35978 | https://github.com/nodejs/node/pull/35978 |
| #33716 | https://github.com/nodejs/node/pull/33716 |
| #34962 | https://github.com/nodejs/node/pull/34962 |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| #35940 | https://github.com/nodejs/node/pull/35940 |
| #34055 | https://github.com/nodejs/node/pull/34055 |
| #36232 | https://github.com/nodejs/node/pull/36232 |
| targos | https://github.com/targos |
|
May 1, 2021
| https://github.com/nodejs/node/pull/33675#ref-commit-ffaa114 |
|
| https://github.com/mattiasrunge |
|
| https://github.com/targos |
| readline: add getPrompt to get the current prompt | https://github.com/nodejs/node/commit/ffaa1149e1b7b783121a795cff1fc8f37af00dcb |
| ffaa114 | https://github.com/nodejs/node/commit/ffaa1149e1b7b783121a795cff1fc8f37af00dcb |
| #33675 | https://github.com/nodejs/node/pull/33675 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
May 3, 2021
| https://github.com/nodejs/node/pull/33675#ref-pullrequest-874193529 |
|
v14.17.0 proposal
#38507
| https://github.com/nodejs/node/pull/38507 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33675 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33675/files/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/33675/files/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/33675/files/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/33675/files/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/33675/files/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/33675/files/f315b21523447b1cd2abee50720346f7b11fbaf4 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/33675/files/9a2e4b8f58e0a3a09d449c20f4470f8823d64bdc |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/33675/files/59b2c023e8d21a6e09d8e0f92ef54f6670899acd |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/33675 |
|
| https://github.com/mattiasrunge |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/antsmartian |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/juanarbol |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |