René's URL Explorer Experiment


Title: src: avoid OOB read in URL parser by addaleax · Pull Request #33640 · nodejs/node · GitHub

Open Graph Title: src: avoid OOB read in URL parser by addaleax · Pull Request #33640 · nodejs/node

X Title: src: avoid OOB read in URL parser by addaleax · Pull Request #33640 · nodejs/node

Description: This is not a big concern, because right now, all (non-test) inputs to the parser are '\0'-terminated, but we should be future-proof here and not perform these OOB reads. Checklist make -j4 tes...

Open Graph Description: This is not a big concern, because right now, all (non-test) inputs to the parser are '\0'-terminated, but we should be future-proof here and not perform these OOB reads. Checklist make...

X Description: This is not a big concern, because right now, all (non-test) inputs to the parser are '\0'-terminated, but we should be future-proof here and not perform these OOB reads. Checklist...

Opengraph URL: https://github.com/nodejs/node/pull/33640

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:33c0dd96-e336-030d-4d7a-83d3b6041d6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B94:14FC13:9EB5C2:D7A0B3:696AB9E9
html-safe-nonce191aa7dbb402d0d9c3aa3dcf87b9d1a392bcc18ba943cca2a464c2e31769aca5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qjk0OjE0RkMxMzo5RUI1QzI6RDdBMEIzOjY5NkFCOUU5IiwidmlzaXRvcl9pZCI6IjQxMTUwODMxMzY3MjAzNTM3NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3a6038b9d8c418fe8c126bffb391dac81c0e7783b4e464d003bf7009e05f5757
hovercard-subject-tagpull_request:425239798
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33640/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1b1ee51dacee73b32afd955aebfa04e2fe944a30c67b81db598b0c510b5875cb/nodejs/node/pull/33640
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1b1ee51dacee73b32afd955aebfa04e2fe944a30c67b81db598b0c510b5875cb/nodejs/node/pull/33640
og:image:altThis is not a big concern, because right now, all (non-test) inputs to the parser are '\0'-terminated, but we should be future-proof here and not perform these OOB reads. Checklist make...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33640#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33640
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33640
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33640
Reloadhttps://github.com/nodejs/node/pull/33640
Reloadhttps://github.com/nodejs/node/pull/33640
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/33640
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/33640
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/33640#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:url-oob-fixhttps://github.com/addaleax/node/tree/url-oob-fix
src: avoid OOB read in URL parser https://github.com/nodejs/node/pull/33640#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:url-oob-fixhttps://github.com/addaleax/node/tree/url-oob-fix
Conversation 3 https://github.com/nodejs/node/pull/33640
Commits 2 https://github.com/nodejs/node/pull/33640/commits
Checks 0 https://github.com/nodejs/node/pull/33640/checks
Files changed https://github.com/nodejs/node/pull/33640/files
Please reload this pagehttps://github.com/nodejs/node/pull/33640
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 29, 2020https://github.com/nodejs/node/pull/33640#issue-627432839
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33640
https://github.com/addaleax
src: avoid OOB read in URL parserhttps://github.com/nodejs/node/pull/33640/commits/8f0dd0f82274af5955a6c539769ce039b005bf59
8f0dd0fhttps://github.com/nodejs/node/pull/33640/commits/8f0dd0f82274af5955a6c539769ce039b005bf59
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 29, 2020https://github.com/nodejs/node/pull/33640#event-3388204783
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
May 29, 2020https://github.com/nodejs/node/pull/33640#event-3388205248
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 29, 2020 https://github.com/nodejs/node/pull/33640#pullrequestreview-421165316
View reviewed changes https://github.com/nodejs/node/pull/33640/files/8f0dd0f82274af5955a6c539769ce039b005bf59
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 29, 2020 https://github.com/nodejs/node/pull/33640#pullrequestreview-421165683
View reviewed changes https://github.com/nodejs/node/pull/33640/files/8f0dd0f82274af5955a6c539769ce039b005bf59
https://github.com/addaleax
fixup! src: avoid OOB read in URL parserhttps://github.com/nodejs/node/pull/33640/commits/ffc213ec1c3f664d933a79c299cd4677f183d096
ffc213ehttps://github.com/nodejs/node/pull/33640/commits/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
May 29, 2020 https://github.com/nodejs/node/pull/33640#pullrequestreview-421174984
View reviewed changes https://github.com/nodejs/node/pull/33640/files/8f0dd0f82274af5955a6c539769ce039b005bf59
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 29, 2020 https://github.com/nodejs/node/pull/33640#pullrequestreview-421255537
View reviewed changes https://github.com/nodejs/node/pull/33640/files/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 30, 2020 https://github.com/nodejs/node/pull/33640#pullrequestreview-421356460
View reviewed changes https://github.com/nodejs/node/pull/33640/files/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2020https://github.com/nodejs/node/pull/33640#issuecomment-636243815
https://ci.nodejs.org/job/node-test-pull-request/31642/https://ci.nodejs.org/job/node-test-pull-request/31642/
Please reload this pagehttps://github.com/nodejs/node/pull/33640
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 30, 2020https://github.com/nodejs/node/pull/33640#event-3389203490
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 30, 2020 https://github.com/nodejs/node/pull/33640#pullrequestreview-421427534
View reviewed changes https://github.com/nodejs/node/pull/33640/files/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 30, 2020https://github.com/nodejs/node/pull/33640#event-3389892928
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 30, 2020https://github.com/nodejs/node/pull/33640#issuecomment-636357385
Please reload this pagehttps://github.com/nodejs/node/pull/33640
jasnellhttps://github.com/jasnell
May 30, 2020 https://github.com/nodejs/node/pull/33640#ref-commit-3f32126
https://github.com/addaleax
https://github.com/jasnell
src: avoid OOB read in URL parserhttps://github.com/nodejs/node/commit/3f32126fd554be32cb53a2458849697146145fda
3f32126https://github.com/nodejs/node/commit/3f32126fd554be32cb53a2458849697146145fda
#33640https://github.com/nodejs/node/pull/33640
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 30, 2020https://github.com/nodejs/node/pull/33640#issuecomment-636360826
Please reload this pagehttps://github.com/nodejs/node/pull/33640
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 30, 2020https://github.com/nodejs/node/pull/33640#event-3389915436
[Nodejs] initial integration. google/oss-fuzz#3860 https://github.com/google/oss-fuzz/pull/3860
Improvements of OSS-Fuzz integration #33724 https://github.com/nodejs/node/issues/33724
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33640#ref-commit-a8824ae
https://github.com/addaleax
https://github.com/codebytere
src: avoid OOB read in URL parserhttps://github.com/nodejs/node/commit/a8824ae0a50f470a3e9fea86e5bab2c831c05520
a8824aehttps://github.com/nodejs/node/commit/a8824ae0a50f470a3e9fea86e5bab2c831c05520
#33640https://github.com/nodejs/node/pull/33640
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 28, 2020 https://github.com/nodejs/node/pull/33640#ref-pullrequest-646828333
v14.5.0 proposal #34093 https://github.com/nodejs/node/pull/34093
codebyterehttps://github.com/codebytere
Jun 30, 2020 https://github.com/nodejs/node/pull/33640#ref-commit-6cadb00
https://github.com/addaleax
https://github.com/codebytere
src: avoid OOB read in URL parserhttps://github.com/nodejs/node/commit/6cadb00deaed22f6aec4f1bd0a1b301c75392487
6cadb00https://github.com/nodejs/node/commit/6cadb00deaed22f6aec4f1bd0a1b301c75392487
#33640https://github.com/nodejs/node/pull/33640
codebyterehttps://github.com/codebytere
Jul 9, 2020 https://github.com/nodejs/node/pull/33640#ref-commit-e3beb78
https://github.com/addaleax
https://github.com/codebytere
src: avoid OOB read in URL parserhttps://github.com/nodejs/node/commit/e3beb781e02769131a67b28a3a871981463c4400
e3beb78https://github.com/nodejs/node/commit/e3beb781e02769131a67b28a3a871981463c4400
#33640https://github.com/nodejs/node/pull/33640
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jul 13, 2020 https://github.com/nodejs/node/pull/33640#ref-pullrequest-656085086
v12.18.3 proposal #34343 https://github.com/nodejs/node/pull/34343
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33640
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33640/files/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/33640/files/8f0dd0f82274af5955a6c539769ce039b005bf59
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33640/files/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/33640/files/ffc213ec1c3f664d933a79c299cd4677f183d096
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/33640/files/8f0dd0f82274af5955a6c539769ce039b005bf59
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/33640/files/8f0dd0f82274af5955a6c539769ce039b005bf59
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Please reload this pagehttps://github.com/nodejs/node/pull/33640
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/sam-github
https://github.com/benjamingr
https://github.com/cjihrig
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.