| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:974cf7ca-913f-e475-0683-953df6ccb72e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E068:155BED:3A20D8:5109BA:696A7243 |
| html-safe-nonce | 3ae51338cc57817de58babf789d48c1521fcfd9b475d6a2071e79405c3133b44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDY4OjE1NUJFRDozQTIwRDg6NTEwOUJBOjY5NkE3MjQzIiwidmlzaXRvcl9pZCI6IjkxNjU2ODk1ODQxNjEwMjY2MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a6bf2cfdca71672c959bc03571e502cac2541fab678b529fc38f64a6f5852af5 |
| hovercard-subject-tag | pull_request:425029118 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33636/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/921b44133b7fa617ca8466fd0d47501a7ce994bc68f8596cee9e840c70cc1f6f/nodejs/node/pull/33636 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/921b44133b7fa617ca8466fd0d47501a7ce994bc68f8596cee9e840c70cc1f6f/nodejs/node/pull/33636 |
| og:image:alt | add maxHeaderSize to http2 as an alias for maxHeaderListSize.
Fixes: #33517
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | preyunk |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33636#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33636 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33636 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33636 |
| Reload | https://github.com/nodejs/node/pull/33636 |
| Reload | https://github.com/nodejs/node/pull/33636 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33636#issue-comment-box |
| preyunk | https://github.com/preyunk |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| preyunk:http2-max-header | https://github.com/preyunk/node/tree/http2-max-header |
|
http2: add maxHeaderSize option to http2
| https://github.com/nodejs/node/pull/33636#top |
| preyunk | https://github.com/preyunk |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| preyunk:http2-max-header | https://github.com/preyunk/node/tree/http2-max-header |
|
Conversation
36
| https://github.com/nodejs/node/pull/33636 |
|
Commits
7
| https://github.com/nodejs/node/pull/33636/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33636/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33636/files |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| May 29, 2020 | https://github.com/nodejs/node/pull/33636#issue-627176244 |
| #33517 | https://github.com/nodejs/node/issues/33517 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| May 29, 2020 | https://github.com/nodejs/node/pull/33636#event-3386652312 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
May 29, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-420875444 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files |
| himself65 | https://github.com/himself65 |
| https://github.com/nodejs/node/pull/33636#pullrequestreview-420875444 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| May 29, 2020 11:45 | https://github.com/nodejs/node/pull/33636#event-3386831635 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
|
May 29, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421050600 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files |
| lib/internal/http2/util.js | https://github.com/nodejs/node/pull/33636/files#diff-34a6697084c4f6df837566b438b8c60abb23966fb026c8790a9225de0b694a1a |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
|
May 29, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421167185 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files |
| rexagod | https://github.com/rexagod |
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421167185 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| lib/internal/http2/util.js | https://github.com/nodejs/node/pull/33636/files#diff-34a6697084c4f6df837566b438b8c60abb23966fb026c8790a9225de0b694a1a |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| lib/internal/http2/util.js | https://github.com/nodejs/node/pull/33636/files#diff-34a6697084c4f6df837566b438b8c60abb23966fb026c8790a9225de0b694a1a |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| preyunk | https://github.com/preyunk |
| May 30, 2020 03:02 | https://github.com/nodejs/node/pull/33636#commits-pushed-984132d |
|
| https://github.com/preyunk |
| http2: add maxHeaderSize option to http2 | https://github.com/nodejs/node/pull/33636/commits/984132d2bec75abd278718eb9fc584e53430ff00 |
| 984132d | https://github.com/nodejs/node/pull/33636/commits/984132d2bec75abd278718eb9fc584e53430ff00 |
| nodejs#33517 | https://github.com/nodejs/node/issues/33517 |
|
| https://github.com/preyunk |
| test: add tests for maxHeaderSize setting in http2 | https://github.com/nodejs/node/pull/33636/commits/3ba02dab885da4010db0d2269251df4905e63ee7 |
| 3ba02da | https://github.com/nodejs/node/pull/33636/commits/3ba02dab885da4010db0d2269251df4905e63ee7 |
| nodejs#33636 | https://github.com/nodejs/node/pull/33636 |
|
| https://github.com/preyunk |
| http2: added more tests for maxHeaderSize | https://github.com/nodejs/node/pull/33636/commits/205f38ab750f9e76afe9fe636aad90ecbe3ef0d5 |
| 205f38a | https://github.com/nodejs/node/pull/33636/commits/205f38ab750f9e76afe9fe636aad90ecbe3ef0d5 |
| nodejs#33636 | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| force-pushed | https://github.com/nodejs/node/compare/96dd578a94036295992aced27ea996742c8610a4..205f38ab750f9e76afe9fe636aad90ecbe3ef0d5 |
| 96dd578 | https://github.com/nodejs/node/commit/96dd578a94036295992aced27ea996742c8610a4 |
| 205f38a | https://github.com/nodejs/node/commit/205f38ab750f9e76afe9fe636aad90ecbe3ef0d5 |
|
Compare
| https://github.com/nodejs/node/compare/96dd578a94036295992aced27ea996742c8610a4..205f38ab750f9e76afe9fe636aad90ecbe3ef0d5 |
| May 29, 2020 21:36 | https://github.com/nodejs/node/pull/33636#event-3388910826 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| May 29, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-636210000 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
| https://github.com/preyunk |
| http2: fixed linting issues | https://github.com/nodejs/node/pull/33636/commits/2f3782ca7530893166893b764573b8821dc09bd8 |
| 2f3782c | https://github.com/nodejs/node/pull/33636/commits/2f3782ca7530893166893b764573b8821dc09bd8 |
| nodejs#33636 | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| force-pushed | https://github.com/nodejs/node/compare/cc3ffed2920f89c389a94c6521f0fdabfb233ee4..2f3782ca7530893166893b764573b8821dc09bd8 |
| cc3ffed | https://github.com/nodejs/node/commit/cc3ffed2920f89c389a94c6521f0fdabfb233ee4 |
| 2f3782c | https://github.com/nodejs/node/commit/2f3782ca7530893166893b764573b8821dc09bd8 |
|
Compare
| https://github.com/nodejs/node/compare/cc3ffed2920f89c389a94c6521f0fdabfb233ee4..2f3782ca7530893166893b764573b8821dc09bd8 |
| May 30, 2020 14:58 | https://github.com/nodejs/node/pull/33636#event-3389800291 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| himself65 | https://github.com/himself65 |
| May 30, 2020 19:12 | https://github.com/nodejs/node/pull/33636#event-3389986551 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
|
May 30, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421447468 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files |
| test/parallel/test-http2-too-large-headers.js | https://github.com/nodejs/node/pull/33636/files#diff-e7b50ada9f704139a3bf826378a81cf06182a0d79875256827a449ff3b956557 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
May 31, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421464849 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files |
| test/parallel/test-http2-too-large-headers.js | https://github.com/nodejs/node/pull/33636/files#diff-e7b50ada9f704139a3bf826378a81cf06182a0d79875256827a449ff3b956557 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
May 31, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421464966 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files |
| himself65 | https://github.com/himself65 |
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421464966 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
| https://github.com/preyunk |
| http2: fixed failing tests | https://github.com/nodejs/node/pull/33636/commits/5857ca5fa339bf6f0be59f4693abe9e0d5daf7c2 |
| 5857ca5 | https://github.com/nodejs/node/pull/33636/commits/5857ca5fa339bf6f0be59f4693abe9e0d5daf7c2 |
| nodejs#33636 | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| force-pushed | https://github.com/nodejs/node/compare/38a899829362dc1455697a0a824eafffc9c015b7..5857ca5fa339bf6f0be59f4693abe9e0d5daf7c2 |
| 38a8998 | https://github.com/nodejs/node/commit/38a899829362dc1455697a0a824eafffc9c015b7 |
| 5857ca5 | https://github.com/nodejs/node/commit/5857ca5fa339bf6f0be59f4693abe9e0d5daf7c2 |
|
Compare
| https://github.com/nodejs/node/compare/38a899829362dc1455697a0a824eafffc9c015b7..5857ca5fa339bf6f0be59f4693abe9e0d5daf7c2 |
| May 31, 2020 08:13 | https://github.com/nodejs/node/pull/33636#event-3390397025 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| May 31, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-636456164 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| @himself65 | https://github.com/himself65 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| force-pushed | https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| 8ae28ff | https://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda |
| 2935f72 | https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5 |
|
Compare
| https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5 |
| May 31, 2020 12:18 | https://github.com/nodejs/node/pull/33636#event-3390558288 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| May 31, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-636471231 |
| @himself65 | https://github.com/himself65 |
| https://github.com/nodejs/node/blob/master/doc/guides/doc-style-guide.md | https://github.com/nodejs/node/blob/master/doc/guides/doc-style-guide.md |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
| https://github.com/preyunk |
| http2: added doc for maxHeaderSize | https://github.com/nodejs/node/pull/33636/commits/8f6c4aaf909486329a1763b907b902fd7b2ce77b |
| 8f6c4aa | https://github.com/nodejs/node/pull/33636/commits/8f6c4aaf909486329a1763b907b902fd7b2ce77b |
| nodejs#33636 | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| himself65 | https://github.com/himself65 |
| May 31, 2020 17:35 | https://github.com/nodejs/node/pull/33636#event-3390817284 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Jun 1, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-421767788 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files/8f6c4aaf909486329a1763b907b902fd7b2ce77b |
| lib/internal/http2/util.js | https://github.com/nodejs/node/pull/33636/files/8f6c4aaf909486329a1763b907b902fd7b2ce77b#diff-34a6697084c4f6df837566b438b8c60abb23966fb026c8790a9225de0b694a1a |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
| https://github.com/preyunk |
| http2: maxHeaderSize overwrites maxHeaderListSize | https://github.com/nodejs/node/pull/33636/commits/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
| 2a506c8 | https://github.com/nodejs/node/pull/33636/commits/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
| nodejs#33636 | https://github.com/nodejs/node/pull/33636 |
|
CI Relability 2020-06-22
JaneaSystems/nodejs-reliability#15
| https://github.com/JaneaSystems/nodejs-reliability/issues/15 |
|
CI Relability 2020-06-23
JaneaSystems/nodejs-reliability#16
| https://github.com/JaneaSystems/nodejs-reliability/issues/16 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| Jun 30, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-651877624 |
| @himself65 | https://github.com/himself65 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
| Jun 30, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-651887904 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| code owners | https://github.com/nodejs/node/blob/64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46/.github/CODEOWNERS#L54 |
| August 10, 2020 16:07 | https://github.com/nodejs/node/pull/33636#event-3639466214 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-464645215 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/33636#pullrequestreview-464645215 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| rexagod | https://github.com/rexagod |
| August 11, 2020 09:12 | https://github.com/nodejs/node/pull/33636#event-3642212457 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 11, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-671951323 |
| https://ci.nodejs.org/job/node-test-pull-request/32726/ | https://ci.nodejs.org/job/node-test-pull-request/32726/ |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 11, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-672070679 |
| @rexagod | https://github.com/rexagod |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/33636#pullrequestreview-465268220 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33636/files/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
| Aug 11, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-672107488 |
| https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/lastFailedBuild/testReport/junit/(root)/test/parallel_test_inspector_multisession_ws/ | https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/lastFailedBuild/testReport/junit/(root)/test/parallel_test_inspector_multisession_ws/ |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/33636#ref-issue-677056994 |
|
Investigate test-inspector-multisession-ws
#34730
| https://github.com/nodejs/node/issues/34730 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 12, 2020 | https://github.com/nodejs/node/pull/33636#issuecomment-672707595 |
| 3b84048 | https://github.com/nodejs/node/commit/3b84048260ba57277b327c1913ca19d826c49158 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Aug 12, 2020 | https://github.com/nodejs/node/pull/33636#event-3646470929 |
| mcollina | https://github.com/mcollina |
|
Aug 12, 2020
| https://github.com/nodejs/node/pull/33636#ref-commit-3b84048 |
|
| https://github.com/preyunk |
|
| https://github.com/mcollina |
| http2: add maxHeaderSize option to http2 | https://github.com/nodejs/node/commit/3b84048260ba57277b327c1913ca19d826c49158 |
| 3b84048 | https://github.com/nodejs/node/commit/3b84048260ba57277b327c1913ca19d826c49158 |
| #33517 | https://github.com/nodejs/node/issues/33517 |
| #33636 | https://github.com/nodejs/node/pull/33636 |
|
CI Reliability 2020-08-15
nodejs/reliability#44
| https://github.com/nodejs/reliability/issues/44 |
|
CI Reliability 2020-08-16
nodejs/reliability#45
| https://github.com/nodejs/reliability/issues/45 |
|
CI Reliability 2020-08-17
nodejs/reliability#46
| https://github.com/nodejs/reliability/issues/46 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/33636#ref-commit-ef356f6 |
|
| https://github.com/preyunk |
|
| https://github.com/MylesBorins |
| http2: add maxHeaderSize option to http2 | https://github.com/nodejs/node/commit/ef356f6a9ca3a106e289aac8476351f6cd385de1 |
| ef356f6 | https://github.com/nodejs/node/commit/ef356f6a9ca3a106e289aac8476351f6cd385de1 |
| #33517 | https://github.com/nodejs/node/issues/33517 |
| #33636 | https://github.com/nodejs/node/pull/33636 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 18, 2020
| https://github.com/nodejs/node/pull/33636#ref-issue-680605948 |
|
CI Reliability 2020-08-18
nodejs/reliability#47
| https://github.com/nodejs/reliability/issues/47 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/33636#ref-pullrequest-682706557 |
|
V14.9.0 proposal
#34852
| https://github.com/nodejs/node/pull/34852 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/33636#ref-commit-6ee2578 |
|
| https://github.com/preyunk |
|
| https://github.com/BethGriggs |
| http2: add maxHeaderSize option to http2 | https://github.com/nodejs/node/commit/6ee2578427d4e18df888a7c0f35d168195ec59cb |
| 6ee2578 | https://github.com/nodejs/node/commit/6ee2578427d4e18df888a7c0f35d168195ec59cb |
| #33517 | https://github.com/nodejs/node/issues/33517 |
| #33636 | https://github.com/nodejs/node/pull/33636 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/33636#ref-commit-205afdf |
|
| https://github.com/preyunk |
|
| https://github.com/addaleax |
| http2: add maxHeaderSize option to http2 | https://github.com/nodejs/node/commit/205afdfb2435dd0819843c01c5c597ec610cdbd2 |
| 205afdf | https://github.com/nodejs/node/commit/205afdfb2435dd0819843c01c5c597ec610cdbd2 |
| #33517 | https://github.com/nodejs/node/issues/33517 |
| #33636 | https://github.com/nodejs/node/pull/33636 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/33636#ref-commit-45d712c |
|
| https://github.com/preyunk |
|
| https://github.com/addaleax |
| http2: add maxHeaderSize option to http2 | https://github.com/nodejs/node/commit/45d712c6f6d198701e3eb765c6e1f35fa5bae9fd |
| 45d712c | https://github.com/nodejs/node/commit/45d712c6f6d198701e3eb765c6e1f35fa5bae9fd |
| #33517 | https://github.com/nodejs/node/issues/33517 |
| #33636 | https://github.com/nodejs/node/pull/33636 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/33636#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33636 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/33636/files/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/33636/files/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
|
| https://github.com/rexagod |
|
rexagod
| https://github.com/rexagod |
|
| https://github.com/nodejs/node/pull/33636/files/2a506c8a3247b2c71baf34cf8002bf00debc4c77 |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
add 'maxHeaderSize' to 'http2'
| https://github.com/nodejs/node/issues/33517 |
| Please reload this page | https://github.com/nodejs/node/pull/33636 |
|
| https://github.com/preyunk |
|
| https://github.com/himself65 |
|
| https://github.com/rexagod |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |