| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d1526327-3f8e-6732-4f64-21d254640222 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C63E:23C31E:1CEF0:277F4:6AED3966 |
| html-safe-nonce | 913743dbe93c214e4a19516b5009513d8f2fa2461199ca02919afb1d3fe6b353 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjNFOjIzQzMxRToxQ0VGMDoyNzdGNDo2QUVEMzk2NiIsInZpc2l0b3JfaWQiOiI4NDg0MzEwMDIyMTU2NTMyMDcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a5b9fc86d4866601e0084019b455f5e121f2bd7ee75b2cd5e65e1eb557ba9827 |
| hovercard-subject-tag | pull_request:418242255 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33409/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/184a441c1f6c1a5abb0b2cb68211a35c9c5cc98cf9ba29698b415c3e745947ed/nodejs/node/pull/33409 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/184a441c1f6c1a5abb0b2cb68211a35c9c5cc98cf9ba29698b415c3e745947ed/nodejs/node/pull/33409 |
| og:image:alt | As an alternative to #33408, fixing up the docs issue with the "type": "module" instructions, while still noting .mjs.
Checklist
make -j4 test (UNIX), or vcbuild test (Window... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c629ad99c254d306375fc8354d04321c2c362236 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33409#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33409 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33409 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33409 |
| Reload | https://github.com/nodejs/node/pull/33409 |
| Reload | https://github.com/nodejs/node/pull/33409 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests664 (664) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| guybedford | https://github.com/guybedford |
| master | https://github.com/nodejs/node/tree/master |
| doc-type-module-ext-fix | https://github.com/nodejs/node/tree/doc-type-module-ext-fix |
| Conversation | https://github.com/nodejs/node/pull/33409 |
| Commits2 (2) | https://github.com/nodejs/node/pull/33409/commits |
| Checks | https://github.com/nodejs/node/pull/33409/checks |
| Files changed | https://github.com/nodejs/node/pull/33409/files |
| doc: fix esm extension example with type module | https://github.com/nodejs/node/pull/33409#top |
| guybedford | https://github.com/guybedford |
| master | https://github.com/nodejs/node/tree/master |
| doc-type-module-ext-fix | https://github.com/nodejs/node/tree/doc-type-module-ext-fix |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| May 14, 2020 | https://github.com/nodejs/node/pull/33409#issue-618530587 |
| #33408 | https://github.com/nodejs/node/pull/33408 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
|
| https://github.com/guybedford |
| doc: fix esm extension example with type module | https://github.com/nodejs/node/pull/33409/commits/085e97d63c35449758a3c62da0674a03ba9e9912 |
| 085e97d | https://github.com/nodejs/node/pull/33409/commits/085e97d63c35449758a3c62da0674a03ba9e9912 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| May 14, 2020 | https://github.com/nodejs/node/pull/33409#event-3338410516 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
May 14, 2020
| https://github.com/nodejs/node/pull/33409#ref-pullrequest-618500767 |
|
doc: fix extension in esm example
#33408
| https://github.com/nodejs/node/pull/33408 |
|
| https://github.com/guybedford |
| fix: skip package.json lint | https://github.com/nodejs/node/pull/33409/commits/ac011501afe96cb0ff0c625a0f05d490111a5750 |
| ac01150 | https://github.com/nodejs/node/pull/33409/commits/ac011501afe96cb0ff0c625a0f05d490111a5750 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| May 14, 2020 | https://github.com/nodejs/node/pull/33409#issuecomment-628941497 |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| May 14, 2020 | https://github.com/nodejs/node/pull/33409#issuecomment-628945497 |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| May 14, 2020 | https://github.com/nodejs/node/pull/33409#issuecomment-628947459 |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| May 15, 2020 | https://github.com/nodejs/node/pull/33409#issuecomment-628949379 |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| May 15, 2020 | https://github.com/nodejs/node/pull/33409#event-3338855018 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| May 15, 2020 | https://github.com/nodejs/node/pull/33409#issuecomment-628950592 |
| @guybedford | https://github.com/guybedford |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| May 15, 2020 07:27 | https://github.com/nodejs/node/pull/33409#event-3339700384 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33409 |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| Please reload this page | https://github.com/nodejs/node/pull/33409 |
|
| https://github.com/guybedford |
|
| https://github.com/devsnek |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |