René's URL Explorer Experiment


Title: worker: fix crash when .unref() is called during exit by addaleax · Pull Request #33394 · nodejs/node · GitHub

Open Graph Title: worker: fix crash when .unref() is called during exit by addaleax · Pull Request #33394 · nodejs/node

X Title: worker: fix crash when .unref() is called during exit by addaleax · Pull Request #33394 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: To be more precise, fix a crash when worker.unref() is called from a message on the Worker that is not emitted before the Worker thread has stopped. Checklist make -j4 test (UNIX), or vcbuild t...

X Description: To be more precise, fix a crash when worker.unref() is called from a message on the Worker that is not emitted before the Worker thread has stopped. Checklist make -j4 test (UNIX), or vcbuild t...

Opengraph URL: https://github.com/nodejs/node/pull/33394

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:51b2aa4a-02ff-4fa5-72a5-b7706e7dc90e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE78:6780E:29E91A:36D437:6AED1B06
html-safe-noncea117dd2ca2e02d09daf0cb2a368e54a72bb99a3b8b2319796215c66ee53a8c64
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTc4OjY3ODBFOjI5RTkxQTozNkQ0Mzc6NkFFRDFCMDYiLCJ2aXNpdG9yX2lkIjoiNzA4MjIzNzc0Mzg4MTU5MTU1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac420a57747eca7f360ea02cb27296eb8f617e2a3e6827340703603a9301c5a0b9
hovercard-subject-tagpull_request:417798888
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33394/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/db581f2f78eda0591826a38146db4215decf001d9a528db0c7e61b8699361513/nodejs/node/pull/33394
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/db581f2f78eda0591826a38146db4215decf001d9a528db0c7e61b8699361513/nodejs/node/pull/33394
og:image:altTo be more precise, fix a crash when worker.unref() is called from a message on the Worker that is not emitted before the Worker thread has stopped. Checklist make -j4 test (UNIX), or vcbuild t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33394#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33394
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33394
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33394
Reloadhttps://github.com/nodejs/node/pull/33394
Reloadhttps://github.com/nodejs/node/pull/33394
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-unref-message-exithttps://github.com/addaleax/node/tree/worker-unref-message-exit
Conversationhttps://github.com/nodejs/node/pull/33394
Commits2 (2)https://github.com/nodejs/node/pull/33394/commits
Checkshttps://github.com/nodejs/node/pull/33394/checks
Files changedhttps://github.com/nodejs/node/pull/33394/files
worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/pull/33394#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-unref-message-exithttps://github.com/addaleax/node/tree/worker-unref-message-exit
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2020https://github.com/nodejs/node/pull/33394#issue-617985064
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/addaleax
worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/pull/33394/commits/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
6ea7484https://github.com/nodejs/node/pull/33394/commits/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
May 14, 2020https://github.com/nodejs/node/pull/33394#event-3335178451
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 14, 2020https://github.com/nodejs/node/pull/33394#event-3335178647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 14, 2020https://github.com/nodejs/node/pull/33394#issuecomment-628440392
https://ci.nodejs.org/job/node-test-pull-request/31319/https://ci.nodejs.org/job/node-test-pull-request/31319/
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 14, 2020 https://github.com/nodejs/node/pull/33394#pullrequestreview-411765884
View reviewed changes https://github.com/nodejs/node/pull/33394/files/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 14, 2020 https://github.com/nodejs/node/pull/33394#pullrequestreview-411794548
View reviewed changes https://github.com/nodejs/node/pull/33394/files/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
test/parallel/test-worker-unref-from-message-during-exit.jshttps://github.com/nodejs/node/pull/33394/files/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1#diff-0a889061bd637db5d7932db7c7d0a8123bec45520584f903212d4f63cad7d44b
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 14, 2020 https://github.com/nodejs/node/pull/33394#pullrequestreview-411794615
View reviewed changes https://github.com/nodejs/node/pull/33394/files/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
https://github.com/addaleax
fixup! worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/pull/33394/commits/e010141eb7a1f86f898f355e8986edcbd2ca319e
e010141https://github.com/nodejs/node/pull/33394/commits/e010141eb7a1f86f898f355e8986edcbd2ca319e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 14, 2020https://github.com/nodejs/node/pull/33394#issuecomment-628770847
https://ci.nodejs.org/job/node-test-pull-request/31335/https://ci.nodejs.org/job/node-test-pull-request/31335/
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 14, 2020https://github.com/nodejs/node/pull/33394#event-3337695505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 15, 2020https://github.com/nodejs/node/pull/33394#issuecomment-628995743
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://ci.nodejs.org/job/node-test-pull-request/31340/https://ci.nodejs.org/job/node-test-pull-request/31340/
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/targos
targoshttps://github.com/targos
May 16, 2020https://github.com/nodejs/node/pull/33394#issuecomment-629615400
48b1595https://github.com/nodejs/node/commit/48b159562d1dfcf005d3f91b0bfdf10206ce2557
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/targos
targoshttps://github.com/targos
May 16, 2020https://github.com/nodejs/node/pull/33394#event-3343396723
targoshttps://github.com/targos
May 16, 2020 https://github.com/nodejs/node/pull/33394#ref-commit-48b1595
https://github.com/addaleax
https://github.com/targos
worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/commit/48b159562d1dfcf005d3f91b0bfdf10206ce2557
48b1595https://github.com/nodejs/node/commit/48b159562d1dfcf005d3f91b0bfdf10206ce2557
#33394https://github.com/nodejs/node/pull/33394
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33394#ref-commit-9d1e577
https://github.com/addaleax
https://github.com/codebytere
worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/commit/9d1e57710997252acb30192d32a0ff77e088a7f1
9d1e577https://github.com/nodejs/node/commit/9d1e57710997252acb30192d32a0ff77e088a7f1
#33394https://github.com/nodejs/node/pull/33394
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33394#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33394#ref-commit-151e3c3
https://github.com/addaleax
https://github.com/codebytere
worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/commit/151e3c398887fd9300fe04e2bf990f3efc21eead
151e3c3https://github.com/nodejs/node/commit/151e3c398887fd9300fe04e2bf990f3efc21eead
#33394https://github.com/nodejs/node/pull/33394
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33394#ref-commit-b4d9034
https://github.com/addaleax
https://github.com/codebytere
worker: fix crash when .unref() is called during exithttps://github.com/nodejs/node/commit/b4d903402b63b19caa3c7c56ada761e627283e85
b4d9034https://github.com/nodejs/node/commit/b4d903402b63b19caa3c7c56ada761e627283e85
#33394https://github.com/nodejs/node/pull/33394
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33394#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Nov 16, 2020https://github.com/nodejs/node/pull/33394#event-4000025360
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33394
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33394/files/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33394/files/6ea74845e5d3f3758a6c73223df2bc3cbbdec6b1
Please reload this pagehttps://github.com/nodejs/node/pull/33394
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/33394
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.