| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:63ce9789-7249-eaf9-961b-6beb794cd3ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 807A:3A3994:C9FAB9:1088F85:6AED4E5A |
| html-safe-nonce | 7321f64e56ad382e97c6568a78a65993d2ba30258af5e46b9cb80f9c54264279 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDdBOjNBMzk5NDpDOUZBQjk6MTA4OEY4NTo2QUVENEU1QSIsInZpc2l0b3JfaWQiOiI1MzU0ODAzMDY5OTU2NDc2NTA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 85aee822a25354d60e4ae4e6a5cae70a5dec3570ef85781cc4015d1c80e59690 |
| hovercard-subject-tag | pull_request:417016199 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33381/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6044c15e4af67e35e2edd1d9f4424ae2468a2ce2359c2560d2db4f9ede7a4ad4/nodejs/node/pull/33381 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6044c15e4af67e35e2edd1d9f4424ae2468a2ce2359c2560d2db4f9ede7a4ad4/nodejs/node/pull/33381 |
| og:image:alt | With V8 8.3, the two APIs basically have feature parity, so
AllocatedBuffer can be turned into a wrapper around
v8::BackingStore.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33381#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33381 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33381 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33381 |
| Reload | https://github.com/nodejs/node/pull/33381 |
| Reload | https://github.com/nodejs/node/pull/33381 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues654 (654) | https://github.com/nodejs/node/issues |
| Pull requests662 (662) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:allocated-buffer-backingstore | https://github.com/addaleax/node/tree/allocated-buffer-backingstore |
| Conversation | https://github.com/nodejs/node/pull/33381 |
| Commits1 (1) | https://github.com/nodejs/node/pull/33381/commits |
| Checks | https://github.com/nodejs/node/pull/33381/checks |
| Files changed | https://github.com/nodejs/node/pull/33381/files |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/pull/33381#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:allocated-buffer-backingstore | https://github.com/addaleax/node/tree/allocated-buffer-backingstore |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 12, 2020 | https://github.com/nodejs/node/pull/33381#issue-617016102 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| May 12, 2020 | https://github.com/nodejs/node/pull/33381#event-3329633486 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| May 12, 2020 | https://github.com/nodejs/node/pull/33381#event-3329633641 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 12, 2020 | https://github.com/nodejs/node/pull/33381#issuecomment-627649466 |
| https://ci.nodejs.org/job/node-test-pull-request/31301/ | https://ci.nodejs.org/job/node-test-pull-request/31301/ |
| Please reload this page | https://github.com/nodejs/node/pull/33381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| May 13, 2020 | https://github.com/nodejs/node/pull/33381#event-3330221187 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 13, 2020 | https://github.com/nodejs/node/pull/33381#issuecomment-627732632 |
| #33321 | https://github.com/nodejs/node/pull/33321 |
| Please reload this page | https://github.com/nodejs/node/pull/33381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 14, 2020
| https://github.com/nodejs/node/pull/33381#ref-pullrequest-614326505 |
|
src: extract AllocatedBuffer from env.h
#33291
| https://github.com/nodejs/node/pull/33291 |
|
| https://github.com/addaleax |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/pull/33381/commits/3ef0e38c90e54d9e1e1da3896e21f0fee1b7f20d |
| 3ef0e38 | https://github.com/nodejs/node/pull/33381/commits/3ef0e38c90e54d9e1e1da3896e21f0fee1b7f20d |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/58511a144d8387b6bd0f6706326de5ee2f38ccce..3ef0e38c90e54d9e1e1da3896e21f0fee1b7f20d |
| 58511a1 | https://github.com/nodejs/node/commit/58511a144d8387b6bd0f6706326de5ee2f38ccce |
| 3ef0e38 | https://github.com/nodejs/node/commit/3ef0e38c90e54d9e1e1da3896e21f0fee1b7f20d |
|
Compare
| https://github.com/nodejs/node/compare/58511a144d8387b6bd0f6706326de5ee2f38ccce..3ef0e38c90e54d9e1e1da3896e21f0fee1b7f20d |
| May 14, 2020 17:11 | https://github.com/nodejs/node/pull/33381#event-3337605309 |
| jasnell | https://github.com/jasnell |
|
May 14, 2020
| https://github.com/nodejs/node/pull/33381#ref-commit-c971497 |
|
| https://github.com/jasnell |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/jasnell/node/commit/c971497883dc4cc87f19aa0eee6cc5d77a78aa5f |
| c971497 | https://github.com/jasnell/node/commit/c971497883dc4cc87f19aa0eee6cc5d77a78aa5f |
| nodejs#33381 | https://github.com/nodejs/node/pull/33381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| May 16, 2020 | https://github.com/nodejs/node/pull/33381#event-3343443554 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 16, 2020 | https://github.com/nodejs/node/pull/33381#issuecomment-629622710 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| Please reload this page | https://github.com/nodejs/node/pull/33381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 16, 2020 | https://github.com/nodejs/node/pull/33381#event-3343444002 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 16, 2020 10:16 | https://github.com/nodejs/node/pull/33381#event-3343444157 |
| jasnell | https://github.com/jasnell |
|
May 30, 2020
| https://github.com/nodejs/node/pull/33381#ref-commit-9f8dc2f |
|
| https://github.com/jasnell |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/jasnell/node/commit/9f8dc2fa386d366634e02be44168f980c748fe30 |
| 9f8dc2f | https://github.com/jasnell/node/commit/9f8dc2fa386d366634e02be44168f980c748fe30 |
| nodejs#33381 | https://github.com/nodejs/node/pull/33381 |
| jasnell | https://github.com/jasnell |
|
May 30, 2020
| https://github.com/nodejs/node/pull/33381#ref-commit-e2cd715 |
|
| https://github.com/jasnell |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/commit/e2cd71536161589dff96adf882970b9a33380f02 |
| e2cd715 | https://github.com/nodejs/node/commit/e2cd71536161589dff96adf882970b9a33380f02 |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33381#ref-commit-27e9cb7 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/commit/27e9cb7e85b9d17d0f331b936c36b5418a2800aa |
| 27e9cb7 | https://github.com/nodejs/node/commit/27e9cb7e85b9d17d0f331b936c36b5418a2800aa |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33381#ref-commit-ee6ec14 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/commit/ee6ec14dda0151015e85fe9017221b645771b8c4 |
| ee6ec14 | https://github.com/nodejs/node/commit/ee6ec14dda0151015e85fe9017221b645771b8c4 |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
|
Apr 21, 2021
| https://github.com/nodejs/node/pull/33381#ref-issue-861467217 |
|
Buffer.from(str) memory leak
#38300
| https://github.com/nodejs/node/issues/38300 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33381 |
| Please reload this page | https://github.com/nodejs/node/pull/33381 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/33381 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |