| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:55781091-85ea-ab1b-5962-082d891075b9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E746:2C3014:39F556:4B329A:6AED1EE8 |
| html-safe-nonce | 9f5c9c143737a2f37d7317316c24b821bcaba12a09115024298676d016959fab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzQ2OjJDMzAxNDozOUY1NTY6NEIzMjlBOjZBRUQxRUU4IiwidmlzaXRvcl9pZCI6IjMyODQxNDI3MTYwMDEwMDExOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4ffc83fabbb4c9cc13b971a2edd19261471f9238270ced3251bcaf201ce38743 |
| hovercard-subject-tag | pull_request:416734459 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33367/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a434d9a8f0b2e25701da60e51946bc9d9c2ccbab469b38073bc90de3478cd026/nodejs/node/pull/33367 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a434d9a8f0b2e25701da60e51946bc9d9c2ccbab469b38073bc90de3478cd026/nodejs/node/pull/33367 |
| og:image:alt | The DNS server will sometimes return an IPv6 address (as seen in nightly
CI from time to time). Use family option to force IPv4.
Hide white-space changes in the diff to ignore all the code moved to... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | e3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 707a24b346ac8a82878b9c084efaa38a997660cb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33367#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33367 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33367 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33367 |
| Reload | https://github.com/nodejs/node/pull/33367 |
| Reload | https://github.com/nodejs/node/pull/33367 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues655 (655) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:idna-again | https://github.com/Trott/io.js/tree/idna-again |
| Conversation | https://github.com/nodejs/node/pull/33367 |
| Commits1 (1) | https://github.com/nodejs/node/pull/33367/commits |
| Checks | https://github.com/nodejs/node/pull/33367/checks |
| Files changed | https://github.com/nodejs/node/pull/33367/files |
| test: fix test-dns-idna2008 | https://github.com/nodejs/node/pull/33367#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:idna-again | https://github.com/Trott/io.js/tree/idna-again |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 12, 2020 | https://github.com/nodejs/node/pull/33367#issue-616667523 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 12, 2020 | https://github.com/nodejs/node/pull/33367#event-3327561381 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 12, 2020 | https://github.com/nodejs/node/pull/33367#issuecomment-627357232 |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
| https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14228/ | https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14228/ |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
| May 12, 2020 | https://github.com/nodejs/node/pull/33367#event-3327588042 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| bnoordhuis | https://github.com/bnoordhuis |
| May 12, 2020 13:48 | https://github.com/nodejs/node/pull/33367#event-3327588248 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 12, 2020
| https://github.com/nodejs/node/pull/33367#pullrequestreview-410134401 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33367/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 14, 2020 | https://github.com/nodejs/node/pull/33367#issuecomment-628636842 |
| https://github.com/nodejs/node/pull/33367/files?diff=unified&w=1 | https://github.com/nodejs/node/pull/33367/files?diff=unified&w=1 |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 15, 2020 | https://github.com/nodejs/node/pull/33367#event-3339282164 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 15, 2020
| https://github.com/nodejs/node/pull/33367#pullrequestreview-412546918 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33367/files |
|
| https://github.com/Trott |
| test: fix test-dns-idna2008 | https://github.com/nodejs/node/pull/33367/commits/23a61eb683bcfb147ca1040e36c70fe366452a77 |
| 23a61eb | https://github.com/nodejs/node/pull/33367/commits/23a61eb683bcfb147ca1040e36c70fe366452a77 |
| nodejs#33367 | https://github.com/nodejs/node/pull/33367 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/f0e96e36aaa9dca30e7a0b3fed4952d871c1b143..23a61eb683bcfb147ca1040e36c70fe366452a77 |
| f0e96e3 | https://github.com/nodejs/node/commit/f0e96e36aaa9dca30e7a0b3fed4952d871c1b143 |
| 23a61eb | https://github.com/nodejs/node/commit/23a61eb683bcfb147ca1040e36c70fe366452a77 |
|
Compare
| https://github.com/nodejs/node/compare/f0e96e36aaa9dca30e7a0b3fed4952d871c1b143..23a61eb683bcfb147ca1040e36c70fe366452a77 |
| May 15, 2020 12:49 | https://github.com/nodejs/node/pull/33367#event-3340775331 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 23a61eb | https://github.com/nodejs/node/commit/23a61eb683bcfb147ca1040e36c70fe366452a77 |
| May 15, 2020 | https://github.com/nodejs/node/pull/33367#event-3340776472 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 15, 2020 | https://github.com/nodejs/node/pull/33367#issuecomment-629217409 |
| 23a61eb | https://github.com/nodejs/node/commit/23a61eb683bcfb147ca1040e36c70fe366452a77 |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 15, 2020 12:49 | https://github.com/nodejs/node/pull/33367#event-3340777071 |
| codebytere | https://github.com/codebytere |
|
May 16, 2020
| https://github.com/nodejs/node/pull/33367#ref-commit-d3e2fc8 |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| test: fix test-dns-idna2008 | https://github.com/nodejs/node/commit/d3e2fc81e8dc440bf4d1fb3374c395aee0cc0dc3 |
| d3e2fc8 | https://github.com/nodejs/node/commit/d3e2fc81e8dc440bf4d1fb3374c395aee0cc0dc3 |
| #33367 | https://github.com/nodejs/node/pull/33367 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
May 18, 2020
| https://github.com/nodejs/node/pull/33367#ref-pullrequest-619852653 |
|
v14.3.0 proposal
#33452
| https://github.com/nodejs/node/pull/33452 |
| codebytere | https://github.com/codebytere |
|
Jun 7, 2020
| https://github.com/nodejs/node/pull/33367#ref-commit-c58fc62 |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| test: fix test-dns-idna2008 | https://github.com/nodejs/node/commit/c58fc627b7c007321e9805c012de4e229ecef475 |
| c58fc62 | https://github.com/nodejs/node/commit/c58fc627b7c007321e9805c012de4e229ecef475 |
| #33367 | https://github.com/nodejs/node/pull/33367 |
| codebytere | https://github.com/codebytere |
|
Jun 9, 2020
| https://github.com/nodejs/node/pull/33367#ref-commit-9f594be |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| test: fix test-dns-idna2008 | https://github.com/codebytere/node/commit/9f594be75a691bf8a884528d4c07a9932f8d6672 |
| 9f594be | https://github.com/codebytere/node/commit/9f594be75a691bf8a884528d4c07a9932f8d6672 |
| nodejs#33367 | https://github.com/nodejs/node/pull/33367 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 9, 2020
| https://github.com/nodejs/node/pull/33367#ref-pullrequest-635542822 |
|
v12.18.1 proposal
#33811
| https://github.com/nodejs/node/pull/33811 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33367 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/33367/files/f0e96e36aaa9dca30e7a0b3fed4952d871c1b143 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/33367/files/f0e96e36aaa9dca30e7a0b3fed4952d871c1b143 |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/33367 |
|
| https://github.com/Trott |
|
| https://github.com/bnoordhuis |
|
| https://github.com/lpinca |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |