René's URL Explorer Experiment


Title: tls: fix --tls-keylog option by mildsunrise · Pull Request #33366 · nodejs/node · GitHub

Open Graph Title: tls: fix --tls-keylog option by mildsunrise · Pull Request #33366 · nodejs/node

X Title: tls: fix --tls-keylog option by mildsunrise · Pull Request #33366 · nodejs/node

Description: There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on tls.Server, not the socket. This behaviour is counterintuitive and has caused more bugs in the past, so make all sockets (server or client) emit keylog. tls.Server will just re-emit these events. Refs: #30055 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on tls.Serv...

X Description: There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on ...

Opengraph URL: https://github.com/nodejs/node/pull/33366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c48f34b2-60b5-ee07-c7fc-0dc534b9df36
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AB6:1CBA8:D5899:122B83:6AED3486
html-safe-nonceb1f2bdd77579fea6ceb8cda23eed358c078f76cab34df808b13d89e4be02ed24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUI2OjFDQkE4OkQ1ODk5OjEyMkI4Mzo2QUVEMzQ4NiIsInZpc2l0b3JfaWQiOiIxMjY1ODMxNTE5MzkzMjMyMDA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd9a2bfa101e7245be85f30e303701fa6c93c6f66f8c86dd4bec3a1d9b1c12bd0
hovercard-subject-tagpull_request:416711751
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/33366/files
twitter:imagehttps://avatars.githubusercontent.com/u/1177304?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1177304?s=400&v=4
og:image:altThere's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on tls.Serv...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33366/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33366%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33366%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33366/files
Reloadhttps://github.com/nodejs/node/pull/33366/files
Reloadhttps://github.com/nodejs/node/pull/33366/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:fix-keylog-clihttps://github.com/mildsunrise/node/tree/fix-keylog-cli
Conversation 3 https://github.com/nodejs/node/pull/33366
Commits 1 https://github.com/nodejs/node/pull/33366/commits
Checks 0 https://github.com/nodejs/node/pull/33366/checks
Files changed https://github.com/nodejs/node/pull/33366/files
Please reload this pagehttps://github.com/nodejs/node/pull/33366/files
tls: fix --tls-keylog option https://github.com/nodejs/node/pull/33366/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/33366/files
4f271ad tls: fix --tls-keylog option mildsunrise May 12, 2020 https://github.com/nodejs/node/pull/33366/commits/4f271ad30e0b2a6a7a8a479a56db235b703745c8
Clear filters https://github.com/nodejs/node/pull/33366/files
Please reload this pagehttps://github.com/nodejs/node/pull/33366/files
Please reload this pagehttps://github.com/nodejs/node/pull/33366/files
tls.md https://github.com/nodejs/node/pull/33366/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
_tls_wrap.js https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
test-tls-enable-keylog-cli.js https://github.com/nodejs/node/pull/33366/files#diff-13aba0fc63e9b829e74706659eb798f0f8e97a066221b439175402991bff089a
doc/api/tls.mdhttps://github.com/nodejs/node/pull/33366/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
View file https://github.com/mildsunrise/node/blob/4f271ad30e0b2a6a7a8a479a56db235b703745c8/doc/api/tls.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33366/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33366/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/33366/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
View file https://github.com/mildsunrise/node/blob/4f271ad30e0b2a6a7a8a479a56db235b703745c8/lib/_tls_wrap.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33366/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
https://github.com/nodejs/node/pull/33366/files#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
test/parallel/test-tls-enable-keylog-cli.jshttps://github.com/nodejs/node/pull/33366/files#diff-13aba0fc63e9b829e74706659eb798f0f8e97a066221b439175402991bff089a
View file https://github.com/mildsunrise/node/blob/4f271ad30e0b2a6a7a8a479a56db235b703745c8/test/parallel/test-tls-enable-keylog-cli.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33366/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33366/files#diff-13aba0fc63e9b829e74706659eb798f0f8e97a066221b439175402991bff089a
https://github.com/nodejs/node/pull/33366/files#diff-13aba0fc63e9b829e74706659eb798f0f8e97a066221b439175402991bff089a
https://github.com/nodejs/node/pull/33366/files#diff-13aba0fc63e9b829e74706659eb798f0f8e97a066221b439175402991bff089a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.