René's URL Explorer Experiment


Title: tls: fix --tls-keylog option by mildsunrise · Pull Request #33366 · nodejs/node · GitHub

Open Graph Title: tls: fix --tls-keylog option by mildsunrise · Pull Request #33366 · nodejs/node

X Title: tls: fix --tls-keylog option by mildsunrise · Pull Request #33366 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on tls.Serv...

X Description: There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on ...

Opengraph URL: https://github.com/nodejs/node/pull/33366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e4413947-f82f-71ee-d2ed-501e8c4d79ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9C2:137C1B:4B4606:61F285:6AED2581
html-safe-nonce197f7654edb6c6df885e95422605accd64f667c8cc34aeb14d7d17de6b85fc74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUMyOjEzN0MxQjo0QjQ2MDY6NjFGMjg1OjZBRUQyNTgxIiwidmlzaXRvcl9pZCI6IjI2MDE4NjAwMjk3MjI5OTQwNDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1bb6b1bf8af0bdfbf384f9fb46646969c2ed7c5b8f740b60718edecf602bce0b
hovercard-subject-tagpull_request:416711751
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33366/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/60c6ad280793a40e0afd4997e1a5754dbca7de6b6f41bfd4d49830f18436a563/nodejs/node/pull/33366
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60c6ad280793a40e0afd4997e1a5754dbca7de6b6f41bfd4d49830f18436a563/nodejs/node/pull/33366
og:image:altThere's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because keylog events are not emitted on tls.Serv...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemildsunrise
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33366#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33366
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33366
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33366
Reloadhttps://github.com/nodejs/node/pull/33366
Reloadhttps://github.com/nodejs/node/pull/33366
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:fix-keylog-clihttps://github.com/mildsunrise/node/tree/fix-keylog-cli
Conversationhttps://github.com/nodejs/node/pull/33366
Commits1 (1)https://github.com/nodejs/node/pull/33366/commits
Checkshttps://github.com/nodejs/node/pull/33366/checks
Files changedhttps://github.com/nodejs/node/pull/33366/files
tls: fix --tls-keylog optionhttps://github.com/nodejs/node/pull/33366#top
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:fix-keylog-clihttps://github.com/mildsunrise/node/tree/fix-keylog-cli
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 12, 2020https://github.com/nodejs/node/pull/33366#issue-616639505
Please reload this pagehttps://github.com/nodejs/node/pull/33366
#30055https://github.com/nodejs/node/pull/30055
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33366
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
May 12, 2020https://github.com/nodejs/node/pull/33366#event-3327388057
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
May 12, 2020https://github.com/nodejs/node/pull/33366#event-3327393254
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 12, 2020 https://github.com/nodejs/node/pull/33366#ref-issue-100583262
Optionally log master secrets for TLS connections #2363 https://github.com/nodejs/node/issues/2363
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 12, 2020https://github.com/nodejs/node/pull/33366#issuecomment-627331515
https://ci.nodejs.org/job/node-test-pull-request/31289/https://ci.nodejs.org/job/node-test-pull-request/31289/
Please reload this pagehttps://github.com/nodejs/node/pull/33366
https://github.com/mildsunrise
tls: fix --tls-keylog optionhttps://github.com/nodejs/node/pull/33366/commits/4f271ad30e0b2a6a7a8a479a56db235b703745c8
4f271adhttps://github.com/nodejs/node/pull/33366/commits/4f271ad30e0b2a6a7a8a479a56db235b703745c8
nodejs#30055https://github.com/nodejs/node/pull/30055
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
force-pushedhttps://github.com/nodejs/node/compare/43d95dc6b823589b27657087b0b6783d42fe3815..4f271ad30e0b2a6a7a8a479a56db235b703745c8
43d95dchttps://github.com/nodejs/node/commit/43d95dc6b823589b27657087b0b6783d42fe3815
4f271adhttps://github.com/nodejs/node/commit/4f271ad30e0b2a6a7a8a479a56db235b703745c8
Compare https://github.com/nodejs/node/compare/43d95dc6b823589b27657087b0b6783d42fe3815..4f271ad30e0b2a6a7a8a479a56db235b703745c8
May 12, 2020 13:12https://github.com/nodejs/node/pull/33366#event-3327424087
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 12, 2020https://github.com/nodejs/node/pull/33366#issuecomment-627338459
Please reload this pagehttps://github.com/nodejs/node/pull/33366
https://ci.nodejs.org/job/node-test-pull-request/31290/https://ci.nodejs.org/job/node-test-pull-request/31290/
Please reload this pagehttps://github.com/nodejs/node/pull/33366
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 12, 2020 https://github.com/nodejs/node/pull/33366#pullrequestreview-410108404
View reviewed changes https://github.com/nodejs/node/pull/33366/files/4f271ad30e0b2a6a7a8a479a56db235b703745c8
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 12, 2020https://github.com/nodejs/node/pull/33366#event-3327816215
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 12, 2020 https://github.com/nodejs/node/pull/33366#pullrequestreview-410192926
View reviewed changes https://github.com/nodejs/node/pull/33366/files/4f271ad30e0b2a6a7a8a479a56db235b703745c8
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 13, 2020 https://github.com/nodejs/node/pull/33366#pullrequestreview-411084916
View reviewed changes https://github.com/nodejs/node/pull/33366/files/4f271ad30e0b2a6a7a8a479a56db235b703745c8
mildsunrisehttps://github.com/mildsunrise
May 14, 2020 https://github.com/nodejs/node/pull/33366#ref-commit-1dafaf0
https://github.com/mildsunrise
tls: fix --tls-keylog optionhttps://github.com/nodejs/node/commit/1dafaf03cb35d51562193afab6e903a10a89d906
1dafaf0https://github.com/nodejs/node/commit/1dafaf03cb35d51562193afab6e903a10a89d906
#30055https://github.com/nodejs/node/pull/30055
#33366https://github.com/nodejs/node/pull/33366
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 14, 2020https://github.com/nodejs/node/pull/33366#issuecomment-628688296
1dafaf0https://github.com/nodejs/node/commit/1dafaf03cb35d51562193afab6e903a10a89d906
Please reload this pagehttps://github.com/nodejs/node/pull/33366
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 14, 2020https://github.com/nodejs/node/pull/33366#event-3337007395
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 14, 2020 14:54https://github.com/nodejs/node/pull/33366#event-3337009157
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33366#ref-commit-6d2aaaf
https://github.com/mildsunrise
https://github.com/codebytere
tls: fix --tls-keylog optionhttps://github.com/nodejs/node/commit/6d2aaaf6b44f3da0b71f6d078cfd1d1543343598
6d2aaafhttps://github.com/nodejs/node/commit/6d2aaaf6b44f3da0b71f6d078cfd1d1543343598
#30055https://github.com/nodejs/node/pull/30055
#33366https://github.com/nodejs/node/pull/33366
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33366#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33366#ref-commit-81749bb
https://github.com/mildsunrise
https://github.com/codebytere
tls: fix --tls-keylog optionhttps://github.com/nodejs/node/commit/81749bbe1ad8b051c540813cfdc3c3132d669dd4
81749bbhttps://github.com/nodejs/node/commit/81749bbe1ad8b051c540813cfdc3c3132d669dd4
#30055https://github.com/nodejs/node/pull/30055
#33366https://github.com/nodejs/node/pull/33366
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33366#ref-commit-7315c22
https://github.com/mildsunrise
https://github.com/codebytere
tls: fix --tls-keylog optionhttps://github.com/codebytere/node/commit/7315c2288a88b4844a1b18806374281b8237e652
7315c22https://github.com/codebytere/node/commit/7315c2288a88b4844a1b18806374281b8237e652
nodejs#30055https://github.com/nodejs/node/pull/30055
nodejs#33366https://github.com/nodejs/node/pull/33366
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33366#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 30, 2021 https://github.com/nodejs/node/pull/33366#ref-issue-906510201
FYI: There's now a simpler way to get the keylog kolontsov/node-sslkeylog#12 https://github.com/kolontsov/node-sslkeylog/issues/12
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33366
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33366/files/4f271ad30e0b2a6a7a8a479a56db235b703745c8
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/33366/files/4f271ad30e0b2a6a7a8a479a56db235b703745c8
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/33366/files/4f271ad30e0b2a6a7a8a479a56db235b703745c8
Please reload this pagehttps://github.com/nodejs/node/pull/33366
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
cli https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acli
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/33366
https://github.com/mildsunrise
https://github.com/nodejs-github-bot
https://github.com/sam-github
https://github.com/jasnell
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.