René's URL Explorer Experiment


Title: build: enable `--error-on-warn` for POSIX workflows by richardlau · Pull Request #33357 · nodejs/node · GitHub

Open Graph Title: build: enable `--error-on-warn` for POSIX workflows by richardlau · Pull Request #33357 · nodejs/node

X Title: build: enable `--error-on-warn` for POSIX workflows by richardlau · Pull Request #33357 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Treat warnings as errors for non-deps code on Linux and macOS workflows. Refs: #32685 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Treat warnings as errors for non-deps code on Linux and macOS workflows. Refs: #32685 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/33357

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8725ba3b-2402-ccb8-dd8f-569032e6f3e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91DE:9DB4A:82E26:B288A:6AED3299
html-safe-noncebd012db5a49f6fc5ec589fc4c8930eba4cc89550708932b6d86c147d8013a2a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MURFOjlEQjRBOjgyRTI2OkIyODhBOjZBRUQzMjk5IiwidmlzaXRvcl9pZCI6IjI2OTg0MjQyMTc1MjU2Mjk1OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1cab7034c9d856dd0f8209d8928c0062f616b3302e8fd507289f89847eb76806
hovercard-subject-tagpull_request:416196263
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33357/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6375f845a2854d1f2352565f33424f43e7904aaa8a2bf99a0dadcc89857622a8/nodejs/node/pull/33357
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6375f845a2854d1f2352565f33424f43e7904aaa8a2bf99a0dadcc89857622a8/nodejs/node/pull/33357
og:image:altTreat warnings as errors for non-deps code on Linux and macOS workflows. Refs: #32685 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33357#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33357
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33357
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33357
Reloadhttps://github.com/nodejs/node/pull/33357
Reloadhttps://github.com/nodejs/node/pull/33357
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:workflowhttps://github.com/richardlau/node-1/tree/workflow
Conversationhttps://github.com/nodejs/node/pull/33357
Commits2 (2)https://github.com/nodejs/node/pull/33357/commits
Checkshttps://github.com/nodejs/node/pull/33357/checks
Files changedhttps://github.com/nodejs/node/pull/33357/files
build: enable --error-on-warn for POSIX workflowshttps://github.com/nodejs/node/pull/33357#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:workflowhttps://github.com/richardlau/node-1/tree/workflow
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2020https://github.com/nodejs/node/pull/33357#issue-615996839
Please reload this pagehttps://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
May 11, 2020https://github.com/nodejs/node/pull/33357#event-3323650723
https://github.com/richardlau
richardlauhttps://github.com/richardlau
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
May 11, 2020https://github.com/nodejs/node/pull/33357#event-3323653942
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 11, 2020 https://github.com/nodejs/node/pull/33357#pullrequestreview-409417218
View reviewed changes https://github.com/nodejs/node/pull/33357/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/33357#pullrequestreview-409417218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 11, 2020 https://github.com/nodejs/node/pull/33357#pullrequestreview-409418700
View reviewed changes https://github.com/nodejs/node/pull/33357/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 11, 2020 https://github.com/nodejs/node/pull/33357#pullrequestreview-409421566
View reviewed changes https://github.com/nodejs/node/pull/33357/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 11, 2020https://github.com/nodejs/node/pull/33357#event-3324222545
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2020https://github.com/nodejs/node/pull/33357#issuecomment-626880910
#33358https://github.com/nodejs/node/pull/33358
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/targos
targoshttps://github.com/targos
May 11, 2020 https://github.com/nodejs/node/pull/33357#pullrequestreview-409431283
View reviewed changes https://github.com/nodejs/node/pull/33357/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2020https://github.com/nodejs/node/pull/33357#issuecomment-626884832
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/nodejs/node/pull/33357/checks?check_run_id=664422885https://github.com/nodejs/node/pull/33357/checks?check_run_id=664422885
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 11, 2020 https://github.com/nodejs/node/pull/33357#pullrequestreview-409565508
View reviewed changes https://github.com/nodejs/node/pull/33357/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
May 11, 2020https://github.com/nodejs/node/pull/33357#event-3325045152
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 11, 2020https://github.com/nodejs/node/pull/33357#issuecomment-627003641
#33358https://github.com/nodejs/node/pull/33358
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/5926333a09602f2dcb4f3d9df0a94efa8c66c8e0..a97bc45666970b3c92c2644f90a31f49db40f234
5926333https://github.com/nodejs/node/commit/5926333a09602f2dcb4f3d9df0a94efa8c66c8e0
a97bc45https://github.com/nodejs/node/commit/a97bc45666970b3c92c2644f90a31f49db40f234
Compare https://github.com/nodejs/node/compare/5926333a09602f2dcb4f3d9df0a94efa8c66c8e0..a97bc45666970b3c92c2644f90a31f49db40f234
May 12, 2020 09:46https://github.com/nodejs/node/pull/33357#event-3326668691
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
May 12, 2020https://github.com/nodejs/node/pull/33357#event-3326670428
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
May 13, 2020 https://github.com/nodejs/node/pull/33357#pullrequestreview-410519144
View reviewed changes https://github.com/nodejs/node/pull/33357/files
richardlauhttps://github.com/richardlau
May 13, 2020 12:07https://github.com/nodejs/node/pull/33357#commits-pushed-3aa5152
https://github.com/richardlau
build: fix --error-on-warn for macOShttps://github.com/nodejs/node/pull/33357/commits/3aa515210afaefcf99b3f4ad49239fc5738ef58d
3aa5152https://github.com/nodejs/node/pull/33357/commits/3aa515210afaefcf99b3f4ad49239fc5738ef58d
nodejs#33357https://github.com/nodejs/node/pull/33357
nodejs#32685https://github.com/nodejs/node/pull/32685
https://github.com/richardlau
build: enable --error-on-warn for POSIX workflowshttps://github.com/nodejs/node/pull/33357/commits/fcc183c99413750b1b965e45cb42a1af73da47ab
fcc183chttps://github.com/nodejs/node/pull/33357/commits/fcc183c99413750b1b965e45cb42a1af73da47ab
nodejs#33357https://github.com/nodejs/node/pull/33357
nodejs#32685https://github.com/nodejs/node/pull/32685
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/a97bc45666970b3c92c2644f90a31f49db40f234..fcc183c99413750b1b965e45cb42a1af73da47ab
a97bc45https://github.com/nodejs/node/commit/a97bc45666970b3c92c2644f90a31f49db40f234
fcc183chttps://github.com/nodejs/node/commit/fcc183c99413750b1b965e45cb42a1af73da47ab
Compare https://github.com/nodejs/node/compare/a97bc45666970b3c92c2644f90a31f49db40f234..fcc183c99413750b1b965e45cb42a1af73da47ab
May 13, 2020 16:09https://github.com/nodejs/node/pull/33357#event-3332821796
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 13, 2020https://github.com/nodejs/node/pull/33357#issuecomment-628091657
365ddb3...fcc183chttps://github.com/nodejs/node/compare/365ddb35036e7e140f5f07962c47bf1fd5f040b7...fcc183c99413750b1b965e45cb42a1af73da47ab
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/richardlau
richardlauhttps://github.com/richardlau
fcc183chttps://github.com/nodejs/node/commit/fcc183c99413750b1b965e45cb42a1af73da47ab
May 13, 2020https://github.com/nodejs/node/pull/33357#event-3332823152
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 13, 2020 https://github.com/nodejs/node/pull/33357#ref-issue-617596257
New build warnings #33389 https://github.com/nodejs/node/issues/33389
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33357#ref-commit-7d4db35
https://github.com/richardlau
https://github.com/codebytere
build: fix --error-on-warn for macOShttps://github.com/nodejs/node/commit/7d4db35f8482e5324e6c44a62a06d5e83658e874
7d4db35https://github.com/nodejs/node/commit/7d4db35f8482e5324e6c44a62a06d5e83658e874
#33357https://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33357#ref-commit-34e7400
https://github.com/richardlau
https://github.com/codebytere
build: enable --error-on-warn for POSIX workflowshttps://github.com/nodejs/node/commit/34e7400fc1269f7db08efb3ac87724ac32a0a724
34e7400https://github.com/nodejs/node/commit/34e7400fc1269f7db08efb3ac87724ac32a0a724
#33357https://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33357#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33357#ref-commit-1a154d1
https://github.com/richardlau
https://github.com/codebytere
build: enable --error-on-warn for POSIX workflowshttps://github.com/nodejs/node/commit/1a154d1e3bb5e3a5dd5eaddef3aa3c1fd51cf25c
1a154d1https://github.com/nodejs/node/commit/1a154d1e3bb5e3a5dd5eaddef3aa3c1fd51cf25c
#33357https://github.com/nodejs/node/pull/33357
#32685https://github.com/nodejs/node/pull/32685
https://github.com/codebytere
codebyterehttps://github.com/codebytere
dont-land-on-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x
Jun 7, 2020https://github.com/nodejs/node/pull/33357#event-3416895223
https://github.com/targos
targoshttps://github.com/targos
May 18, 2021 https://github.com/nodejs/node/pull/33357#ref-issue-894047539
Compiler warnings make test-linux workflow fail on v14.x #38718 https://github.com/nodejs/node/issues/38718
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33357
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33357/files/5926333a09602f2dcb4f3d9df0a94efa8c66c8e0
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33357/files/638521206d32341b431f0a1eef806a9e6c671f70
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/33357/files/a97bc45666970b3c92c2644f90a31f49db40f234
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/33357/files/638521206d32341b431f0a1eef806a9e6c671f70
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/33357/files/638521206d32341b431f0a1eef806a9e6c671f70
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/33357/files/638521206d32341b431f0a1eef806a9e6c671f70
Please reload this pagehttps://github.com/nodejs/node/pull/33357
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Please reload this pagehttps://github.com/nodejs/node/pull/33357
https://github.com/richardlau
https://github.com/addaleax
https://github.com/targos
https://github.com/cjihrig
https://github.com/gengjiawen
https://github.com/BridgeAR
https://github.com/mhdawson
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.