René's URL Explorer Experiment


Title: async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled by addaleax · Pull Request #33347 · nodejs/node · GitHub

Open Graph Title: async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled by addaleax · Pull Request #33347 · nodejs/node

X Title: async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled by addaleax · Pull Request #33347 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: worker: call CancelTerminateExecution() before exiting Locker As the comment indicates, this fixes a DCHECK failure, although I don’t quite understand why it is happening in the first place. async_...

X Description: worker: call CancelTerminateExecution() before exiting Locker As the comment indicates, this fixes a DCHECK failure, although I don’t quite understand why it is happening in the first place. async_...

Opengraph URL: https://github.com/nodejs/node/pull/33347

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:980b13c8-7075-0536-1903-7fe1126de321
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE262:254A2:332B0E:450034:6AED10A6
html-safe-nonce721bac2a2d178c332de065a0ca80323c543a87e71a0fefc021d8f9e55e2203cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjYyOjI1NEEyOjMzMkIwRTo0NTAwMzQ6NkFFRDEwQTYiLCJ2aXNpdG9yX2lkIjoiNDIzOTQxNTExNzA0NTYzMzE5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac058985b4bbc6366e6101ee0b2b90bbe0661431a0a7d0cc05499c451f627ab33e
hovercard-subject-tagpull_request:415808948
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33347/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b9d87e44f36a0534b1d875aaadf4b62e92dc4f81b8170c8d4234f7b46e7c4cb9/nodejs/node/pull/33347
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b9d87e44f36a0534b1d875aaadf4b62e92dc4f81b8170c8d4234f7b46e7c4cb9/nodejs/node/pull/33347
og:image:altworker: call CancelTerminateExecution() before exiting Locker As the comment indicates, this fixes a DCHECK failure, although I don’t quite understand why it is happening in the first place. async_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33347#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33347
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33347
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33347
Reloadhttps://github.com/nodejs/node/pull/33347
Reloadhttps://github.com/nodejs/node/pull/33347
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:async-hooks-promises-terminatehttps://github.com/addaleax/node/tree/async-hooks-promises-terminate
Conversationhttps://github.com/nodejs/node/pull/33347
Commits4 (4)https://github.com/nodejs/node/pull/33347/commits
Checkshttps://github.com/nodejs/node/pull/33347/checks
Files changedhttps://github.com/nodejs/node/pull/33347/files
async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabledhttps://github.com/nodejs/node/pull/33347#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:async-hooks-promises-terminatehttps://github.com/addaleax/node/tree/async-hooks-promises-terminate
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 11, 2020https://github.com/nodejs/node/pull/33347#issue-615514102
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33347
addaleaxhttps://github.com/addaleax
May 11, 2020 01:24https://github.com/nodejs/node/pull/33347#commits-pushed-b523a31
https://github.com/addaleax
worker: call CancelTerminateExecution() before exiting Lockerhttps://github.com/nodejs/node/pull/33347/commits/b523a314bb3759b7d5d1aac8d472bfe16c3c33f4
b523a31https://github.com/nodejs/node/pull/33347/commits/b523a314bb3759b7d5d1aac8d472bfe16c3c33f4
https://github.com/addaleax
async_hooks: clear async_id_stack for terminations in more placeshttps://github.com/nodejs/node/pull/33347/commits/d90c3d1d780d1c670f61e8bc289cdf9daf6ea517
d90c3d1https://github.com/nodejs/node/pull/33347/commits/d90c3d1d780d1c670f61e8bc289cdf9daf6ea517
https://github.com/addaleax
test: regression tests for async_hooks + Promise + Worker interactionhttps://github.com/nodejs/node/pull/33347/commits/7b45371695348a355a6a2cf4bc50c0652f1ff887
7b45371https://github.com/nodejs/node/pull/33347/commits/7b45371695348a355a6a2cf4bc50c0652f1ff887
13c5a16https://github.com/addaleax/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
May 11, 2020https://github.com/nodejs/node/pull/33347#event-3320869149
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
May 11, 2020https://github.com/nodejs/node/pull/33347#event-3320869468
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 11, 2020https://github.com/nodejs/node/pull/33347#issuecomment-626416638
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://ci.nodejs.org/job/node-test-pull-request/31271/https://ci.nodejs.org/job/node-test-pull-request/31271/
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
May 11, 2020https://github.com/nodejs/node/pull/33347#event-3320869917
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 11, 2020 https://github.com/nodejs/node/pull/33347#pullrequestreview-409185124
View reviewed changes https://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887
test/parallel/test-async-hooks-worker-asyncfn-terminate-3.jshttps://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887#diff-701c523d4459dd7ea23eb9ed0baf9e9e1ab9ca12e9c75ddec3165bcd048a77e0
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 11, 2020 https://github.com/nodejs/node/pull/33347#pullrequestreview-409210019
View reviewed changes https://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
May 11, 2020 https://github.com/nodejs/node/pull/33347#pullrequestreview-409308387
View reviewed changes https://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
May 11, 2020https://github.com/nodejs/node/pull/33347#issuecomment-626793340
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/addaleax
https://github.com/cjihrig
fixup! test: regression tests for async_hooks + Promise + Worker inte…https://github.com/nodejs/node/pull/33347/commits/3d9d564db7b9b33f0fe0f66e5dc7e59b621f9705
3d9d564https://github.com/nodejs/node/pull/33347/commits/3d9d564db7b9b33f0fe0f66e5dc7e59b621f9705
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 11, 2020https://github.com/nodejs/node/pull/33347#issuecomment-626856195
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 11, 2020https://github.com/nodejs/node/pull/33347#event-3324093304
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 11, 2020https://github.com/nodejs/node/pull/33347#issuecomment-626857438
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://ci.nodejs.org/job/node-test-pull-request/31280/https://ci.nodejs.org/job/node-test-pull-request/31280/
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/devnexen
devnexenhttps://github.com/devnexen
May 11, 2020 https://github.com/nodejs/node/pull/33347#pullrequestreview-409534636
View reviewed changes https://github.com/nodejs/node/pull/33347/files/3d9d564db7b9b33f0fe0f66e5dc7e59b621f9705
addaleaxhttps://github.com/addaleax
May 15, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-dd0980e
https://github.com/addaleax
worker: call CancelTerminateExecution() before exiting Lockerhttps://github.com/nodejs/node/commit/dd0980ecc287537a48cd5d6f7f803cd8c681dbdb
dd0980ehttps://github.com/nodejs/node/commit/dd0980ecc287537a48cd5d6f7f803cd8c681dbdb
#33347https://github.com/nodejs/node/pull/33347
addaleaxhttps://github.com/addaleax
May 15, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-fe4e4dd
https://github.com/addaleax
async_hooks: clear async_id_stack for terminations in more placeshttps://github.com/nodejs/node/commit/fe4e4ddc718a359b97f3fc89e5ff44625dcd6e7d
fe4e4ddhttps://github.com/nodejs/node/commit/fe4e4ddc718a359b97f3fc89e5ff44625dcd6e7d
#33347https://github.com/nodejs/node/pull/33347
addaleaxhttps://github.com/addaleax
May 15, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-e65d189
https://github.com/addaleax
test: regression tests for async_hooks + Promise + Worker interactionhttps://github.com/nodejs/node/commit/e65d189e508056e9ce16377bcc42dc02a64e46c6
e65d189https://github.com/nodejs/node/commit/e65d189e508056e9ce16377bcc42dc02a64e46c6
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
#33347https://github.com/nodejs/node/pull/33347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2020https://github.com/nodejs/node/pull/33347#issuecomment-629389708
c7eeef5...e65d189https://github.com/nodejs/node/compare/c7eeef568ce5a3714b89689160ec85c017527364...e65d189e508056e9ce16377bcc42dc02a64e46c6
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2020https://github.com/nodejs/node/pull/33347#event-3341926422
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2020 17:38https://github.com/nodejs/node/pull/33347#event-3341926656
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-b1a7fda
https://github.com/addaleax
https://github.com/codebytere
worker: call CancelTerminateExecution() before exiting Lockerhttps://github.com/nodejs/node/commit/b1a7fdac43aee592934df453f0ca6490d8fa8bb7
b1a7fdahttps://github.com/nodejs/node/commit/b1a7fdac43aee592934df453f0ca6490d8fa8bb7
#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-dd4789b
https://github.com/addaleax
https://github.com/codebytere
async_hooks: clear async_id_stack for terminations in more placeshttps://github.com/nodejs/node/commit/dd4789b8eecf69edb9ade7dc15b9b8fc101a1302
dd4789bhttps://github.com/nodejs/node/commit/dd4789b8eecf69edb9ade7dc15b9b8fc101a1302
#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-b93a723
https://github.com/addaleax
https://github.com/codebytere
test: regression tests for async_hooks + Promise + Worker interactionhttps://github.com/nodejs/node/commit/b93a723fe6dbafe608fc9921fc9f31786123cdc1
b93a723https://github.com/nodejs/node/commit/b93a723fe6dbafe608fc9921fc9f31786123cdc1
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
#33347https://github.com/nodejs/node/pull/33347
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33347#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-60e2bcf
https://github.com/addaleax
https://github.com/codebytere
worker: call CancelTerminateExecution() before exiting Lockerhttps://github.com/nodejs/node/commit/60e2bcf128153d03ca4b6cd7e99b8f816d25c3ae
60e2bcfhttps://github.com/nodejs/node/commit/60e2bcf128153d03ca4b6cd7e99b8f816d25c3ae
#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-d572d4c
https://github.com/addaleax
https://github.com/codebytere
async_hooks: clear async_id_stack for terminations in more placeshttps://github.com/nodejs/node/commit/d572d4c397dcc73a3e7318c4e10f5360e8a5934e
d572d4chttps://github.com/nodejs/node/commit/d572d4c397dcc73a3e7318c4e10f5360e8a5934e
#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-ca4c3e0
https://github.com/addaleax
https://github.com/codebytere
test: regression tests for async_hooks + Promise + Worker interactionhttps://github.com/nodejs/node/commit/ca4c3e07b43fc247b386e1c7a016f6912204f96a
ca4c3e0https://github.com/nodejs/node/commit/ca4c3e07b43fc247b386e1c7a016f6912204f96a
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-8a92698
https://github.com/addaleax
https://github.com/codebytere
worker: call CancelTerminateExecution() before exiting Lockerhttps://github.com/nodejs/node/commit/8a926982e5202d2a4fb5cf945c71c77f94fe7cd6
8a92698https://github.com/nodejs/node/commit/8a926982e5202d2a4fb5cf945c71c77f94fe7cd6
#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-ba93c8d
https://github.com/addaleax
https://github.com/codebytere
async_hooks: clear async_id_stack for terminations in more placeshttps://github.com/codebytere/node/commit/ba93c8d87deaa5943b50408bf89f7500fcf27bd8
ba93c8dhttps://github.com/codebytere/node/commit/ba93c8d87deaa5943b50408bf89f7500fcf27bd8
nodejs#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-5da7d52
https://github.com/addaleax
https://github.com/codebytere
test: regression tests for async_hooks + Promise + Worker interactionhttps://github.com/nodejs/node/commit/5da7d52a9ffb9df47601849173342382fa290f2a
5da7d52https://github.com/nodejs/node/commit/5da7d52a9ffb9df47601849173342382fa290f2a
13c5a16https://github.com/nodejs/node/commit/13c5a1629cd025ba560f34f6d3190b2f38d184d4
#33347https://github.com/nodejs/node/pull/33347
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33347#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-40dae27
https://github.com/codebytere
Fixup async id assertion patchhttps://github.com/electron/electron/commit/40dae27995c9729e310104ddecbd6a96f424626c
40dae27https://github.com/electron/electron/commit/40dae27995c9729e310104ddecbd6a96f424626c
nodejs/node#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Jun 18, 2020 https://github.com/nodejs/node/pull/33347#ref-commit-1d8e416
https://github.com/codebytere
Fixup async id assertion patchhttps://github.com/electron/electron/commit/1d8e416b12e50d7e0986d8641caed5c6ff779494
1d8e416https://github.com/electron/electron/commit/1d8e416b12e50d7e0986d8641caed5c6ff779494
nodejs/node#33347https://github.com/nodejs/node/pull/33347
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Nov 16, 2020https://github.com/nodejs/node/pull/33347#event-4000024902
https://github.com/Qard
Qardhttps://github.com/Qard
Apr 21, 2021 https://github.com/nodejs/node/pull/33347#ref-pullrequest-757367255
async_hooks: use new v8::Context PromiseHook API #36394 https://github.com/nodejs/node/pull/36394
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 5, 2026 https://github.com/nodejs/node/pull/33347#ref-pullrequest-5359169385
src: fix Stop() terminating the next Environment on the isolate #65819 https://github.com/nodejs/node/pull/65819
codebyterehttps://github.com/codebytere
Sep 5, 2026 https://github.com/nodejs/node/pull/33347#ref-commit-ec575f4
https://github.com/codebytere
src: fix Stop() terminating the next Environment on the isolatehttps://github.com/codebytere/node/commit/ec575f4cbed0d1fefe1fbc4da86bc7eb69c22bdd
ec575f4https://github.com/codebytere/node/commit/ec575f4cbed0d1fefe1fbc4da86bc7eb69c22bdd
nodejs#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Sep 7, 2026 https://github.com/nodejs/node/pull/33347#ref-commit-169f34a
https://github.com/codebytere
src: fix Stop() terminating the next Environment on the isolatehttps://github.com/codebytere/node/commit/169f34a1ef870e1c7c2581024b47f0d541c7d8ed
169f34ahttps://github.com/codebytere/node/commit/169f34a1ef870e1c7c2581024b47f0d541c7d8ed
nodejs#33347https://github.com/nodejs/node/pull/33347
codebyterehttps://github.com/codebytere
Sep 10, 2026 https://github.com/nodejs/node/pull/33347#ref-commit-0de4fcc
https://github.com/codebytere
src: fix Stop() terminating the next Environment on the isolatehttps://github.com/nodejs/node/commit/0de4fcceb9372b5974f7bacc315d90f82f456d67
0de4fcchttps://github.com/nodejs/node/commit/0de4fcceb9372b5974f7bacc315d90f82f456d67
#33347https://github.com/nodejs/node/pull/33347
#65819https://github.com/nodejs/node/pull/65819
aduh95https://github.com/aduh95
Sep 16, 2026 https://github.com/nodejs/node/pull/33347#ref-commit-afc3e55
https://github.com/codebytere
https://github.com/aduh95
src: fix Stop() terminating the next Environment on the isolatehttps://github.com/nodejs/node/commit/afc3e559d21251eb979c7fdb396b59e059325636
afc3e55https://github.com/nodejs/node/commit/afc3e559d21251eb979c7fdb396b59e059325636
#33347https://github.com/nodejs/node/pull/33347
#65819https://github.com/nodejs/node/pull/65819
aduh95https://github.com/aduh95
Sep 22, 2026 https://github.com/nodejs/node/pull/33347#ref-commit-bedf7e7
https://github.com/codebytere
https://github.com/aduh95
src: fix Stop() terminating the next Environment on the isolatehttps://github.com/nodejs/node/commit/bedf7e7001fd93bdd5e787e22587fd1f37467b45
bedf7e7https://github.com/nodejs/node/commit/bedf7e7001fd93bdd5e787e22587fd1f37467b45
#33347https://github.com/nodejs/node/pull/33347
#65819https://github.com/nodejs/node/pull/65819
aduh95https://github.com/aduh95
Sep 25, 2026 https://github.com/nodejs/node/pull/33347#ref-commit-3c814e8
https://github.com/codebytere
https://github.com/aduh95
src: fix Stop() terminating the next Environment on the isolatehttps://github.com/nodejs/node/commit/3c814e8c3cd06f1a00b65ddb7ece6ac3ead5a9b7
3c814e8https://github.com/nodejs/node/commit/3c814e8c3cd06f1a00b65ddb7ece6ac3ead5a9b7
#33347https://github.com/nodejs/node/pull/33347
#65819https://github.com/nodejs/node/pull/65819
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33347
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33347/files/7b45371695348a355a6a2cf4bc50c0652f1ff887
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33347/files/3d9d564db7b9b33f0fe0f66e5dc7e59b621f9705
Please reload this pagehttps://github.com/nodejs/node/pull/33347
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/33347
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.