René's URL Explorer Experiment


Title: module: do not check circular dependencies for exported proxies by BridgeAR · Pull Request #33338 · nodejs/node · GitHub

Open Graph Title: module: do not check circular dependencies for exported proxies by BridgeAR · Pull Request #33338 · nodejs/node

X Title: module: do not check circular dependencies for exported proxies by BridgeAR · Pull Request #33338 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In case the exported module is a proxy that has the getPrototypeOf or setPrototypeOf trap, skip the circular dependencies check. It would otherwise be triggered by the check itself. Fixes: #33334 S...

X Description: In case the exported module is a proxy that has the getPrototypeOf or setPrototypeOf trap, skip the circular dependencies check. It would otherwise be triggered by the check itself. Fixes: #33334 S...

Mail addresses
ruben@bridgewater.de

Opengraph URL: https://github.com/nodejs/node/pull/33338

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd0661d2-04a2-65ac-9b4b-d9469e33c259
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA256:1CAA92:3A01CC:4AF6BE:6AED1F2B
html-safe-nonce9bdca152fad2c4ce05878aa1311c15830d95f2a9ddd44e449ea6a1e2d80642a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjU2OjFDQUE5MjozQTAxQ0M6NEFGNkJFOjZBRUQxRjJCIiwidmlzaXRvcl9pZCI6IjU2Mzc2OTE0MDg3MzUwODQzMzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfe06420c30e0c8539dc4afed2bdd4b9a10d864540eacb344f29ef09840b4eef0
hovercard-subject-tagpull_request:415709542
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33338/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/736e066e1e551bbaec9db44036b38db4c4403dce66cd06986e2c11d51611bd2c/nodejs/node/pull/33338
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/736e066e1e551bbaec9db44036b38db4c4403dce66cd06986e2c11d51611bd2c/nodejs/node/pull/33338
og:image:altIn case the exported module is a proxy that has the getPrototypeOf or setPrototypeOf trap, skip the circular dependencies check. It would otherwise be triggered by the check itself. Fixes: #33334 S...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33338#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33338
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33338
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33338
Reloadhttps://github.com/nodejs/node/pull/33338
Reloadhttps://github.com/nodejs/node/pull/33338
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-circular-modules-check-with-proxieshttps://github.com/BridgeAR/node/tree/fix-circular-modules-check-with-proxies
Conversationhttps://github.com/nodejs/node/pull/33338
Commits1 (1)https://github.com/nodejs/node/pull/33338/commits
Checkshttps://github.com/nodejs/node/pull/33338/checks
Files changedhttps://github.com/nodejs/node/pull/33338/files
module: do not check circular dependencies for exported proxieshttps://github.com/nodejs/node/pull/33338#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-circular-modules-check-with-proxieshttps://github.com/BridgeAR/node/tree/fix-circular-modules-check-with-proxies
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2020https://github.com/nodejs/node/pull/33338#issue-615376128
#33334https://github.com/nodejs/node/issues/33334
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
addaleaxhttps://github.com/addaleax
May 10, 2020 11:56https://github.com/nodejs/node/pull/33338#event-3320252058
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 10, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-408740034
View reviewed changes https://github.com/nodejs/node/pull/33338/files
test/fixtures/cycles/warning-skip-proxy-traps-a.jshttps://github.com/nodejs/node/pull/33338/files#diff-e2d6931e305d0c2bd636ccdc8baae845d3a0ad0af9231ac6e25ca390d94877e6
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/rickyes
rickyeshttps://github.com/rickyes
May 10, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-408744071
View reviewed changes https://github.com/nodejs/node/pull/33338/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/33338/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/33338
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/33338/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/ghost
ghosthttps://github.com/ghost
May 10, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626351792
Please reload this pagehttps://github.com/nodejs/node/pull/33338
cobra effecthttps://en.wikipedia.org/wiki/Cobra_effect
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/rickyes
rickyeshttps://github.com/rickyes
May 10, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626355982
Please reload this pagehttps://github.com/nodejs/node/pull/33338
cobra effecthttps://en.wikipedia.org/wiki/Cobra_effect
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/ghost
ghosthttps://github.com/ghost
May 10, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626364312
Please reload this pagehttps://github.com/nodejs/node/pull/33338
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-408768382
View reviewed changes https://github.com/nodejs/node/pull/33338/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/33338#pullrequestreview-408768382
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33338
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/33338/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/33338
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/33338/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 10, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626367539
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/dba07f55fef7d76abda0ec5f66d842e170dde868..83e5b2a25796167ab95dc471e148d14be55457c6
dba07f5https://github.com/nodejs/node/commit/dba07f55fef7d76abda0ec5f66d842e170dde868
83e5b2ahttps://github.com/nodejs/node/commit/83e5b2a25796167ab95dc471e148d14be55457c6
Compare https://github.com/nodejs/node/compare/dba07f55fef7d76abda0ec5f66d842e170dde868..83e5b2a25796167ab95dc471e148d14be55457c6
May 11, 2020 12:45https://github.com/nodejs/node/pull/33338#event-3322797927
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 11, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626684137
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
May 11, 2020https://github.com/nodejs/node/pull/33338#event-3322878510
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 11, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626689940
https://ci.nodejs.org/job/node-test-pull-request/31274/https://ci.nodejs.org/job/node-test-pull-request/31274/
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 11, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-409216431
View reviewed changes https://github.com/nodejs/node/pull/33338/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/33338/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33338
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 11, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-409395408
View reviewed changes https://github.com/nodejs/node/pull/33338/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/33338#pullrequestreview-409395408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 11, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626861031
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/31b25e40a56c1bc31e9b9b638f39e070ce6ee87b..ed4978408487a7ac4ff3a8b300e043b3f9cd1348
31b25e4https://github.com/nodejs/node/commit/31b25e40a56c1bc31e9b9b638f39e070ce6ee87b
ed49784https://github.com/nodejs/node/commit/ed4978408487a7ac4ff3a8b300e043b3f9cd1348
Compare https://github.com/nodejs/node/compare/31b25e40a56c1bc31e9b9b638f39e070ce6ee87b..ed4978408487a7ac4ff3a8b300e043b3f9cd1348
May 11, 2020 18:12https://github.com/nodejs/node/pull/33338#event-3324165846
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 11, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626868301
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
module: do not check circular dependencies for exported proxieshttps://github.com/nodejs/node/pull/33338/commits/4e7e478e922333e79bdf0b2e397a441a054d5c9b
4e7e478https://github.com/nodejs/node/pull/33338/commits/4e7e478e922333e79bdf0b2e397a441a054d5c9b
nodejs#33334https://github.com/nodejs/node/issues/33334
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/ed4978408487a7ac4ff3a8b300e043b3f9cd1348..4e7e478e922333e79bdf0b2e397a441a054d5c9b
ed49784https://github.com/nodejs/node/commit/ed4978408487a7ac4ff3a8b300e043b3f9cd1348
4e7e478https://github.com/nodejs/node/commit/4e7e478e922333e79bdf0b2e397a441a054d5c9b
Compare https://github.com/nodejs/node/compare/ed4978408487a7ac4ff3a8b300e043b3f9cd1348..4e7e478e922333e79bdf0b2e397a441a054d5c9b
May 11, 2020 18:16https://github.com/nodejs/node/pull/33338#event-3324180603
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 11, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-409419265
View reviewed changes https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 11, 2020https://github.com/nodejs/node/pull/33338#issuecomment-626881237
https://ci.nodejs.org/job/node-test-pull-request/31282/https://ci.nodejs.org/job/node-test-pull-request/31282/
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/targos
targoshttps://github.com/targos
May 11, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-409442505
View reviewed changes https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/targos
targoshttps://github.com/targos
May 11, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-409442935
View reviewed changes https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 11, 2020https://github.com/nodejs/node/pull/33338#event-3324840286
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 12, 2020https://github.com/nodejs/node/pull/33338#issuecomment-627448575
https://ci.nodejs.org/job/node-test-pull-request/31293/https://ci.nodejs.org/job/node-test-pull-request/31293/
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/himself65
himself65https://github.com/himself65
May 13, 2020 https://github.com/nodejs/node/pull/33338#pullrequestreview-410595803
View reviewed changes https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
BridgeARhttps://github.com/BridgeAR
May 14, 2020 https://github.com/nodejs/node/pull/33338#ref-commit-24bf1ad
https://github.com/BridgeAR
module: do not check circular dependencies for exported proxieshttps://github.com/BridgeAR/node/commit/24bf1adacc61a96111ae3ad06afba6f9b7f435a7
24bf1adhttps://github.com/BridgeAR/node/commit/24bf1adacc61a96111ae3ad06afba6f9b7f435a7
nodejs#33334https://github.com/nodejs/node/issues/33334
nodejs#33338https://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2020https://github.com/nodejs/node/pull/33338#issuecomment-628946439
24bf1adhttps://github.com/nodejs/node/commit/24bf1adacc61a96111ae3ad06afba6f9b7f435a7
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 14, 2020https://github.com/nodejs/node/pull/33338#event-3338836813
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33338#ref-commit-c2d2dfc
https://github.com/BridgeAR
https://github.com/codebytere
module: do not check circular dependencies for exported proxieshttps://github.com/nodejs/node/commit/c2d2dfc09f390549e63803c9f0523e000d510408
c2d2dfchttps://github.com/nodejs/node/commit/c2d2dfc09f390549e63803c9f0523e000d510408
#33334https://github.com/nodejs/node/issues/33334
#33338https://github.com/nodejs/node/pull/33338
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33338#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 7, 2020https://github.com/nodejs/node/pull/33338#issuecomment-640253712
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Jun 7, 2020https://github.com/nodejs/node/pull/33338#event-3416891035
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Jun 7, 2020https://github.com/nodejs/node/pull/33338#event-3416892470
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33338
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33338/files/31b25e40a56c1bc31e9b9b638f39e070ce6ee87b
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/33338/files/eb26e1d2e58e899ec32d829aa1663018ea9463c5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
https://github.com/rickyes
rickyes https://github.com/rickyes
https://github.com/nodejs/node/pull/33338/files/eb26e1d2e58e899ec32d829aa1663018ea9463c5
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/33338/files/4e7e478e922333e79bdf0b2e397a441a054d5c9b
Please reload this pagehttps://github.com/nodejs/node/pull/33338
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
Assertion error starting from v14.0.0 https://github.com/nodejs/node/issues/33334
Please reload this pagehttps://github.com/nodejs/node/pull/33338
https://github.com/BridgeAR
https://github.com/rickyes
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/codebytere
https://github.com/jasnell
https://github.com/targos
https://github.com/richardlau
https://github.com/himself65
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.