René's URL Explorer Experiment


Title: chore: add #include in json_utils.h by zcbenz · Pull Request #33332 · nodejs/node · GitHub

Open Graph Title: chore: add #include in json_utils.h by zcbenz · Pull Request #33332 · nodejs/node

X Title: chore: add #include in json_utils.h by zcbenz · Pull Request #33332 · nodejs/node

Description: When precompile headers are disabled this file would cause compilation errors due to #include not included. d:\a\1\s\node\src\json_utils.h(141): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'std::string' (or there is no acceptable conversion) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: When precompile headers are disabled this file would cause compilation errors due to #include <string> not included. d:\a\1\s\node\src\json_utils.h(141): error C2679: binary '<<'...

X Description: When precompile headers are disabled this file would cause compilation errors due to #include &lt;string&gt; not included. d:\a\1\s\node\src\json_utils.h(141): error C2679: binary &#39;...

Opengraph URL: https://github.com/nodejs/node/pull/33332

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:054c0334-77ce-58eb-f32b-8efff9b0053b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD748:7DD00:5B9D17:7C3B60:6AED231A
html-safe-noncecc0d7234e57b06265857e544afd1eb5017240f42fb6015308e87930929fffb55
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzQ4OjdERDAwOjVCOUQxNzo3QzNCNjA6NkFFRDIzMUEiLCJ2aXNpdG9yX2lkIjoiODc3Mzg0NjgxNTY5MDUzMTYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaced2f2cd52f10c4cad4b4eb516f943f03e698bfa336e080cfe1a7b39e3577856f
hovercard-subject-tagpull_request:415650163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/33332/files
twitter:imagehttps://avatars.githubusercontent.com/u/639601?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/639601?s=400&v=4
og:image:altWhen precompile headers are disabled this file would cause compilation errors due to #include <string> not included. d:\a\1\s\node\src\json_utils.h(141): error C2679: binary '<<'...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33332/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33332%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33332%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33332/files
Reloadhttps://github.com/nodejs/node/pull/33332/files
Reloadhttps://github.com/nodejs/node/pull/33332/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
zcbenzhttps://github.com/zcbenz
nodejs:masterhttps://github.com/nodejs/node/tree/master
zcbenz:patch-1https://github.com/zcbenz/node/tree/patch-1
Conversation 3 https://github.com/nodejs/node/pull/33332
Commits 1 https://github.com/nodejs/node/pull/33332/commits
Checks 0 https://github.com/nodejs/node/pull/33332/checks
Files changed https://github.com/nodejs/node/pull/33332/files
Please reload this pagehttps://github.com/nodejs/node/pull/33332/files
chore: add #include in json_utils.h https://github.com/nodejs/node/pull/33332/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/33332/files
5f793b1 chore: add #include in json_utils.h zcbenz May 10, 2020 https://github.com/nodejs/node/pull/33332/commits/5f793b12a1667cbe86c33162a686daea6ec51229
Clear filters https://github.com/nodejs/node/pull/33332/files
Please reload this pagehttps://github.com/nodejs/node/pull/33332/files
Please reload this pagehttps://github.com/nodejs/node/pull/33332/files
src/json_utils.hhttps://github.com/nodejs/node/pull/33332/files#diff-b47d99257d2803f65e5a7ab2ffdba7de6a7b50ac18af202bf1fcce2cebc0c6fa
View file https://github.com/zcbenz/node/blob/5f793b12a1667cbe86c33162a686daea6ec51229/src/json_utils.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33332/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33332/files#diff-b47d99257d2803f65e5a7ab2ffdba7de6a7b50ac18af202bf1fcce2cebc0c6fa
https://github.com/nodejs/node/pull/33332/files#diff-b47d99257d2803f65e5a7ab2ffdba7de6a7b50ac18af202bf1fcce2cebc0c6fa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.