| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9159261a-ebfa-607f-1e1f-eaa3f42ef9a0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E20E:7DD00:46EADA:6075C5:6AED1B9D |
| html-safe-nonce | 8b65017571c2f8a6918929634fa687bd21b4938653dc8fa5c4d3411abe634d8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjBFOjdERDAwOjQ2RUFEQTo2MDc1QzU6NkFFRDFCOUQiLCJ2aXNpdG9yX2lkIjoiNDc4NDA5NDUxMTUxNzk5Nzk4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 92df81376b544389e7140cd1d5eb8318c5fc4a5ae2093dd65adad30deefaa6e1 |
| hovercard-subject-tag | pull_request:415513233 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33318/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ac9853048fae8ce68188554e0f3a6b77c723ea5af6414bcc67f5eb161bddf5a3/nodejs/node/pull/33318 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ac9853048fae8ce68188554e0f3a6b77c723ea5af6414bcc67f5eb161bddf5a3/nodejs/node/pull/33318 |
| og:image:alt | This commit adds the primordials argument to the comment of arguments
passed to bootstrap/node.js.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e12fd03aa775dceadc5a793c3a0791e43ca256bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33318#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33318 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33318 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33318 |
| Reload | https://github.com/nodejs/node/pull/33318 |
| Reload | https://github.com/nodejs/node/pull/33318 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues655 (655) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:add-primordials-command | https://github.com/danbev/node/tree/add-primordials-command |
| Conversation | https://github.com/nodejs/node/pull/33318 |
| Commits1 (1) | https://github.com/nodejs/node/pull/33318/commits |
| Checks | https://github.com/nodejs/node/pull/33318/checks |
| Files changed | https://github.com/nodejs/node/pull/33318/files |
| src: add primordials to arguments comment | https://github.com/nodejs/node/pull/33318#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:add-primordials-command | https://github.com/danbev/node/tree/add-primordials-command |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 9, 2020 | https://github.com/nodejs/node/pull/33318#issue-615088578 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33318 |
|
| https://github.com/danbev |
| src: add primordials to arguments comment | https://github.com/nodejs/node/pull/33318/commits/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| 1120148 | https://github.com/nodejs/node/pull/33318/commits/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 9, 2020
| https://github.com/nodejs/node/pull/33318#pullrequestreview-408611366 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 9, 2020
| https://github.com/nodejs/node/pull/33318#pullrequestreview-408611616 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
May 9, 2020
| https://github.com/nodejs/node/pull/33318#pullrequestreview-408652657 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 9, 2020 | https://github.com/nodejs/node/pull/33318#event-3319426882 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
May 11, 2020
| https://github.com/nodejs/node/pull/33318#pullrequestreview-408818619 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
May 11, 2020
| https://github.com/nodejs/node/pull/33318#pullrequestreview-408819881 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 11, 2020 | https://github.com/nodejs/node/pull/33318#event-3321727872 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 12, 2020 | https://github.com/nodejs/node/pull/33318#issuecomment-627090306 |
| https://ci.nodejs.org/job/node-test-pull-request/31285/ | https://ci.nodejs.org/job/node-test-pull-request/31285/ |
| Please reload this page | https://github.com/nodejs/node/pull/33318 |
| danbev | https://github.com/danbev |
|
May 13, 2020
| https://github.com/nodejs/node/pull/33318#ref-commit-e1b90be |
|
| https://github.com/danbev |
| src: add primordials to arguments comment | https://github.com/nodejs/node/commit/e1b90be3b7c687fcf263db72862b6a199d239f89 |
| e1b90be | https://github.com/nodejs/node/commit/e1b90be3b7c687fcf263db72862b6a199d239f89 |
| #33318 | https://github.com/nodejs/node/pull/33318 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 13, 2020 | https://github.com/nodejs/node/pull/33318#issuecomment-627800094 |
| e1b90be | https://github.com/nodejs/node/commit/e1b90be3b7c687fcf263db72862b6a199d239f89 |
| Please reload this page | https://github.com/nodejs/node/pull/33318 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 13, 2020 | https://github.com/nodejs/node/pull/33318#event-3330686507 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 13, 2020 07:24 | https://github.com/nodejs/node/pull/33318#event-3330687947 |
| codebytere | https://github.com/codebytere |
|
May 16, 2020
| https://github.com/nodejs/node/pull/33318#ref-commit-d292633 |
|
| https://github.com/danbev |
|
| https://github.com/codebytere |
| src: add primordials to arguments comment | https://github.com/nodejs/node/commit/d292633ed48bddc5ae7328ee86651909bf5b0f15 |
| d292633 | https://github.com/nodejs/node/commit/d292633ed48bddc5ae7328ee86651909bf5b0f15 |
| #33318 | https://github.com/nodejs/node/pull/33318 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
May 18, 2020
| https://github.com/nodejs/node/pull/33318#ref-pullrequest-619852653 |
|
v14.3.0 proposal
#33452
| https://github.com/nodejs/node/pull/33452 |
| codebytere | https://github.com/codebytere |
|
Jun 7, 2020
| https://github.com/nodejs/node/pull/33318#ref-commit-1f159e4 |
|
| https://github.com/danbev |
|
| https://github.com/codebytere |
| src: add primordials to arguments comment | https://github.com/nodejs/node/commit/1f159e45f2d78d17102ddbf50eca374852167130 |
| 1f159e4 | https://github.com/nodejs/node/commit/1f159e45f2d78d17102ddbf50eca374852167130 |
| #33318 | https://github.com/nodejs/node/pull/33318 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 9, 2020
| https://github.com/nodejs/node/pull/33318#ref-pullrequest-635542822 |
|
v12.18.1 proposal
#33811
| https://github.com/nodejs/node/pull/33811 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33318 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/33318/files/1120148a11cc6ed1c9b72b0f0d33bb2d44db2908 |
| Please reload this page | https://github.com/nodejs/node/pull/33318 |
| Please reload this page | https://github.com/nodejs/node/pull/33318 |
|
| https://github.com/danbev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/himself65 |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |