René's URL Explorer Experiment


Title: src: remove unnecessary Isolate::GetCurrent() calls by addaleax · Pull Request #33298 · nodejs/node · GitHub

Open Graph Title: src: remove unnecessary Isolate::GetCurrent() calls by addaleax · Pull Request #33298 · nodejs/node

X Title: src: remove unnecessary Isolate::GetCurrent() calls by addaleax · Pull Request #33298 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: These calls are unnecessary in Release mode but would still have been included, so move them to the DebugSealHandleScope constructor. Checklist make -j4 test (UNIX), or vcbuild test (Windows) p...

X Description: These calls are unnecessary in Release mode but would still have been included, so move them to the DebugSealHandleScope constructor. Checklist make -j4 test (UNIX), or vcbuild test (Windows) p...

Opengraph URL: https://github.com/nodejs/node/pull/33298

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9dd64edd-0b05-c3fe-a3d4-f501fa6b634a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF6C:3C4A99:39A3D0:4AD86C:6AED1EDA
html-safe-nonceabe221e926c9a49517ccb70ae6944391ba3d50e4917aef30a3dc46b0b5bc5641
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjZDOjNDNEE5OTozOUEzRDA6NEFEODZDOjZBRUQxRURBIiwidmlzaXRvcl9pZCI6IjUwNTM0MzM0MjI0Nzg2NDcwMDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2167e777f850b6e5c4a255b6a73b643a5363ddd7bb0d40b862a4cce51c183bc4
hovercard-subject-tagpull_request:415037260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33298/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1dc6711eab9ec09bcdacc55f1d03eee706661d94ab98c4bb5613f2e5aab515e7/nodejs/node/pull/33298
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1dc6711eab9ec09bcdacc55f1d03eee706661d94ab98c4bb5613f2e5aab515e7/nodejs/node/pull/33298
og:image:altThese calls are unnecessary in Release mode but would still have been included, so move them to the DebugSealHandleScope constructor. Checklist make -j4 test (UNIX), or vcbuild test (Windows) p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33298#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33298
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33298
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33298
Reloadhttps://github.com/nodejs/node/pull/33298
Reloadhttps://github.com/nodejs/node/pull/33298
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:debug-seal-handlescope-getcurrenthttps://github.com/addaleax/node/tree/debug-seal-handlescope-getcurrent
Conversationhttps://github.com/nodejs/node/pull/33298
Commits2 (2)https://github.com/nodejs/node/pull/33298/commits
Checkshttps://github.com/nodejs/node/pull/33298/checks
Files changedhttps://github.com/nodejs/node/pull/33298/files
src: remove unnecessary Isolate::GetCurrent() callshttps://github.com/nodejs/node/pull/33298#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:debug-seal-handlescope-getcurrenthttps://github.com/addaleax/node/tree/debug-seal-handlescope-getcurrent
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 8, 2020https://github.com/nodejs/node/pull/33298#issue-614493010
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33298
https://github.com/addaleax
src: remove unnecessary Isolate::GetCurrent() callshttps://github.com/nodejs/node/pull/33298/commits/773e6699c5d79330c89e699261565ff2312dfe71
773e669https://github.com/nodejs/node/pull/33298/commits/773e6699c5d79330c89e699261565ff2312dfe71
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 8, 2020https://github.com/nodejs/node/pull/33298#event-3315520078
https://github.com/danbev
danbevhttps://github.com/danbev
May 8, 2020 https://github.com/nodejs/node/pull/33298#pullrequestreview-408033526
View reviewed changes https://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71
src/node_internals.hhttps://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d
Please reload this pagehttps://github.com/nodejs/node/pull/33298
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 8, 2020 https://github.com/nodejs/node/pull/33298#pullrequestreview-408213300
View reviewed changes https://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71
https://github.com/devnexen
devnexenhttps://github.com/devnexen
May 8, 2020 https://github.com/nodejs/node/pull/33298#pullrequestreview-408362662
View reviewed changes https://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71
https://github.com/addaleax
fixup! src: remove unnecessary Isolate::GetCurrent() callshttps://github.com/nodejs/node/pull/33298/commits/08d076d18934c112ae94ef98c9733dccfc2dbea5
08d076dhttps://github.com/nodejs/node/pull/33298/commits/08d076d18934c112ae94ef98c9733dccfc2dbea5
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 8, 2020 https://github.com/nodejs/node/pull/33298#pullrequestreview-408434759
View reviewed changes https://github.com/nodejs/node/pull/33298/files/08d076d18934c112ae94ef98c9733dccfc2dbea5
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/33298#pullrequestreview-408434759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33298
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 9, 2020https://github.com/nodejs/node/pull/33298#event-3319669242
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 9, 2020https://github.com/nodejs/node/pull/33298#issuecomment-626222910
https://ci.nodejs.org/job/node-test-pull-request/31260/https://ci.nodejs.org/job/node-test-pull-request/31260/
Please reload this pagehttps://github.com/nodejs/node/pull/33298
targoshttps://github.com/targos
May 10, 2020 https://github.com/nodejs/node/pull/33298#ref-commit-34d92b7
https://github.com/addaleax
https://github.com/targos
src: remove unnecessary Isolate::GetCurrent() callshttps://github.com/nodejs/node/commit/34d92b78ab93e86168a2ddfe633eea42958bdd9d
34d92b7https://github.com/nodejs/node/commit/34d92b78ab93e86168a2ddfe633eea42958bdd9d
#33298https://github.com/nodejs/node/pull/33298
https://github.com/targos
targoshttps://github.com/targos
May 10, 2020https://github.com/nodejs/node/pull/33298#issuecomment-626318238
34d92b7https://github.com/nodejs/node/commit/34d92b78ab93e86168a2ddfe633eea42958bdd9d
Please reload this pagehttps://github.com/nodejs/node/pull/33298
https://github.com/targos
targoshttps://github.com/targos
May 10, 2020https://github.com/nodejs/node/pull/33298#event-3320261812
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33298#ref-commit-3de9dd9
https://github.com/addaleax
https://github.com/codebytere
src: remove unnecessary Isolate::GetCurrent() callshttps://github.com/nodejs/node/commit/3de9dd9c8dd1181cacb1046f93dd17d0d594e39e
3de9dd9https://github.com/nodejs/node/commit/3de9dd9c8dd1181cacb1046f93dd17d0d594e39e
#33298https://github.com/nodejs/node/pull/33298
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33298#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33298#ref-commit-b630079
https://github.com/addaleax
https://github.com/codebytere
src: remove unnecessary Isolate::GetCurrent() callshttps://github.com/nodejs/node/commit/b6300793fb3317d5b247ec4fa10d9b7e19ef91a1
b630079https://github.com/nodejs/node/commit/b6300793fb3317d5b247ec4fa10d9b7e19ef91a1
#33298https://github.com/nodejs/node/pull/33298
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33298#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33298
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33298/files/773e6699c5d79330c89e699261565ff2312dfe71
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/33298/files/08d076d18934c112ae94ef98c9733dccfc2dbea5
Please reload this pagehttps://github.com/nodejs/node/pull/33298
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33298
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/danbev
https://github.com/cjihrig
https://github.com/devnexen
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.