| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a2612956-617c-ee47-b5d9-c7a8835a188b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A482:34BA18:580D6C:79C5F7:6AED8912 |
| html-safe-nonce | 4ed1f9450130d05c929d69794bcbf8223c0b764eb31d541feddf07c5ec984719 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDgyOjM0QkExODo1ODBENkM6NzlDNUY3OjZBRUQ4OTEyIiwidmlzaXRvcl9pZCI6IjQ1MTgyODU0OTY3MzkwMDY3MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ad6938309d49fd2e2eab007202dc60220e17ae5193360ee10a4494e5c015650a |
| hovercard-subject-tag | pull_request:414905534 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33291/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ef147affe251472f6cc330d2e95ad8a974af18d697fb484354012018dea3be1b/nodejs/node/pull/33291 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ef147affe251472f6cc330d2e95ad8a974af18d697fb484354012018dea3be1b/nodejs/node/pull/33291 |
| og:image:alt | Cleanup up env.h by removing things that are not
specific to Environment.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33291#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33291 |
| Reload | https://github.com/nodejs/node/pull/33291 |
| Reload | https://github.com/nodejs/node/pull/33291 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues654 (654) | https://github.com/nodejs/node/issues |
| Pull requests662 (662) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:extract-allocated-buffer | https://github.com/jasnell/node/tree/extract-allocated-buffer |
| Conversation | https://github.com/nodejs/node/pull/33291 |
| Commits3 (3) | https://github.com/nodejs/node/pull/33291/commits |
| Checks | https://github.com/nodejs/node/pull/33291/checks |
| Files changed | https://github.com/nodejs/node/pull/33291/files |
| src: extract AllocatedBuffer from env.h | https://github.com/nodejs/node/pull/33291#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:extract-allocated-buffer | https://github.com/jasnell/node/tree/extract-allocated-buffer |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 7, 2020 | https://github.com/nodejs/node/pull/33291#issue-614326505 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| May 7, 2020 | https://github.com/nodejs/node/pull/33291#event-3314558274 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| addaleax | https://github.com/addaleax |
| May 7, 2020 20:34 | https://github.com/nodejs/node/pull/33291#event-3314558298 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 7, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-625484946 |
| https://ci.nodejs.org/job/node-test-pull-request/31211/ | https://ci.nodejs.org/job/node-test-pull-request/31211/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 7, 2020
| https://github.com/nodejs/node/pull/33291#pullrequestreview-407864438 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33291/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/33291#pullrequestreview-407864438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| src/env.cc | https://github.com/nodejs/node/pull/33291/files#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
May 8, 2020
| https://github.com/nodejs/node/pull/33291#pullrequestreview-408019533 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33291/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/77ff8efd0db257cb11e5461c67c0273a20577de6..2fc6b652ac358cd85f0cd021b10fc4c95b8832d3 |
| 77ff8ef | https://github.com/nodejs/node/commit/77ff8efd0db257cb11e5461c67c0273a20577de6 |
| 2fc6b65 | https://github.com/nodejs/node/commit/2fc6b652ac358cd85f0cd021b10fc4c95b8832d3 |
|
Compare
| https://github.com/nodejs/node/compare/77ff8efd0db257cb11e5461c67c0273a20577de6..2fc6b652ac358cd85f0cd021b10fc4c95b8832d3 |
| May 14, 2020 15:37 | https://github.com/nodejs/node/pull/33291#event-3337208110 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/5a0bd994eccaf4dec8a9f2d94e855daccffcdb31..9fa9f61ed1fea1920236cfcc0a80afc4f2483848 |
| 5a0bd99 | https://github.com/nodejs/node/commit/5a0bd994eccaf4dec8a9f2d94e855daccffcdb31 |
| 9fa9f61 | https://github.com/nodejs/node/commit/9fa9f61ed1fea1920236cfcc0a80afc4f2483848 |
|
Compare
| https://github.com/nodejs/node/compare/5a0bd994eccaf4dec8a9f2d94e855daccffcdb31..9fa9f61ed1fea1920236cfcc0a80afc4f2483848 |
| May 14, 2020 16:42 | https://github.com/nodejs/node/pull/33291#event-3337484203 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/9fa9f61ed1fea1920236cfcc0a80afc4f2483848..72b65427565ec15d59ba3093402b66c3b4915bb5 |
| 9fa9f61 | https://github.com/nodejs/node/commit/9fa9f61ed1fea1920236cfcc0a80afc4f2483848 |
| 72b6542 | https://github.com/nodejs/node/commit/72b65427565ec15d59ba3093402b66c3b4915bb5 |
|
Compare
| https://github.com/nodejs/node/compare/9fa9f61ed1fea1920236cfcc0a80afc4f2483848..72b65427565ec15d59ba3093402b66c3b4915bb5 |
| May 14, 2020 16:50 | https://github.com/nodejs/node/pull/33291#event-3337527608 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-628766926 |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-628770401 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-628772145 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://ci.nodejs.org/job/node-test-pull-request/31336/ | https://ci.nodejs.org/job/node-test-pull-request/31336/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-628777602 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-628778449 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/9388529d3de3bb95ba506d425863852fb0831d29..c971497883dc4cc87f19aa0eee6cc5d77a78aa5f |
| 9388529 | https://github.com/nodejs/node/commit/9388529d3de3bb95ba506d425863852fb0831d29 |
| c971497 | https://github.com/nodejs/node/commit/c971497883dc4cc87f19aa0eee6cc5d77a78aa5f |
|
Compare
| https://github.com/nodejs/node/compare/9388529d3de3bb95ba506d425863852fb0831d29..c971497883dc4cc87f19aa0eee6cc5d77a78aa5f |
| May 14, 2020 19:10 | https://github.com/nodejs/node/pull/33291#event-3338040036 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-628851861 |
| @addaleax | https://github.com/addaleax |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33321 | https://github.com/nodejs/node/pull/33321 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| May 14, 2020 | https://github.com/nodejs/node/pull/33291#event-3338169088 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| addaleax | https://github.com/addaleax |
| devnexen | https://github.com/devnexen |
| May 14, 2020 19:53 | https://github.com/nodejs/node/pull/33291#event-3338181887 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 14, 2020
| https://github.com/nodejs/node/pull/33291#pullrequestreview-412210813 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33291/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/33291#pullrequestreview-412210813 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
May 14, 2020
| https://github.com/nodejs/node/pull/33291#pullrequestreview-412233195 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33291/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 16, 2020
| https://github.com/nodejs/node/pull/33291#ref-pullrequest-617016102 |
|
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
#33381
| https://github.com/nodejs/node/pull/33381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| May 16, 2020 | https://github.com/nodejs/node/pull/33291#event-3343444340 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 16, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-629622849 |
| https://ci.nodejs.org/job/node-test-pull-request/31358/ | https://ci.nodejs.org/job/node-test-pull-request/31358/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| May 23, 2020 | https://github.com/nodejs/node/pull/33291#event-3367258711 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 23, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-633101894 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 28, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-635347663 |
| https://ci.nodejs.org/job/node-test-pull-request/31601/ | https://ci.nodejs.org/job/node-test-pull-request/31601/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 29, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-636218267 |
| https://ci.nodejs.org/job/node-test-pull-request/31635/ | https://ci.nodejs.org/job/node-test-pull-request/31635/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| May 30, 2020 | https://github.com/nodejs/node/pull/33291#event-3389266745 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 30, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-636252337 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://ci.nodejs.org/job/node-test-pull-request/31648/ | https://ci.nodejs.org/job/node-test-pull-request/31648/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/07f8173966ab3fc1f7c2493d1acaa5433939bff6..e368fc4a8e4c99f63532df6379b8818a2be38b6f |
| 07f8173 | https://github.com/nodejs/node/commit/07f8173966ab3fc1f7c2493d1acaa5433939bff6 |
| e368fc4 | https://github.com/nodejs/node/commit/e368fc4a8e4c99f63532df6379b8818a2be38b6f |
|
Compare
| https://github.com/nodejs/node/compare/07f8173966ab3fc1f7c2493d1acaa5433939bff6..e368fc4a8e4c99f63532df6379b8818a2be38b6f |
| May 30, 2020 17:55 | https://github.com/nodejs/node/pull/33291#event-3389934321 |
| jasnell | https://github.com/jasnell |
| May 30, 2020 10:58 | https://github.com/nodejs/node/pull/33291#commits-pushed-1c61aba |
|
| https://github.com/jasnell |
| src: extract AllocatedBuffer from env.h | https://github.com/nodejs/node/pull/33291/commits/1c61aba3e6d6a81082f0f7b00cc1bfec0b68e7c4 |
| 1c61aba | https://github.com/nodejs/node/pull/33291/commits/1c61aba3e6d6a81082f0f7b00cc1bfec0b68e7c4 |
|
| https://github.com/jasnell |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/pull/33291/commits/9f8dc2fa386d366634e02be44168f980c748fe30 |
| 9f8dc2f | https://github.com/nodejs/node/pull/33291/commits/9f8dc2fa386d366634e02be44168f980c748fe30 |
| nodejs#33381 | https://github.com/nodejs/node/pull/33381 |
|
| https://github.com/jasnell |
| src: remove superfluous inline keywords | https://github.com/nodejs/node/pull/33291/commits/3c49e03ce2053558d5ef923f60cb95c584dfbc2e |
| 3c49e03 | https://github.com/nodejs/node/pull/33291/commits/3c49e03ce2053558d5ef923f60cb95c584dfbc2e |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/e368fc4a8e4c99f63532df6379b8818a2be38b6f..3c49e03ce2053558d5ef923f60cb95c584dfbc2e |
| e368fc4 | https://github.com/nodejs/node/commit/e368fc4a8e4c99f63532df6379b8818a2be38b6f |
| 3c49e03 | https://github.com/nodejs/node/commit/3c49e03ce2053558d5ef923f60cb95c584dfbc2e |
|
Compare
| https://github.com/nodejs/node/compare/e368fc4a8e4c99f63532df6379b8818a2be38b6f..3c49e03ce2053558d5ef923f60cb95c584dfbc2e |
| May 30, 2020 17:59 | https://github.com/nodejs/node/pull/33291#event-3389937228 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 30, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-636364463 |
| https://ci.nodejs.org/job/node-test-pull-request/31661/ | https://ci.nodejs.org/job/node-test-pull-request/31661/ |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| jasnell | https://github.com/jasnell |
|
May 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-56ff1ee |
|
| https://github.com/jasnell |
| src: extract AllocatedBuffer from env.h | https://github.com/nodejs/node/commit/56ff1ee55a57b1169dc567f0f51e58a6f2ccda6d |
| 56ff1ee | https://github.com/nodejs/node/commit/56ff1ee55a57b1169dc567f0f51e58a6f2ccda6d |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| jasnell | https://github.com/jasnell |
|
May 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-e2cd715 |
|
| https://github.com/jasnell |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/commit/e2cd71536161589dff96adf882970b9a33380f02 |
| e2cd715 | https://github.com/nodejs/node/commit/e2cd71536161589dff96adf882970b9a33380f02 |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| jasnell | https://github.com/jasnell |
|
May 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-830ef81 |
|
| https://github.com/jasnell |
| src: remove superfluous inline keywords | https://github.com/nodejs/node/commit/830ef8134160fdcbb96289af4a136b70d994f6d6 |
| 830ef81 | https://github.com/nodejs/node/commit/830ef8134160fdcbb96289af4a136b70d994f6d6 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 30, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-636397465 |
| 56ff1ee | https://github.com/nodejs/node/commit/56ff1ee55a57b1169dc567f0f51e58a6f2ccda6d |
| e2cd715 | https://github.com/nodejs/node/commit/e2cd71536161589dff96adf882970b9a33380f02 |
| 830ef81 | https://github.com/nodejs/node/commit/830ef8134160fdcbb96289af4a136b70d994f6d6 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 30, 2020 | https://github.com/nodejs/node/pull/33291#event-3390143156 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-d8f040e |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: extract AllocatedBuffer from env.h | https://github.com/nodejs/node/commit/d8f040e33d228c95f18aec463ba324f4f355d1d5 |
| d8f040e | https://github.com/nodejs/node/commit/d8f040e33d228c95f18aec463ba324f4f355d1d5 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-27e9cb7 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/commit/27e9cb7e85b9d17d0f331b936c36b5418a2800aa |
| 27e9cb7 | https://github.com/nodejs/node/commit/27e9cb7e85b9d17d0f331b936c36b5418a2800aa |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-7725ff3 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: remove superfluous inline keywords | https://github.com/nodejs/node/commit/7725ff392c7f650fbf8c9dd3fa794c9056854905 |
| 7725ff3 | https://github.com/nodejs/node/commit/7725ff392c7f650fbf8c9dd3fa794c9056854905 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 28, 2020
| https://github.com/nodejs/node/pull/33291#ref-pullrequest-646828333 |
|
v14.5.0 proposal
#34093
| https://github.com/nodejs/node/pull/34093 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-issue-647739563 |
|
SEGFAULT on Node Fermium
#34126
| https://github.com/nodejs/node/issues/34126 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-39f42d1 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: extract AllocatedBuffer from env.h | https://github.com/nodejs/node/commit/39f42d1a2d5c07fbef0e47b4b39cb91782c4e4ad |
| 39f42d1 | https://github.com/nodejs/node/commit/39f42d1a2d5c07fbef0e47b4b39cb91782c4e4ad |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-ee6ec14 |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: turn AllocatedBuffer into thin wrapper around v8::BackingStore | https://github.com/nodejs/node/commit/ee6ec14dda0151015e85fe9017221b645771b8c4 |
| ee6ec14 | https://github.com/nodejs/node/commit/ee6ec14dda0151015e85fe9017221b645771b8c4 |
| #33381 | https://github.com/nodejs/node/pull/33381 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| codebytere | https://github.com/codebytere |
|
Jun 30, 2020
| https://github.com/nodejs/node/pull/33291#ref-commit-0bd3c0a |
|
| https://github.com/jasnell |
|
| https://github.com/codebytere |
| src: remove superfluous inline keywords | https://github.com/nodejs/node/commit/0bd3c0a3ada80e34e8c755782307a5b01fa86cc4 |
| 0bd3c0a | https://github.com/nodejs/node/commit/0bd3c0a3ada80e34e8c755782307a5b01fa86cc4 |
| #33291 | https://github.com/nodejs/node/pull/33291 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Jul 8, 2020 | https://github.com/nodejs/node/pull/33291#issuecomment-655764971 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
backport-requested-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x |
| Jul 8, 2020 | https://github.com/nodejs/node/pull/33291#event-3527081673 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jul 10, 2020
| https://github.com/nodejs/node/pull/33291#ref-pullrequest-628542830 |
|
build: fix node.gyp config
#33685
| https://github.com/nodejs/node/pull/33685 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
|
Apr 21, 2021
| https://github.com/nodejs/node/pull/33291#ref-issue-861467217 |
|
Buffer.from(str) memory leak
#38300
| https://github.com/nodejs/node/issues/38300 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33291 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/33291/files/488a3739c3474e04d59bbfd49fe84f9f96058ca5 |
|
| https://github.com/devnexen |
|
devnexen
| https://github.com/devnexen |
|
| https://github.com/nodejs/node/pull/33291/files/488a3739c3474e04d59bbfd49fe84f9f96058ca5 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/33291 |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/BridgeAR |
|
| https://github.com/codebytere |
|
| https://github.com/devnexen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |