René's URL Explorer Experiment


Title: fs: fix memory corruption issues around fs.Dir by addaleax · Pull Request #33274 · nodejs/node · GitHub

Open Graph Title: fs: fix memory corruption issues around fs.Dir by addaleax · Pull Request #33274 · nodejs/node

X Title: fs: fix memory corruption issues around fs.Dir by addaleax · Pull Request #33274 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fs: clean up Dir.read() uv_fs_t data before calling into JS A call into JS can schedule another operation on the same uv_dir_t. In particular, when the handle is closed from the callback for a dire...

X Description: fs: clean up Dir.read() uv_fs_t data before calling into JS A call into JS can schedule another operation on the same uv_dir_t. In particular, when the handle is closed from the callback for a dire...

Opengraph URL: https://github.com/nodejs/node/pull/33274

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:781cbf22-3b2b-c29b-ad8e-3501747d77d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFFC:1E2715:2B4B67:380D4F:6AED1AEA
html-safe-nonce9e476cb6de53a1bae58693270a987c34c67fb74905e77a3086b39882b0f68443
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkZDOjFFMjcxNToyQjRCNjc6MzgwRDRGOjZBRUQxQUVBIiwidmlzaXRvcl9pZCI6IjcwNTkzNjQ1MzA0NzQ1MjMzNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac14abe29a12dd5ac3d2defe2144ac4f2d41935e20417b730f7df2267e03cf3897
hovercard-subject-tagpull_request:414407961
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33274/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/766bf5f8a63481bbff0aaeff48a66a9b6f4adbbc1785fb330d3b76e205082bec/nodejs/node/pull/33274
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/766bf5f8a63481bbff0aaeff48a66a9b6f4adbbc1785fb330d3b76e205082bec/nodejs/node/pull/33274
og:image:altfs: clean up Dir.read() uv_fs_t data before calling into JS A call into JS can schedule another operation on the same uv_dir_t. In particular, when the handle is closed from the callback for a dire...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33274#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33274
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33274
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33274
Reloadhttps://github.com/nodejs/node/pull/33274
Reloadhttps://github.com/nodejs/node/pull/33274
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:dir-clear-before-jshttps://github.com/addaleax/node/tree/dir-clear-before-js
Conversationhttps://github.com/nodejs/node/pull/33274
Commits2 (2)https://github.com/nodejs/node/pull/33274/commits
Checkshttps://github.com/nodejs/node/pull/33274/checks
Files changedhttps://github.com/nodejs/node/pull/33274/files
fs: fix memory corruption issues around fs.Dirhttps://github.com/nodejs/node/pull/33274#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:dir-clear-before-jshttps://github.com/addaleax/node/tree/dir-clear-before-js
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020https://github.com/nodejs/node/pull/33274#issue-613705388
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33274
addaleaxhttps://github.com/addaleax
May 7, 2020 03:05https://github.com/nodejs/node/pull/33274#commits-pushed-fa868cb
https://github.com/addaleax
fs: clean up Dir.read() uv_fs_t data before calling into JShttps://github.com/nodejs/node/pull/33274/commits/fa868cb77289b9eecb61a6fa904a969ff9d9b9a3
fa868cbhttps://github.com/nodejs/node/pull/33274/commits/fa868cb77289b9eecb61a6fa904a969ff9d9b9a3
https://github.com/addaleax
fs: forbid concurrent operations on Dir handlehttps://github.com/nodejs/node/pull/33274/commits/e287d24aaa94fc6de831cb54d707aebf0a01de30
e287d24https://github.com/nodejs/node/pull/33274/commits/e287d24aaa94fc6de831cb54d707aebf0a01de30
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 7, 2020https://github.com/nodejs/node/pull/33274#event-3310828896
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 7, 2020https://github.com/nodejs/node/pull/33274#event-3310829124
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2020https://github.com/nodejs/node/pull/33274#issuecomment-624971912
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://ci.nodejs.org/job/node-test-pull-request/31197/https://ci.nodejs.org/job/node-test-pull-request/31197/
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 7, 2020https://github.com/nodejs/node/pull/33274#issuecomment-624974428
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020 https://github.com/nodejs/node/pull/33274#ref-pullrequest-610253702
build: run full test suite in ASAN action #33170 https://github.com/nodejs/node/pull/33170
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020https://github.com/nodejs/node/pull/33274#issuecomment-624982685
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
May 7, 2020https://github.com/nodejs/node/pull/33274#event-3314921798
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33274#issuecomment-626092456
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 9, 2020 https://github.com/nodejs/node/pull/33274#pullrequestreview-408605102
View reviewed changes https://github.com/nodejs/node/pull/33274/files/e287d24aaa94fc6de831cb54d707aebf0a01de30
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
May 15, 2020https://github.com/nodejs/node/pull/33274#event-3339140466
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2020https://github.com/nodejs/node/pull/33274#issuecomment-629388999
441e703...d3a8a23https://github.com/nodejs/node/compare/441e703b2851be4c0f924907ff3c20cc4bab8588...d3a8a23089af06bb047bf9bad7531fbfc70f6314
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2020https://github.com/nodejs/node/pull/33274#event-3341920831
addaleaxhttps://github.com/addaleax
May 15, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-e9f2937
https://github.com/addaleax
fs: clean up Dir.read() uv_fs_t data before calling into JShttps://github.com/nodejs/node/commit/e9f293750760d59243020d0376edf242c9a26b67
e9f2937https://github.com/nodejs/node/commit/e9f293750760d59243020d0376edf242c9a26b67
#33274https://github.com/nodejs/node/pull/33274
addaleaxhttps://github.com/addaleax
May 15, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-d3a8a23
https://github.com/addaleax
fs: forbid concurrent operations on Dir handlehttps://github.com/nodejs/node/commit/d3a8a23089af06bb047bf9bad7531fbfc70f6314
d3a8a23https://github.com/nodejs/node/commit/d3a8a23089af06bb047bf9bad7531fbfc70f6314
#33274https://github.com/nodejs/node/pull/33274
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2020 17:37https://github.com/nodejs/node/pull/33274#event-3341921113
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-12391c7
https://github.com/addaleax
https://github.com/codebytere
fs: clean up Dir.read() uv_fs_t data before calling into JShttps://github.com/nodejs/node/commit/12391c7a20415bc691a4dfd124dc557f9b4eb18a
12391c7https://github.com/nodejs/node/commit/12391c7a20415bc691a4dfd124dc557f9b4eb18a
#33274https://github.com/nodejs/node/pull/33274
codebyterehttps://github.com/codebytere
May 16, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-c7c420e
https://github.com/addaleax
https://github.com/codebytere
fs: forbid concurrent operations on Dir handlehttps://github.com/nodejs/node/commit/c7c420ec87fb87a723ef967f6b4e24f9e8931dde
c7c420ehttps://github.com/nodejs/node/commit/c7c420ec87fb87a723ef967f6b4e24f9e8931dde
#33274https://github.com/nodejs/node/pull/33274
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33274#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-c21ebb2
https://github.com/addaleax
https://github.com/codebytere
fs: clean up Dir.read() uv_fs_t data before calling into JShttps://github.com/nodejs/node/commit/c21ebb23d81219e50e3fccffd1fce5f4b6288920
c21ebb2https://github.com/nodejs/node/commit/c21ebb23d81219e50e3fccffd1fce5f4b6288920
#33274https://github.com/nodejs/node/pull/33274
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-180a4c4
https://github.com/addaleax
https://github.com/codebytere
fs: forbid concurrent operations on Dir handlehttps://github.com/nodejs/node/commit/180a4c47255b09ba8e4d10c1fb50f0979f0b55a0
180a4c4https://github.com/nodejs/node/commit/180a4c47255b09ba8e4d10c1fb50f0979f0b55a0
#33274https://github.com/nodejs/node/pull/33274
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-aa4611c
https://github.com/addaleax
https://github.com/codebytere
fs: clean up Dir.read() uv_fs_t data before calling into JShttps://github.com/codebytere/node/commit/aa4611cccbcb197df51a9f7056d019005d91acf4
aa4611chttps://github.com/codebytere/node/commit/aa4611cccbcb197df51a9f7056d019005d91acf4
nodejs#33274https://github.com/nodejs/node/pull/33274
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33274#ref-commit-c129e88
https://github.com/addaleax
https://github.com/codebytere
fs: forbid concurrent operations on Dir handlehttps://github.com/codebytere/node/commit/c129e8809e209fcadad6912ad11bf478336948ce
c129e88https://github.com/codebytere/node/commit/c129e8809e209fcadad6912ad11bf478336948ce
nodejs#33274https://github.com/nodejs/node/pull/33274
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33274#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33274
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33274/files/e287d24aaa94fc6de831cb54d707aebf0a01de30
Please reload this pagehttps://github.com/nodejs/node/pull/33274
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/33274
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.