René's URL Explorer Experiment


Title: module: better error for named exports from cjs by MylesBorins · Pull Request #33256 · nodejs/node · GitHub

Open Graph Title: module: better error for named exports from cjs by MylesBorins · Pull Request #33256 · nodejs/node

X Title: module: better error for named exports from cjs by MylesBorins · Pull Request #33256 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We do not support importing named exports from a CJS module. This change decorates the error message for missing named exports in the case that the module being imported is expected to be CJS by th...

X Description: We do not support importing named exports from a CJS module. This change decorates the error message for missing named exports in the case that the module being imported is expected to be CJS by th...

Opengraph URL: https://github.com/nodejs/node/pull/33256

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8d1c5dd-1352-9bf7-2736-6fc077099176
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90B6:2B6F5F:2C82B57:3EB5EEF:6AED2B08
html-safe-nonce33d37a1a35f742f354d72b5191d3634b1098b66addfca1578ab51d35899db770
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEI2OjJCNkY1RjoyQzgyQjU3OjNFQjVFRUY6NkFFRDJCMDgiLCJ2aXNpdG9yX2lkIjoiNjIzOTY3NTQyOTM5Njc1MzE2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac80c6ec7a27341e41a66cfead154b86bf1a622f9bb49dcf29b2fb4341c1489e1f
hovercard-subject-tagpull_request:413732081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33256/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7e768bae437796a4df15e7cfa53e843443b3b5bab3a18e7633750cdd8fb64f8b/nodejs/node/pull/33256
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7e768bae437796a4df15e7cfa53e843443b3b5bab3a18e7633750cdd8fb64f8b/nodejs/node/pull/33256
og:image:altWe do not support importing named exports from a CJS module. This change decorates the error message for missing named exports in the case that the module being imported is expected to be CJS by th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMylesBorins
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33256#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33256
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33256
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33256
Reloadhttps://github.com/nodejs/node/pull/33256
Reloadhttps://github.com/nodejs/node/pull/33256
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
MylesBorinshttps://github.com/MylesBorins
nodejs:masterhttps://github.com/nodejs/node/tree/master
MylesBorins:better-cjs-named-export-errorhttps://github.com/MylesBorins/node/tree/better-cjs-named-export-error
Conversationhttps://github.com/nodejs/node/pull/33256
Commits1 (1)https://github.com/nodejs/node/pull/33256/commits
Checkshttps://github.com/nodejs/node/pull/33256/checks
Files changedhttps://github.com/nodejs/node/pull/33256/files
module: better error for named exports from cjshttps://github.com/nodejs/node/pull/33256#top
MylesBorinshttps://github.com/MylesBorins
nodejs:masterhttps://github.com/nodejs/node/tree/master
MylesBorins:better-cjs-named-export-errorhttps://github.com/MylesBorins/node/tree/better-cjs-named-export-error
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 5, 2020https://github.com/nodejs/node/pull/33256#issue-612869234
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
May 5, 2020https://github.com/nodejs/node/pull/33256#event-3305861314
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
May 5, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624286800
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/mathiasbynens
mathiasbynenshttps://github.com/mathiasbynens
May 5, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406129048
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 5, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624288600
@guybedfordhttps://github.com/guybedford
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 5, 2020 https://github.com/nodejs/node/pull/33256#ref-issue-611585550
Rediscussion for out-of-order CJS exec? nodejs/modules#509 https://github.com/nodejs/modules/issues/509
https://github.com/ljharb
ljharbhttps://github.com/ljharb
May 5, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406172669
View reviewed changes https://github.com/nodejs/node/pull/33256/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/33256#pullrequestreview-406172669
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406174384
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 5, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624320482
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 5, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406174816
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624320990
@GeoffreyBoothhttps://github.com/GeoffreyBooth
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 5, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624335474
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 6, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406288808
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/util.jshttps://github.com/nodejs/node/pull/33256/files#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 6, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624428419
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/ljharb
ljharbhttps://github.com/ljharb
May 6, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406311711
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/util.jshttps://github.com/nodejs/node/pull/33256/files#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
May 6, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624546636
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 6, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624701371
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/mafintosh
mafintoshhttps://github.com/mafintosh
May 6, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624731035
@MylesBorinshttps://github.com/MylesBorins
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/ljharb
ljharbhttps://github.com/ljharb
May 6, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-406865894
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 6, 2020https://github.com/nodejs/node/pull/33256#issuecomment-624898138
…https://github.com/nodejs/node/pull/33256
#33256 (comment)https://github.com/nodejs/node/pull/33256#discussion_r421098237
#33256 (comment)https://github.com/nodejs/node/pull/33256#discussion_r421098237
https://github.com/notifications/unsubscribe-auth/AADZYVZE2I67XE62JGFUFMLRQHHYTANCNFSM4MZ4EM7Qhttps://github.com/notifications/unsubscribe-auth/AADZYVZE2I67XE62JGFUFMLRQHHYTANCNFSM4MZ4EM7Q
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 6, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407029909
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/util.jshttps://github.com/nodejs/node/pull/33256/files#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 7, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407145596
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/util.jshttps://github.com/nodejs/node/pull/33256/files#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/69199b7f5875080992a20fb8989db88ddceec62e..7a4082148ec15ffa230f78a9524a8acb8d83d598
69199b7https://github.com/nodejs/node/commit/69199b7f5875080992a20fb8989db88ddceec62e
7a40821https://github.com/nodejs/node/commit/7a4082148ec15ffa230f78a9524a8acb8d83d598
Compare https://github.com/nodejs/node/compare/69199b7f5875080992a20fb8989db88ddceec62e..7a4082148ec15ffa230f78a9524a8acb8d83d598
May 7, 2020 06:45https://github.com/nodejs/node/pull/33256#event-3311442701
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 7, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625063826
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/targos
targoshttps://github.com/targos
May 7, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625067044
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/ljharb
ljharbhttps://github.com/ljharb
May 7, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407194505
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/ljharb
ljharbhttps://github.com/ljharb
May 7, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407201422
View reviewed changes https://github.com/nodejs/node/pull/33256/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/33256#pullrequestreview-407201422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/util.jshttps://github.com/nodejs/node/pull/33256/files#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 7, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625111236
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 7, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407262374
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 7, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407264084
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407891731
View reviewed changes https://github.com/nodejs/node/pull/33256/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/33256#pullrequestreview-407891731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625538095
https://ci.nodejs.org/job/node-test-pull-request/31215/https://ci.nodejs.org/job/node-test-pull-request/31215/
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
May 8, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407964929
View reviewed changes https://github.com/nodejs/node/pull/33256/files
test/es-module/test-esm-cjs-named-error.mjshttps://github.com/nodejs/node/pull/33256/files#diff-7d57c5f9b5a77128d443e653d6e7fc945287665ba45123d67060e0deba941b97
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/603a87934ff4a6f12bac1f1e517f7a1c54e9bdbf..06cdf08b337a2aef127f18f2f6ffab74aa7a18f6
603a879https://github.com/nodejs/node/commit/603a87934ff4a6f12bac1f1e517f7a1c54e9bdbf
06cdf08https://github.com/nodejs/node/commit/06cdf08b337a2aef127f18f2f6ffab74aa7a18f6
Compare https://github.com/nodejs/node/compare/603a87934ff4a6f12bac1f1e517f7a1c54e9bdbf..06cdf08b337a2aef127f18f2f6ffab74aa7a18f6
May 8, 2020 05:06https://github.com/nodejs/node/pull/33256#event-3315597718
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625632830
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625633272
https://ci.nodejs.org/job/node-test-pull-request/31236/https://ci.nodejs.org/job/node-test-pull-request/31236/
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/ljharb
ljharbhttps://github.com/ljharb
May 8, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-407998311
View reviewed changes https://github.com/nodejs/node/pull/33256/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/33256#pullrequestreview-407998311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
test/fixtures/es-modules/package-cjs-named-error/json-hack/fail.jshttps://github.com/nodejs/node/pull/33256/files#diff-ca5ed256cbfcea20e08ce34c24e3eff748c61803bde409b5621a8b90b2e0c318
ljharbhttps://github.com/ljharb
May 8, 2020https://github.com/nodejs/node/pull/33256#discussion_r421940626
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
DerekNonGenerichttps://github.com/DerekNonGeneric
May 8, 2020https://github.com/nodejs/node/pull/33256#discussion_r421952675
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
ljharbhttps://github.com/ljharb
May 8, 2020https://github.com/nodejs/node/pull/33256#discussion_r421959713
Please reload this pagehttps://github.com/nodejs/node/pull/33256
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/targos
targoshttps://github.com/targos
May 8, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-408029081
View reviewed changes https://github.com/nodejs/node/pull/33256/files
lib/internal/modules/esm/module_job.jshttps://github.com/nodejs/node/pull/33256/files#diff-96737fe4ad6eeaa04f6a92ff3d6c51e31b0145292df8e3cd044d77a5851acc6c
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/targos
targoshttps://github.com/targos
May 8, 2020 https://github.com/nodejs/node/pull/33256#pullrequestreview-408033531
View reviewed changes https://github.com/nodejs/node/pull/33256/files
https://github.com/MylesBorins
module: better error for named exports from cjshttps://github.com/nodejs/node/pull/33256/commits/75f08f9888a5b5ef564f5f2db7aef0c3f353e449
75f08f9https://github.com/nodejs/node/pull/33256/commits/75f08f9888a5b5ef564f5f2db7aef0c3f353e449
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/d0df6abbf5205f08bd421065e10dccf16979126f..75f08f9888a5b5ef564f5f2db7aef0c3f353e449
d0df6abhttps://github.com/nodejs/node/commit/d0df6abbf5205f08bd421065e10dccf16979126f
75f08f9https://github.com/nodejs/node/commit/75f08f9888a5b5ef564f5f2db7aef0c3f353e449
Compare https://github.com/nodejs/node/compare/d0df6abbf5205f08bd421065e10dccf16979126f..75f08f9888a5b5ef564f5f2db7aef0c3f353e449
May 8, 2020 15:42https://github.com/nodejs/node/pull/33256#event-3317438734
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625878145
https://ci.nodejs.org/job/node-test-pull-request/31242/https://ci.nodejs.org/job/node-test-pull-request/31242/
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625894724
https://ci.nodejs.org/job/node-test-pull-request/31243/https://ci.nodejs.org/job/node-test-pull-request/31243/
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625919056
Please reload this pagehttps://github.com/nodejs/node/pull/33256
MylesBorinshttps://github.com/MylesBorins
May 8, 2020 https://github.com/nodejs/node/pull/33256#ref-commit-2c3c9f5
https://github.com/MylesBorins
module: better error for named exports from cjshttps://github.com/nodejs/node/commit/2c3c9f5a3f6d54230dcc65efacb5b57d0979b462
2c3c9f5https://github.com/nodejs/node/commit/2c3c9f5a3f6d54230dcc65efacb5b57d0979b462
#33256https://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2020https://github.com/nodejs/node/pull/33256#issuecomment-625982412
2c3c9f5https://github.com/nodejs/node/commit/2c3c9f5a3f6d54230dcc65efacb5b57d0979b462
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2020https://github.com/nodejs/node/pull/33256#event-3318173490
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33256#ref-commit-ad86807
https://github.com/MylesBorins
https://github.com/codebytere
module: better error for named exports from cjshttps://github.com/nodejs/node/commit/ad8680773e7cfecf6c90b97e055eb92dd886c667
ad86807https://github.com/nodejs/node/commit/ad8680773e7cfecf6c90b97e055eb92dd886c667
#33256https://github.com/nodejs/node/pull/33256
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33256#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33256#ref-commit-77caf92
https://github.com/MylesBorins
https://github.com/codebytere
module: better error for named exports from cjshttps://github.com/nodejs/node/commit/77caf92314a803ad788939650ff63d24d18cbb7b
77caf92https://github.com/nodejs/node/commit/77caf92314a803ad788939650ff63d24d18cbb7b
#33256https://github.com/nodejs/node/pull/33256
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33256#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.com/ctavan
ctavanhttps://github.com/ctavan
Sep 18, 2020 https://github.com/nodejs/node/pull/33256#ref-issue-704441498
module: improve error decoration for cjs named exports for multi-line import statements #35259 https://github.com/nodejs/node/issues/35259
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33256
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/33256/files/32f6520dd0d45e4948ae7e69242c79b8edcf61fb
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/33256/files/352350c79570e0acf4ebc81249a1e6d535b0ade9
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/33256/files/de38cdbc9c5a0a9e1a044bec772397e713e1ace2
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33256/files/352350c79570e0acf4ebc81249a1e6d535b0ade9
https://github.com/mathiasbynens
mathiasbynens https://github.com/mathiasbynens
https://github.com/nodejs/node/pull/33256/files/a20f379fc3a53362d33e7581ea5042468ae981aa
https://github.com/pipobscure
pipobscure https://github.com/pipobscure
https://github.com/nodejs/node/pull/33256/files/a20f379fc3a53362d33e7581ea5042468ae981aa
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/33256/files/a20f379fc3a53362d33e7581ea5042468ae981aa
https://github.com/DerekNonGeneric
DerekNonGeneric https://github.com/DerekNonGeneric
https://github.com/nodejs/node/pull/33256/files/32f6520dd0d45e4948ae7e69242c79b8edcf61fb
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/33256/files/32f6520dd0d45e4948ae7e69242c79b8edcf61fb
Please reload this pagehttps://github.com/nodejs/node/pull/33256
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Please reload this pagehttps://github.com/nodejs/node/pull/33256
https://github.com/MylesBorins
https://github.com/guybedford
https://github.com/GeoffreyBooth
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/mafintosh
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/ljharb
https://github.com/mathiasbynens
https://github.com/pipobscure
https://github.com/hybrist
https://github.com/devsnek
https://github.com/DerekNonGeneric
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.