René's URL Explorer Experiment


Title: wasi: prevent syscalls before start by tniessen · Pull Request #33235 · nodejs/node · GitHub

Open Graph Title: wasi: prevent syscalls before start by tniessen · Pull Request #33235 · nodejs/node

X Title: wasi: prevent syscalls before start by tniessen · Pull Request #33235 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Calling instance.exports._start() crashes the process with a segmentation fault. This prevents syscalls before start() has been called. Checklist make -j4 test (UNIX), or vcbuild test (Windows)...

X Description: Calling instance.exports._start() crashes the process with a segmentation fault. This prevents syscalls before start() has been called. Checklist make -j4 test (UNIX), or vcbuild test (Windows)...

Opengraph URL: https://github.com/nodejs/node/pull/33235

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:56d56363-6c3f-2a67-8663-4cbc53546704
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E78:17D884:29AC1D:364C48:6AED1B0F
html-safe-nonce11cc0018cf6e81ce3740566906c0a7d0fd463099edb97ebd4de0772c63e9dfbb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTc4OjE3RDg4NDoyOUFDMUQ6MzY0QzQ4OjZBRUQxQjBGIiwidmlzaXRvcl9pZCI6IjEwMzUzNTY3MjgxMTE5OTU2NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd2c1a6274a1642c576ffce35e23406a59f8a6348d52d125a0819caf4bb91b404
hovercard-subject-tagpull_request:413056929
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33235/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aaaabe6f6b9119094f3c98e86d27a7e380dbe765d9c535be5da6e4bbab88b14d/nodejs/node/pull/33235
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aaaabe6f6b9119094f3c98e86d27a7e380dbe765d9c535be5da6e4bbab88b14d/nodejs/node/pull/33235
og:image:altCalling instance.exports._start() crashes the process with a segmentation fault. This prevents syscalls before start() has been called. Checklist make -j4 test (UNIX), or vcbuild test (Windows)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33235#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33235
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33235
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33235
Reloadhttps://github.com/nodejs/node/pull/33235
Reloadhttps://github.com/nodejs/node/pull/33235
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:wasi-check-startedhttps://github.com/tniessen/node/tree/wasi-check-started
Conversationhttps://github.com/nodejs/node/pull/33235
Commits3 (3)https://github.com/nodejs/node/pull/33235/commits
Checkshttps://github.com/nodejs/node/pull/33235/checks
Files changedhttps://github.com/nodejs/node/pull/33235/files
wasi: prevent syscalls before starthttps://github.com/nodejs/node/pull/33235#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:wasi-check-startedhttps://github.com/tniessen/node/tree/wasi-check-started
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 4, 2020https://github.com/nodejs/node/pull/33235#issue-612008961
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33235
https://github.com/tniessen
wasi: prevent syscalls before starthttps://github.com/nodejs/node/pull/33235/commits/d17c310401d0fd5375380d01ff8858cef866628c
d17c310https://github.com/nodejs/node/pull/33235/commits/d17c310401d0fd5375380d01ff8858cef866628c
https://github.com/tniessen
tniessenhttps://github.com/tniessen
cjihrighttps://github.com/cjihrig
May 4, 2020 16:32https://github.com/nodejs/node/pull/33235#event-3300706437
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
wasi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi
May 4, 2020https://github.com/nodejs/node/pull/33235#event-3300706679
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 4, 2020https://github.com/nodejs/node/pull/33235#issuecomment-623572410
#33184https://github.com/nodejs/node/pull/33184
Please reload this pagehttps://github.com/nodejs/node/pull/33235
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 4, 2020 https://github.com/nodejs/node/pull/33235#ref-pullrequest-610512328
wasi: avoid hard crash if start() is never called #33184 https://github.com/nodejs/node/pull/33184
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 4, 2020 https://github.com/nodejs/node/pull/33235#pullrequestreview-405171971
View reviewed changes https://github.com/nodejs/node/pull/33235/files/d17c310401d0fd5375380d01ff8858cef866628c
src/node_errors.hhttps://github.com/nodejs/node/pull/33235/files/d17c310401d0fd5375380d01ff8858cef866628c#diff-28f58d089c794577a7dbd65432de6f1eab5b00f5470626cccdb7656ddd481fb2
Please reload this pagehttps://github.com/nodejs/node/pull/33235
https://github.com/tniessen
https://github.com/cjihrig
Update src/node_errors.hhttps://github.com/nodejs/node/pull/33235/commits/425ee11411ee454cce24f2e74f42a5e82c27db48
425ee11https://github.com/nodejs/node/pull/33235/commits/425ee11411ee454cce24f2e74f42a5e82c27db48
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 4, 2020 https://github.com/nodejs/node/pull/33235#pullrequestreview-405227839
View reviewed changes https://github.com/nodejs/node/pull/33235/files/425ee11411ee454cce24f2e74f42a5e82c27db48
test/wasi/test-wasi-not-started.jshttps://github.com/nodejs/node/pull/33235/files/425ee11411ee454cce24f2e74f42a5e82c27db48#diff-7a7cfa6efdc2c7fd33e98c1e34cae275bc71dd0389c205a0d8d104c82b7cceb4
Please reload this pagehttps://github.com/nodejs/node/pull/33235
https://github.com/tniessen
Update test/wasi/test-wasi-not-started.jshttps://github.com/nodejs/node/pull/33235/commits/6f6128e51a3eee4c1e385ad30c3d7af906b48958
6f6128ehttps://github.com/nodejs/node/pull/33235/commits/6f6128e51a3eee4c1e385ad30c3d7af906b48958
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 4, 2020 https://github.com/nodejs/node/pull/33235#pullrequestreview-405253855
View reviewed changes https://github.com/nodejs/node/pull/33235/files/6f6128e51a3eee4c1e385ad30c3d7af906b48958
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2020 https://github.com/nodejs/node/pull/33235#pullrequestreview-405857834
View reviewed changes https://github.com/nodejs/node/pull/33235/files/6f6128e51a3eee4c1e385ad30c3d7af906b48958
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2020https://github.com/nodejs/node/pull/33235#issuecomment-624891612
https://ci.nodejs.org/job/node-test-pull-request/31194/https://ci.nodejs.org/job/node-test-pull-request/31194/
Please reload this pagehttps://github.com/nodejs/node/pull/33235
addaleaxhttps://github.com/addaleax
May 7, 2020 https://github.com/nodejs/node/pull/33235#ref-commit-c01544d
https://github.com/tniessen
https://github.com/addaleax
wasi: prevent syscalls before starthttps://github.com/nodejs/node/commit/c01544de1f0ed033327861d65ddb5cb94ea1fb94
c01544dhttps://github.com/nodejs/node/commit/c01544de1f0ed033327861d65ddb5cb94ea1fb94
#33235https://github.com/nodejs/node/pull/33235
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020https://github.com/nodejs/node/pull/33235#issuecomment-625539856
c01544dhttps://github.com/nodejs/node/commit/c01544de1f0ed033327861d65ddb5cb94ea1fb94
Please reload this pagehttps://github.com/nodejs/node/pull/33235
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020https://github.com/nodejs/node/pull/33235#event-3314958801
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33235#ref-commit-4465d23
https://github.com/tniessen
https://github.com/codebytere
wasi: prevent syscalls before starthttps://github.com/nodejs/node/commit/4465d23c30f36a385b751f7af03eadd89bb3e60c
4465d23https://github.com/nodejs/node/commit/4465d23c30f36a385b751f7af03eadd89bb3e60c
#33235https://github.com/nodejs/node/pull/33235
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33235#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33235#ref-commit-33aacbe
https://github.com/tniessen
https://github.com/codebytere
wasi: prevent syscalls before starthttps://github.com/nodejs/node/commit/33aacbefb1387e94200ce793b9faa7663df50400
33aacbehttps://github.com/nodejs/node/commit/33aacbefb1387e94200ce793b9faa7663df50400
#33235https://github.com/nodejs/node/pull/33235
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33235#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33235
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33235/files/6f6128e51a3eee4c1e385ad30c3d7af906b48958
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33235/files/d17c310401d0fd5375380d01ff8858cef866628c
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/33235/files/6f6128e51a3eee4c1e385ad30c3d7af906b48958
Please reload this pagehttps://github.com/nodejs/node/pull/33235
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
wasi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi
Please reload this pagehttps://github.com/nodejs/node/pull/33235
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/devsnek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.