René's URL Explorer Experiment


Title: buffer: improve copy() performance by seishun · Pull Request #33214 · nodejs/node · GitHub

Open Graph Title: buffer: improve copy() performance by seishun · Pull Request #33214 · nodejs/node

X Title: buffer: improve copy() performance by seishun · Pull Request #33214 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: There is no need to create a slice when sourceEnd is out of bounds. Results of included benchmark: confidence improvement ...

X Description: There is no need to create a slice when sourceEnd is out of bounds. Results of included benchmark: confidence improvement ...

Opengraph URL: https://github.com/nodejs/node/pull/33214

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dcec4524-2689-9546-5208-4c98e1aeac5d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB672:3E0336:69CB42:89BCC5:6AED2E10
html-safe-nonce65db597ab4da366cd0d9da28eeb08d013a50a8fb1f11f1a14cb80f1324f5b582
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjcyOjNFMDMzNjo2OUNCNDI6ODlCQ0M1OjZBRUQyRTEwIiwidmlzaXRvcl9pZCI6IjMxNDgzMjMyNjU4NDczMDc3OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace17f39d73e7c8ae67916f89b4b2ac0f46f2e3204bec013b5a8c8d6807ea102de
hovercard-subject-tagpull_request:412483929
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33214/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7d2441345aaa8e29b571fde4a99d307577911494968f9abf88eb2fc00b16108e/nodejs/node/pull/33214
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d2441345aaa8e29b571fde4a99d307577911494968f9abf88eb2fc00b16108e/nodejs/node/pull/33214
og:image:altThere is no need to create a slice when sourceEnd is out of bounds. Results of included benchmark: confidence improvement ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameseishun
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33214#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33214
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33214
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33214
Reloadhttps://github.com/nodejs/node/pull/33214
Reloadhttps://github.com/nodejs/node/pull/33214
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
seishunhttps://github.com/seishun
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/33214
Commits2 (2)https://github.com/nodejs/node/pull/33214/commits
Checkshttps://github.com/nodejs/node/pull/33214/checks
Files changedhttps://github.com/nodejs/node/pull/33214/files
buffer: improve copy() performancehttps://github.com/nodejs/node/pull/33214#top
seishunhttps://github.com/seishun
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/seishun
seishunhttps://github.com/seishun
May 2, 2020https://github.com/nodejs/node/pull/33214#issue-611238644
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33214
https://github.com/seishun
buffer: improve copy() performancehttps://github.com/nodejs/node/pull/33214/commits/3aa630d81aa9a39239559afc364b9605f988205d
3aa630dhttps://github.com/nodejs/node/pull/33214/commits/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
May 2, 2020https://github.com/nodejs/node/pull/33214#event-3296467789
https://github.com/seishun
seishunhttps://github.com/seishun
mscdexhttps://github.com/mscdex
May 2, 2020 17:39https://github.com/nodejs/node/pull/33214#event-3296468014
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 2, 2020 https://github.com/nodejs/node/pull/33214#pullrequestreview-404549664
View reviewed changes https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 3, 2020 https://github.com/nodejs/node/pull/33214#pullrequestreview-404575952
View reviewed changes https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/himself65
himself65https://github.com/himself65
May 3, 2020 https://github.com/nodejs/node/pull/33214#pullrequestreview-404576455
View reviewed changes https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 3, 2020 https://github.com/nodejs/node/pull/33214#pullrequestreview-404593774
View reviewed changes https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 3, 2020 https://github.com/nodejs/node/pull/33214#pullrequestreview-404630083
View reviewed changes https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
benchmark/buffers/buffer-copy.jshttps://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d#diff-6a5265030b644f09273457f24c77b836addb807aa83a1f81f3fd5326c88e00ef
Please reload this pagehttps://github.com/nodejs/node/pull/33214
https://github.com/seishun
remove benchmarkhttps://github.com/nodejs/node/pull/33214/commits/621eb2358a54521bbd5f96ef4b9db338e367acab
621eb23https://github.com/nodejs/node/pull/33214/commits/621eb2358a54521bbd5f96ef4b9db338e367acab
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 7, 2020https://github.com/nodejs/node/pull/33214#event-3314975601
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2020https://github.com/nodejs/node/pull/33214#issuecomment-625542258
https://ci.nodejs.org/job/node-test-pull-request/31218/https://ci.nodejs.org/job/node-test-pull-request/31218/
Please reload this pagehttps://github.com/nodejs/node/pull/33214
addaleaxhttps://github.com/addaleax
May 9, 2020 https://github.com/nodejs/node/pull/33214#ref-commit-339690c
https://github.com/seishun
https://github.com/addaleax
buffer: improve copy() performancehttps://github.com/nodejs/node/commit/339690ce9b78da84bf9ea1b4dc9107da91ee4041
339690chttps://github.com/nodejs/node/commit/339690ce9b78da84bf9ea1b4dc9107da91ee4041
#33214https://github.com/nodejs/node/pull/33214
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33214#issuecomment-626112538
339690chttps://github.com/nodejs/node/commit/339690ce9b78da84bf9ea1b4dc9107da91ee4041
Please reload this pagehttps://github.com/nodejs/node/pull/33214
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33214#event-3319044340
https://github.com/seishun
seishunhttps://github.com/seishun
May 9, 2020 14:06https://github.com/nodejs/node/pull/33214#event-3319418019
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33214#ref-commit-cae2051
https://github.com/seishun
https://github.com/codebytere
buffer: improve copy() performancehttps://github.com/nodejs/node/commit/cae2051b832d6f836d6ab9bc5752113fc01fc0c8
cae2051https://github.com/nodejs/node/commit/cae2051b832d6f836d6ab9bc5752113fc01fc0c8
#33214https://github.com/nodejs/node/pull/33214
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33214#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33214#ref-commit-964adfa
https://github.com/seishun
https://github.com/codebytere
buffer: improve copy() performancehttps://github.com/nodejs/node/commit/964adfafa56ba2601d7c18f754a3476894ab8224
964adfahttps://github.com/nodejs/node/commit/964adfafa56ba2601d7c18f754a3476894ab8224
#33214https://github.com/nodejs/node/pull/33214
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33214#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33214
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/33214/files/3aa630d81aa9a39239559afc364b9605f988205d
https://github.com/mscdex
mscdex https://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/33214
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Please reload this pagehttps://github.com/nodejs/node/pull/33214
https://github.com/seishun
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/BridgeAR
https://github.com/himself65
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.