René's URL Explorer Experiment


Title: doc: add warning for socket.connect reuse by ronag · Pull Request #33204 · nodejs/node · GitHub

Open Graph Title: doc: add warning for socket.connect reuse by ronag · Pull Request #33204 · nodejs/node

X Title: doc: add warning for socket.connect reuse by ronag · Pull Request #33204 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: socket.connect is subtly broken due to timing and _undestroy issues. Discourage usage and ask users to instead create a new socket instance. Note, this is a problem when calling connect a second ti...

X Description: socket.connect is subtly broken due to timing and _undestroy issues. Discourage usage and ask users to instead create a new socket instance. Note, this is a problem when calling connect a second ti...

Opengraph URL: https://github.com/nodejs/node/pull/33204

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:94713f81-37b1-e8e2-58d9-b778e518d560
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDD4:12F69A:293F5B:359735:6AED1B02
html-safe-nonce5eed27ff0ea771aef21d622513f987cc52cfb9a63b76a8518be5599a097ad802
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREQ0OjEyRjY5QToyOTNGNUI6MzU5NzM1OjZBRUQxQjAyIiwidmlzaXRvcl9pZCI6Ijk0NzQyMjg3NzY1ODcxNjkzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdb3b582308bfeaf6602481a5ad35a741d1abf583ceaf8f9ab76c901902c65855
hovercard-subject-tagpull_request:412312095
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33204/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/64529a7ca3fc3961565a7c0d5b37759784df01a3baf03e3f98236d0d76194c1a/nodejs/node/pull/33204
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64529a7ca3fc3961565a7c0d5b37759784df01a3baf03e3f98236d0d76194c1a/nodejs/node/pull/33204
og:image:altsocket.connect is subtly broken due to timing and _undestroy issues. Discourage usage and ask users to instead create a new socket instance. Note, this is a problem when calling connect a second ti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33204#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33204
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33204
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33204
Reloadhttps://github.com/nodejs/node/pull/33204
Reloadhttps://github.com/nodejs/node/pull/33204
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:deprecate-socket-connecthttps://github.com/nxtedition/node/tree/deprecate-socket-connect
Conversationhttps://github.com/nodejs/node/pull/33204
Commits4 (4)https://github.com/nodejs/node/pull/33204/commits
Checkshttps://github.com/nodejs/node/pull/33204/checks
Files changedhttps://github.com/nodejs/node/pull/33204/files
doc: add warning for socket.connect reusehttps://github.com/nodejs/node/pull/33204#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:deprecate-socket-connecthttps://github.com/nxtedition/node/tree/deprecate-socket-connect
https://github.com/ronag
ronaghttps://github.com/ronag
May 1, 2020https://github.com/nodejs/node/pull/33204#issue-610982446
Please reload this pagehttps://github.com/nodejs/node/pull/33204
#25969https://github.com/nodejs/node/issues/25969
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
May 1, 2020 21:41https://github.com/nodejs/node/pull/33204#event-3294555456
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
May 1, 2020https://github.com/nodejs/node/pull/33204#event-3294555540
https://github.com/ronag
doc: deprecate socket.connecthttps://github.com/nodejs/node/pull/33204/commits/76bf3ddee7f1714c924e648b2aaad0e36222d9b5
76bf3ddhttps://github.com/nodejs/node/pull/33204/commits/76bf3ddee7f1714c924e648b2aaad0e36222d9b5
nodejs#33203https://github.com/nodejs/node/pull/33203
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d44867183ed4f73f3e48d7a4cbe2a68eec007a35..76bf3ddee7f1714c924e648b2aaad0e36222d9b5
d448671https://github.com/nodejs/node/commit/d44867183ed4f73f3e48d7a4cbe2a68eec007a35
76bf3ddhttps://github.com/nodejs/node/commit/76bf3ddee7f1714c924e648b2aaad0e36222d9b5
Compare https://github.com/nodejs/node/compare/d44867183ed4f73f3e48d7a4cbe2a68eec007a35..76bf3ddee7f1714c924e648b2aaad0e36222d9b5
May 1, 2020 21:41https://github.com/nodejs/node/pull/33204#event-3294556079
https://github.com/ronag
ronaghttps://github.com/ronag
May 1, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622580841
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 1, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622587232
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
bnoordhuishttps://github.com/bnoordhuis
May 1, 2020 22:12https://github.com/nodejs/node/pull/33204#event-3294616943
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 1, 2020 https://github.com/nodejs/node/pull/33204#pullrequestreview-404427080
View reviewed changes https://github.com/nodejs/node/pull/33204/files/76bf3ddee7f1714c924e648b2aaad0e36222d9b5
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/33204#pullrequestreview-404427080
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/Trott
Trotthttps://github.com/Trott
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
May 1, 2020https://github.com/nodejs/node/pull/33204#event-3294760960
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 1, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622612850
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 1, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622613403
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 2, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622648145
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 2, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622795699
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 2, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622796402
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 2, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622935341
#25969https://github.com/nodejs/node/issues/25969
#25969https://github.com/nodejs/node/issues/25969
53fb7af1b2https://github.com/nodejs/node/commit/53fb7af1b2
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 2, 2020https://github.com/nodejs/node/pull/33204#issuecomment-622936892
Please reload this pagehttps://github.com/nodejs/node/pull/33204
#25969https://github.com/nodejs/node/issues/25969
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 4, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623403218
0618f02https://github.com/nodejs/node/commit/0618f02f6f2fa326cef971522fc8d5066d7c38f3
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 4, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623708421
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623951585
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623953126
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623958739
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623974918
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623982033
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
Revert "doc: deprecate socket.connect"https://github.com/nodejs/node/pull/33204/commits/32939548885f285afd2bf91ff4e9d38720e78a3d
3293954https://github.com/nodejs/node/pull/33204/commits/32939548885f285afd2bf91ff4e9d38720e78a3d
76bf3ddhttps://github.com/nxtedition/node/commit/76bf3ddee7f1714c924e648b2aaad0e36222d9b5
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-623990128
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/2071fb9ed74a0870fc4aa2064f02f5183cc3f45e..b4c24ef0a22e9e0ae32a348a1ee876ac9875f9e7
2071fb9https://github.com/nodejs/node/commit/2071fb9ed74a0870fc4aa2064f02f5183cc3f45e
b4c24efhttps://github.com/nodejs/node/commit/b4c24ef0a22e9e0ae32a348a1ee876ac9875f9e7
Compare https://github.com/nodejs/node/compare/2071fb9ed74a0870fc4aa2064f02f5183cc3f45e..b4c24ef0a22e9e0ae32a348a1ee876ac9875f9e7
May 5, 2020 11:07https://github.com/nodejs/node/pull/33204#event-3303719460
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624200712
@sam-githubhttps://github.com/sam-github
@jasnellhttps://github.com/jasnell
@mscdexhttps://github.com/mscdex
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 5, 2020 https://github.com/nodejs/node/pull/33204#pullrequestreview-406041499
View reviewed changes https://github.com/nodejs/node/pull/33204/files/11ae8f421976017dd22ffe764590a11be6fca13a
doc/api/net.mdhttps://github.com/nodejs/node/pull/33204/files/11ae8f421976017dd22ffe764590a11be6fca13a#diff-d76469e9e7f555294a7a5488c5c8fc4ef8ce5aea448cc26a1322d1ab693e09ca
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 5, 2020 https://github.com/nodejs/node/pull/33204#pullrequestreview-406044666
View reviewed changes https://github.com/nodejs/node/pull/33204/files/11ae8f421976017dd22ffe764590a11be6fca13a
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624245549
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624248236
Please reload this pagehttps://github.com/nodejs/node/pull/33204
#33204 (comment)https://github.com/nodejs/node/pull/33204#issuecomment-624269807
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624250267
Please reload this pagehttps://github.com/nodejs/node/pull/33204
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624267738
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624269807
#33137https://github.com/nodejs/node/pull/33137
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
May 5, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624277633
#33204 (comment)https://github.com/nodejs/node/pull/33204#issuecomment-624250267
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/0382a341b1e7d30331013a31361eb36427f2a38c..3d26329cbb3f919bca3e7edfb867aaf900b664ea
0382a34https://github.com/nodejs/node/commit/0382a341b1e7d30331013a31361eb36427f2a38c
3d26329https://github.com/nodejs/node/commit/3d26329cbb3f919bca3e7edfb867aaf900b664ea
Compare https://github.com/nodejs/node/compare/0382a341b1e7d30331013a31361eb36427f2a38c..3d26329cbb3f919bca3e7edfb867aaf900b664ea
May 6, 2020 20:42https://github.com/nodejs/node/pull/33204#event-3310217654
https://github.com/ronag
ronaghttps://github.com/ronag
May 6, 2020https://github.com/nodejs/node/pull/33204#issuecomment-624880197
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
fixuphttps://github.com/nodejs/node/pull/33204/commits/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
74430cehttps://github.com/nodejs/node/pull/33204/commits/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/3d26329cbb3f919bca3e7edfb867aaf900b664ea..74430ce8a2e8abdfc427c2ccb0aae85aace4b265
3d26329https://github.com/nodejs/node/commit/3d26329cbb3f919bca3e7edfb867aaf900b664ea
74430cehttps://github.com/nodejs/node/commit/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
Compare https://github.com/nodejs/node/compare/3d26329cbb3f919bca3e7edfb867aaf900b664ea..74430ce8a2e8abdfc427c2ccb0aae85aace4b265
May 6, 2020 20:43https://github.com/nodejs/node/pull/33204#event-3310220159
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2020 https://github.com/nodejs/node/pull/33204#pullrequestreview-407898681
View reviewed changes https://github.com/nodejs/node/pull/33204/files/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
https://github.com/ronag
ronaghttps://github.com/ronag
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
May 8, 2020https://github.com/nodejs/node/pull/33204#event-3316534075
https://github.com/ronag
ronaghttps://github.com/ronag
jasnellhttps://github.com/jasnell
lpincahttps://github.com/lpinca
May 8, 2020 11:00https://github.com/nodejs/node/pull/33204#event-3316535235
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 8, 2020https://github.com/nodejs/node/pull/33204#event-3316536801
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 8, 2020 https://github.com/nodejs/node/pull/33204#pullrequestreview-408169319
View reviewed changes https://github.com/nodejs/node/pull/33204/files/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 8, 2020 https://github.com/nodejs/node/pull/33204#pullrequestreview-408336956
View reviewed changes https://github.com/nodejs/node/pull/33204/files/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/33204#pullrequestreview-408336956
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 8, 2020https://github.com/nodejs/node/pull/33204#issuecomment-625887568
e50ae7ahttps://github.com/nodejs/node/commit/e50ae7a259238a6920736e78a19ce62a0f676ad9
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
ronaghttps://github.com/ronag
May 8, 2020https://github.com/nodejs/node/pull/33204#event-3317512315
ronaghttps://github.com/ronag
May 8, 2020 https://github.com/nodejs/node/pull/33204#ref-commit-e50ae7a
https://github.com/ronag
doc: add warning for socket.connect reusehttps://github.com/nodejs/node/commit/e50ae7a259238a6920736e78a19ce62a0f676ad9
e50ae7ahttps://github.com/nodejs/node/commit/e50ae7a259238a6920736e78a19ce62a0f676ad9
#33204https://github.com/nodejs/node/pull/33204
#25969https://github.com/nodejs/node/issues/25969
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33204#ref-commit-0cbee57
https://github.com/ronag
https://github.com/codebytere
doc: add warning for socket.connect reusehttps://github.com/nodejs/node/commit/0cbee57109d3104815ff3233800249401bc6eba2
0cbee57https://github.com/nodejs/node/commit/0cbee57109d3104815ff3233800249401bc6eba2
#33204https://github.com/nodejs/node/pull/33204
#25969https://github.com/nodejs/node/issues/25969
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33204#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
https://github.com/ronag
ronaghttps://github.com/ronag
May 27, 2020 https://github.com/nodejs/node/pull/33204#ref-issue-625758460
Use stream._construct #33586 https://github.com/nodejs/node/issues/33586
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33204#ref-commit-9dde1db
https://github.com/ronag
https://github.com/codebytere
doc: add warning for socket.connect reusehttps://github.com/nodejs/node/commit/9dde1db33263c4acf2883fd1a31715ca9e788c90
9dde1dbhttps://github.com/nodejs/node/commit/9dde1db33263c4acf2883fd1a31715ca9e788c90
#33204https://github.com/nodejs/node/pull/33204
#25969https://github.com/nodejs/node/issues/25969
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33204#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33204
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/33204/files/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33204/files/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/33204/files/74430ce8a2e8abdfc427c2ccb0aae85aace4b265
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/33204/files/11ae8f421976017dd22ffe764590a11be6fca13a
Please reload this pagehttps://github.com/nodejs/node/pull/33204
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Please reload this pagehttps://github.com/nodejs/node/pull/33204
https://github.com/ronag
https://github.com/sam-github
https://github.com/mscdex
https://github.com/jasnell
https://github.com/lpinca
https://github.com/bnoordhuis
https://github.com/mcollina
https://github.com/addaleax
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.