René's URL Explorer Experiment


Title: Revert test-abort-aliased-buffer-overflow by richardlau · Pull Request #33196 · nodejs/node · GitHub

Open Graph Title: Revert test-abort-aliased-buffer-overflow by richardlau · Pull Request #33196 · nodejs/node

X Title: Revert test-abort-aliased-buffer-overflow by richardlau · Pull Request #33196 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Revert the test and associated Makefile changes from #31740. This test is dead code as it is not executed as the abort tests' AbortTestConfiguration inherits from SimpleTestConfiguration which ...

X Description: Revert the test and associated Makefile changes from #31740. This test is dead code as it is not executed as the abort tests' AbortTestConfiguration inherits from SimpleTestConfiguration wh...

Opengraph URL: https://github.com/nodejs/node/pull/33196

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8258e7e4-a334-5e0a-624a-907edcd107b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD890:185F51:6C7F86:9032A3:6AED201F
html-safe-nonce678c470ca175eb7dbe86d1bc25891ae8bdfa7f989a75c4c95e28fad057891dee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODkwOjE4NUY1MTo2QzdGODY6OTAzMkEzOjZBRUQyMDFGIiwidmlzaXRvcl9pZCI6Ijk3MzA4NDgxNzYyNjA0NjQ5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3b98c6e6130843987c419571474a014f5894b8f8ef8b88d7a72d9bb297cd9aca
hovercard-subject-tagpull_request:412114190
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33196/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9d69ae18b90a44e54b80fd7256ebfb6cb5adf1e109356a4035ea240c4dd0efd9/nodejs/node/pull/33196
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d69ae18b90a44e54b80fd7256ebfb6cb5adf1e109356a4035ea240c4dd0efd9/nodejs/node/pull/33196
og:image:altRevert the test and associated Makefile changes from #31740. This test is dead code as it is not executed as the abort tests' AbortTestConfiguration inherits from SimpleTestConfiguration which ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33196#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33196
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33196
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33196
Reloadhttps://github.com/nodejs/node/pull/33196
Reloadhttps://github.com/nodejs/node/pull/33196
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:revertabortaliasedbufferstesthttps://github.com/richardlau/node-1/tree/revertabortaliasedbufferstest
Conversationhttps://github.com/nodejs/node/pull/33196
Commits2 (2)https://github.com/nodejs/node/pull/33196/commits
Checkshttps://github.com/nodejs/node/pull/33196/checks
Files changedhttps://github.com/nodejs/node/pull/33196/files
Revert test-abort-aliased-buffer-overflowhttps://github.com/nodejs/node/pull/33196#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:revertabortaliasedbufferstesthttps://github.com/richardlau/node-1/tree/revertabortaliasedbufferstest
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 1, 2020https://github.com/nodejs/node/pull/33196#issue-610729413
#31740https://github.com/nodejs/node/pull/31740
not executedhttps://github.com/nodejs/node/pull/31740#issuecomment-608152952
node/test/abort/testcfg.pyhttps://github.com/nodejs/node/blob/e9518254d79645c3c060ea8d7f4898f8e12af9bb/test/abort/testcfg.py#L6
e951825https://github.com/nodejs/node/commit/e9518254d79645c3c060ea8d7f4898f8e12af9bb
node/test/testpy/__init__.pyhttps://github.com/nodejs/node/blob/e9518254d79645c3c060ea8d7f4898f8e12af9bb/test/testpy/__init__.py#L159
e951825https://github.com/nodejs/node/commit/e9518254d79645c3c060ea8d7f4898f8e12af9bb
#31740https://github.com/nodejs/node/pull/31740
test/cctest/test_aliased_buffer.cchttps://github.com/nodejs/node/blob/master/test/cctest/test_aliased_buffer.cc
#31740https://github.com/nodejs/node/pull/31740
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
May 1, 2020https://github.com/nodejs/node/pull/33196#event-3293059991
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 1, 2020 https://github.com/nodejs/node/pull/33196#ref-pullrequest-593019586
test: run test-abort-aliased-buffer-overflow #32626 https://github.com/nodejs/node/pull/32626
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2020https://github.com/nodejs/node/pull/33196#issuecomment-622371444
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://ci.nodejs.org/job/node-test-pull-request/31130/https://ci.nodejs.org/job/node-test-pull-request/31130/
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 1, 2020 https://github.com/nodejs/node/pull/33196#pullrequestreview-404140256
View reviewed changes https://github.com/nodejs/node/pull/33196/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 1, 2020https://github.com/nodejs/node/pull/33196#issuecomment-622372874
#32624https://github.com/nodejs/node/pull/32624
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://github.com/richardlau
richardlauhttps://github.com/richardlau
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
May 1, 2020https://github.com/nodejs/node/pull/33196#event-3293080991
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
May 2, 2020https://github.com/nodejs/node/pull/33196#issuecomment-622660669
Codecovhttps://codecov.io/gh/nodejs/node/pull/33196?src=pr&el=h1
#33196https://codecov.io/gh/nodejs/node/pull/33196?src=pr&el=desc
masterhttps://codecov.io/gh/nodejs/node/commit/e9518254d79645c3c060ea8d7f4898f8e12af9bb&el=desc
https://codecov.io/gh/nodejs/node/pull/33196?src=pr&el=tree
Continue to review full report at Codecovhttps://codecov.io/gh/nodejs/node/pull/33196?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/nodejs/node/pull/33196?src=pr&el=footer
e951825...9769f84https://codecov.io/gh/nodejs/node/pull/33196?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 2, 2020 https://github.com/nodejs/node/pull/33196#pullrequestreview-404495686
View reviewed changes https://github.com/nodejs/node/pull/33196/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 3, 2020 https://github.com/nodejs/node/pull/33196#pullrequestreview-404631373
View reviewed changes https://github.com/nodejs/node/pull/33196/files
richardlauhttps://github.com/richardlau
May 6, 2020 09:39https://github.com/nodejs/node/pull/33196#commits-pushed-a22991b
https://github.com/richardlau
Revert "src: add aliased-buffer-overflow abort test"https://github.com/nodejs/node/pull/33196/commits/a22991b04461a1aa8dd6e1793f26f3b9e6eaaa27
a22991bhttps://github.com/nodejs/node/pull/33196/commits/a22991b04461a1aa8dd6e1793f26f3b9e6eaaa27
babeb58https://github.com/richardlau/node-1/commit/babeb58c5286c55f00e6dfc48c0b609314bcc381
nodejs#33196https://github.com/nodejs/node/pull/33196
nodejs#31740https://github.com/nodejs/node/pull/31740
https://github.com/richardlau
Revert "src: add test/abort build tasks"https://github.com/nodejs/node/pull/33196/commits/120d7076d5462f7f664ed0c92be26541e3298a24
120d707https://github.com/nodejs/node/pull/33196/commits/120d7076d5462f7f664ed0c92be26541e3298a24
e08ac09https://github.com/richardlau/node-1/commit/e08ac095690015a8c488e05251e05feb2acc57a0
nodejs#33196https://github.com/nodejs/node/pull/33196
nodejs#31740https://github.com/nodejs/node/pull/31740
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/9769f8443ca88551bbd210280053ddee4eb254b5..120d7076d5462f7f664ed0c92be26541e3298a24
9769f84https://github.com/nodejs/node/commit/9769f8443ca88551bbd210280053ddee4eb254b5
120d707https://github.com/nodejs/node/commit/120d7076d5462f7f664ed0c92be26541e3298a24
Compare https://github.com/nodejs/node/compare/9769f8443ca88551bbd210280053ddee4eb254b5..120d7076d5462f7f664ed0c92be26541e3298a24
May 6, 2020 13:41https://github.com/nodejs/node/pull/33196#event-3308558320
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 6, 2020https://github.com/nodejs/node/pull/33196#issuecomment-624657206
86fdaa7...120d707https://github.com/nodejs/node/compare/86fdaa745572a3bec4370ac7bd05d18e6bf64c01...120d7076d5462f7f664ed0c92be26541e3298a24
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://github.com/richardlau
richardlauhttps://github.com/richardlau
120d707https://github.com/nodejs/node/commit/120d7076d5462f7f664ed0c92be26541e3298a24
May 6, 2020https://github.com/nodejs/node/pull/33196#event-3308561362
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 6, 2020 13:43https://github.com/nodejs/node/pull/33196#event-3308564210
codebyterehttps://github.com/codebytere
May 7, 2020 https://github.com/nodejs/node/pull/33196#ref-commit-a56b600
https://github.com/richardlau
https://github.com/codebytere
Revert "src: add aliased-buffer-overflow abort test"https://github.com/nodejs/node/commit/a56b600e93a3eae72994a059cc708572bdcaf123
a56b600https://github.com/nodejs/node/commit/a56b600e93a3eae72994a059cc708572bdcaf123
babeb58https://github.com/nodejs/node/commit/babeb58c5286c55f00e6dfc48c0b609314bcc381
#33196https://github.com/nodejs/node/pull/33196
#31740https://github.com/nodejs/node/pull/31740
codebyterehttps://github.com/codebytere
May 7, 2020 https://github.com/nodejs/node/pull/33196#ref-commit-5ff3192
https://github.com/richardlau
https://github.com/codebytere
Revert "src: add test/abort build tasks"https://github.com/nodejs/node/commit/5ff31921cc997f4a60b444a4d4730f244723095b
5ff3192https://github.com/nodejs/node/commit/5ff31921cc997f4a60b444a4d4730f244723095b
e08ac09https://github.com/nodejs/node/commit/e08ac095690015a8c488e05251e05feb2acc57a0
#33196https://github.com/nodejs/node/pull/33196
#31740https://github.com/nodejs/node/pull/31740
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33196#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33196#ref-commit-b43fc64
https://github.com/richardlau
https://github.com/codebytere
Revert "src: add aliased-buffer-overflow abort test"https://github.com/nodejs/node/commit/b43fc64aa754761d8954eadbf9f83b0276bfd4a2
b43fc64https://github.com/nodejs/node/commit/b43fc64aa754761d8954eadbf9f83b0276bfd4a2
babeb58https://github.com/nodejs/node/commit/babeb58c5286c55f00e6dfc48c0b609314bcc381
#33196https://github.com/nodejs/node/pull/33196
#31740https://github.com/nodejs/node/pull/31740
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33196#ref-commit-c054834
https://github.com/richardlau
https://github.com/codebytere
Revert "src: add test/abort build tasks"https://github.com/nodejs/node/commit/c05483483fb1fdfc8ea8cc6634a48a2c0e24fa1f
c054834https://github.com/nodejs/node/commit/c05483483fb1fdfc8ea8cc6634a48a2c0e24fa1f
e08ac09https://github.com/nodejs/node/commit/e08ac095690015a8c488e05251e05feb2acc57a0
#33196https://github.com/nodejs/node/pull/33196
#31740https://github.com/nodejs/node/pull/31740
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33196#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33196
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33196/files/9769f8443ca88551bbd210280053ddee4eb254b5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33196/files/9769f8443ca88551bbd210280053ddee4eb254b5
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/33196/files/9769f8443ca88551bbd210280053ddee4eb254b5
Please reload this pagehttps://github.com/nodejs/node/pull/33196
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/33196
https://github.com/richardlau
https://github.com/nodejs-github-bot
https://github.com/codecov-io
https://github.com/jasnell
https://github.com/addaleax
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.