René's URL Explorer Experiment


Title: test: add tests for options.fs in fs streams by julianduque · Pull Request #33185 · nodejs/node · GitHub

Open Graph Title: test: add tests for options.fs in fs streams by julianduque · Pull Request #33185 · nodejs/node

X Title: test: add tests for options.fs in fs streams by julianduque · Pull Request #33185 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This add tests for the new options.fs override methods in the fs Stream operations Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included document...

X Description: This add tests for the new options.fs override methods in the fs Stream operations Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included document...

Opengraph URL: https://github.com/nodejs/node/pull/33185

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cc167d7d-aec5-983f-8625-2f7e77a4ba2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAD4:1F05C8:49671E:5F63E2:6AED2432
html-safe-nonce373315b91e2eca1011c5f5ccf0eb780fbe301e0f908aafc65424dfa1c17d5917
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUQ0OjFGMDVDODo0OTY3MUU6NUY2M0UyOjZBRUQyNDMyIiwidmlzaXRvcl9pZCI6IjUyMzE4NjE3MzAzMTI5NDAwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9235e2386c3962841c1bb2d44714f315d86edc42ac18f33f6bc3f589a681b394
hovercard-subject-tagpull_request:411943795
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33185/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9d6d8ab2513df6e899abfc8bd5ca4b9a1b3eed33cf6e29ccc570f4720315535e/nodejs/node/pull/33185
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d6d8ab2513df6e899abfc8bd5ca4b9a1b3eed33cf6e29ccc570f4720315535e/nodejs/node/pull/33185
og:image:altThis add tests for the new options.fs override methods in the fs Stream operations Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included document...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejulianduque
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33185#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33185
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33185
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33185
Reloadhttps://github.com/nodejs/node/pull/33185
Reloadhttps://github.com/nodejs/node/pull/33185
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
julianduquehttps://github.com/julianduque
nodejs:masterhttps://github.com/nodejs/node/tree/master
julianduque:julianduque/test-fs-streams-fs-optionshttps://github.com/julianduque/node/tree/julianduque/test-fs-streams-fs-options
Conversationhttps://github.com/nodejs/node/pull/33185
Commits1 (1)https://github.com/nodejs/node/pull/33185/commits
Checkshttps://github.com/nodejs/node/pull/33185/checks
Files changedhttps://github.com/nodejs/node/pull/33185/files
test: add tests for options.fs in fs streamshttps://github.com/nodejs/node/pull/33185#top
julianduquehttps://github.com/julianduque
nodejs:masterhttps://github.com/nodejs/node/tree/master
julianduque:julianduque/test-fs-streams-fs-optionshttps://github.com/julianduque/node/tree/julianduque/test-fs-streams-fs-options
https://github.com/julianduque
julianduquehttps://github.com/julianduque
May 1, 2020https://github.com/nodejs/node/pull/33185#issue-610518052
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 1, 2020https://github.com/nodejs/node/pull/33185#event-3292033677
https://github.com/edsadr
edsadrhttps://github.com/edsadr
May 1, 2020 https://github.com/nodejs/node/pull/33185#pullrequestreview-403993550
View reviewed changes https://github.com/nodejs/node/pull/33185/files
edsadrhttps://github.com/edsadr
https://github.com/nodejs/node/pull/33185#pullrequestreview-403993550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33185
test/parallel/test-fs-stream-fs-options.jshttps://github.com/nodejs/node/pull/33185/files#diff-62347747cb0bd321fbcd3964b42f0bfa1162c635a93dd40b284596d22a631648
Please reload this pagehttps://github.com/nodejs/node/pull/33185
test/parallel/test-fs-stream-fs-options.jshttps://github.com/nodejs/node/pull/33185/files#diff-62347747cb0bd321fbcd3964b42f0bfa1162c635a93dd40b284596d22a631648
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/julianduque
julianduquehttps://github.com/julianduque
force-pushedhttps://github.com/nodejs/node/compare/6e16e76657b2dcf35bb3392e573604ec0fb41718..e1e860ade252907e7bb2c8c4e524d03f4cbc65cc
6e16e76https://github.com/nodejs/node/commit/6e16e76657b2dcf35bb3392e573604ec0fb41718
e1e860ahttps://github.com/nodejs/node/commit/e1e860ade252907e7bb2c8c4e524d03f4cbc65cc
Compare https://github.com/nodejs/node/compare/6e16e76657b2dcf35bb3392e573604ec0fb41718..e1e860ade252907e7bb2c8c4e524d03f4cbc65cc
May 1, 2020 02:57https://github.com/nodejs/node/pull/33185#event-3292075737
https://github.com/julianduque
julianduquehttps://github.com/julianduque
edsadrhttps://github.com/edsadr
May 1, 2020 02:58https://github.com/nodejs/node/pull/33185#event-3292077222
https://github.com/edsadr
edsadrhttps://github.com/edsadr
May 1, 2020 https://github.com/nodejs/node/pull/33185#pullrequestreview-403999742
View reviewed changes https://github.com/nodejs/node/pull/33185/files
edsadrhttps://github.com/edsadr
https://github.com/nodejs/node/pull/33185#pullrequestreview-403999742
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/julianduque
julianduquehttps://github.com/julianduque
force-pushedhttps://github.com/nodejs/node/compare/e1e860ade252907e7bb2c8c4e524d03f4cbc65cc..c671654eb6abe0b2314a9a9a392fa51caf6f8a07
e1e860ahttps://github.com/nodejs/node/commit/e1e860ade252907e7bb2c8c4e524d03f4cbc65cc
c671654https://github.com/nodejs/node/commit/c671654eb6abe0b2314a9a9a392fa51caf6f8a07
Compare https://github.com/nodejs/node/compare/e1e860ade252907e7bb2c8c4e524d03f4cbc65cc..c671654eb6abe0b2314a9a9a392fa51caf6f8a07
May 1, 2020 14:34https://github.com/nodejs/node/pull/33185#event-3293363687
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 1, 2020 https://github.com/nodejs/node/pull/33185#pullrequestreview-404193457
View reviewed changes https://github.com/nodejs/node/pull/33185/files
juanarbolhttps://github.com/juanarbol
https://github.com/nodejs/node/pull/33185#pullrequestreview-404193457
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/lib/internal/fs/streams.js#L83https://github.com/nodejs/node/blob/master/lib/internal/fs/streams.js#L83
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/julianduque
julianduquehttps://github.com/julianduque
force-pushedhttps://github.com/nodejs/node/compare/c671654eb6abe0b2314a9a9a392fa51caf6f8a07..258a8ca2005abd92b5eabc504240bd373b66ce8e
c671654https://github.com/nodejs/node/commit/c671654eb6abe0b2314a9a9a392fa51caf6f8a07
258a8cahttps://github.com/nodejs/node/commit/258a8ca2005abd92b5eabc504240bd373b66ce8e
Compare https://github.com/nodejs/node/compare/c671654eb6abe0b2314a9a9a392fa51caf6f8a07..258a8ca2005abd92b5eabc504240bd373b66ce8e
May 1, 2020 15:04https://github.com/nodejs/node/pull/33185#event-3293451106
https://github.com/julianduque
julianduquehttps://github.com/julianduque
May 1, 2020https://github.com/nodejs/node/pull/33185#issuecomment-622424932
@juanarbolhttps://github.com/juanarbol
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/julianduque
julianduquehttps://github.com/julianduque
juanarbolhttps://github.com/juanarbol
May 1, 2020 15:06https://github.com/nodejs/node/pull/33185#event-3293455942
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 1, 2020 https://github.com/nodejs/node/pull/33185#pullrequestreview-404210657
View reviewed changes https://github.com/nodejs/node/pull/33185/files
test/parallel/test-fs-stream-fs-options.jshttps://github.com/nodejs/node/pull/33185/files#diff-62347747cb0bd321fbcd3964b42f0bfa1162c635a93dd40b284596d22a631648
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 1, 2020 https://github.com/nodejs/node/pull/33185#pullrequestreview-404213208
View reviewed changes https://github.com/nodejs/node/pull/33185/files
test/parallel/test-fs-stream-fs-options.jshttps://github.com/nodejs/node/pull/33185/files#diff-62347747cb0bd321fbcd3964b42f0bfa1162c635a93dd40b284596d22a631648
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/julianduque
test: add tests for options.fs in fs streamshttps://github.com/nodejs/node/pull/33185/commits/41415f4d4e9070dad4a23911a240937f2163352d
41415f4https://github.com/nodejs/node/pull/33185/commits/41415f4d4e9070dad4a23911a240937f2163352d
https://github.com/julianduque
julianduquehttps://github.com/julianduque
force-pushedhttps://github.com/nodejs/node/compare/258a8ca2005abd92b5eabc504240bd373b66ce8e..41415f4d4e9070dad4a23911a240937f2163352d
258a8cahttps://github.com/nodejs/node/commit/258a8ca2005abd92b5eabc504240bd373b66ce8e
41415f4https://github.com/nodejs/node/commit/41415f4d4e9070dad4a23911a240937f2163352d
Compare https://github.com/nodejs/node/compare/258a8ca2005abd92b5eabc504240bd373b66ce8e..41415f4d4e9070dad4a23911a240937f2163352d
May 1, 2020 15:18https://github.com/nodejs/node/pull/33185#event-3293490778
https://github.com/julianduque
julianduquehttps://github.com/julianduque
juanarbolhttps://github.com/juanarbol
May 1, 2020 15:18https://github.com/nodejs/node/pull/33185#event-3293491428
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 1, 2020 https://github.com/nodejs/node/pull/33185#pullrequestreview-404218129
View reviewed changes https://github.com/nodejs/node/pull/33185/files/41415f4d4e9070dad4a23911a240937f2163352d
juanarbolhttps://github.com/juanarbol
https://github.com/nodejs/node/pull/33185#pullrequestreview-404218129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 4, 2020https://github.com/nodejs/node/pull/33185#event-3300838056
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 4, 2020https://github.com/nodejs/node/pull/33185#issuecomment-623586987
https://ci.nodejs.org/job/node-test-pull-request/31166/https://ci.nodejs.org/job/node-test-pull-request/31166/
Please reload this pagehttps://github.com/nodejs/node/pull/33185
juanarbolhttps://github.com/juanarbol
May 4, 2020 https://github.com/nodejs/node/pull/33185#ref-commit-39ff647
https://github.com/julianduque
https://github.com/juanarbol
test: add tests for options.fs in fs streamshttps://github.com/nodejs/node/commit/39ff64756bd5bc7147236b36ee9444ceddb3e6d2
39ff647https://github.com/nodejs/node/commit/39ff64756bd5bc7147236b36ee9444ceddb3e6d2
#33185https://github.com/nodejs/node/pull/33185
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 4, 2020https://github.com/nodejs/node/pull/33185#issuecomment-623630878
39ff647https://github.com/nodejs/node/commit/39ff64756bd5bc7147236b36ee9444ceddb3e6d2
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 4, 2020https://github.com/nodejs/node/pull/33185#event-3301163071
codebyterehttps://github.com/codebytere
May 7, 2020 https://github.com/nodejs/node/pull/33185#ref-commit-676ef95
https://github.com/julianduque
https://github.com/codebytere
test: add tests for options.fs in fs streamshttps://github.com/nodejs/node/commit/676ef952abf09c95a06d6c4da91098976bb2ceae
676ef95https://github.com/nodejs/node/commit/676ef952abf09c95a06d6c4da91098976bb2ceae
#33185https://github.com/nodejs/node/pull/33185
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33185#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
codebyterehttps://github.com/codebytere
Jun 7, 2020 https://github.com/nodejs/node/pull/33185#ref-commit-1766514
https://github.com/julianduque
https://github.com/codebytere
test: add tests for options.fs in fs streamshttps://github.com/nodejs/node/commit/1766514c5bfb4718e88814b700f770cc6abc8fe2
1766514https://github.com/nodejs/node/commit/1766514c5bfb4718e88814b700f770cc6abc8fe2
#33185https://github.com/nodejs/node/pull/33185
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33185#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33185
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/33185/files/41415f4d4e9070dad4a23911a240937f2163352d
https://github.com/edsadr
edsadr https://github.com/edsadr
https://github.com/nodejs/node/pull/33185/files/e1e860ade252907e7bb2c8c4e524d03f4cbc65cc
Please reload this pagehttps://github.com/nodejs/node/pull/33185
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/33185
https://github.com/julianduque
https://github.com/nodejs-github-bot
https://github.com/juanarbol
https://github.com/edsadr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.