René's URL Explorer Experiment


Title: wasi: avoid hard crash if start() is never called by cjihrig · Pull Request #33184 · nodejs/node · GitHub

Open Graph Title: wasi: avoid hard crash if start() is never called by cjihrig · Pull Request #33184 · nodejs/node

X Title: wasi: avoid hard crash if start() is never called by cjihrig · Pull Request #33184 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Prior to this commit, calling the WebAssembly instance's _start() export directly would hard crash the process because the memory was never configured. This commit adds an additional check that...

X Description: Prior to this commit, calling the WebAssembly instance's _start() export directly would hard crash the process because the memory was never configured. This commit adds an additional check ...

Opengraph URL: https://github.com/nodejs/node/pull/33184

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3972c519-06b3-1f6f-5219-abee3e552c36
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB100:2F193C:9039E:C3A9C:6AED32D2
html-safe-nonce3948d26fc3026869835572211c1c27733d7b2f7fedeb6cae3a340a4b04dd056b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTAwOjJGMTkzQzo5MDM5RTpDM0E5Qzo2QUVEMzJEMiIsInZpc2l0b3JfaWQiOiIxNzQ2NTU3NzM0MTM2NjU2NTk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccf6f20c0e3b2c14aeff63409d3d9b0caa24a2459a4911cf61c7e7497d84c218f
hovercard-subject-tagpull_request:411939146
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33184/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/774278ff0416ad114c40028680629dfb491ec26c798beb45a40fed5c96f19780/nodejs/node/pull/33184
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/774278ff0416ad114c40028680629dfb491ec26c798beb45a40fed5c96f19780/nodejs/node/pull/33184
og:image:altPrior to this commit, calling the WebAssembly instance's _start() export directly would hard crash the process because the memory was never configured. This commit adds an additional check that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33184#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33184
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33184
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33184
Reloadhttps://github.com/nodejs/node/pull/33184
Reloadhttps://github.com/nodejs/node/pull/33184
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:wasi-starthttps://github.com/cjihrig/node/tree/wasi-start
Conversationhttps://github.com/nodejs/node/pull/33184
Commits1 (1)https://github.com/nodejs/node/pull/33184/commits
Checkshttps://github.com/nodejs/node/pull/33184/checks
Files changedhttps://github.com/nodejs/node/pull/33184/files
wasi: avoid hard crash if start() is never calledhttps://github.com/nodejs/node/pull/33184#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:wasi-starthttps://github.com/cjihrig/node/tree/wasi-start
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 1, 2020https://github.com/nodejs/node/pull/33184#issue-610512328
#33175https://github.com/nodejs/node/issues/33175
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33184
https://github.com/cjihrig
wasi: avoid hard crash if start() is never calledhttps://github.com/nodejs/node/pull/33184/commits/7c2870d5f367ec57e5319a716e1a8bca944a8029
7c2870dhttps://github.com/nodejs/node/pull/33184/commits/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
wasi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi
May 1, 2020https://github.com/nodejs/node/pull/33184#event-3292006137
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 1, 2020 https://github.com/nodejs/node/pull/33184#pullrequestreview-403989909
View reviewed changes https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 1, 2020 https://github.com/nodejs/node/pull/33184#pullrequestreview-404143116
View reviewed changes https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 1, 2020 https://github.com/nodejs/node/pull/33184#pullrequestreview-404227286
View reviewed changes https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 1, 2020https://github.com/nodejs/node/pull/33184#issuecomment-622473350
Please reload this pagehttps://github.com/nodejs/node/pull/33184
https://ci.nodejs.org/job/node-test-pull-request/31137/https://ci.nodejs.org/job/node-test-pull-request/31137/
Please reload this pagehttps://github.com/nodejs/node/pull/33184
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 1, 2020 https://github.com/nodejs/node/pull/33184#pullrequestreview-404345799
View reviewed changes https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 1, 2020https://github.com/nodejs/node/pull/33184#event-3294663150
https://github.com/devnexen
devnexenhttps://github.com/devnexen
May 3, 2020 https://github.com/nodejs/node/pull/33184#pullrequestreview-404660115
View reviewed changes https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
May 3, 2020 https://github.com/nodejs/node/pull/33184#pullrequestreview-404661673
View reviewed changes https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 4, 2020 https://github.com/nodejs/node/pull/33184#ref-pullrequest-612008961
wasi: prevent syscalls before start #33235 https://github.com/nodejs/node/pull/33235
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 4, 2020https://github.com/nodejs/node/pull/33184#issuecomment-623574484
#33235https://github.com/nodejs/node/pull/33235
Please reload this pagehttps://github.com/nodejs/node/pull/33184
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 4, 2020https://github.com/nodejs/node/pull/33184#issuecomment-623582992
#33235https://github.com/nodejs/node/pull/33235
Please reload this pagehttps://github.com/nodejs/node/pull/33184
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 4, 2020https://github.com/nodejs/node/pull/33184#event-3300809768
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 4, 2020 16:58https://github.com/nodejs/node/pull/33184#event-3300810068
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Sep 29, 2020 https://github.com/nodejs/node/pull/33184#ref-issue-610356841
[BUG] Segfault on combo of global ctors, ostream, wasi #33175 https://github.com/nodejs/node/issues/33175
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33184
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/santigimeno
santigimeno https://github.com/santigimeno
https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/devnexen
devnexen https://github.com/devnexen
https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/33184/files/7c2870d5f367ec57e5319a716e1a8bca944a8029
Please reload this pagehttps://github.com/nodejs/node/pull/33184
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
wasi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi
[BUG] Segfault on combo of global ctors, ostream, wasi https://github.com/nodejs/node/issues/33175
Please reload this pagehttps://github.com/nodejs/node/pull/33184
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/tniessen
https://github.com/jasnell
https://github.com/addaleax
https://github.com/santigimeno
https://github.com/devnexen
https://github.com/devsnek
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.