| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:eef8cb78-3e1f-eab3-cb08-48b5174c2644 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E89E:17D884:76DD09:9B496A:6AED3417 |
| html-safe-nonce | 60526615c0cf1d01321e753d4173d4a31965a146929a2238ba521894f33884f7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODlFOjE3RDg4NDo3NkREMDk6OUI0OTZBOjZBRUQzNDE3IiwidmlzaXRvcl9pZCI6IjUzNTg1MTg3NjIxMjgzNTYzNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a60f4bb6d144a5d8a6ce70e81e8461bf90edd77709418631acea54b058921b25 |
| hovercard-subject-tag | pull_request:411705638 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33168/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/27223afbd3a139ecb0cfe93a64661ec91c40aecf60f16dbcc6c72410839c6588/nodejs/node/pull/33168 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/27223afbd3a139ecb0cfe93a64661ec91c40aecf60f16dbcc6c72410839c6588/nodejs/node/pull/33168 |
| og:image:alt | Fixes: #28060
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rosaxxny |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33168#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33168 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33168 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33168 |
| Reload | https://github.com/nodejs/node/pull/33168 |
| Reload | https://github.com/nodejs/node/pull/33168 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests665 (665) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| rosaxxny | https://github.com/rosaxxny |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rosaxxny:doc/esm-import-export | https://github.com/rosaxxny/node/tree/doc/esm-import-export |
| Conversation | https://github.com/nodejs/node/pull/33168 |
| Commits3 (3) | https://github.com/nodejs/node/pull/33168/commits |
| Checks | https://github.com/nodejs/node/pull/33168/checks |
| Files changed | https://github.com/nodejs/node/pull/33168/files |
| doc: add examples for implementing ESM | https://github.com/nodejs/node/pull/33168#top |
| rosaxxny | https://github.com/rosaxxny |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rosaxxny:doc/esm-import-export | https://github.com/rosaxxny/node/tree/doc/esm-import-export |
|
| https://github.com/rosaxxny |
| rosaxxny | https://github.com/rosaxxny |
| Apr 30, 2020 | https://github.com/nodejs/node/pull/33168#issue-610224841 |
| #28060 | https://github.com/nodejs/node/issues/28060 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
|
| https://github.com/rosaxxny |
| doc: add examples for implementing ESM | https://github.com/nodejs/node/pull/33168/commits/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
| bf5dd8c | https://github.com/nodejs/node/pull/33168/commits/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
| nodejs#28060 | https://github.com/nodejs/node/issues/28060 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| Apr 30, 2020 | https://github.com/nodejs/node/pull/33168#event-3290371973 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/33168#pullrequestreview-403690857 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 30, 2020 | https://github.com/nodejs/node/pull/33168#issuecomment-621966460 |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/33168#pullrequestreview-403700715 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| https://github.com/nodejs/node/pull/33168#pullrequestreview-403700715 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #31479 | https://github.com/nodejs/node/pull/31479 |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
|
| https://github.com/rosaxxny |
| fixup! doc: add examples for implementing ESM | https://github.com/nodejs/node/pull/33168/commits/20eddec92a1b002ac3a66833dba675de585ad14a |
| 20eddec | https://github.com/nodejs/node/pull/33168/commits/20eddec92a1b002ac3a66833dba675de585ad14a |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
| May 1, 2020 | https://github.com/nodejs/node/pull/33168#issuecomment-622379665 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
|
May 1, 2020
| https://github.com/nodejs/node/pull/33168#pullrequestreview-404148535 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33168/files/20eddec92a1b002ac3a66833dba675de585ad14a |
| https://github.com/dnalborczyk |
| dnalborczyk | https://github.com/dnalborczyk |
|
May 1, 2020
| https://github.com/nodejs/node/pull/33168#pullrequestreview-404240226 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
| doc/api/esm.md | https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
| doc/api/esm.md | https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
|
| https://github.com/rosaxxny |
| fixup! fixup! doc: add examples for implementing ESM | https://github.com/nodejs/node/pull/33168/commits/60b9a13c12f1947022624a6ee0c13e0c80ab5db1 |
| 60b9a13 | https://github.com/nodejs/node/pull/33168/commits/60b9a13c12f1947022624a6ee0c13e0c80ab5db1 |
| https://github.com/rosaxxny |
| rosaxxny | https://github.com/rosaxxny |
| May 12, 2020 | https://github.com/nodejs/node/pull/33168#issuecomment-627034453 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| @bmeck | https://github.com/bmeck |
| @dnalborczyk | https://github.com/dnalborczyk |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 14, 2020 | https://github.com/nodejs/node/pull/33168#issuecomment-628794775 |
| 4780493 | https://github.com/nodejs/node/commit/47804933012841f2dc90626bdcc161adf34569a5 |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
| addaleax | https://github.com/addaleax |
|
May 14, 2020
| https://github.com/nodejs/node/pull/33168#ref-commit-4780493 |
|
| https://github.com/rosaxxny |
|
| https://github.com/addaleax |
| doc: add examples for implementing ESM | https://github.com/nodejs/node/commit/47804933012841f2dc90626bdcc161adf34569a5 |
| 4780493 | https://github.com/nodejs/node/commit/47804933012841f2dc90626bdcc161adf34569a5 |
| #28060 | https://github.com/nodejs/node/issues/28060 |
| #33168 | https://github.com/nodejs/node/pull/33168 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 14, 2020 | https://github.com/nodejs/node/pull/33168#event-3337780802 |
| codebytere | https://github.com/codebytere |
|
May 16, 2020
| https://github.com/nodejs/node/pull/33168#ref-commit-0ffa040 |
|
| https://github.com/rosaxxny |
|
| https://github.com/codebytere |
| doc: add examples for implementing ESM | https://github.com/nodejs/node/commit/0ffa0402a5dfe313fd6a3d683c9e3d1a50142938 |
| 0ffa040 | https://github.com/nodejs/node/commit/0ffa0402a5dfe313fd6a3d683c9e3d1a50142938 |
| #28060 | https://github.com/nodejs/node/issues/28060 |
| #33168 | https://github.com/nodejs/node/pull/33168 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
May 18, 2020
| https://github.com/nodejs/node/pull/33168#ref-pullrequest-619852653 |
|
v14.3.0 proposal
#33452
| https://github.com/nodejs/node/pull/33452 |
| codebytere | https://github.com/codebytere |
|
Jun 7, 2020
| https://github.com/nodejs/node/pull/33168#ref-commit-02a37c5 |
|
| https://github.com/rosaxxny |
|
| https://github.com/codebytere |
| doc: add examples for implementing ESM | https://github.com/nodejs/node/commit/02a37c5b33e17c692079217eaa93bcded4669f0e |
| 02a37c5 | https://github.com/nodejs/node/commit/02a37c5b33e17c692079217eaa93bcded4669f0e |
| #28060 | https://github.com/nodejs/node/issues/28060 |
| #33168 | https://github.com/nodejs/node/pull/33168 |
| codebytere | https://github.com/codebytere |
|
Jun 9, 2020
| https://github.com/nodejs/node/pull/33168#ref-commit-3d8ba29 |
|
| https://github.com/rosaxxny |
|
| https://github.com/codebytere |
| doc: add examples for implementing ESM | https://github.com/codebytere/node/commit/3d8ba292e267d49dcd36148fd1e52f9833686f2c |
| 3d8ba29 | https://github.com/codebytere/node/commit/3d8ba292e267d49dcd36148fd1e52f9833686f2c |
| nodejs#28060 | https://github.com/nodejs/node/issues/28060 |
| nodejs#33168 | https://github.com/nodejs/node/pull/33168 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 9, 2020
| https://github.com/nodejs/node/pull/33168#ref-pullrequest-635542822 |
|
v12.18.1 proposal
#33811
| https://github.com/nodejs/node/pull/33811 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33168 |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/33168/files/20eddec92a1b002ac3a66833dba675de585ad14a |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
|
| https://github.com/dnalborczyk |
|
dnalborczyk
| https://github.com/dnalborczyk |
|
| https://github.com/nodejs/node/pull/33168/files/bf5dd8cb0cb0059807b4d18e037b2326e02c22ae |
|
| https://github.com/bmeck |
|
bmeck
| https://github.com/bmeck |
|
| https://github.com/nodejs/node/pull/33168/files/20eddec92a1b002ac3a66833dba675de585ad14a |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
esm modules documentation doesn't describe how to implement a module
| https://github.com/nodejs/node/issues/28060 |
| Please reload this page | https://github.com/nodejs/node/pull/33168 |
|
| https://github.com/rosaxxny |
|
| https://github.com/addaleax |
|
| https://github.com/bmeck |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/dnalborczyk |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |