| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:99c2ffc1-64c7-f953-b9d4-e8f903f5457e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A294:1E2F2A:4CAD95:6835FA:6AED1CED |
| html-safe-nonce | 3c56a6c1a8f7336a2e0bb48d1ef1437b0ad86833f15f392b80b10874f8279d36 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjk0OjFFMkYyQTo0Q0FEOTU6NjgzNUZBOjZBRUQxQ0VEIiwidmlzaXRvcl9pZCI6IjUxNzgzMDYzMjgxMzk3MzQyNTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1a67ead4ad1b83fe5e2dfa83622ce62c8afc8ef8b49a38c706e0cdec64425a6b |
| hovercard-subject-tag | pull_request:411214422 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33162/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bf97d21de3708059e90a1e3b02c8a8bd30be7c19ce669b7654a2c72f633e4f37/nodejs/node/pull/33162 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bf97d21de3708059e90a1e3b02c8a8bd30be7c19ce669b7654a2c72f633e4f37/nodejs/node/pull/33162 |
| og:image:alt | Refs: #29829
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rexagod |
| hostname | github.com |
| expected-hostname | github.com |
| None | 120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e12fd03aa775dceadc5a793c3a0791e43ca256bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/33162#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33162 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33162 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33162 |
| Reload | https://github.com/nodejs/node/pull/33162 |
| Reload | https://github.com/nodejs/node/pull/33162 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues655 (655) | https://github.com/nodejs/node/issues |
| Pull requests666 (666) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| rexagod | https://github.com/rexagod |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rexagod:i-29829-1 | https://github.com/rexagod/node/tree/i-29829-1 |
| Conversation | https://github.com/nodejs/node/pull/33162 |
| Commits2 (2) | https://github.com/nodejs/node/pull/33162/commits |
| Checks | https://github.com/nodejs/node/pull/33162/checks |
| Files changed | https://github.com/nodejs/node/pull/33162/files |
| http2: add bytesWritten test for Http2Stream | https://github.com/nodejs/node/pull/33162#top |
| rexagod | https://github.com/rexagod |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rexagod:i-29829-1 | https://github.com/rexagod/node/tree/i-29829-1 |
|
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
| Apr 30, 2020 | https://github.com/nodejs/node/pull/33162#issue-609668578 |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
| #29829 | https://github.com/nodejs/node/issues/29829 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
|
| https://github.com/rexagod |
| http2: add bytesWritten test for Http2Stream | https://github.com/nodejs/node/pull/33162/commits/b0040279744034845ee36805fcb2988917b68c5b |
| b004027 | https://github.com/nodejs/node/pull/33162/commits/b0040279744034845ee36805fcb2988917b68c5b |
| nodejs#29829 | https://github.com/nodejs/node/issues/29829 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Apr 30, 2020 | https://github.com/nodejs/node/pull/33162#event-3287949837 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 30, 2020
| https://github.com/nodejs/node/pull/33162#pullrequestreview-403701423 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33162/files/b0040279744034845ee36805fcb2988917b68c5b |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
May 1, 2020
| https://github.com/nodejs/node/pull/33162#pullrequestreview-404124315 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33162/files/b0040279744034845ee36805fcb2988917b68c5b |
| test/parallel/test-http2-byteswritten-server.js | https://github.com/nodejs/node/pull/33162/files/b0040279744034845ee36805fcb2988917b68c5b#diff-d4ab7b7b2801dd8ebafcfc0cbb839c32ac7754530bcba7ccb0a03f4f4c0bd594 |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
|
| https://github.com/rexagod |
| don't use PerformanceObserver API | https://github.com/nodejs/node/pull/33162/commits/e691fd33a21752997befae24cef38165713130cc |
| e691fd3 | https://github.com/nodejs/node/pull/33162/commits/e691fd33a21752997befae24cef38165713130cc |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 3, 2020 | https://github.com/nodejs/node/pull/33162#issuecomment-623139920 |
| https://ci.nodejs.org/job/node-test-pull-request/31149/ | https://ci.nodejs.org/job/node-test-pull-request/31149/ |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 3, 2020 | https://github.com/nodejs/node/pull/33162#event-3297628848 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 7, 2020 | https://github.com/nodejs/node/pull/33162#issuecomment-625546875 |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 7, 2020 | https://github.com/nodejs/node/pull/33162#issuecomment-625546921 |
| https://ci.nodejs.org/job/node-test-pull-request/31222/ | https://ci.nodejs.org/job/node-test-pull-request/31222/ |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
| addaleax | https://github.com/addaleax |
|
May 9, 2020
| https://github.com/nodejs/node/pull/33162#ref-commit-1aa491a |
|
| https://github.com/rexagod |
|
| https://github.com/addaleax |
| http2: add bytesWritten test for Http2Stream | https://github.com/nodejs/node/commit/1aa491a88fdaf8695dc49ede67fce82ee44e53b6 |
| 1aa491a | https://github.com/nodejs/node/commit/1aa491a88fdaf8695dc49ede67fce82ee44e53b6 |
| #29829 | https://github.com/nodejs/node/issues/29829 |
| #33162 | https://github.com/nodejs/node/pull/33162 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 9, 2020 | https://github.com/nodejs/node/pull/33162#issuecomment-626112130 |
| 1aa491a | https://github.com/nodejs/node/commit/1aa491a88fdaf8695dc49ede67fce82ee44e53b6 |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 9, 2020 | https://github.com/nodejs/node/pull/33162#event-3319041535 |
| codebytere | https://github.com/codebytere |
|
May 11, 2020
| https://github.com/nodejs/node/pull/33162#ref-commit-41c5524 |
|
| https://github.com/rexagod |
|
| https://github.com/codebytere |
| http2: add bytesWritten test for Http2Stream | https://github.com/nodejs/node/commit/41c5524432d3688efb1d2778b8500743cda70271 |
| 41c5524 | https://github.com/nodejs/node/commit/41c5524432d3688efb1d2778b8500743cda70271 |
| #29829 | https://github.com/nodejs/node/issues/29829 |
| #33162 | https://github.com/nodejs/node/pull/33162 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
May 18, 2020
| https://github.com/nodejs/node/pull/33162#ref-pullrequest-619852653 |
|
v14.3.0 proposal
#33452
| https://github.com/nodejs/node/pull/33452 |
| https://github.com/rexagod |
| rexagod | https://github.com/rexagod |
|
Jun 6, 2020
| https://github.com/nodejs/node/pull/33162#ref-issue-501844506 |
|
The differences between http2 compatibility API and http[s]
#29829
| https://github.com/nodejs/node/issues/29829 |
| codebytere | https://github.com/codebytere |
|
Jun 7, 2020
| https://github.com/nodejs/node/pull/33162#ref-commit-66dbaff |
|
| https://github.com/rexagod |
|
| https://github.com/codebytere |
| http2: add bytesWritten test for Http2Stream | https://github.com/nodejs/node/commit/66dbaff84846ea85f14a5be52589ef1fb75cbe15 |
| 66dbaff | https://github.com/nodejs/node/commit/66dbaff84846ea85f14a5be52589ef1fb75cbe15 |
| #29829 | https://github.com/nodejs/node/issues/29829 |
| #33162 | https://github.com/nodejs/node/pull/33162 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 9, 2020
| https://github.com/nodejs/node/pull/33162#ref-pullrequest-635542822 |
|
v12.18.1 proposal
#33811
| https://github.com/nodejs/node/pull/33811 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33162 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/33162/files/b0040279744034845ee36805fcb2988917b68c5b |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33162/files/b0040279744034845ee36805fcb2988917b68c5b |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/33162 |
|
| https://github.com/rexagod |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/ronag |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |