René's URL Explorer Experiment


Title: src: separate owning and non-owning AliasedBuffers by joyeecheung · Pull Request #33142 · nodejs/node · GitHub

Open Graph Title: src: separate owning and non-owning AliasedBuffers by joyeecheung · Pull Request #33142 · nodejs/node

X Title: src: separate owning and non-owning AliasedBuffers by joyeecheung · Pull Request #33142 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Move the reserve() method into an owning variant of AliasedBuffer, and split the two constructors to different classes to make the contract explicit instead of relying on run time CHECKs. Also dele...

X Description: Move the reserve() method into an owning variant of AliasedBuffer, and split the two constructors to different classes to make the contract explicit instead of relying on run time CHECKs. Also dele...

Opengraph URL: https://github.com/nodejs/node/pull/33142

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e9464ec1-1358-1da8-a5d4-b1c67c6941b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2CE:2973C7:5B7824:76AC66:6AED2945
html-safe-nonce1355f691d45b077c8a5aff4745d544368fd2ad620e07aeb4acb1ea43029bd603
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkNFOjI5NzNDNzo1Qjc4MjQ6NzZBQzY2OjZBRUQyOTQ1IiwidmlzaXRvcl9pZCI6IjE3NDUxNDA2NzQxMDE4NDgzODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdff00a3b1ee39c1e6e43bd40c117db56275ed7678047418e7a112b88a145e1cf
hovercard-subject-tagpull_request:410625372
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33142/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97148ebd18dde8412f551550740ad9c00a5a431e99700e017279e4a0a1cef258/nodejs/node/pull/33142
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97148ebd18dde8412f551550740ad9c00a5a431e99700e017279e4a0a1cef258/nodejs/node/pull/33142
og:image:altMove the reserve() method into an owning variant of AliasedBuffer, and split the two constructors to different classes to make the contract explicit instead of relying on run time CHECKs. Also dele...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33142#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33142
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33142
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33142
Reloadhttps://github.com/nodejs/node/pull/33142
Reloadhttps://github.com/nodejs/node/pull/33142
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-aliasedhttps://github.com/joyeecheung/node/tree/refactor-aliased
Conversationhttps://github.com/nodejs/node/pull/33142
Commits1 (1)https://github.com/nodejs/node/pull/33142/commits
Checkshttps://github.com/nodejs/node/pull/33142/checks
Files changedhttps://github.com/nodejs/node/pull/33142/files
src: separate owning and non-owning AliasedBuffershttps://github.com/nodejs/node/pull/33142#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:refactor-aliasedhttps://github.com/joyeecheung/node/tree/refactor-aliased
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 29, 2020https://github.com/nodejs/node/pull/33142#issue-608946853
Please reload this pagehttps://github.com/nodejs/node/pull/33142
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/joyeecheung
src: separate owning and non-owning AliasedBuffershttps://github.com/nodejs/node/pull/33142/commits/520da4a1f866584a12666c849db2866d6e9cdf3e
520da4ahttps://github.com/nodejs/node/pull/33142/commits/520da4a1f866584a12666c849db2866d6e9cdf3e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Apr 29, 2020https://github.com/nodejs/node/pull/33142#event-3283975771
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 29, 2020https://github.com/nodejs/node/pull/33142#issuecomment-621118121
https://ci.nodejs.org/job/node-test-pull-request/31094/https://ci.nodejs.org/job/node-test-pull-request/31094/
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 29, 2020 https://github.com/nodejs/node/pull/33142#ref-pullrequest-604304106
bootstrap: include bootstrapped Environment in builtin snapshot #32984 https://github.com/nodejs/node/pull/32984
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 29, 2020 https://github.com/nodejs/node/pull/33142#pullrequestreview-402551236
View reviewed changes https://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e
test/abort/test_abort-aliased-buffer-overflow/binding.cchttps://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e#diff-dbe1a0c01354308a27e166eff963d21cabd9d079059f895398625bba5416a69a
richardlauhttps://github.com/richardlau
Apr 29, 2020https://github.com/nodejs/node/pull/33142#discussion_r417222485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#32626https://github.com/nodejs/node/pull/32626
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 29, 2020 https://github.com/nodejs/node/pull/33142#pullrequestreview-402759456
View reviewed changes https://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e
addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/nodejs/node/pull/33142#pullrequestreview-402759456
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 29, 2020 https://github.com/nodejs/node/pull/33142#pullrequestreview-402893450
View reviewed changes https://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e
src/aliased_buffer.hhttps://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e#diff-e4a7d7aff776cfb74a0fa98f86f812f572d7079a5686c1fe108e172c978ab315
jasnellhttps://github.com/jasnell
Apr 29, 2020https://github.com/nodejs/node/pull/33142#discussion_r417494454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 29, 2020https://github.com/nodejs/node/pull/33142#issuecomment-621362240
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 30, 2020https://github.com/nodejs/node/pull/33142#issuecomment-621589719
Please reload this pagehttps://github.com/nodejs/node/pull/33142
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 30, 2020https://github.com/nodejs/node/pull/33142#issuecomment-621593288
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
8ae28ffhttps://github.com/nodejs/node/commit/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda
2935f72https://github.com/nodejs/node/commit/2935f72ae1b991c64118031dec12e7d7db7714a5
Compare https://github.com/nodejs/node/compare/8ae28ff3ac49cbf83f4fc3445d63b9900f3cdcda..2935f72ae1b991c64118031dec12e7d7db7714a5
May 31, 2020 12:18https://github.com/nodejs/node/pull/33142#event-3390558621
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
code ownershttps://github.com/nodejs/node/blob/64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46/.github/CODEOWNERS#L57
August 10, 2020 16:07https://github.com/nodejs/node/pull/33142#event-3639466718
https://github.com/aduh95
aduh95https://github.com/aduh95
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Oct 16, 2020https://github.com/nodejs/node/pull/33142#event-3888083161
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 16, 2020https://github.com/nodejs/node/pull/33142#issuecomment-710576482
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 16, 2020https://github.com/nodejs/node/pull/33142#issuecomment-727661472
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 16, 2020https://github.com/nodejs/node/pull/33142#event-3997963302
https://github.com/Dmarch28
Dmarch28https://github.com/Dmarch28
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276134035
[Snyk] Fix for 1 vulnerabilities Dmarch28/node#61 https://github.com/Dmarch28/node/pull/61
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276143818
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#61 https://github.com/aliceUnhinged613/node/pull/61
https://github.com/137717unity
137717unityhttps://github.com/137717unity
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276149351
[Snyk] Fix for 1 vulnerabilities 137717unity/node#60 https://github.com/137717unity/node/pull/60
https://github.com/baby636
baby636https://github.com/baby636
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276151977
[Snyk] Fix for 1 vulnerabilities baby636/node#58 https://github.com/baby636/node/pull/58
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276166941
[Snyk] Fix for 1 vulnerabilities Rednickle/node-1#51 https://github.com/Rednickle/node-1/pull/51
https://github.com/kissofire
kissofirehttps://github.com/kissofire
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276169062
[Snyk] Fix for 1 vulnerabilities kissofire/node#70 https://github.com/kissofire/node/pull/70
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276185260
[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#36 https://github.com/wedataintelligence/node/pull/36
https://github.com/ron-a20
ron-a20https://github.com/ron-a20
Jun 19, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276200453
[Snyk] Fix for 1 vulnerabilities ron-a20/node#69 https://github.com/ron-a20/node/pull/69
https://github.com/molllyn1
molllyn1https://github.com/molllyn1
Jun 20, 2022 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1276376997
[Snyk] Fix for 1 vulnerabilities molllyn1/node#51 https://github.com/molllyn1/node/pull/51
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jan 30, 2023 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1562763640
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#89 https://github.com/aliceUnhinged613/node/pull/89
https://github.com/wedataintelligence
wedataintelligencehttps://github.com/wedataintelligence
Jan 30, 2023 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1563184477
[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#73 https://github.com/wedataintelligence/node/pull/73
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jan 30, 2023 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1563272992
[Snyk] Fix for 1 vulnerabilities kissofire/node#94 https://github.com/kissofire/node/pull/94
https://github.com/molllyn1
molllyn1https://github.com/molllyn1
Jan 31, 2023 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1563506365
[Snyk] Fix for 1 vulnerabilities molllyn1/node#76 https://github.com/molllyn1/node/pull/76
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jan 31, 2023 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1563601683
[Snyk] Fix for 1 vulnerabilities 137717unity/node#93 https://github.com/137717unity/node/pull/93
https://github.com/baby636
baby636https://github.com/baby636
Jan 31, 2023 https://github.com/nodejs/node/pull/33142#ref-pullrequest-1563683204
[Snyk] Fix for 1 vulnerabilities baby636/node#88 https://github.com/baby636/node/pull/88
[Snyk] Fix for 1 vulnerabilities ron-a20/node#93 https://github.com/ron-a20/node/pull/93
[Snyk] Fix for 1 vulnerabilities Rednickle/node-1#70 https://github.com/Rednickle/node-1/pull/70
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33142
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33142/files/520da4a1f866584a12666c849db2866d6e9cdf3e
Please reload this pagehttps://github.com/nodejs/node/pull/33142
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Please reload this pagehttps://github.com/nodejs/node/pull/33142
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/addaleax
https://github.com/richardlau
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.