René's URL Explorer Experiment


Title: http: set IncomingMessage.destroyed by ronag · Pull Request #33131 · nodejs/node · GitHub

Open Graph Title: http: set IncomingMessage.destroyed by ronag · Pull Request #33131 · nodejs/node

X Title: http: set IncomingMessage.destroyed by ronag · Pull Request #33131 · nodejs/node

Description: IncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: IncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. ...

X Description: IncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. ...

Opengraph URL: https://github.com/nodejs/node/pull/33131

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:43fcdad2-78fc-fcfa-f495-fbfcba6bc0ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE074:2FF8F1:3B8779:4D381D:6AED1F9D
html-safe-nonce41009550688143f9dba14d2826441de22f60cb5d7d7675295cc9976843a0d856
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDc0OjJGRjhGMTozQjg3Nzk6NEQzODFEOjZBRUQxRjlEIiwidmlzaXRvcl9pZCI6IjM5MTkxMTA1NDc4OTc2NTUxOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac66c8a3d92b2e789f2920b86fff81c5e6277b5260f623c47ca208cda4183df62c
hovercard-subject-tagpull_request:410253911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/33131/files
twitter:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3065230?s=400&v=4
og:image:altIncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33131/changes#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33131%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33131%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33131/changes
Reloadhttps://github.com/nodejs/node/pull/33131/changes
Reloadhttps://github.com/nodejs/node/pull/33131/changes
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-outgoing-destroyedhttps://github.com/nxtedition/node/tree/http-outgoing-destroyed
Conversation 8 https://github.com/nodejs/node/pull/33131
Commits 2 https://github.com/nodejs/node/pull/33131/commits
Checks 0 https://github.com/nodejs/node/pull/33131/checks
Files changed https://github.com/nodejs/node/pull/33131/files
Please reload this pagehttps://github.com/nodejs/node/pull/33131/changes
http: set IncomingMessage.destroyed https://github.com/nodejs/node/pull/33131/changes#top
Show all changes 2 commits https://github.com/nodejs/node/pull/33131/files
cea30bb http: set IncomingMessage.destroyed ronag Apr 28, 2020 https://github.com/nodejs/node/pull/33131/commits/cea30bb39cc2aa8981d8424b7129ef067cbb86ce
39b5d2b fixup: more cases ronag Apr 30, 2020 https://github.com/nodejs/node/pull/33131/commits/39b5d2bca5d4198a1d62f27c7807eae062681af9
Clear filters https://github.com/nodejs/node/pull/33131/files
Please reload this pagehttps://github.com/nodejs/node/pull/33131/changes
Please reload this pagehttps://github.com/nodejs/node/pull/33131/changes
_http_client.js https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
_http_incoming.js https://github.com/nodejs/node/pull/33131/changes#diff-91659c35a59a70aaf7db1c7cec1fcbcd5b78b33f9b37f9babfb140d099229446
_http_server.js https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
test-http-client-res-destroyed.js https://github.com/nodejs/node/pull/33131/changes#diff-5bced777fd778172e7862d9e73e269b1d94c75245cd17336efc10f275916676f
test-http-connect-req-res.js https://github.com/nodejs/node/pull/33131/changes#diff-865c176975e6ebde40ee271af7290e5a85f57f3c58b6ab70f8bc34a31f5758dd
test-http-connect.js https://github.com/nodejs/node/pull/33131/changes#diff-82d74b9a663e6e8cb403b5bd4fcd60389e0914022f7c700b63a56fe375c787cf
test-http-pause-resume-one-end.js https://github.com/nodejs/node/pull/33131/changes#diff-3bbce078b38ced0d41dae87930efc0ee20b2802b0a709f5c0d32c8e421f98390
test-http-req-res-close.js https://github.com/nodejs/node/pull/33131/changes#diff-37ba37693383248eaa42b62dbeb1702d5b29cd104540272e3ef7d40a0a51c665
test-http-response-close.js https://github.com/nodejs/node/pull/33131/changes#diff-8ff515b549c1d955a3a09319b3dee9d8041e0c77449aa4a5c4f096a8d91a7131
test-http-server-stale-close.js https://github.com/nodejs/node/pull/33131/changes#diff-55a84a38d9c65d514bed60add400fe5708c310e80db59da342d472d438213d84
lib/_http_client.jshttps://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/lib/_http_client.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/33131/changes#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
lib/_http_incoming.jshttps://github.com/nodejs/node/pull/33131/changes#diff-91659c35a59a70aaf7db1c7cec1fcbcd5b78b33f9b37f9babfb140d099229446
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/lib/_http_incoming.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-91659c35a59a70aaf7db1c7cec1fcbcd5b78b33f9b37f9babfb140d099229446
https://github.com/nodejs/node/pull/33131/changes#diff-91659c35a59a70aaf7db1c7cec1fcbcd5b78b33f9b37f9babfb140d099229446
lib/_http_server.jshttps://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/lib/_http_server.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
https://github.com/nodejs/node/pull/33131/changes#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
test/parallel/test-http-client-res-destroyed.jshttps://github.com/nodejs/node/pull/33131/changes#diff-5bced777fd778172e7862d9e73e269b1d94c75245cd17336efc10f275916676f
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-client-res-destroyed.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
test/parallel/test-http-connect-req-res.jshttps://github.com/nodejs/node/pull/33131/changes#diff-865c176975e6ebde40ee271af7290e5a85f57f3c58b6ab70f8bc34a31f5758dd
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-connect-req-res.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-865c176975e6ebde40ee271af7290e5a85f57f3c58b6ab70f8bc34a31f5758dd
https://github.com/nodejs/node/pull/33131/changes#diff-865c176975e6ebde40ee271af7290e5a85f57f3c58b6ab70f8bc34a31f5758dd
test/parallel/test-http-connect.jshttps://github.com/nodejs/node/pull/33131/changes#diff-82d74b9a663e6e8cb403b5bd4fcd60389e0914022f7c700b63a56fe375c787cf
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-connect.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-82d74b9a663e6e8cb403b5bd4fcd60389e0914022f7c700b63a56fe375c787cf
https://github.com/nodejs/node/pull/33131/changes#diff-82d74b9a663e6e8cb403b5bd4fcd60389e0914022f7c700b63a56fe375c787cf
test/parallel/test-http-pause-resume-one-end.jshttps://github.com/nodejs/node/pull/33131/changes#diff-3bbce078b38ced0d41dae87930efc0ee20b2802b0a709f5c0d32c8e421f98390
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-pause-resume-one-end.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-3bbce078b38ced0d41dae87930efc0ee20b2802b0a709f5c0d32c8e421f98390
https://github.com/nodejs/node/pull/33131/changes#diff-3bbce078b38ced0d41dae87930efc0ee20b2802b0a709f5c0d32c8e421f98390
test/parallel/test-http-req-res-close.jshttps://github.com/nodejs/node/pull/33131/changes#diff-37ba37693383248eaa42b62dbeb1702d5b29cd104540272e3ef7d40a0a51c665
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-req-res-close.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-37ba37693383248eaa42b62dbeb1702d5b29cd104540272e3ef7d40a0a51c665
https://github.com/nodejs/node/pull/33131/changes#diff-37ba37693383248eaa42b62dbeb1702d5b29cd104540272e3ef7d40a0a51c665
test/parallel/test-http-response-close.jshttps://github.com/nodejs/node/pull/33131/changes#diff-8ff515b549c1d955a3a09319b3dee9d8041e0c77449aa4a5c4f096a8d91a7131
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-response-close.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-8ff515b549c1d955a3a09319b3dee9d8041e0c77449aa4a5c4f096a8d91a7131
https://github.com/nodejs/node/pull/33131/changes#diff-8ff515b549c1d955a3a09319b3dee9d8041e0c77449aa4a5c4f096a8d91a7131
https://github.com/nodejs/node/pull/33131/changes#diff-8ff515b549c1d955a3a09319b3dee9d8041e0c77449aa4a5c4f096a8d91a7131
https://github.com/nodejs/node/pull/33131/changes#diff-8ff515b549c1d955a3a09319b3dee9d8041e0c77449aa4a5c4f096a8d91a7131
test/parallel/test-http-server-stale-close.jshttps://github.com/nodejs/node/pull/33131/changes#diff-55a84a38d9c65d514bed60add400fe5708c310e80db59da342d472d438213d84
View file https://github.com/nxtedition/node/blob/39b5d2bca5d4198a1d62f27c7807eae062681af9/test/parallel/test-http-server-stale-close.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/33131/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/33131/changes#diff-55a84a38d9c65d514bed60add400fe5708c310e80db59da342d472d438213d84
https://github.com/nodejs/node/pull/33131/changes#diff-55a84a38d9c65d514bed60add400fe5708c310e80db59da342d472d438213d84
https://github.com/nodejs/node/pull/33131/changes#diff-55a84a38d9c65d514bed60add400fe5708c310e80db59da342d472d438213d84
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.