René's URL Explorer Experiment


Title: http: set IncomingMessage.destroyed by ronag · Pull Request #33131 · nodejs/node · GitHub

Open Graph Title: http: set IncomingMessage.destroyed by ronag · Pull Request #33131 · nodejs/node

X Title: http: set IncomingMessage.destroyed by ronag · Pull Request #33131 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: IncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. ...

X Description: IncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. ...

Opengraph URL: https://github.com/nodejs/node/pull/33131

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fb375232-1bb3-f389-0a7b-137b9c1425c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1B0:3B1A19:56E827:73C2F6:6AED1AE4
html-safe-nonce1546706dc4e3f4a0708aa79815438aa3d1a7083d375c86db22e1a2bc1405823b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIwOjNCMUExOTo1NkU4Mjc6NzNDMkY2OjZBRUQxQUU0IiwidmlzaXRvcl9pZCI6IjY2MTkzNTA5Njc4NTk4Nzg2MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4e7a55041f69648d0265ba55682b30420f6f1026823d32f3954755597f870d15
hovercard-subject-tagpull_request:410253911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33131/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7c51e5cbd981b8b4c98f75ecc2766fd2e7103627c6cc0c3dcb19c75e27c79acc/nodejs/node/pull/33131
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c51e5cbd981b8b4c98f75ecc2766fd2e7103627c6cc0c3dcb19c75e27c79acc/nodejs/node/pull/33131
og:image:altIncomingMessage is a Readable stream and should properly set the destroyed property. This code is a little weird in general but this is the best solution I can think of until a bigger refactoring. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33131#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33131
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33131
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33131
Reloadhttps://github.com/nodejs/node/pull/33131
Reloadhttps://github.com/nodejs/node/pull/33131
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-outgoing-destroyedhttps://github.com/nxtedition/node/tree/http-outgoing-destroyed
Conversationhttps://github.com/nodejs/node/pull/33131
Commits2 (2)https://github.com/nodejs/node/pull/33131/commits
Checkshttps://github.com/nodejs/node/pull/33131/checks
Files changedhttps://github.com/nodejs/node/pull/33131/files
http: set IncomingMessage.destroyedhttps://github.com/nodejs/node/pull/33131#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-outgoing-destroyedhttps://github.com/nxtedition/node/tree/http-outgoing-destroyed
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2020https://github.com/nodejs/node/pull/33131#issue-608483584
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
http: set IncomingMessage.destroyedhttps://github.com/nodejs/node/pull/33131/commits/cea30bb39cc2aa8981d8424b7129ef067cbb86ce
cea30bbhttps://github.com/nodejs/node/pull/33131/commits/cea30bb39cc2aa8981d8424b7129ef067cbb86ce
https://github.com/ronag
ronaghttps://github.com/ronag
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Apr 28, 2020https://github.com/nodejs/node/pull/33131#event-3281342821
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
April 28, 2020 17:19https://github.com/nodejs/node/pull/33131#event-3281342828
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2020https://github.com/nodejs/node/pull/33131#issuecomment-620743430
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2020 https://github.com/nodejs/node/pull/33131#ref-issue-608109277
http: Reduce API surface #33118 https://github.com/nodejs/node/issues/33118
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 28, 2020https://github.com/nodejs/node/pull/33131#issuecomment-620743752
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://ci.nodejs.org/job/node-test-pull-request/31063/https://ci.nodejs.org/job/node-test-pull-request/31063/
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 28, 2020 https://github.com/nodejs/node/pull/33131#pullrequestreview-402052193
View reviewed changes https://github.com/nodejs/node/pull/33131/files/cea30bb39cc2aa8981d8424b7129ef067cbb86ce
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 28, 2020 https://github.com/nodejs/node/pull/33131#pullrequestreview-402229632
View reviewed changes https://github.com/nodejs/node/pull/33131/files/cea30bb39cc2aa8981d8424b7129ef067cbb86ce
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/33131#pullrequestreview-402229632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 29, 2020https://github.com/nodejs/node/pull/33131#event-3282557505
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Apr 29, 2020 https://github.com/nodejs/node/pull/33131#pullrequestreview-402821159
View reviewed changes https://github.com/nodejs/node/pull/33131/files/cea30bb39cc2aa8981d8424b7129ef067cbb86ce
juanarbolhttps://github.com/juanarbol
https://github.com/nodejs/node/pull/33131#pullrequestreview-402821159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 29, 2020 https://github.com/nodejs/node/pull/33131#ref-issue-609186793
http: ServerRequest & ServerResponse does not set destroyed false #33147 https://github.com/nodejs/node/issues/33147
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 30, 2020https://github.com/nodejs/node/pull/33131#event-3288035908
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 30, 2020https://github.com/nodejs/node/pull/33131#issuecomment-621677449
Please reload this pagehttps://github.com/nodejs/node/pull/33131
#33147https://github.com/nodejs/node/issues/33147
#33118https://github.com/nodejs/node/issues/33118
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
fixup: more caseshttps://github.com/nodejs/node/pull/33131/commits/39b5d2bca5d4198a1d62f27c7807eae062681af9
39b5d2bhttps://github.com/nodejs/node/pull/33131/commits/39b5d2bca5d4198a1d62f27c7807eae062681af9
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/7c5696ca7c0ad76bb3f3e39c49a3bf3a2df9eb6e..39b5d2bca5d4198a1d62f27c7807eae062681af9
7c5696chttps://github.com/nodejs/node/commit/7c5696ca7c0ad76bb3f3e39c49a3bf3a2df9eb6e
39b5d2bhttps://github.com/nodejs/node/commit/39b5d2bca5d4198a1d62f27c7807eae062681af9
Compare https://github.com/nodejs/node/compare/7c5696ca7c0ad76bb3f3e39c49a3bf3a2df9eb6e..39b5d2bca5d4198a1d62f27c7807eae062681af9
April 30, 2020 08:03https://github.com/nodejs/node/pull/33131#event-3288061558
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 30, 2020https://github.com/nodejs/node/pull/33131#issuecomment-621680327
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://ci.nodejs.org/job/node-test-pull-request/31111/https://ci.nodejs.org/job/node-test-pull-request/31111/
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
ronaghttps://github.com/ronag
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Apr 30, 2020https://github.com/nodejs/node/pull/33131#event-3288230588
https://github.com/ronag
ronaghttps://github.com/ronag
addaleaxhttps://github.com/addaleax
juanarbolhttps://github.com/juanarbol
mcollinahttps://github.com/mcollina
April 30, 2020 08:46https://github.com/nodejs/node/pull/33131#event-3288230640
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 30, 2020https://github.com/nodejs/node/pull/33131#issuecomment-621701031
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
ronaghttps://github.com/ronag
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Apr 30, 2020https://github.com/nodejs/node/pull/33131#event-3288235790
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Apr 30, 2020 https://github.com/nodejs/node/pull/33131#pullrequestreview-403578693
View reviewed changes https://github.com/nodejs/node/pull/33131/files/39b5d2bca5d4198a1d62f27c7807eae062681af9
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 1, 2020https://github.com/nodejs/node/pull/33131#event-3293191715
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
dont-land-on-v13.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v13.x
May 1, 2020https://github.com/nodejs/node/pull/33131#event-3293876832
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33131#issuecomment-626111847
28e6626https://github.com/nodejs/node/commit/28e6626ce7020b490438e3ee8a8188a59c5f856f
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2020https://github.com/nodejs/node/pull/33131#event-3319039879
addaleaxhttps://github.com/addaleax
May 9, 2020 https://github.com/nodejs/node/pull/33131#ref-commit-28e6626
https://github.com/ronag
https://github.com/addaleax
http: set IncomingMessage.destroyedhttps://github.com/nodejs/node/commit/28e6626ce7020b490438e3ee8a8188a59c5f856f
28e6626https://github.com/nodejs/node/commit/28e6626ce7020b490438e3ee8a8188a59c5f856f
#33131https://github.com/nodejs/node/pull/33131
https://github.com/ronag
ronaghttps://github.com/ronag
May 10, 2020 https://github.com/nodejs/node/pull/33131#ref-issue-615363224
request.destroyed is undefined after request.destroy() #33336 https://github.com/nodejs/node/issues/33336
codebyterehttps://github.com/codebytere
May 11, 2020 https://github.com/nodejs/node/pull/33131#ref-commit-b634d4b
https://github.com/ronag
https://github.com/codebytere
http: set IncomingMessage.destroyedhttps://github.com/nodejs/node/commit/b634d4b000842ad2a426f9b354d8624e4f0003d3
b634d4bhttps://github.com/nodejs/node/commit/b634d4b000842ad2a426f9b354d8624e4f0003d3
#33131https://github.com/nodejs/node/pull/33131
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33131#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
async_hooks: improve resource stack performance #33575 https://github.com/nodejs/node/pull/33575
async-resource-vs-destroy benchmark is broken locally #33591 https://github.com/nodejs/node/issues/33591
https://github.com/ronag
ronaghttps://github.com/ronag
May 29, 2020 https://github.com/nodejs/node/pull/33131#ref-issue-627557629
OutgoingMessage should set writable false #33643 https://github.com/nodejs/node/issues/33643
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 1, 2020 https://github.com/nodejs/node/pull/33131#ref-pullrequest-627683347
http: align OutgoingMessage.writable with streams #33655 https://github.com/nodejs/node/pull/33655
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33131
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/33131/files/39b5d2bca5d4198a1d62f27c7807eae062681af9
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/mcollina
mcollina https://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/33131
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/33131
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/mcollina
https://github.com/juanarbol
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.