René's URL Explorer Experiment


Title: src: use BaseObjectPtr in StreamReq::Dispose by jasnell · Pull Request #33102 · nodejs/node · GitHub

Open Graph Title: src: use BaseObjectPtr in StreamReq::Dispose by jasnell · Pull Request #33102 · nodejs/node

X Title: src: use BaseObjectPtr in StreamReq::Dispose by jasnell · Pull Request #33102 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Allow the AsyncWrap to be properly detached. Extracted from the QUIC PR. Refs: https://github.com/nodejs/node/pull/32379/files?file-filters[]=.bat&file-filters[]=.gyp&file-filters%5...

X Description: Allow the AsyncWrap to be properly detached. Extracted from the QUIC PR. Refs: https://github.com/nodejs/node/pull/32379/files?file-filters[]=.bat&file-filters[]=.gyp&file-f...

Opengraph URL: https://github.com/nodejs/node/pull/33102

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:980fbcd9-dbac-0e71-471f-7fc81158120d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9AEA:2B3418:2A9DF6:37985C:6AED1AF2
html-safe-nonce4e99435b5211c564d538f84d21ab55f07eeb0636310490c95ad700ac03ccf346
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUVBOjJCMzQxODoyQTlERjY6Mzc5ODVDOjZBRUQxQUYyIiwidmlzaXRvcl9pZCI6Ijg2MzM1NTAwNDU3Nzk3OTEyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2cf2ca840e462ecc70858e47b049952c3ccb5e1ad63a96c5ff50f8d1e774324a
hovercard-subject-tagpull_request:409717226
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33102/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/633b2a7ce08e8024f9686ae324833da807dd937dc9771a962073412622aecf13/nodejs/node/pull/33102
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/633b2a7ce08e8024f9686ae324833da807dd937dc9771a962073412622aecf13/nodejs/node/pull/33102
og:image:altAllow the AsyncWrap to be properly detached. Extracted from the QUIC PR. Refs: https://github.com/nodejs/node/pull/32379/files?file-filters[]=.bat&file-filters[]=.gyp&file-filters%5...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/33102#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33102
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33102
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/33102
Reloadhttps://github.com/nodejs/node/pull/33102
Reloadhttps://github.com/nodejs/node/pull/33102
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:stream-base-dispose-use-baseobjectptrhttps://github.com/jasnell/node/tree/stream-base-dispose-use-baseobjectptr
Conversationhttps://github.com/nodejs/node/pull/33102
Commits1 (1)https://github.com/nodejs/node/pull/33102/commits
Checkshttps://github.com/nodejs/node/pull/33102/checks
Files changedhttps://github.com/nodejs/node/pull/33102/files
src: use BaseObjectPtr in StreamReq::Disposehttps://github.com/nodejs/node/pull/33102#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:stream-base-dispose-use-baseobjectptrhttps://github.com/jasnell/node/tree/stream-base-dispose-use-baseobjectptr
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 27, 2020https://github.com/nodejs/node/pull/33102#issue-607817142
Please reload this pagehttps://github.com/nodejs/node/pull/33102
QUIC PRhttps://github.com/nodejs/node/pull/32379
https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763
@addaleaxhttps://github.com/addaleax
@sam-githubhttps://github.com/sam-github
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/jasnell
src: use BaseObjectPtr in StreamReq::Disposehttps://github.com/nodejs/node/pull/33102/commits/981de8efeabe41d2487a6de3241642dd2359a87a
981de8ehttps://github.com/nodejs/node/pull/33102/commits/981de8efeabe41d2487a6de3241642dd2359a87a
nodejs#32379https://github.com/nodejs/node/pull/32379
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Apr 27, 2020https://github.com/nodejs/node/pull/33102#event-3277403304
https://github.com/jasnell
jasnellhttps://github.com/jasnell
addaleaxhttps://github.com/addaleax
sam-githubhttps://github.com/sam-github
April 27, 2020 20:05https://github.com/nodejs/node/pull/33102#event-3277405605
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 27, 2020https://github.com/nodejs/node/pull/33102#issuecomment-620207810
https://ci.nodejs.org/job/node-test-pull-request/31021/https://ci.nodejs.org/job/node-test-pull-request/31021/
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 27, 2020 https://github.com/nodejs/node/pull/33102#pullrequestreview-401302780
View reviewed changes https://github.com/nodejs/node/pull/33102/files/981de8efeabe41d2487a6de3241642dd2359a87a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 28, 2020https://github.com/nodejs/node/pull/33102#issuecomment-620831607
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://ci.nodejs.org/job/node-test-pull-request/31066/https://ci.nodejs.org/job/node-test-pull-request/31066/
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 28, 2020https://github.com/nodejs/node/pull/33102#event-3282336817
jasnellhttps://github.com/jasnell
May 6, 2020 https://github.com/nodejs/node/pull/33102#ref-commit-1dc006e
https://github.com/jasnell
src: use BaseObjectPtr in StreamReq::Disposehttps://github.com/nodejs/node/commit/1dc006ef1990d4dcb67a9521bc643638aeba248b
1dc006ehttps://github.com/nodejs/node/commit/1dc006ef1990d4dcb67a9521bc643638aeba248b
#32379https://github.com/nodejs/node/pull/32379
#33102https://github.com/nodejs/node/pull/33102
https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 6, 2020https://github.com/nodejs/node/pull/33102#issuecomment-624700952
1dc006ehttps://github.com/nodejs/node/commit/1dc006ef1990d4dcb67a9521bc643638aeba248b
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 6, 2020https://github.com/nodejs/node/pull/33102#event-3308910972
codebyterehttps://github.com/codebytere
May 7, 2020 https://github.com/nodejs/node/pull/33102#ref-commit-cf47698
https://github.com/jasnell
https://github.com/codebytere
src: use BaseObjectPtr in StreamReq::Disposehttps://github.com/nodejs/node/commit/cf476984f652705e0d9c181f5f1d416eb1701e61
cf47698https://github.com/nodejs/node/commit/cf476984f652705e0d9c181f5f1d416eb1701e61
#32379https://github.com/nodejs/node/pull/32379
#33102https://github.com/nodejs/node/pull/33102
https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763
https://github.com/codebytere
codebyterehttps://github.com/codebytere
May 18, 2020 https://github.com/nodejs/node/pull/33102#ref-pullrequest-619852653
v14.3.0 proposal #33452 https://github.com/nodejs/node/pull/33452
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 7, 2020https://github.com/nodejs/node/pull/33102#issuecomment-640248043
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Jun 7, 2020https://github.com/nodejs/node/pull/33102#event-3416827866
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 7, 2020https://github.com/nodejs/node/pull/33102#issuecomment-640251253
@codebyterehttps://github.com/codebytere
#32307https://github.com/nodejs/node/pull/32307
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 7, 2020https://github.com/nodejs/node/pull/33102#issuecomment-640251394
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-requested-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v12.x
Jun 7, 2020https://github.com/nodejs/node/pull/33102#event-3416870066
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33102#ref-commit-e67df04
https://github.com/jasnell
https://github.com/codebytere
src: use BaseObjectPtr in StreamReq::Disposehttps://github.com/nodejs/node/commit/e67df04df299a09af661f58508563ad8d3fa0e6b
e67df04https://github.com/nodejs/node/commit/e67df04df299a09af661f58508563ad8d3fa0e6b
#32379https://github.com/nodejs/node/pull/32379
#33102https://github.com/nodejs/node/pull/33102
https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763https://github.com/nodejs/node/pull/32379/files?file-filters%5B%5D=.bat&file-filters%5B%5D=.gyp&file-filters%5B%5D=.gypi&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.py&file-filters%5B%5D=.sh&file-filters%5B%5D=No+extension&file-filters%5B%5D=dotfile#r409084763
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Jun 9, 2020 https://github.com/nodejs/node/pull/33102#ref-pullrequest-635542822
v12.18.1 proposal #33811 https://github.com/nodejs/node/pull/33811
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33102
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/33102/files/981de8efeabe41d2487a6de3241642dd2359a87a
https://github.com/sam-github
sam-github https://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/33102
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/33102
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/codebytere
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.