| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:18241ea1-b985-4640-768a-db7e43fa912e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE1A:B7306:22CB4BE:2FDF96E:696ABE09 |
| html-safe-nonce | 4408053c52dd4f6286be0f0d0455908309487fd8c7814f3c17041af425593f1a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTFBOkI3MzA2OjIyQ0I0QkU6MkZERjk2RTo2OTZBQkUwOSIsInZpc2l0b3JfaWQiOiIxMTAzNDM1MTU5NDc4OTEwNDczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7fb534bc9451744365cd2dadd74c4aa10215994bec8708ec26b9c49e0aff24d4 |
| hovercard-subject-tag | pull_request:408995968 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/33070/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f9f9933007c4c502ae0ffc7589565954b56aae568f8a1b71d9c17065996cc2d1/nodejs/node/pull/33070 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f9f9933007c4c502ae0ffc7589565954b56aae568f8a1b71d9c17065996cc2d1/nodejs/node/pull/33070 |
| og:image:alt | Document the used members of the headers in src/util.h,
also removes the assert header which is not being used.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | juanarbol |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/33070#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33070 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33070 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/33070 |
| Reload | https://github.com/nodejs/node/pull/33070 |
| Reload | https://github.com/nodejs/node/pull/33070 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/33070#issue-comment-box |
| juanarbol | https://github.com/juanarbol |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| juanarbol:juanarbol/add-headers-information | https://github.com/juanarbol/node/tree/juanarbol/add-headers-information |
|
src: document headers members in src/util.h
| https://github.com/nodejs/node/pull/33070#top |
| juanarbol | https://github.com/juanarbol |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| juanarbol:juanarbol/add-headers-information | https://github.com/juanarbol/node/tree/juanarbol/add-headers-information |
|
Conversation
8
| https://github.com/nodejs/node/pull/33070 |
|
Commits
1
| https://github.com/nodejs/node/pull/33070/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/33070/checks |
|
Files changed
| https://github.com/nodejs/node/pull/33070/files |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/33070#issue-606890446 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Apr 26, 2020 | https://github.com/nodejs/node/pull/33070#event-3272428356 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| force-pushed | https://github.com/nodejs/node/compare/13881f505771e8f71968545ceaeeac1939cf6981..dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637 |
| 13881f5 | https://github.com/nodejs/node/commit/13881f505771e8f71968545ceaeeac1939cf6981 |
| dfe3f44 | https://github.com/nodejs/node/commit/dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637 |
|
Compare
| https://github.com/nodejs/node/compare/13881f505771e8f71968545ceaeeac1939cf6981..dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637 |
| April 26, 2020 01:14 | https://github.com/nodejs/node/pull/33070#event-3272429189 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 27, 2020
| https://github.com/nodejs/node/pull/33070#pullrequestreview-401066754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33070/files |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
| May 5, 2020 | https://github.com/nodejs/node/pull/33070#event-3305722992 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
| May 19, 2020 | https://github.com/nodejs/node/pull/33070#event-3352951685 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 19, 2020
| https://github.com/nodejs/node/pull/33070#pullrequestreview-414667672 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33070/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 19, 2020 | https://github.com/nodejs/node/pull/33070#issuecomment-630965606 |
| https://ci.nodejs.org/job/node-test-pull-request/31427/ | https://ci.nodejs.org/job/node-test-pull-request/31427/ |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
May 19, 2020
| https://github.com/nodejs/node/pull/33070#pullrequestreview-414695829 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33070/files |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/33070#pullrequestreview-414695829 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| May 19, 2020 | https://github.com/nodejs/node/pull/33070#issuecomment-631033883 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| May 20, 2020 | https://github.com/nodejs/node/pull/33070#issuecomment-631158039 |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 21, 2020 | https://github.com/nodejs/node/pull/33070#event-3362192440 |
|
| https://github.com/juanarbol |
| src: remove unused headers in src/util.h | https://github.com/nodejs/node/pull/33070/commits/a667ed26b1fb05249696f7829be2271e1be5bcfc |
| a667ed2 | https://github.com/nodejs/node/pull/33070/commits/a667ed26b1fb05249696f7829be2271e1be5bcfc |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| force-pushed | https://github.com/nodejs/node/compare/dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637..a667ed26b1fb05249696f7829be2271e1be5bcfc |
| dfe3f44 | https://github.com/nodejs/node/commit/dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637 |
| a667ed2 | https://github.com/nodejs/node/commit/a667ed26b1fb05249696f7829be2271e1be5bcfc |
|
Compare
| https://github.com/nodejs/node/compare/dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637..a667ed26b1fb05249696f7829be2271e1be5bcfc |
| May 21, 2020 20:33 | https://github.com/nodejs/node/pull/33070#event-3362215113 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| sam-github | https://github.com/sam-github |
| May 21, 2020 20:33 | https://github.com/nodejs/node/pull/33070#event-3362217834 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
May 21, 2020
| https://github.com/nodejs/node/pull/33070#pullrequestreview-416475426 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/33070/files/a667ed26b1fb05249696f7829be2271e1be5bcfc |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/33070#pullrequestreview-416475426 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| May 21, 2020 | https://github.com/nodejs/node/pull/33070#issuecomment-632334870 |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 21, 2020 | https://github.com/nodejs/node/pull/33070#issuecomment-632336495 |
| https://ci.nodejs.org/job/node-test-pull-request/31465/ | https://ci.nodejs.org/job/node-test-pull-request/31465/ |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 21, 2020 | https://github.com/nodejs/node/pull/33070#event-3362284385 |
| jasnell | https://github.com/jasnell |
|
May 22, 2020
| https://github.com/nodejs/node/pull/33070#ref-commit-39ceb6a |
|
| https://github.com/juanarbol |
|
| https://github.com/jasnell |
| src: remove unused headers in src/util.h | https://github.com/nodejs/node/commit/39ceb6ae785e274422369e3bf6834a896e10c232 |
| 39ceb6a | https://github.com/nodejs/node/commit/39ceb6ae785e274422369e3bf6834a896e10c232 |
| #33070 | https://github.com/nodejs/node/pull/33070 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 22, 2020 | https://github.com/nodejs/node/pull/33070#issuecomment-632428768 |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 22, 2020 | https://github.com/nodejs/node/pull/33070#event-3362895334 |
| codebytere | https://github.com/codebytere |
|
Jun 18, 2020
| https://github.com/nodejs/node/pull/33070#ref-commit-9018e92 |
|
| https://github.com/juanarbol |
|
| https://github.com/codebytere |
| src: remove unused headers in src/util.h | https://github.com/nodejs/node/commit/9018e92b13c5a81a48d205e0547b7df73933d32f |
| 9018e92 | https://github.com/nodejs/node/commit/9018e92b13c5a81a48d205e0547b7df73933d32f |
| #33070 | https://github.com/nodejs/node/pull/33070 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 28, 2020
| https://github.com/nodejs/node/pull/33070#ref-pullrequest-646828333 |
|
v14.5.0 proposal
#34093
| https://github.com/nodejs/node/pull/34093 |
| codebytere | https://github.com/codebytere |
|
Jul 8, 2020
| https://github.com/nodejs/node/pull/33070#ref-commit-0837c2c |
|
| https://github.com/juanarbol |
|
| https://github.com/codebytere |
| src: remove unused headers in src/util.h | https://github.com/nodejs/node/commit/0837c2cc99e39de7df7923cae790ff3a4860b071 |
| 0837c2c | https://github.com/nodejs/node/commit/0837c2cc99e39de7df7923cae790ff3a4860b071 |
| #33070 | https://github.com/nodejs/node/pull/33070 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jul 13, 2020
| https://github.com/nodejs/node/pull/33070#ref-pullrequest-656085086 |
|
v12.18.3 proposal
#34343
| https://github.com/nodejs/node/pull/34343 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| January 19, 2021 16:25 | https://github.com/nodejs/node/pull/33070#event-4223440099 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F33070 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/33070/files/dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/33070/files/dfe3f44dcb4a94bd94ca06f1bedfb96ddc664637 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/33070/files/a667ed26b1fb05249696f7829be2271e1be5bcfc |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/33070 |
|
| https://github.com/juanarbol |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/sam-github |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |